Re: [PATCH] ipsec: remove unneccessary null check

2023-01-16 Thread Zhang, Fan
On 1/13/2023 6:44 PM, Stephen Hemminger wrote: The function rte_ring_free() accepts NULL as vaild input like free() and other functions. Found with null_free_check.cocci. Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- driver

Re: [PATCH v3 0/4] compressdev: add LZ4 support

2023-02-13 Thread Zhang, Fan
Hi, The patchset only have library change and added performance tests. We shall have at least one PMD to support the added algorithms and unit test updated for the PMD/algorithms. Regards, Fan On 2/13/2023 6:11 AM, Michael Baum wrote: Add support for LZ4 compression algorithm for both API

Re: [PATCH v1] eventdev/crypto: wrong crypto enqueue count stats

2023-02-24 Thread Zhang, Fan
On 11/30/2022 3:11 PM, Ganapati Kundapura wrote: crypto_enq_count is updated on failure to enqueue ops to cryptodev. Updated crypto_enq_count on successful enqueue of ops to cryptodev. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_e

Re: [PATCH v1] doc: update release notes for 23.03

2023-03-30 Thread Zhang, Fan
On 3/30/2023 5:09 PM, John McNamara wrote: Fix grammar, spelling and formatting of DPDK 23.03 release notes. Signed-off-by: John McNamara --- * Minor fixes/changes only. doc/guides/rel_notes/release_23_03.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --

Re: [PATCH] test/crypto: add cryptodev reconfig test

2023-04-06 Thread Zhang, Fan
Hi Aakash, I really like the idea to create a test for device reconfiguration. I am wondering if we need to test all PMDs against this patch first. Regards, Fan On 4/5/2023 8:41 AM, Aakash Sasidharan wrote: Add cryptodev tests to verify that the device supports reconfiguration any number of

Re: [PATCH] test/crypto: add cryptodev reconfig test

2023-04-18 Thread Zhang, Fan
On 4/5/2023 8:41 AM, Aakash Sasidharan wrote: Add cryptodev tests to verify that the device supports reconfiguration any number of times via rte_cryptodev_configure API. Signed-off-by: Aakash Sasidharan --- Acked-by: Fan Zhang

Re: [PATCH 6/6] crypto/qat: remove useless log level checks

2023-06-09 Thread Zhang, Fan
On 6/9/2023 2:54 PM, Maxime Coquelin wrote: qat_sym_debug_log_dump() being stubbed if log level is less than debug, it is not necessary to check the log level before calling it. Signed-off-by: Maxime Coquelin --- Acked-by: Fan Zhang

Re: [PATCH 1/6] crypto/qat: fix sym device prototype

2023-06-09 Thread Zhang, Fan
On 6/9/2023 2:54 PM, Maxime Coquelin wrote: qat_dev_cmd_param parameter of qat_sym_dev_create() was wrongly marked as unused, this patch fixes it. Fixes: fb3b9f492205 ("crypto/qat: rework burst data path") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- drivers/crypto/qat/qat_sym.c

Re: [EXT] [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-09 Thread Zhang, Fan
Hi Akhil, On 06/10/2022 19:49, Akhil Goyal wrote: As some cryptode PMDs have multiprocess support, the secondary process needs queue-pair to be configured by the primary process before to use. This patch adds an IPC register function to help the primary process to register IPC action that allow

Re: [PATCH v3] doc: support IPsec Multi-buffer lib v1.3

2022-11-10 Thread Zhang, Fan
Hi Pablo, On 11/10/2022 11:07 AM, Pablo de Lara wrote: Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara Acked-by: Ciara Power --- -v3: Fixed library versi

Re: [dpdk-dev v1] app/test: fix of bitwise and operator in return

2022-11-11 Thread Zhang, Fan
On 11/11/2022 11:59 AM, Kai Ji wrote: This patch remove incorrect bitwise and operator used in the return function of sw snow3g testcase Signed-off-by: Kai Ji --- app/test/test_cryptodev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/a

Re: [dpdk-dev v5] doc: support IPsec Multi-buffer lib v1.3

2022-11-15 Thread Zhang, Fan
Hi, On 11/15/2022 5:11 PM, Kai Ji wrote: From: Pablo de Lara Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara Acked-by: Ciara Power Ac

Re: [PATCH] doc: fix max supported packet len for virtio driver

2022-11-18 Thread Zhang, Fan
Hi Yi, Please add "Fixes: x" description to the commit message. You may find more information in https://core.dpdk.org/contribute/. Regards, Fan On 11/18/2022 1:26 AM, li...@chinatelecom.cn wrote: From: Yi Li According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver current

Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3

2022-11-21 Thread Zhang, Fan
Hi Akhil, From 22.11 the ipsec-mb PMDs will be working on two different libraries that may or may not work the same. We also have two different contributor groups working on adding features on top of each library, again one may or may not be compatible to another. I believe there should be

Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3

2022-11-21 Thread Zhang, Fan
Hi Akhil, Agreed. Thanks for clarification. Regards, Fan On 11/21/2022 11:35 AM, Akhil Goyal wrote: Hi Fan, Hi Akhil, From 22.11 the ipsec-mb PMDs will be working on two different libraries that may or may not work the same. We also have two different contributor groups working on addin

Re: [PATCH] maintainers: split baseband from crypto tree

2022-12-05 Thread Zhang, Fan
On 12/5/2022 7:59 AM, Akhil Goyal wrote: Baseband patches are now split from dpdk-next-crypto, All baseband patches need to be submitted to dpdk-next-baseband which will be maintained by Maxime. Cc: maxime.coque...@redhat.com Signed-off-by: Akhil Goyal --- MAINTAINERS | 12 1 f

Re: [PATCH] build: fix missing crypto vec limits in version

2022-12-06 Thread Zhang, Fan
On 12/6/2022 9:23 AM, Volodymyr Fialko wrote: Add missing function `rte_event_crypto_adapter_vector_limits_get` to version.map. Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") Signed-off-by: Volodymyr Fialko --- lib/eventdev/version.map | 1 + 1 file changed, 1 inser

Re: [PATCH] cryptodev: add algo enums to string conversion APIs

2022-12-14 Thread Zhang, Fan
On 12/12/2022 3:10 PM, Akhil Goyal wrote: Symmetric/Asymmetric algorithm strings are accessed by application using arrays in cryptodev lib, which hampers new algorithms addition in the array due to ABI breakage. These arrays are now deprecated and will be removed in next ABI break release. New AP

Re: [PATCH] crypto/qat: add SHA3 plain hash support

2022-12-16 Thread Zhang, Fan
On 12/14/2022 4:26 PM, Ciara Power wrote: Add support for plain SHA3-224, SHA3-256, SHA3-384, and SHA3-512 hash support in QAT GEN3. Add support for SHA3-256 in GEN2. Signed-off-by: Ciara Power --- Tested using testcases from patch not yet merged. https://patchwork.dpdk.org/project/dpdk/patch

Re: questions about crypto_scheduler

2022-12-16 Thread Zhang, Fan
Hi Zhangfei, The crypto scheduler PMD's session contains "sub-sessions" for all works, 1 sub-session per driver ID, to minimize the memory footprint. When configuring session, it configures the sub-sessions one by one. Since your UADK devices sharing the same driver ID, the crypto scheduler w

Re: questions about crypto_scheduler

2022-12-21 Thread Zhang, Fan
Hi Zhangfei, The crypto scheduler PMD's session contains "sub-sessions" for all works, 1 sub-session per driver ID, to minimize the memory footprint. When configuring session, it configures the sub-sessions one by one. Since your UADK devices sharing the same driver ID, the crypto scheduler w

Re: [PATCH] test/crypto: add further ZUC testcases

2022-12-21 Thread Zhang, Fan
Hi Ciara, On 12/21/2022 2:04 PM, Ciara Power wrote: Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. + if (direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT) { +

Re: [PATCH] cryptodev: increase default max nb queue pairs

2023-01-04 Thread Zhang, Fan
On 1/4/2023 7:30 AM, Anoob Joseph wrote: Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with larger number of cores. Application would be

Re: [PATCH] net/cnxk: fix deadlock in security session creation

2023-01-05 Thread Zhang, Fan
On 1/5/2023 1:57 PM, David Marchand wrote: Releasing the lock was missing in this branch. Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/cnxk/cn9k_ethdev_sec.c | 1 + 1 file changed, 1 insertion(+) dif

Re: [PATCH] net/ena: fix deadlock in RSS reta update

2023-01-05 Thread Zhang, Fan
On 1/5/2023 1:57 PM, David Marchand wrote: Add missing lock release in case of internal failure. Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/ena/ena_rss.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [PATCH] test/crypto: fix and improve ZUC cipher and auth tests

2023-01-06 Thread Zhang, Fan
On 1/6/2023 4:15 PM, Ciara Power wrote: The incorrect value was used for the reference plaintext offset in ZUC cipher function. This is now fixed to convert to byte length, rather than bits. Also, to cleanup the ZUC test code, some small improvements are made. The authentication function takes t