ice_get_flow_field should not set error if item->type is
RTE_FLOW_ITEM_TYPE_VOID.
This patch fixes this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_generic_flow.c | 4 +++-
1 file changed,
Action is a list. We should check each element of the action
rather than the first one.
This patch fixes this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_generic_f
Patch 1/3 avoids set error for RTE_FLOW_ITEM_TYPE_VOID in inputset check.
Patch 2/3 adds check for each element of action list.
Patch 3/3 adds ipv6 tc support for flow rule.
Wang Ying A (3):
net/ice: fix flow get inputset check
net/ice: fix flow action validation
net/ice: add flow ipv6 tc
When set flow ipv6 tc rule, ice_get_flow_field will set error.
This patch fixes this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_generic_flow.c | 10 +++---
1 file changed, 7 insertions(+), 3
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, July 18, 2019 10:33 AM
> To: Wang, Ying A ; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check
>
> It's no need to add RTE_FLOW_I
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, July 18, 2019 10:47 AM
> To: Wang, Ying A ; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check
>
> So I think the bug is the skipped patter
For VXLAN/NVGRE packet, vni/tni should be included in the matching
keys. This patch fixes this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_generic_flow.c | 8
drivers/net/ice/ice_gene
The patch fix the issue that lldp packet can't be forwarded to host.
Fixes: 59d151de6673 ("net/ice: stop LLDP by default")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_ethdev.c | 46 +++-
1 file changed, 45 i
The patch fix the issue that lldp packet can't be forwarded to host.
Fixes: 59d151de6673 ("net/ice: stop LLDP by default")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
---
V2: Remove redundant macro definiton and function argument;
Modify the function name, variables
> -Original Message-
> From: Ye, Xiaolong
> Sent: Saturday, July 27, 2019 11:31 AM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward
>
> On 07/26, Wang Ying A
The patch fix the issue that lldp packet can't be forwarded to host.
Fixes: 59d151de6673 ("net/ice: stop LLDP by default")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
---
V2: Remove redundant macro definiton and rewrite
ice_vsi_config_sw_lldp function.
v3: Fix impro
stage header.
Change-Id: I9da6f2c32aca5611ab5a7bb2699f2ad6d3071c59
Signed-off-by: Wang Ying A
---
app/test-pmd/cmdline_flow.c | 80 +
doc/guides/prog_guide/rte_flow.rst | 25 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 10
lib
stage header.
Signed-off-by: Wang Ying A
---
---
v2: Remove Gerrit Change-Id's.
---
app/test-pmd/cmdline_flow.c | 80 +
doc/guides/prog_guide/rte_flow.rst | 25 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 10
lib/librte_e
- RTE_FLOW_ITEM_TYPE_GTP_PSC: matches a GTP
PDU extension header (PDU session container).
Signed-off-by: Wang Ying A
---
app/test-pmd/cmdline_flow.c | 36 +
doc/guides/prog_guide/rte_flow.rst | 9
doc/guides/testpmd_app_ug
patch 1/2: Add GTP extension header to flow API.
patch 2/2: Add PPPoE to flow API.
---
v3: Split original patch, one for GTP and the other for PPPoE.
Add RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID for PPPoE session packets.
v2: Remove Gerrit Change-Id's.
---
Wang Ying A (2):
ethdev: ad
- RTE_FLOW_ITEM_TYPE_PPPOES: matches a PPPoE session header.
- RTE_FLOW_ITEM_TYPE_PPPOED: matches a PPPoE discovery header.
- RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: matches a PPPoE session
protocol identifier.
Signed-off-by: Wang Ying A
---
app/test-pmd/cmdline_flow.c | 51
Hi, Xiaolong
I will fix the coding style warning and send v5.
Thanks
-Ying
> -Original Message-
> From: Ye, Xiaolong
> Sent: Wednesday, October 16, 2019 10:55 AM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming
> ; Zhao1, Wei
> Subject: Re: [
Hi, Xiaolong
Thanks for your comments, will fix them in v2.
> -Original Message-
> From: Ye, Xiaolong
> Sent: Monday, September 30, 2019 5:26 PM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming
> ; sta...@dpdk.org
> Subject: Re: [PATCH] net/ice: cle
Variable "status" should be difined as "int" instead of "uint_16t".
This patch fixes the issue.
Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_ethdev.c | 8
1 fi
Patch 1/2 modifies the variable type of "status" from "uint16_t" to "int"
to follow the standard programming style.
Patch 2/2 adds a return value check to give user a correct prompt.
Wang Ying A (2):
net/ice: code clean
net/ice: fix promiscuous mode
dri
@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 72831bb..cb82a6f 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/i
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, April 15, 2019 8:44 PM
> To: Wang, Ying A ; Lu, Wenzhuo
> ; Yang, Qiming
> Cc: dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/ice: code clean
>
>
&
essage
and rename the patch title. For patch 2/2, make the commit log concise and
clear.
Wang Ying A (2):
net/ice: fix wrong type
net/ice: fix promiscuous mode
drivers/net/ice/ice_ethdev.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
--
1.8.3.1
Variable "status" should be defined as "enum ice_status"
instead of "uint16_t". This patch fixes the issue.
Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_ethdev.c | 8
When device promiscuous mode has already been enabled,
should not return error if user re-enable it.
Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
Cc: sta...@dpdk.org
Signed-off-by: Wang Ying A
---
drivers/net/ice/ice_ethdev.c | 4 +++-
1 file changed, 3 insertions(+),
Wang Ying A (2):
ethdev: add GTP extension header to flow API
ethdev: add PPPoE to flow API
app/test-pmd/cmdline_flow.c | 93 -
doc/guides/prog_guide/rte_flow.rst | 28 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 13
- RTE_FLOW_ITEM_TYPE_GTP_PSC: matches a GTP
PDU extension header (PDU session container).
Signed-off-by: Wang Ying A
---
app/test-pmd/cmdline_flow.c | 36 +
doc/guides/prog_guide/rte_flow.rst | 9
doc/guides/testpmd_app_ug
- RTE_FLOW_ITEM_TYPE_PPPOES: matches a PPPoE session header.
- RTE_FLOW_ITEM_TYPE_PPPOED: matches a PPPoE discovery header.
- RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: matches a PPPoE session
protocol identifier.
Signed-off-by: Wang Ying A
---
app/test-pmd/cmdline_flow.c | 57
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Wednesday, September 4, 2019 10:45 PM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; Zhao1, Wei
> Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling
>
>
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Saturday, September 7, 2019 12:13 AM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; Zhao1, Wei
> Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling
>
>
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Sunday, September 8, 2019 11:56 PM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; Zhao1, Wei
> Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling
>
> On 09/
> -Original Message-
> From: Ye, Xiaolong
> Sent: Monday, September 9, 2019 5:54 PM
> To: Wang, Ying A
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; Zhao1, Wei
> Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling
>
> O
32 matches
Mail list logo
