Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-25 Thread Wang Xiang
Hi Ori and Jerin, One comment regarding my concern with len and end_offset problem. >From open source SW regex library(libpcre, re2 and Hyperscan) and Intel's perspective, the matching results returned are always start offset and end offset. More importantly, Hyperscan only reports end offset mos

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-26 Thread Wang Xiang
, does all solutions return the leftmost start_offset, i.e. for rule: foo.*bar and input: foofoobar, the returned start_offset will be 0 not 3? Thanks, Xiang On Wed, Feb 26, 2020 at 08:36:51AM +, Ori Kam wrote: > Hi Xiang, > > > > -Original Message- > > From: dev O

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-27 Thread Wang Xiang
Hi Ori, Look forward to your v4:). Thanks, Xiang On Thu, Feb 27, 2020 at 07:31:48AM +, Ori Kam wrote: > Hi Xiang, > > > -Original Message- > > From: Wang Xiang > > Sent: Thursday, February 27, 2020 11:26 AM > > To: Ori Kam > > Cc: Jerin Jacob

Re: [dpdk-dev] [RFC v5] regexdev: introduce regexdev subsystem

2020-03-01 Thread Wang Xiang
Hi Ori, Comments below. Thanks, Xiang On Thu, Feb 27, 2020 at 03:08:35PM +, Ori Kam wrote: > From: Jerin Jacob > > Even though there are some vendors which offer Regex HW offload, due to > lack of standard API, It is diffcult for DPDK consumer to use them > in a portable way. > > This _RF

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-12 Thread Wang Xiang
Hi Ori, Sorry for the late response as I am occupied by other works. Two comments below to make the definitions compatible to Hyperscan. Thanks, Xiang On Tue, Mar 10, 2020 at 10:32:33AM +, Ori Kam wrote: > +#define RTE_REGEX_PCRE_RULE_MATCH_ALL_F (1ULL << 13) > +/**< This flag marks that the

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-15 Thread Wang Xiang
On Sun, Mar 15, 2020 at 10:05:53AM +, Ori Kam wrote: Hi Ori, > Hi Xiang, > > > > -Original Message- > > From: Wang Xiang > > Sent: Friday, March 13, 2020 3:20 AM > > To: Ori Kam > > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marve

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Wang Xiang
Hi Ori, On Mon, Mar 16, 2020 at 09:09:06AM +, Ori Kam wrote: > Hi Xiang, > > > -Original Message- > > From: Wang Xiang > > Sent: Monday, March 16, 2020 3:26 AM > > To: Ori Kam > > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marvell.

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Wang Xiang
s > in the v1 patch, > > Thanks, > Ori > > > -Original Message- > > From: Wang Xiang > > Sent: Monday, March 16, 2020 10:48 PM > > To: Ori Kam > > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marvell.com; Shahaf > > Shul

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-10-13 Thread Wang Xiang
On Fri, Sep 27, 2019 at 02:35:00PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Wang Xiang > > > > Hi Jerin, > > > > Thanks for your response. More comments below and inline. > > > > 1) I think the size of some

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-18 Thread Wang Xiang
Hi Jerin, Thanks for your response. More comments below and inline. 1) I think the size of some varaibles (e.g. nb_matches, scan_size, matching offset, etc) should be increased based on what Hyperscan supports. a) struct rte_regex_ops: uint16_t scan_size => uint32_t scan_size

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-08-19 Thread Wang, Xiang W
; Dovrat Zifroni ; Prasun Kapoor ; Nipun Gupta ; Wang, Xiang W ; Richardson, Bruce ; Hong, Yang A ; Chang, Harry ; gu.ji...@zte.com.cn; shanjia...@chinatelecom.cn; zhangy@chinatelecom.cn; lixin...@huachentel.com; wush...@inspur.com; yuying...@yxlink.com; fanchengg...@sunyainfo.com; davidf