[dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: fix spi transaction issue

2020-07-09 Thread Tianfei zhang
From: Tianfei Zhang 0x4a means idle status on physical layer. when encounter 0x4a on raw data, it need insert a ESCAPE character for indication. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/

[dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: fix NIOS SPI initial

2020-07-09 Thread Tianfei zhang
From: Tianfei Zhang Add fecmode setting on NIOS SPI master initialization. this SPI is shared by NIOS core inside FPGA, NIOS will use this SPI master to do some one time initialization after power up, and then release the control to DPDK. Fix the timeout initialization for polling the

[dpdk-dev] [PATCH v2 2/2] raw/ifpga/base: fix NIOS SPI initial

2020-07-09 Thread Tianfei zhang
From: Tianfei Zhang Add fecmode setting on NIOS SPI primary initialization. this SPI is shared by NIOS core inside FPGA, NIOS will use this SPI primary to do some one time initialization after power up, and then release the control to DPDK. Fix the timeout initialization for polling the

[dpdk-dev] [PATCH v2 1/2] raw/ifpga/base: fix spi transaction issue

2020-07-09 Thread Tianfei zhang
From: Tianfei Zhang 0x4a means idle status on physical layer. when encounter 0x4a on raw data, it need insert a ESCAPE character for indication. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/

[dpdk-dev] [PATCH v4 2/5] raw/ifpga_rawdev: fix logically dead code

2019-06-20 Thread Tianfei zhang
add temporary variable in max10_reg_write(). Coverity issue: 337927 Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 -- 1 file

[dpdk-dev] [PATCH v4 3/5] raw/ifpga_rawdev/base: fix bit fields definition

2019-06-20 Thread Tianfei zhang
Fix CTRL_DEV_SELECT bit fields definition about eth_group devices. Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/opae_eth_group.h | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH v4 1/5] raw/ifpga_rawdev: fix use of untrusted scalar value

2019-06-20 Thread Tianfei zhang
Add checking the buffer size and use const char * for buffer declaration. Coverity issue: 279449 Fixes: ef1e8ede ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/ifpga_api.

[dpdk-dev] [PATCH v4 5/5] raw/ifpga_rawdev/base: fix retimer link status issue

2019-06-20 Thread Tianfei zhang
y: Sampath Amrutha Signed-off-by: Tianfei zhang --- .../raw/ifpga_rawdev/base/opae_eth_group.c| 172 ++ .../raw/ifpga_rawdev/base/opae_eth_group.h| 6 + .../raw/ifpga_rawdev/base/opae_intel_max10.c | 7 - 3 files changed, 178 insertions(+), 7 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v4 4/5] raw/ifpga_rawdev/base: fix miss physical address

2019-06-20 Thread Tianfei zhang
Fix miss phy_addr on ifpga_acc_get_region_info() function. Fixes: 56bb54ea1bd ("raw/ifpga/base: add Intel FPGA OPAE share code") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 1 + 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value

2019-06-10 Thread Tianfei zhang
Add checking the buffer size and use const char * for buffer declaration. Coverity issue: 279449 Fixes: ef1e8ede ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 4 +-- drivers/raw/if

[dpdk-dev] [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code

2019-06-10 Thread Tianfei zhang
add temporary variable in max10_reg_write(). Coverity issue: 337927 Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH v3 4/4] raw/ifpga_rawdev/base: fix miss physical address

2019-06-10 Thread Tianfei zhang
Fix miss phy_addr on ifpga_acc_get_region_info() function. Fixes: 56bb54ea1bd ("raw/ifpga/base: add Intel FPGA OPAE share code") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[dpdk-dev] [PATCH v3 3/4] raw/ifpga_rawdev/base: fix bit fields definition

2019-06-10 Thread Tianfei zhang
Fix CTRL_DEV_SELECT bit fields definition about eth_group devices. Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/opae_eth_group.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check

2019-09-17 Thread Tianfei zhang
Add pointer null check before dereference. Coverity issue: 344976 Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/base/opae_eth_group.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[dpdk-dev] [PATCH v3 1/5] raw/ifpga/base: fix interrupt handler instance usage

2020-10-23 Thread Tianfei zhang
'ifpga_irq_handle' as intended. Fixes: e0a1aafe ("raw/ifpga: introduce IRQ functions") Cc: sta...@dpdk.org Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- v2: fix typo in commit log v3: slit into 2 patches, one is fix the pointer variable, other is fix the return

[dpdk-dev] [PATCH v3 3/5] raw/ifpga/base: fix return of IRQ unregister properly

2020-10-23 Thread Tianfei zhang
.@dpdk.org Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 374a7ff1d..04ca5032a 100644 --- a/drivers/raw/ifpga/if

[dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process

2020-10-23 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Patch #1: Fix a bug for register and unregister interrupt functions. Patch #2: Fix the return value of unsupported interrupt type. Patch #3: Fix the r

[dpdk-dev] [PATCH v3 2/5] raw/ifpga/base: handle unsupported interrupt type

2020-10-23 Thread Tianfei zhang
.org Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 76b0f8a5b..374a7ff1d 100644 --- a/drivers/raw/ifpga/if

[dpdk-dev] [PATCH v3 5/5] raw/ifpga/base: enhance driver reliablity in multi-process

2020-10-23 Thread Tianfei zhang
be cached in shared memory. Then MAX10 driver can read DTB from shared memory instead of flash. This avoid confliction of concurrent flash access between hardware and software. Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/base/ifpga_fme.c| 52 +++- dr

[dpdk-dev] [PATCH v3 4/5] raw/ifpga/base: free resources when destroying ifpga device

2020-10-23 Thread Tianfei zhang
urces. Also 'opae_adapter_free()' is removed from 'ifpga_rawdev_destroy()', because opae adapter is pointed by dev_private member in raw_dev, it will be freed in 'rte_rawdev_pmd_release()'. Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- v3: Free the driver

[dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process

2020-10-23 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Main changes from v3: - Split into 2 small patches, one is fix the pointer variable, other is fix the return value. - Free the driver's resource in ra

[dpdk-dev] [PATCH v3 1/2] raw/ifpga/base: fix spi transaction issue

2020-07-14 Thread Tianfei zhang
From: Tianfei Zhang 0x4a means idle status on physical layer. when encounter 0x4a on raw data, it need insert a ESCAPE character for indication. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- v3: resend wit

[dpdk-dev] [PATCH v3 2/2] raw/ifpga/base: fix NIOS SPI initial

2020-07-14 Thread Tianfei zhang
From: Tianfei Zhang Add fecmode setting on NIOS SPI primary initialization. this SPI is shared by NIOS core inside FPGA, NIOS will use this SPI primary to do some one-time initialization after power up, and then release the control to DPDK. Fix the timeout initialization for polling the

[dpdk-dev] [PATCH v4 0/4] raw/ifpga/base: An inprovement for multi-process

2020-09-23 Thread Tianfei zhang
This patches set will impove the ifpga base driver reliablity in multi-process envirment. Patch #1: Fix a bug for register and unregister interrupt functions. Patch #2: Add two functions to free the resouce when we destroy the opae adapter. Patch #3: Add function ifpga_rawdev_cleanup() to cleanup

[dpdk-dev] [PATCH v4 1/4] raw/ifpga/base: fix bug in IRQ functions

2020-09-23 Thread Tianfei zhang
.@dpdk.org Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 41 ++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index a50173264..374a7ff1d 10

[dpdk-dev] [PATCH v4 2/4] raw/ifpga/base: free resources when destroying ifpga device

2020-09-23 Thread Tianfei zhang
adapter will be released in rte_rawdev_pmd_release(). Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/base/ifpga_api.c | 12 drivers/raw/ifpga/base/ifpga_enumerate.c | 16 drivers/raw/ifpga/base/ifpga_enumerate.h | 1 + drivers/raw

[dpdk-dev] [PATCH v4 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit

2020-09-23 Thread Tianfei zhang
From: Wei Huang Add function ifpga_rawdev_cleanup() to cleanup all ifpga raw devices and register it as RTE_FINI function to make it called after main(). Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 20 1 file changed, 20

[dpdk-dev] [PATCH v4 4/4] raw/ifpga/base: enhance driver reliablity in multi-process

2020-09-23 Thread Tianfei zhang
be cached in shared memory. Then MAX10 driver can read DTB from shared memory instead of flash. This avoid confliction of concurrent flash access between hardware and software. Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/base/ifpga_fme.c| 52 +++- dr

[dpdk-dev] [PATCH v2 0/4] raw/ifpga/base: An improvement for multi-process

2020-09-27 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Patch #1: Fix a bug for register and unregister interrupt functions. Patch #2: Add two functions to free the resource when we destroy the opae adapter

[dpdk-dev] [PATCH v2 1/4] raw/ifpga/base: fix bug in IRQ functions

2020-09-27 Thread Tianfei zhang
.@dpdk.org Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- v2: fix typo in commit log --- drivers/raw/ifpga/ifpga_rawdev.c | 41 ++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawd

[dpdk-dev] [PATCH v2 2/4] raw/ifpga/base: free resources when destroying ifpga device

2020-09-27 Thread Tianfei zhang
adapter will be released in rte_rawdev_pmd_release(). Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/base/ifpga_api.c | 12 drivers/raw/ifpga/base/ifpga_enumerate.c | 16 drivers/raw/ifpga/base/ifpga_enumerate.h | 1 + drivers/raw

[dpdk-dev] [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit

2020-09-27 Thread Tianfei zhang
From: Wei Huang Add function ifpga_rawdev_cleanup() to cleanup all ifpga raw devices and register it as RTE_FINI function to make it called after main(). Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 20 1 file changed, 20

[dpdk-dev] [PATCH v2 4/4] raw/ifpga/base: enhance driver reliability in multi-process

2020-09-27 Thread Tianfei zhang
be cached in shared memory. Then MAX10 driver can read DTB from shared memory instead of flash. This avoid confliction of concurrent flash access between hardware and software. Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- v2: fix typo in commit log. 'master' is not misspell