[PATCH v3 0/3] add uncore api to be called through l3fwd-power

2022-09-19 Thread Tadhg Kearney
: tadhgkearney --- v2: Fix compilation warnings and errors. v3: Remove addition of x86 global macros. Add 2 new API's for getting package and die numbers from system. Address comments from mailing list. Improve efficiency of code and code quality. Tadhg Kearney (3): power: add uncore frequency co

[PATCH v3 1/3] power: add uncore frequency control API to the power library

2022-09-19 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney --- doc/g

[PATCH v3 2/3] l3fwd-power: add option to call uncore API

2022-09-19 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst

[PATCH v3 3/3] test/power: add unit tests for uncore API

2022-09-19 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 293 +++ 2 files changed, 295 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --

[PATCH v4 0/3] add uncore api to be called through l3fwd-power

2022-09-20 Thread Tadhg Kearney
: tadhgkearney --- v2: Fix compilation warnings and errors. v3: Remove addition of x86 global macros. Add 2 new API's for getting package and die numbers from system. Address comments from mailing list. Improve efficiency of code and code quality. v4: Fix compilation warnings and errors. Tadhg Kearn

[PATCH v4 1/3] power: add uncore frequency control API to the power library

2022-09-20 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney --- doc/g

[PATCH v4 2/3] l3fwd-power: add option to call uncore API

2022-09-20 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst

[PATCH v4 3/3] test/power: add unit tests for uncore API

2022-09-20 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 299 +++ 2 files changed, 301 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --

[PATCH v5 0/3] add uncore api to be called through l3fwd-power

2022-09-27 Thread Tadhg Kearney
error message for uncore access not working. Tadhg Kearney (3): power: add uncore frequency control API to the power library l3fwd-power: add option to call uncore API test/power: add unit tests for uncore API app/test/meson.build | 2 + app/test/test_power_unc

[PATCH v5 1/3] power: add uncore frequency control API to the power library

2022-09-27 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney --- doc/g

[PATCH v5 2/3] l3fwd-power: add option to call uncore API

2022-09-27 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst

[PATCH v5 3/3] test/power: add unit tests for uncore API

2022-09-27 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 301 +++ 2 files changed, 303 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --

[PATCH v6 0/3] add uncore api to be called through l3fwd-power

2022-09-28 Thread Tadhg Kearney
s and errors. v5: Improve error message for uncore access not working. v6: Fix uncore exit being called if uncore option not selected. Tadhg Kearney (3): power: add uncore frequency control API to the power library l3fwd-power: add option to call uncore API test/power: add unit tests for uncor

[PATCH v6 1/3] power: add uncore frequency control API to the power library

2022-09-28 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney Review

[PATCH v6 2/3] l3fwd-power: add option to call uncore API

2022-09-28 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt --- .../sample_app_ug

[PATCH v6 3/3] test/power: add unit tests for uncore API

2022-09-28 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 301 +++ 2 files changed, 303 insertions(+) create mode 100644 app

[PATCH v7 0/3] add uncore api to be called through l3fwd-power

2022-09-28 Thread Tadhg Kearney
s and errors. v5: Improve error message for uncore access not working. v6: Fix uncore exit being called if uncore option not selected. v7: Address ml comments. Tadhg Kearney (3): power: add uncore frequency control API to the power library l3fwd-power: add option to call uncore API test/power

[PATCH v7 1/3] power: add uncore frequency control API to the power library

2022-09-28 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney Review

[PATCH v7 2/3] l3fwd-power: add option to call uncore API

2022-09-28 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt --- .../sample_app_ug

[PATCH v7 3/3] test/power: add unit tests for uncore API

2022-09-28 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 301 +++ 2 files changed, 303 insertions(+) create mode 100644 app

[PATCH v8 0/3] add Intel uncore api to be called through l3fwd-power

2022-10-05 Thread Tadhg Kearney
: Fix compilation warnings and errors. v5: Improve error message for uncore access not working. v6: Fix uncore exit being called if uncore option not selected. v7: Address mailing list comments. v8: Address mailing list comments. Tadhg Kearney (3): power: add Intel uncore frequency control API to power li

[PATCH v8 1/3] power: add Intel uncore frequency control API to power library

2022-10-05 Thread Tadhg Kearney
maximum uncore frequency values and works on Linux for Intel hardware. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst| 54 +++ doc/guides/rel_notes/release_22_11.rst | 6 + lib/power/meson.build | 2 + lib

[PATCH v8 3/3] test/power: add unit tests for uncore API

2022-10-05 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_intel_uncore.c | 301 + 2 files changed, 303 insertions(+) c

[PATCH v8 2/3] l3fwd-power: add option to call uncore API

2022-10-05 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt

[PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power

2022-10-06 Thread Tadhg Kearney
: Fix compilation warnings and errors. v5: Improve error message for uncore access not working. v6: Fix uncore exit being called if uncore option not selected. v7: Address mailing list comments. v8: Address mailing list comments. v9: Fix build errors. Tadhg Kearney (3): power: add Intel uncore freq

[PATCH v9 1/3] power: add Intel uncore frequency control API to power library

2022-10-06 Thread Tadhg Kearney
maximum uncore frequency values and works on Linux for Intel hardware. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst| 54 +++ doc/guides/rel_notes/release_22_11.rst | 6 + lib/power/meson.build | 2 + lib

[PATCH v9 2/3] l3fwd-power: add option to call uncore API

2022-10-06 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt

[PATCH v9 3/3] test/power: add unit tests for uncore API

2022-10-06 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_intel_uncore.c | 301 + 2 files changed, 303 insertions(+) c

[PATCH] power: fix resource leak by open file pointers

2022-10-12 Thread Tadhg Kearney
Close file pointers to Intel uncore sysfiles. Coverity issue: 381400 381397 Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") CC: david.h...@intel.com Signed-off-by: Tadhg Kearney --- lib/power/rte_power_intel_uncore.c | 5 + 1 file changed, 5 insertions(+) di

[PATCH] power: fix double free of opened files

2022-11-04 Thread Tadhg Kearney
Fix double free of f_min and f_max by reverting the flcose() for f_min and f_max. As f_min and f_max are stored for further use and closed in uncore deinitialization. Fixes: b127e74 ("power: fix open file descriptors leak") Signed-off-by: Tadhg Kearney --- lib/power/rte_power_inte

[PATCH v2 0/3] add uncore api to be called through l3fwd-power

2022-07-13 Thread Tadhg Kearney
This is targeting 22.11 and aims to add an API to DPDK to allow uncore frequency adjustment. This will be called through the l3fwd-power app, and gives the ability to set the min, max and specific frequency index that you want the uncore to be at. Signed-off-by: Tadhg Kearney --- v2: Fix

[PATCH v2 1/3] power: add uncore API to power library

2022-07-13 Thread Tadhg Kearney
Add api to allow uncore frequency adjustment. This is done through manipulating related sysfs entries to adjust the min/max uncore values. Seven api's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney --- config/x86/meson.build | 2 + doc/g

[PATCH v2 2/3] test/power: add unit tests for uncore API

2022-07-13 Thread Tadhg Kearney
Add basic unit tests covering all seven uncore api's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 245 +++ 2 files changed, 247 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --

[PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-13 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore api. This will be set for each package and die on the SKU. On exit, uncore frequency will be reverted back to previous frequency. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst| 28