Re: [dpdk-dev] [PATCH v2 2/8] net/bnxt: fix to avoid a segfault

2017-07-21 Thread Stephen Hurd
> > Fixes: 36735a932ca7 ("support set VF QOS and MAC anti spoof") > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde > > -- > v1->v2: incorporate review feedback. > --- > drivers/net/bnxt/rte_pmd_bnxt.c | 101 +++---

[dpdk-dev] [PATCH] bnxt: Update MAINTAINERS file for bnxt driver

2016-09-21 Thread Stephen Hurd
On Wed, Sep 21, 2016 at 3:27 PM, Ajit Khaparde wrote: > Add Ajit Khaparde as the maintainer of the bnxt PMD > > CC: Stephen Hurd > Signed-off-by: Ajit Khaparde > Reviewed-by: David Christensen > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > &

[dpdk-dev] [PATCH] app/test-pmd: Detect NUMA socket count

2015-08-20 Thread Stephen Hurd
max number of sockets is required. Signed-off-by: Stephen Hurd --- app/test-pmd/parameters.c | 12 ++-- app/test-pmd/testpmd.c| 17 + app/test-pmd/testpmd.h| 3 +-- 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/app/test-pmd/parameters.c b/app

[dpdk-dev] [PATCH] app/testpmd Fix max_socket detection

2016-01-13 Thread Stephen Hurd
Previously, max_socket was set to the highest numbered socket with an enabled lcore. The intent is to set it to the highest socket regardless of it being enabled. Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132 Signed-off-by: Stephen Hurd --- app/test-pmd/testpmd.c | 10 +- 1 file

[dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection

2016-01-13 Thread Stephen Hurd
Previously, max_socket was set to the highest numbered socket with an enabled lcore. The intent is to set it to the highest socket regardless of it being enabled. Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132 Signed-off-by: Stephen Hurd v2: Forgot to commit before sending email... sorry

[dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection

2016-01-15 Thread Stephen Hurd
L: Error - exiting with code: 1 >> Cause: The socket number should be < 1 >> His example command was: ./testpmd -c 0x3 -n 4 -- -i -socket-num=1 -- Stephen Hurd -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Thursday, January 14, 2016 5

[dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection

2016-01-15 Thread Stephen Hurd
Found it... http://www.dpdk.org/ml/archives/dev/2015-December/030564.html -- Stephen Hurd -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Thursday, January 14, 2016 5:44 AM To: Stephen Hurd Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app

[dpdk-dev] [PATCH v5 03/38] bnxt: add driver register/unregister support

2016-06-14 Thread Stephen Hurd
used by the function driver to unregister with the HWRM. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comment regarding removal of bnxt_dev_close_op v5: Reformat footer Add HWRM function descriptions --- drivers/net/bnxt

[dpdk-dev] [PATCH v5 02/38] bnxt: add HWRM init code

2016-06-14 Thread Stephen Hurd
Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix few issues highlighted by checkpatch. v5: Fix footer formatting Switch to using the HWRM function descriptions from the source documentation --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH v5 07/38] bnxt: declare generic ring structs and free() func

2016-06-14 Thread Stephen Hurd
the ring types and tracks the the host Buffer Descriptors (BDs) and the HWRM assigned ID. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address checkpatch warnings. v5: Reorder footer --- drivers/net/bnxt/Makefile| 1 + drivers/net/bnxt

[dpdk-dev] [PATCH v5 05/38] bnxt: add dev configure operation

2016-06-14 Thread Stephen Hurd
calls: bnxt_hwrm_port_phy_cfg: This command configures the PHY device for the port. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fixed few issues identified by checkpatch. v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v5 08/38] bnxt: add completion ring support

2016-06-14 Thread Stephen Hurd
HWRM interface if needed. New HWRM Calls: bnxt_hwrm_exec_fwd_resp: Execute an encapsulated command and forward the response. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch.

[dpdk-dev] [PATCH v5 10/38] bnxt: add Tx queue operations (nonfunctional)

2016-06-14 Thread Stephen Hurd
. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v5 12/38] bnxt: add statistics operations

2016-06-14 Thread Stephen Hurd
memory allocated by the driver for statistics. New HWRM calls: bnxt_hwrm_stat_clear: This command clears statistics of a context Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch

[dpdk-dev] [PATCH v5 36/38] bnxt: add reta update/query operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add code to Update/query reta dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added earlier. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt

[dpdk-dev] [PATCH v5 38/38] bnxt: add flow control operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add flow_ctrl_get and flow_ctrl_set dev_ops. Uses the bnxt_set_hwrm_link_config() HWRM API added in earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v5 30/38] bnxt: add start/stop/link update operations

2016-06-14 Thread Stephen Hurd
-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. Shorten the string passed for reserving memzone when default completion ring is created. v5: Reorder footer --- drivers/net/bnxt/bnxt_ethdev.c | 269 + 1 file

[dpdk-dev] [PATCH v5 26/38] bnxt: add HWRM stat context free function

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add function and associated structures and definitions to free statistics context from the ASIC. New HWRM call: bnxt_hwrm_stat_ctx_free This command is used to free a stat context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v5 22/38] bnxt: add API for L2 Rx mask set/clear functions

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add API to set/clear L2 Rx mask. New HWRM calls: bnxt_hwrm_cfa_l2_clear_rx_mask bnxt_hwrm_cfa_l2_set_rx_mask These HWRM APIs allow setting and clearing of Rx masks in L2 context per VNIC. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v5 18/38] bnxt: add HWRM vnic free function

2016-06-14 Thread Stephen Hurd
: bnxt_hwrm_vnic_free: Frees a vnic allocated by the bnxt_hwrm_vnic_alloc() function. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 21 + drivers/net

[dpdk-dev] [PATCH v5 20/38] bnxt: add API to allow configuration of vnic

2016-06-14 Thread Stephen Hurd
bnxt_hwrm_vnic_ctx_free: Used to free COS/Load Balance context of VNIC Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: More description in commit log Reorder footer

[dpdk-dev] [PATCH v5 15/38] bnxt: add code to alloc/free Tx Rx and cmpl rings

2016-06-14 Thread Stephen Hurd
allocation fails. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. Change the argument passed to bnxt_alloc_rings. Instead of passing bnxt_tx_ring and bnxt_rx_ring, shorten them to

[dpdk-dev] [PATCH v5 17/38] bnxt: add HWRM vnic alloc function

2016-06-14 Thread Stephen Hurd
such as RSS, MAC filtering etc.. for the physical function in use. New HWRM call: bnxt_hwrm_vnic_alloc: Allocates a VNIC resource in the hardware. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder

[dpdk-dev] [PATCH v5 04/38] bnxt: add dev infos get operation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Gets device info from the bp structure filled in the init() function. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer --- drivers/net/bnxt/bnxt.h| 3 ++ drivers/net/bnxt/bnxt_ethdev.c | 95

[dpdk-dev] [PATCH v5 23/38] bnxt: add HWRM API for stats context allocation

2016-06-14 Thread Stephen Hurd
at context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt/bnxt_hwrm.c | 52 d

[dpdk-dev] [PATCH v5 06/38] bnxt: add vnic functions and structs

2016-06-14 Thread Stephen Hurd
Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 14 ++ drivers/net/bnxt/bnxt_vnic.c | 277 + drivers/net/bnxt/bnxt_vnic.h

[dpdk-dev] [PATCH v5 32/38] bnxt: add all multicast enable/disable operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to enable/disable multicast traffic. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer Rewrite the patch

[dpdk-dev] [PATCH v5 31/38] bnxt: add promiscuous enable/disable operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the promiscuous mode enable and disable dev_ops. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix couple of typos in the commit

[dpdk-dev] [PATCH v5 25/38] bnxt: add ring group alloc/free functions

2016-06-14 Thread Stephen Hurd
HWRM calls: bnxt_hwrm_ring_grp_alloc Allocates and does basic preparation for a ring group bnxt_hwrm_ring_grp_free Frees and does cleansup resources of a ring group Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address issues

[dpdk-dev] [PATCH v5 37/38] bnxt: add RSS device operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add rss_hash_update and rss_hash_conf_get dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the

[dpdk-dev] [PATCH v5 01/38] bnxt: new driver for Broadcom NetXtreme-C devices

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the initial skeleton for bnxt driver along with the nic guide to tie into the build system. At this point, the driver simply fails init. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix a warning that the

[dpdk-dev] [PATCH v5 28/38] bnxt: allocate and free all HWRM rings and groups

2016-06-14 Thread Stephen Hurd
needed to add start/stop device operations. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comment to merge another patch into this to avoid a compilation issue. Fix issues pointed out by checkpatch. v5: Reorder the footer. Remove

[dpdk-dev] [PATCH v5 35/38] bnxt: add set link up/down operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Adds dev_ops to set link UP or DOWN as appropriate. Uses the bnxt_set_hwrm_link_config() API added in previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v5 27/38] bnxt: add HWRM API to set and clear filters

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde New HWRM call: bnxt_clear_hwrm_vnic_filters This patch adds code to set and clear L2 filters from the corresponding VNIC. These filters will determine the Rx flows Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen

[dpdk-dev] [PATCH v5 13/38] bnxt: add initial Tx code implementation

2016-06-14 Thread Stephen Hurd
Tx operations. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Expand the patch description Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt

[dpdk-dev] [PATCH v5 21/38] bnxt: add HWRM API to configure RSS

2016-06-14 Thread Stephen Hurd
of the VNIC. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Expand the commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 24 drivers/net/bnxt/bnxt_hwrm.h | 2 ++ drivers/net/bnxt

[dpdk-dev] [PATCH v5 19/38] bnxt: add HWRM vnic configure function

2016-06-14 Thread Stephen Hurd
vnic_alloc function from the previous patch. bnxt_hwrm_vnic_cfg: Configure the VNIC structure in hardware. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c

[dpdk-dev] [PATCH v5 11/38] bnxt: add Rx queue create/destroy operations

2016-06-14 Thread Stephen Hurd
patches. We are also adding hwrm_vnic_rss_cfg_* structures, which will be used in subsequent patches to enable RSS configuration. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5

[dpdk-dev] [PATCH v5 16/38] bnxt: add HWRM function reset command

2016-06-14 Thread Stephen Hurd
ff-by: Stephen Hurd Reviewed-by: David Christensen -- More descriptive commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 17 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 129 + 3 files changed

[dpdk-dev] [PATCH v5 09/38] bnxt: add L2 filter alloc/init/free

2016-06-14 Thread Stephen Hurd
the incoming traffic to an appropriate VNIC or Rx ring. New HWRM calls: bnxt_hwrm_clear_filter: Free a L2 filter. bnxt_hwrm_set_filter Allocate an An L2 filter or a L2 context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4

[dpdk-dev] [PATCH v5 14/38] bnxt: add initial Rx code implementation

2016-06-14 Thread Stephen Hurd
() bnxt_init_rx_ring_struct() which initializes various structures before a Rx can begin. bnxt_init_rxbds() initializes the Rx Buffer Descriptors while bnxt_alloc_rx_data() allocates a buffer in the host to receive the incoming packet. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v5 29/38] bnxt: add HWRM port PHY config call and helpers

2016-06-14 Thread Stephen Hurd
link state. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Reorder footer Rewrite the patch description. --- drivers/net/bnxt/bnxt_hwrm.c | 120 + drivers/net/bnxt/bnxt_hwrm.h

[dpdk-dev] [PATCH v5 24/38] bnxt: add HWRM ring alloc/free functions

2016-06-14 Thread Stephen Hurd
-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments. v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt/bnxt_hwrm.c | 108 drivers/net/bnxt/bnxt_hwrm.h | 7 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 305

[dpdk-dev] [PATCH v5 33/38] bnxt: free memory in close operation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds code to free all resources except the one corresponding to HWRM, which are required to notify the HWRM that the driver is unloaded (these are freed in uninit()). Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5

[dpdk-dev] [PATCH v5 34/38] bnxt: add MAC address add/remove dev ops

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to Add/Remove MAC addresses. These use the bnxt_hwrm_set_filter() defined in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the

[dpdk-dev] [PATCH v5 02/38] bnxt: add HWRM init code

2016-06-15 Thread Stephen Hurd
_FLOW_CONTROL > This is intentional, is this style of copy/paste avoidance not allowed? -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd at broadcom.com

[dpdk-dev] [PATCH v6 00/38] new bnxt poll mode driver library

2016-06-15 Thread Stephen Hurd
The bnxt poll mode library (librte_pmd_bnxt) implements support for Broadcom NetXtreme C-Series. These adapters support Standards- compliant 10/25/50Gbps 30MPPS full-duplex throughput. Information about this family of adapters can be found in the NetXtreme Brand section https://goo.gl/4H7q63 of t

[dpdk-dev] [PATCH v6 01/38] bnxt: new driver for Broadcom NetXtreme-C devices

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the initial skeleton for bnxt driver along with the nic guide to tie into the build system. At this point, the driver simply fails init. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix a warning that the

[dpdk-dev] [PATCH v6 04/38] bnxt: add dev infos get operation

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Gets device info from the bp structure filled in the init() function. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer --- drivers/net/bnxt/bnxt.h| 3 ++ drivers/net/bnxt/bnxt_ethdev.c | 95

[dpdk-dev] [PATCH v6 06/38] bnxt: add vnic functions and structs

2016-06-15 Thread Stephen Hurd
Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 14 ++ drivers/net/bnxt/bnxt_vnic.c | 277 + drivers/net/bnxt/bnxt_vnic.h

[dpdk-dev] [PATCH v6 07/38] bnxt: declare generic ring structs and free() func

2016-06-15 Thread Stephen Hurd
the ring types and tracks the the host Buffer Descriptors (BDs) and the HWRM assigned ID. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address checkpatch warnings. v5: Reorder footer v6: Correct typo --- drivers/net/bnxt/Makefile| 1

[dpdk-dev] [PATCH v6 05/38] bnxt: add dev configure operation

2016-06-15 Thread Stephen Hurd
calls: bnxt_hwrm_port_phy_cfg: This command configures the PHY device for the port. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fixed few issues identified by checkpatch. v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v6 03/38] bnxt: add driver register/unregister support

2016-06-15 Thread Stephen Hurd
used by the function driver to unregister with the HWRM. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comment regarding removal of bnxt_dev_close_op v5: Reformat footer Add HWRM function descriptions --- drivers/net/bnxt

[dpdk-dev] [PATCH v6 15/38] bnxt: add code to alloc/free Tx Rx and cmpl rings

2016-06-15 Thread Stephen Hurd
allocation fails. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. Change the argument passed to bnxt_alloc_rings. Instead of passing bnxt_tx_ring and bnxt_rx_ring, shorten them to

[dpdk-dev] [PATCH v6 13/38] bnxt: add initial Tx code implementation

2016-06-15 Thread Stephen Hurd
Tx operations. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Expand the patch description Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt

[dpdk-dev] [PATCH v6 16/38] bnxt: add HWRM function reset command

2016-06-15 Thread Stephen Hurd
ff-by: Stephen Hurd Reviewed-by: David Christensen -- More descriptive commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 17 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 129 + 3 files changed

[dpdk-dev] [PATCH v6 10/38] bnxt: add Tx queue operations (nonfunctional)

2016-06-15 Thread Stephen Hurd
. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v6 11/38] bnxt: add Rx queue create/destroy operations

2016-06-15 Thread Stephen Hurd
patches. We are also adding hwrm_vnic_rss_cfg_* structures, which will be used in subsequent patches to enable RSS configuration. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5

[dpdk-dev] [PATCH v6 17/38] bnxt: add HWRM vnic alloc function

2016-06-15 Thread Stephen Hurd
such as RSS, MAC filtering etc.. for the physical function in use. New HWRM call: bnxt_hwrm_vnic_alloc: Allocates a VNIC resource in the hardware. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder

[dpdk-dev] [PATCH v6 26/38] bnxt: add HWRM stat context free function

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Add function and associated structures and definitions to free statistics context from the ASIC. New HWRM call: bnxt_hwrm_stat_ctx_free This command is used to free a stat context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v6 20/38] bnxt: add API to allow configuration of vnic

2016-06-15 Thread Stephen Hurd
bnxt_hwrm_vnic_ctx_free: Used to free COS/Load Balance context of VNIC Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: More description in commit log Reorder footer

[dpdk-dev] [PATCH v6 12/38] bnxt: add statistics operations

2016-06-15 Thread Stephen Hurd
memory allocated by the driver for statistics. New HWRM calls: bnxt_hwrm_stat_clear: This command clears statistics of a context Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch

[dpdk-dev] [PATCH v6 25/38] bnxt: add ring group alloc/free functions

2016-06-15 Thread Stephen Hurd
HWRM calls: bnxt_hwrm_ring_grp_alloc Allocates and does basic preparation for a ring group bnxt_hwrm_ring_grp_free Frees and does cleanup resources of a ring group Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address issues

[dpdk-dev] [PATCH v6 19/38] bnxt: add HWRM vnic configure function

2016-06-15 Thread Stephen Hurd
vnic_alloc function from the previous patch. bnxt_hwrm_vnic_cfg: Configure the VNIC structure in hardware. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c

[dpdk-dev] [PATCH v6 27/38] bnxt: add HWRM API to set and clear filters

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde New HWRM call: bnxt_clear_hwrm_vnic_filters This patch adds code to set and clear L2 filters from the corresponding VNIC. These filters will determine the Rx flows Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen

[dpdk-dev] [PATCH v6 29/38] bnxt: add HWRM port PHY config call and helpers

2016-06-15 Thread Stephen Hurd
link state. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Reorder footer Rewrite the patch description. --- drivers/net/bnxt/bnxt_hwrm.c | 120 + drivers/net/bnxt/bnxt_hwrm.h

[dpdk-dev] [PATCH v6 38/38] bnxt: add flow control operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Add flow_ctrl_get and flow_ctrl_set dev_ops. Uses the bnxt_set_hwrm_link_config() HWRM API added in earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v6 32/38] bnxt: add all multicast enable/disable operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to enable/disable multicast traffic. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer Rewrite the patch

[dpdk-dev] [PATCH v6 22/38] bnxt: add API for L2 Rx mask set/clear functions

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Add API to set/clear L2 Rx mask. New HWRM calls: bnxt_hwrm_cfa_l2_clear_rx_mask bnxt_hwrm_cfa_l2_set_rx_mask These HWRM APIs allow setting and clearing of Rx masks in L2 context per VNIC. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v6 34/38] bnxt: add MAC address add/remove dev ops

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to Add/Remove MAC addresses. These use the bnxt_hwrm_set_filter() defined in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the

[dpdk-dev] [PATCH v6 23/38] bnxt: add HWRM API for stats context allocation

2016-06-15 Thread Stephen Hurd
at context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch. v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt/bnxt_hwrm.c | 52 d

[dpdk-dev] [PATCH v6 31/38] bnxt: add promiscuous enable/disable operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the promiscuous mode enable and disable dev_ops. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix couple of typos in the commit

[dpdk-dev] [PATCH v6 35/38] bnxt: add set link up/down operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Adds dev_ops to set link UP or DOWN as appropriate. Uses the bnxt_set_hwrm_link_config() API added in previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer

[dpdk-dev] [PATCH v6 02/38] bnxt: add HWRM init code

2016-06-15 Thread Stephen Hurd
Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix few issues highlighted by checkpatch. v5: Fix footer formatting Switch to using the HWRM function descriptions from the source documentation --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH v6 08/38] bnxt: add completion ring support

2016-06-15 Thread Stephen Hurd
HWRM interface if needed. New HWRM Calls: bnxt_hwrm_exec_fwd_resp: Execute an encapsulated command and forward the response. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments and fix issues pointed out by checkpatch.

[dpdk-dev] [PATCH v6 21/38] bnxt: add HWRM API to configure RSS

2016-06-15 Thread Stephen Hurd
of the VNIC. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Expand the commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 24 drivers/net/bnxt/bnxt_hwrm.h | 2 ++ drivers/net/bnxt

[dpdk-dev] [PATCH v6 14/38] bnxt: add initial Rx code implementation

2016-06-15 Thread Stephen Hurd
() bnxt_init_rx_ring_struct() which initializes various structures before a Rx can begin. bnxt_init_rxbds() initializes the Rx Buffer Descriptors while bnxt_alloc_rx_data() allocates a buffer in the host to receive the incoming packet. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH v6 18/38] bnxt: add HWRM vnic free function

2016-06-15 Thread Stephen Hurd
: bnxt_hwrm_vnic_free: Frees a vnic allocated by the bnxt_hwrm_vnic_alloc() function. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Add more description in commit log Reorder footer --- drivers/net/bnxt/bnxt_hwrm.c | 21 + drivers/net

[dpdk-dev] [PATCH v6 09/38] bnxt: add L2 filter alloc/init/free

2016-06-15 Thread Stephen Hurd
the incoming traffic to an appropriate VNIC or Rx ring. New HWRM calls: bnxt_hwrm_clear_filter: Free a L2 filter. bnxt_hwrm_set_filter Allocate an An L2 filter or a L2 context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4

[dpdk-dev] [PATCH v6 28/38] bnxt: allocate and free all HWRM rings and groups

2016-06-15 Thread Stephen Hurd
needed to add start/stop device operations. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comment to merge another patch into this to avoid a compilation issue. Fix issues pointed out by checkpatch. v5: Reorder the footer. Remove

[dpdk-dev] [PATCH v6 24/38] bnxt: add HWRM ring alloc/free functions

2016-06-15 Thread Stephen Hurd
-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Address review comments. v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt/bnxt_hwrm.c | 108 drivers/net/bnxt/bnxt_hwrm.h | 7 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 305

[dpdk-dev] [PATCH v6 36/38] bnxt: add reta update/query operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Add code to Update/query reta dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added earlier. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt

[dpdk-dev] [PATCH v6 33/38] bnxt: free memory in close operation

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde This patch adds code to free all resources except the one corresponding to HWRM, which are required to notify the HWRM that the driver is unloaded (these are freed in uninit()). Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5

[dpdk-dev] [PATCH v6 30/38] bnxt: add start/stop/link update operations

2016-06-15 Thread Stephen Hurd
-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. Shorten the string passed for reserving memzone when default completion ring is created. v5: Reorder footer v6: Correct typos --- drivers/net/bnxt/bnxt_ethdev.c | 269

[dpdk-dev] [PATCH v6 37/38] bnxt: add RSS device operations

2016-06-15 Thread Stephen Hurd
From: Ajit Khaparde Add rss_hash_update and rss_hash_conf_get dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the

[dpdk-dev] New driver (large patch) question.

2016-03-01 Thread Stephen Hurd
I submitted a new driver on Friday, and it was rejected for being over 300k. The rejection email suggested contacing dev-owner at dpdk.org, which I did on Monday with no reply. What's the process to submit patches larger than the mailing list size limit? -- Stephen Hurd Principal Eng

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
x27;s not wanted either. I'll submit without comments in the hardware interface file and take it from there. On Wed, Mar 2, 2016 at 8:24 AM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Wed, 02 Mar 2016 11:21:26 +0100 > Thomas Monjalon wrote: > > > Hi, >

[dpdk-dev] [PATCH] drivers/net/bnxt New driver for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
Initial new driver for Broadcom bnxt (Cumulus) devices. - Adds drivers/net/bnxt and the librte_pmd_bnxt - Adds bnxt PCI IDs - Adds support for 2/2.5/25/50Gbps modes to rte_ethdev.h Signed-off-by: Stephen Hurd --- MAINTAINERS |4 + config/common_bsdapp

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
that's too big. On Wed, Mar 2, 2016 at 1:54 PM, Thomas Monjalon wrote: > 2016-03-02 13:30, Stephen Hurd: > > The bulk of the patch is the hardware interface header file. With all > the > > comments, it weighs in around 800k. If I strip the comments, it's around >

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon wrote: > > The comments in it are the only publicly available > > documentation on the hardware I'm aware of. > > So you must keep the comments. > That's my goal, but the comments are well over the 300k limit. > > The driver itself doesn't have a

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
ointers, I'll try to get as many of the suggestions done as possible and talk to marketing to find web resources for the device and its performance. -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd at broadcom.com

[dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds

2016-03-02 Thread Stephen Hurd
Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links Signed-off-by: Stephen Hurd --- lib/librte_ether/rte_ethdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 16da821..cb40bbb 100644 --- a/lib

[dpdk-dev] [PATCH 0/7] drivers/net/bnxt: new Broadcom bnxt driver

2016-03-02 Thread Stephen Hurd
New driver for Broadcom NetXtreme-C family of controllers and cards capable of up to 50Gbps link with 30Mpps throughput. v2: * Split into multiple patches * Add nic guide * Add features in overview.rst Stephen Hurd (7): lib/librte_ether: Add 2/2.5/25/50Gbps link speeds lib/librte_eal: Add

[dpdk-dev] [PATCH 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
Add Broadcom Vendor ID and RTE_PCI_DEV_ID_DECL_BNXT() macro. Add Device IDs for Broadcom bnxt devices. Signed-off-by: Stephen Hurd --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 45 ++--- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH 4/7] maintainers: claim drivers/net/bnxt

2016-03-02 Thread Stephen Hurd
Claim ownership of new drivers/net/bnxt driver. Signed-off-by: Stephen Hurd --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 628bc05..6ee6c3c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -359,6 +359,10 @@ F: drivers/crypto/aesni_mb/ Intel

[dpdk-dev] [PATCH 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
New driver for Broadcom bnxt (NexXtreme C-series) devices. Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput http://www.broadcom.com/press/release.php?id=s923886 Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 79 ++ drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH 5/7] build: add bnxt PMD to build

2016-03-02 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- config/common_bsdapp | 5 + config/common_linuxapp | 5 + drivers/net/Makefile | 1 + mk/rte.app.mk | 1 + 4 files changed, 12 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 696382c..f37c7bb 100644 --- a/config

[dpdk-dev] [PATCH 6/7] doc: Add bnxt to overview table

2016-03-02 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- doc/guides/nics/overview.rst | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index d4c6ff4..e606bdf 100644 --- a/doc/guides/nics

[dpdk-dev] [PATCH 7/7] doc: add guide for new bnxt driver

2016-03-02 Thread Stephen Hurd
Initial guide for bnxt driver, documents current limitations and provides information link. Signed-off-by: Stephen Hurd --- doc/guides/nics/bnxt.rst | 49 1 file changed, 49 insertions(+) create mode 100644 doc/guides/nics/bnxt.rst diff --git a

[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Stephen Hurd
Unfortunately no. On Wed, Mar 2, 2016 at 9:53 PM, Qiu, Michael wrote: > On 3/3/2016 7:11 AM, Stephen Hurd wrote: > > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > > > >>> The comments in it are the only

  1   2   3   >