[dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow

2020-07-06 Thread Shougang Wang
When create a rss rule with void action, the error log is "Invalid input set". This patch fix the issue by adding check for the type of first actions item. Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang

[dpdk-dev] [PATCH] net/i40e: fix queue region issue in RSS flow

2020-04-24 Thread Shougang Wang
This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_flow.c | 34 +++

[dpdk-dev] [PATCH v2] net/i40e: fix queue region issue in RSS flow

2020-04-24 Thread Shougang Wang
This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v2: -Update the various name. --- drivers/net/i40e/i40e_f

[dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow

2020-05-05 Thread Shougang Wang
This patch fixes the issue that the flow which both source MAC mask and destination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_flow.c | 3 ++- 1 fi

[dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

2020-05-07 Thread Shougang Wang
This patch fixes the issue that failed to create an RSS rule with type L2-payload. Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_flow.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletion

[dpdk-dev] [PATCH] net/ice: fix incorrect EEPROM data

2020-05-08 Thread Shougang Wang
Kernel driver reads EEPROM data from flash but DPDK reads from shadow ram. This patch fixes the issue by changing method to get EEPROM data from flash. Fixes: 68a1ab82ad74 ("net/ice: speed up to retrieve EEPROM") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/ne

[dpdk-dev] [PATCH v2] net/i40e: fix failing to create FDIR flow

2020-05-12 Thread Shougang Wang
This patch fixes the issue that the flow which both source MAC mask and destination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") Signed-off-by: Shougang Wang Tested-by: Hailin Xu Reviewed-by: Jeff Guo ---

[dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow

2020-05-12 Thread Shougang Wang
This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Reviewed-by: Jeff Guo --- drivers/net/i40e/i40e_f

[dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RSS flow

2020-05-15 Thread Shougang Wang
This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Reviewed-by: Jeff Guo Tested-by: Hailin Xu Tested-by: Lunyuan C

[dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-12 Thread Shougang Wang
sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 23b3f5b0c..206358b85 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/dr

[dpdk-dev] [PATCH] net/ixgbe: fix coverity issue

2020-02-10 Thread Shougang Wang
This patch fixes (Logically dead code ) coverity issue. Coverity issue: 353624 Fixes: ba7b12dd64e4 ("net/ixgbe: fix link up in FreeBSD") Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2] net/ixgbe: fix coverity issue

2020-02-11 Thread Shougang Wang
This patch fixes (Logically dead code ) coverity issue. Coverity issue: 353624 Fixes: ba7b12dd64e4 ("net/ixgbe: fix link up in FreeBSD") Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/d

[dpdk-dev] [PATCH] net/i40e: fix multiple interrupt for VF

2020-02-16 Thread Shougang Wang
Interrupt mapping should be 1:n queue(s).This patch fixes the logic of interrupt bind by code reconstruction. Fixes: 6a6cf5f88b4a ("net/i40e: enable multi-queue Rx interrupt for VF") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 63 -

[dpdk-dev] [PATCH] net/i40e: fix compile warning

2020-02-18 Thread Shougang Wang
This patch adds memset array before using. Fixes: 622e24aa6712 ("net/i40e: fix multiple interrupt for VF") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/driver

[dpdk-dev] [PATCH] net/i40e: fix DCB init issue

2020-03-05 Thread Shougang Wang
pport persistent LLDP") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 9fbda1c34..9f37662f8 100644 --- a/d

[dpdk-dev] [PATCH v2] net/ice: fix incorrect EEPROM data

2020-06-27 Thread Shougang Wang
Kernel driver reads EEPROM data from flash but DPDK reads from shadow ram. This patch fixes the issue by changing method to get EEPROM data from flash. Fixes: 68a1ab82ad74 ("net/ice: speed up to retrieve EEPROM") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/ic

[dpdk-dev] [PATCH v2] net/i40e: fix DCB init issue

2020-03-05 Thread Shougang Wang
pport persistent LLDP") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 9fbda1c34.

[dpdk-dev] [PATCH] net/iavf: unify Rx ptype table

2020-03-05 Thread Shougang Wang
From: Wang Shougang This patch unified the Rx ptype table. Signed-off-by: Wang Shougang --- drivers/net/iavf/iavf.h | 3 +- drivers/net/iavf/iavf_ethdev.c| 3 + drivers/net/iavf/iavf_rxtx.c | 604 +++--- drivers/net/iavf/iavf_rxtx.h

[dpdk-dev] [PATCH] net/ixgbe: fix qos sched sample app performance drop

2019-11-20 Thread Shougang Wang
Currently MACsec register is set without any conditions when start port. It should be set only when user needs. To avoid wild value, I add init function. This patch fixes the issue. Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") Signed-off-by: Shougang Wang --- drivers

[dpdk-dev] [PATCH v2] net/ixgbe: fix QoS performance drop issue

2019-11-21 Thread Shougang Wang
Currently macsec offload will be enabled all the time when device start. It will cause QoS sample application performance drop issue. This patch add check before this feature enabled. Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") Signed-off-by: Shougang Wang --- drivers

[dpdk-dev] [PATCH] net/ice: fix packet type table

2019-12-09 Thread Shougang Wang
According to comms package, index 94 should be MAC_IPV6_ICMP, not MAC_IPV4_ICMP. This patch fix the issue. Fixes: 4cf29798b4c9 ("net/ice: fix packet type table") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/ice_rxtx.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] doc: update firmware/driver mapping table for i40e

2020-11-10 Thread Shougang Wang
Update i40e PMD firmware/driver mapping table. Signed-off-by: Shougang Wang --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 828a25988..961a51820 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides

[dpdk-dev] [PATCH] net/i40e: fix incorrect hash look up table

2020-07-14 Thread Shougang Wang
initializing the LUT when creating an RSS rule. Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev.c | 52 ++ 1 file changed, 52 insertions(+) diff --git

[dpdk-dev] [PATCH] net/i40e: fix missed i40e filter pctype

2020-07-15 Thread Shougang Wang
The i40e_filter_pctype TCP_SYN_NO_ACK, UNICAST_IPV4_UDP and MULTICAST_IPV4_UDP for x722 are missed when translate RSS type to i40e_filter_pctype. This patche fix it. Fixes: da7018ec29d4 ("net/i40e: fix queue region in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- d

[dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-20 Thread Shougang Wang
creating an RSS rule. Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev.c | 134 - 1 file changed, 63 insertions(+), 71 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table

2020-07-22 Thread Shougang Wang
/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v3: -Updated the time of initializing the look up table --- drivers/net/i40e/i40e_ethdev.c | 85 -- 1 file changed, 49 insertions(+), 36 deletions(-) diff --git

[dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table

2020-07-23 Thread Shougang Wang
/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v4: -Updated code. --- drivers/net/i40e/i40e_ethdev.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40

[dpdk-dev] [PATCH v5] net/i40e: fix incorrect hash look up table

2020-07-24 Thread Shougang Wang
/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v5: -Removed useless function --- drivers/net/i40e/i40e_ethdev.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v6] net/i40e: fix incorrect hash look up table

2020-07-24 Thread Shougang Wang
/i40e: support hash configuration in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Tested-by: Zhang, XiX --- v6: -Remove useless comment. drivers/net/i40e/i40e_ethdev.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH] net/ice: fix incorrect firmware version

2020-08-06 Thread Shougang Wang
Kernel driver shows firmware version as hex but ice PMD shows as decimal. This patch fixes the issue to make consistent with kernel driver. Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drive

[dpdk-dev] [PATCH v2] net/ice: fix incorrect firmware version

2020-08-06 Thread Shougang Wang
Kernel driver shows firmware version as hex but ice PMD shows as decimal. This patch fixes the issue to make consistent with kernel driver. Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v2: corrected fix

[dpdk-dev] [PATCH v3] net/ice: fix incorrect firmware version

2020-09-10 Thread Shougang Wang
Kernel driver shows firmware version as hex but ice PMD shows as decimal. This patch fixes the issue to make consistent with kernel driver. Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Acked-by: Qiming Ya