Hi Honnappa,
Responses inline.
I will continue with an initial implementation of this feature and capture
performance data as suggested.
Rgds,
Rory
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Wednesday, April 5, 2023 1:46 AM
> To: Sexton, Rory ; konst
nd it
removes the need for an API change.
Rory
-Original Message-
From: Wu, Jingjing
Sent: Tuesday, January 17, 2017 3:09 PM
To: Sexton, Rory
Cc: dev@dpdk.org; Marjanovic, Nemanja
Subject: RE: [PATCH v2] net/i40e: set no drop for traffic class
> -Original Message-
> F
have to be increased to
2048 to eliminate packet loss.
Ideally it would be an optional setting as using it may increase the max
latency.
Regards,
Rory/Nemanja
-Original Message-
From: Wu, Jingjing
Sent: Monday, December 5, 2016 8:45 AM
To: Sexton, Rory
Cc: dev@dpdk.org; Marjanovic
Hi Ori,
See comments below.
Regards,
Rory
> > > > > > +/**
> > > > > > + * RTE_FLOW_ITEM_TYPE_L2TPV3.
> > > > > > + *
> > > > > > + * Matches a L2TPv3 header.
> > > > > > + */
> > > > > > +struct rte_flow_item_l2tpv3 {
> > > > > > + rte_be32_t session_id; /**< Session ID. */ };
> > > > >
> > >
: dev On Behalf Of Sexton, Rory
Sent: Wednesday, December 11, 2019 4:31 PM
To: Ori Kam ; dev@dpdk.org
Cc: Zhang, Qi Z ; Xing, Beilei ;
Adrien Mazarguil ; Jagus, DariuszX
Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API
Hi Ori,
See comments below.
Regards,
Rory
Hi Beilei,
See comments below.
Regards,
Rory
> > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3
> It's not only add new customized pctype, but mainly enable FDIR for l2ipv3,
> so how about " net/i40e: support FDIR for L2TPv3"?
>
> Detailed commit log is also needed.
Of course
Hi Beilei,
See below,
Rory
> > > > +/* A structure used to define the input for L2TPv3 flow */ struct
> > > > +i40e_l2tpv3_flow {
> > >
> > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here?
> > >
> >
> > I'm not convinced we need struct rte_eth_ipv4_flow or struct
> >
Hi Beilei,
I have resolved all comments below in v3 of patch.
Rory
> > Adding FDIR support for L2TPv3 over IP header matching and adding a
> > new customized pctype for l2tpv3 over IP.
> >
> > Signed-off-by: Rory Sexton
> > Signed-off-by: Dariusz Jagus
> > ---
>
> Version change is needed h
Hi Beilei,
PSB
Regards,
Rory
>
> Sorry, NACK the patch since there's compilation issue with clang and coding
> style issue.
> Please check
> http://mails.dpdk.org/archives/test-report/2020-January/112422.html and
> http://mails.dpdk.org/archives/test-report/2020-January/112412.html
> BTW, Do
= I40E_CUSTOMIZED_IPV4_L2TPV3 {
-Original Message-
From: Iremonger, Bernard
Sent: Tuesday, January 21, 2020 4:29 PM
To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z
; Yigit, Ferruh ; Sexton, Rory
Subject: RE: [PATCH] net/i40e: fix i40e flow director merge
> -Original Message-
&g
Acked-by: Rory Sexton
This change is required to allow the branch ratio algorithm to
power manage cores with no workload running on them. This is
useful both when idle cores don't use C-states and for a number of
hyperthreading scenarios.
---
examples/vm_power_manager/oob_monitor_x86.c | 8
1 file changed, 4 i
This modification allows for the branch ratio threshold to be set
per core rather than system wide. This gives greater flexibility to
the branch ration monitoring allowing it to manage different
workloads with different characteristics on the same system.
---
examples/vm_power_manager/main.c
---
doc/guides/sample_app_ug/vm_power_management.rst | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst
b/doc/guides/sample_app_ug/vm_power_management.rst
index e98277ccb..dd0f46158 100644
--- a/doc/guides/sample_app_
Please ignore, fixed checkpatch errors in v2.
Rgds,
Rory
This modification allows for the branch ratio threshold to be set
per core rather than system wide. This gives greater flexibility to
the branch ration monitoring allowing it to manage different
workloads with different characteristics on the same system.
Signed-off-by: Rory Sexton
---
examples/
This change is required to allow the branch ratio algorithm to
power manage cores with no workload running on them. This is
useful both when idle cores don't use C-states and for a number of
hyperthreading scenarios.
Signed-off-by: Rory Sexton
---
examples/vm_power_manager/oob_monitor_x86.c | 8
Signed-off-by: Rory Sexton
---
doc/guides/sample_app_ug/vm_power_management.rst | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst
b/doc/guides/sample_app_ug/vm_power_management.rst
index e98277ccb..dd0f46158 100644
>
> Subject: [PATCH v3] net/i40e: fix i40e flow director merge
>
> Merge of ESP and L2TP code in i40e_fdir.c added checks on cus_pctype->index
> which caused flow creation for ESP to fail.
>
> Added fill_ipv4_function()
> Refactored code to have one path for customized and non customized pctype
Signed-off-by: Rory Sexton
---
doc/guides/sample_app_ug/vm_power_management.rst | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst
b/doc/guides/sample_app_ug/vm_power_management.rst
index e98277ccb..1b6de8e93 1006
This modification allows for the branch ratio threshold to be set
per core rather than system wide. This gives greater flexibility to
the branch ration monitoring allowing it to manage different
workloads with different characteristics on the same system.
Signed-off-by: Rory Sexton
Reviewed-by: D
This change is required to allow the branch ratio algorithm to
power manage cores with no workload running on them. This is
useful both when idle cores don't use C-states and for a number of
hyperthreading scenarios.
Signed-off-by: Rory Sexton
Reviewed-by: David Hunt
---
examples/vm_power_manag
Hi Ori,
> One general question why do we want to support only v3 and not also v2?
l2tpv3 is more widely used as a tunneling protocol hence it's inclusion.
A specific example is the cable industry where DOCSIS cable traffic is
encapsulated using depi and uepi protocols which both make use of l2tpv
Hi Ori,
See my comments below.
Regards,
Rory
>>
>>> One general question why do we want to support only v3 and not also v2?
>> l2tpv3 is more widely used as a tunneling protocol hence it's inclusion.
>> A specific example is the cable industry where DOCSIS cable traffic is
>> encapsulated usin
Replacing patchset with v4 to add an upper limit check to branch ratio value.
Rgds,
Rory
Thanks for merge and thanks for feedback for next contribution.
>
> Series applied with minor changes and doc squashed.
>
> 2 more comments for next contributions:
> - use a cover letter if there are multiple patches
> - please use --in-reply-to to thread all versions with the first one
26 matches
Mail list logo
