RE: [PATCH 15/21] bus/fslmc: replace strtok with strtok_r

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Jie Hai > Sent: 13 November 2023 04:16 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena > Cc: haij...@huawei.com; lihuis...@huawei.com; fengcheng...@huawei.com > Subject: [PATCH 15/21] bus/fslmc: replace

RE: [PATCH v2 03/16] bus/fslmc: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 03/16] bus/fslmc: ve

RE: [PATCH v2 02/16] bus/dpaa: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 02/16] bus/dpaa: ve

Re: [dpdk-dev] [PATCH] mk: change TLS model for ARMv8 and DPAA machine

2018-06-13 Thread Sachin Saxena
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, June 10, 2018 4:37 PM > To: Hemant Agrawal > Cc: dev@dpdk.org; Sachin Saxena > Subject: Re: [dpdk-dev] [PATCH] mk: change TLS model for ARMv8 and DPAA > machine >

Re: [dpdk-dev] [PATCH] mk: change TLS model for ARMv8 and DPAA machine

2018-06-13 Thread Sachin Saxena
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, June 11, 2018 1:15 PM > To: Sachin Saxena > Cc: Hemant Agrawal ; dev@dpdk.org; > nitin.sax...@cavium.com; narayanaprasad.athr...@cavium.com > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable

2018-07-05 Thread Sachin Saxena
But this model require for addtional slot on DTV when dlopen > +# object with thread local variable. > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +TOOLCHAIN_CFLAGS += -ftls-model=initial-exec endif > + [Sachin Saxena] Using initial-exec model for shared object is not recommended. If y

[dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
dpaa2: support new ethdev offload APIs") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena Reviewed-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethd

Re: [dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 11, 2019 9:27 PM > To: Sachin Saxena > Cc: dev@dpdk.org; ferruh.yi...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx > offloads flags

[dpdk-dev] [PATCH v2] net/dpaa2: fix Rx offload flags on jumbo MTU set

2019-11-11 Thread Sachin Saxena
dpaa2: support new ethdev offload APIs") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena Reviewed-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethd

Re: [dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-18 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; Hemant > Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Imp

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

2019-11-21 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Wednesday, November 20, 2019 3:20 AM > To: Anatoly Burakov ; Thomas Monjalon > > Cc: dev ; Hemant Agrawal ; > Sachin Saxena ; Stephen Hemminger > ; Mcnamara, John > ; Kinsella, Ray ; Bruce > Richardson

Re: [dpdk-dev] [dpdk-announce] release candidate 19.11-rc4

2019-11-28 Thread Sachin Saxena
dpdk_ethtool_function dpdk_ipv4_multicast regards, Sachin Saxena > -Original Message- > From: dev On Behalf Of Luca Boccassi > Sent: Thursday, November 28, 2019 3:21 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Ju-Hyoung Lee ; > Abhishek Marathe > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-31 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Friday, October 25, 2019 12:47 AM > To: Sachin Saxena > Cc: Babu Radhakrishnan, AgalyaX ; > dev@dpdk.org; Pattan, Reshma ; Hemant > Agrawal ; Parthasarathy, JananeeX M > ; sta...@dpdk.org > Subject: Re: [

[dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-06 Thread Sachin Saxena
Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman/fman.c| 2 +- drivers/bus/dpaa/base/fman/netcfg_layer.c| 2 +- drivers/bus/dpaa/rte_dpaa_bus.h | 2 +- drivers/bus/fslmc/mc/dpci.c | 1 + drivers/bus/fslmc/mc/dpcon.c

Re: [dpdk-dev] [PATCH] drivers: copyrights update for NXP files

2019-11-06 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; > Hemant Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Imp

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-03 Thread Sachin Saxena
Acked-by: Sachin Saxena regards, Sachin Saxena > -Original Message- > From: Agalya Babu RadhaKrishnan > Sent: Tuesday, September 10, 2019 1:01 PM > To: dev@dpdk.org > Cc: reshma.pat...@intel.com; Hemant Agrawal > ; Sachin Saxena ; > jananeex.m.parthasara...@i

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-03 Thread Sachin Saxena
> -Original Message- > From: Babu Radhakrishnan, AgalyaX > > Sent: Tuesday, September 10, 2019 1:11 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Hemant Agrawal > ; Sachin Saxena ; > Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: RE: [PATCH] bu

[dpdk-dev] [PATCH v1 00/30] Enhancements and fixes in NXP dpaax drivers and fsl-mc bus

2019-08-27 Thread Sachin Saxena
support in Tx for non DPAA buffer net/dpaa2: add optional non-prefetch Rx mode Priyanka Jain (4): net/dpaa2: add Tx confirmation mode support net/dpaa2: add timestamp support net/dpaa2: add dprtc sub-module net/dpaa2: add ptp driver Sachin Saxena (1): net/dpaa2: use LFQIDs in Tx

[dpdk-dev] [PATCH v1 02/30] net/dpaa: improve the Rx offload debug message

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal This patch also align few RX offload support to right category. Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/dpaa

[dpdk-dev] [PATCH v1 01/30] bus/dpaa: fix DPAA SEC blacklist case

2019-08-27 Thread Sachin Saxena
r form max-fman_device +1 Fixes: 6e0752205bb2 ("bus/dpaa: support device blacklisting") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- doc/guides/cryptodevs/dpaa_sec.rst | 6 +++--- drivers/bus/dpaa/dpaa_bus.c| 6 +++--- drivers/crypto/dpaa_sec/dpaa_se

[dpdk-dev] [PATCH v1 03/30] bus/dpaa: remove un-necessary thread affinity

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta Thread affinity is already taken care by DPDK. Remove them from bus. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman_driver.c | 56 ++- drivers/bus/dpaa/dpaa_bus.c | 13 -- 2 files changed, 3 insertions(+), 66 deletions(-)

[dpdk-dev] [PATCH v1 04/30] bus/dpaa: decouple fq portal alloc and init

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta The decoupling of FQ portal allocation is required as a pre-requisite to support Rx interrupts as we need to have event FD's at portal allocation i.e. before the initialization of the Frame Queues. This change will help us get the event fd once the portals have been allocated fo

[dpdk-dev] [PATCH v1 05/30] net/dpaa: support Rx interrupt handler

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta This patch adds interrupt handler support for the ethernet devices which are configured with a dedicated portal for packet Rx (i.e. for FQ's in push mode). Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman_driver.c | 3 ++- drivers/bus/dpaa/include/fsl_qman.h

[dpdk-dev] [PATCH v1 06/30] net/dpaa: support for Rx interrupt enable and disable

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta This patch adds support for dpaa eth driver interrupt enable and disable callback functions. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c| 45 +++ drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +++ drivers/bus/dpaa/base/qbman/

[dpdk-dev] [PATCH v1 10/30] common/dpaax: reduce debug mesages

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/common/dpaax/dpaax_iova_table.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c

[dpdk-dev] [PATCH v1 11/30] mempool/dpaa: reduce debug messages

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/mempool/dpaa/dpaa_mempool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index c371d3a6b..a25697f05

[dpdk-dev] [PATCH v1 08/30] net/dpaa: reduce debug messages

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 42ab3d05f..dc2e584b1 100644 --- a

[dpdk-dev] [PATCH v1 09/30] net/dpaa2: improve the Rx offload debug message

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index dd6a78f9f..bbebb66fe 100644 --- a/drivers/

[dpdk-dev] [PATCH v1 12/30] net/dpaa2: realign Rx offload support types

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index bbebb66fe..130fb5297 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v1 07/30] net/dpaa: add SG support in Tx for non DPAA buffer

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta This patch adds support for Scatter Gather in the transmit side, for the cases where the buffer are received which are not from DPAA buffer pool. Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_rxtx.c | 189 +++ 1 file changed, 101 inserti

[dpdk-dev] [PATCH v1 15/30] net/dpaa2: add optional non-prefetch Rx mode

2019-08-27 Thread Sachin Saxena
From: Nipun Gupta When we need particular number of packets from the rx routine, which would change in every call, we cannot prefetch the packets and provide previous results to the user. User can select the mode by using devargs for non pretech mode. Signed-off-by: Nipun Gupta --- doc/guides

[dpdk-dev] [PATCH v1 16/30] net/dpaa2: add taildrop support on frame count basis

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal The existing taildrop was based on queue data size. This patch replaces it with frame count bases using CGR methods of DPAA2 device. The number of CGRs are limited. So, - use per queue CGR based tail drop for as many as CGR available. - Remaining queues shall use the legacy b

[dpdk-dev] [PATCH v1 19/30] net/dpaa2: use LFQIDs in Tx instead of qdid

2019-08-27 Thread Sachin Saxena
Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 10 ++ drivers/net/dpaa2/dpaa2_rxtx.c | 12 +--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 925637409..8814de271

[dpdk-dev] [PATCH v1 14/30] net/dpaa2: support L2 payload based RSS distribution

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index 33b1506aa..69ab577f5 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/

[dpdk-dev] [PATCH v1 17/30] net/dpaa2: add cgr counters in xtra stats

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Add congestion frame drop and byte drop count in xtra stats. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa

[dpdk-dev] [PATCH v1 18/30] net/dpaa2: add support for config max Rx length in HW

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal The MC expects the length to be configured without CRC Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethde

[dpdk-dev] [PATCH v1 13/30] net/dpaa2: enable Rx offload for timestamp

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 130fb5297..4689cf9a4 100644 --- a/drivers/net/dpaa2/dpaa2_et

[dpdk-dev] [PATCH v1 24/30] net/dpaa2: add ptp driver

2019-08-27 Thread Sachin Saxena
From: Priyanka Jain This patch adds the support for PTP driver for DPAA2 devices. To enable set CONFIG_RTE_LIBRTE_IEEE1588=y in config/defconfig_arm64-dpaa2-linuxapp-gc Signed-off-by: Priyanka Jain --- config/defconfig_arm64-dpaa2-linuxapp-gcc| 2 +- drivers/bus/fslmc/fslmc_bus.c

[dpdk-dev] [PATCH v1 20/30] net/dpaa2: support dpdmux classification on eth type

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_mux.c | 84 +++ 1 file changed, 55 insertions(+), 29 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index e487c6b54..1910cc418 100644 --- a/dr

[dpdk-dev] [PATCH v1 23/30] net/dpaa2: add dprtc sub-module

2019-08-27 Thread Sachin Saxena
From: Priyanka Jain This patch add support for dprtc (Data Path Real Time Clock) sub-module based on MC 10.16.0 flib. It provides interface for PTP stack software to access physical IEEE 1588 Real Time Clock. Signed-off-by: Priyanka Jain --- drivers/net/dpaa2/Makefile | 1 + drive

[dpdk-dev] [PATCH v1 22/30] net/dpaa2: add timestamp support

2019-08-27 Thread Sachin Saxena
From: Priyanka Jain IEEE1588 driver needs timestamp of packets. For DPAA2, the timestamp of TX packets is stored in annotation area of corresponding TX confirmation packet. This patch enables timestamp fields in annotation area and TX confirmation mode if CONFIG_RTE_LIBRTE_IEEE1588 is set in con

[dpdk-dev] [PATCH v1 21/30] net/dpaa2: add Tx confirmation mode support

2019-08-27 Thread Sachin Saxena
From: Priyanka Jain TX confirmation mode provides dedicated confirmation queues for transmitted packets. These queues are used by software to get the status and release transmitted packets buffers. By default TX confirmation mode is kept disabled. Signed-off-by: Priyanka Jain --- drivers/bus/

[dpdk-dev] [PATCH v1 29/30] net/dpaa2: add support for soft parser in MC

2019-08-27 Thread Sachin Saxena
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori Reviewed-by: Sachin Saxena --- drivers/net/dpaa2/mc/dpni.c | 117 drivers/net/dpaa2/mc/fsl_dpni.h | 133 drivers/net/dpaa2/mc/fsl_dpni_cmd.h | 43 - 3 files

[dpdk-dev] [PATCH v1 28/30] net/dpaa2: support separate MC portal per process

2019-08-27 Thread Sachin Saxena
used as part of the DPNI configuration. By using the process_private member of the rte_eth_dev, it is possible to keep separate handles per process. Without worry of overwriting when secondary process accesses the dev_private. Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers

[dpdk-dev] [PATCH v1 27/30] bus/fslmc: support multi vfio group

2019-08-27 Thread Sachin Saxena
From: Hemant Agrawal DPAA2 support VFIO device passthrough in VM. However in this case, each device is associated with different vfio group. This code required different container id for each group. On using the same container fd the second time, ioctl calls are returning error. Signed-off-by:

[dpdk-dev] [PATCH v1 25/30] bus/fslmc: update PA-VA dpaax library only in PA mode

2019-08-27 Thread Sachin Saxena
xx This was caused by call to update the DPAAX table when VA mode was enabled, in which case the VA==IOVA address. Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_bus.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v1 26/30] bus/fslmc: check for Dma map in primary process only

2019-08-27 Thread Sachin Saxena
From: Shreyansh Jain DMA mapping is a property of primary process - SMMU population done once by primary doesn't need to be populated again in secondary Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_bus.c | 15 +-- 1 file chang

[dpdk-dev] [PATCH v1 30/30] net/dpaa2: add soft parser driver

2019-08-27 Thread Sachin Saxena
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa2/Makefile| 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 24 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 4 + drivers/net/dpaa2/dpaa2_sparser.c | 269 ++ drivers/net/dpaa2/dpaa2_sparser.h

[dpdk-dev] [PATCH v2 00/30] Enhancements and fixes in NXP dpaax drivers and fsl-mc bus

2019-08-29 Thread Sachin Saxena
net/dpaa2: add ptp driver Sachin Saxena (1): net/dpaa2: use LFQIDs in Tx instead of qdid Shreyansh Jain (3): bus/fslmc: update PA-VA dpaax library only in PA mode bus/fslmc: check for Dma map in primary process only net/dpaa2: support separate MC portal per process Sunil Kumar Kori (2

[dpdk-dev] [PATCH v2 01/30] bus/dpaa: fix DPAA SEC blacklist case

2019-08-29 Thread Sachin Saxena
r form max-fman_device +1 Fixes: 6e0752205bb2 ("bus/dpaa: support device blacklisting") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- doc/guides/cryptodevs/dpaa_sec.rst | 6 +++--- drivers/bus/dpaa/dpaa_bus.c| 6 +++--- drivers/crypto/dpaa_sec/dpaa_se

[dpdk-dev] [PATCH v2 02/30] net/dpaa: improve the Rx offload debug message

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal This patch also align few RX offload support to right category. Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/dpaa

[dpdk-dev] [PATCH v2 03/30] bus/dpaa: remove un-necessary thread affinity

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta Thread affinity is already taken care by DPDK. Remove them from bus. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman_driver.c | 56 ++- drivers/bus/dpaa/dpaa_bus.c | 13 -- 2 files changed, 3 insertions(+), 66 deletions(-)

[dpdk-dev] [PATCH v2 04/30] bus/dpaa: decouple fq portal alloc and init

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta The decoupling of FQ portal allocation is required as a pre-requisite to support Rx interrupts as we need to have event FD's at portal allocation i.e. before the initialization of the Frame Queues. This change will help us get the event fd once the portals have been allocated fo

[dpdk-dev] [PATCH v2 06/30] net/dpaa: support for Rx interrupt enable and disable

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta This patch adds support for dpaa eth driver interrupt enable and disable callback functions. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c| 45 +++ drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +++ drivers/bus/dpaa/base/qbman/

[dpdk-dev] [PATCH v2 08/30] net/dpaa: reduce debug messages

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 42ab3d05f..dc2e584b1 100644 --- a

[dpdk-dev] [PATCH v2 07/30] net/dpaa: add SG support in Tx for non DPAA buffer

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta This patch adds support for Scatter Gather in the transmit side, for the cases where the buffer are received which are not from DPAA buffer pool. Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_rxtx.c | 189 +++ 1 file changed, 101 inserti

[dpdk-dev] [PATCH v2 05/30] net/dpaa: support Rx interrupt handler

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta This patch adds interrupt handler support for the ethernet devices which are configured with a dedicated portal for packet Rx (i.e. for FQ's in push mode). Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman_driver.c | 3 ++- drivers/bus/dpaa/include/fsl_qman.h

[dpdk-dev] [PATCH v2 09/30] net/dpaa2: improve the Rx offload debug message

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index dd6a78f9f..bbebb66fe 100644 --- a/drivers/

[dpdk-dev] [PATCH v2 12/30] net/dpaa2: realign Rx offload support types

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index bbebb66fe..130fb5297 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v2 11/30] mempool/dpaa: reduce debug messages

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/mempool/dpaa/dpaa_mempool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index c371d3a6b..a25697f05

[dpdk-dev] [PATCH v2 14/30] net/dpaa2: support L2 payload based RSS distribution

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index 33b1506aa..69ab577f5 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/

[dpdk-dev] [PATCH v2 10/30] common/dpaax: reduce debug mesages

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Reviewed-by: Sachin Saxena --- drivers/common/dpaax/dpaax_iova_table.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c

[dpdk-dev] [PATCH v2 15/30] net/dpaa2: add optional non-prefetch Rx mode

2019-08-29 Thread Sachin Saxena
From: Nipun Gupta When we need particular number of packets from the rx routine, which would change in every call, we cannot prefetch the packets and provide previous results to the user. User can select the mode by using devargs for non pretech mode. Signed-off-by: Nipun Gupta --- doc/guides

[dpdk-dev] [PATCH v2 13/30] net/dpaa2: enable Rx offload for timestamp

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 130fb5297..4689cf9a4 100644 --- a/drivers/net/dpaa2/dpaa2_et

[dpdk-dev] [PATCH v2 16/30] net/dpaa2: add taildrop support on frame count basis

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal The existing taildrop was based on queue data size. This patch replaces it with frame count bases using CGR methods of DPAA2 device. The number of CGRs are limited. So, - use per queue CGR based tail drop for as many as CGR available. - Remaining queues shall use the legacy b

[dpdk-dev] [PATCH v2 21/30] net/dpaa2: add Tx confirmation mode support

2019-08-29 Thread Sachin Saxena
From: Priyanka Jain TX confirmation mode provides dedicated confirmation queues for transmitted packets. These queues are used by software to get the status and release transmitted packets buffers. By default TX confirmation mode is kept disabled. Signed-off-by: Priyanka Jain --- drivers/bus/

[dpdk-dev] [PATCH v2 18/30] net/dpaa2: add support for config max Rx length in HW

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal The MC expects the length to be configured without CRC Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethde

[dpdk-dev] [PATCH v2 20/30] net/dpaa2: support dpdmux classification on eth type

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_mux.c | 84 +++ 1 file changed, 55 insertions(+), 29 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index e487c6b54..1910cc418 100644 --- a/dr

[dpdk-dev] [PATCH v2 19/30] net/dpaa2: use LFQIDs in Tx instead of qdid

2019-08-29 Thread Sachin Saxena
Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 10 ++ drivers/net/dpaa2/dpaa2_rxtx.c | 12 +--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a1ef5be6a..29f0bfdf2

[dpdk-dev] [PATCH v2 17/30] net/dpaa2: add cgr counters in xtra stats

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal Add congestion frame drop and byte drop count in xtra stats. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa

[dpdk-dev] [PATCH v2 22/30] net/dpaa2: add timestamp support

2019-08-29 Thread Sachin Saxena
From: Priyanka Jain IEEE1588 driver needs timestamp of packets. For DPAA2, the timestamp of TX packets is stored in annotation area of corresponding TX confirmation packet. This patch enables timestamp fields in annotation area and TX confirmation mode if CONFIG_RTE_LIBRTE_IEEE1588 is set in con

[dpdk-dev] [PATCH v2 25/30] bus/fslmc: update PA-VA dpaax library only in PA mode

2019-08-29 Thread Sachin Saxena
xx This was caused by call to update the DPAAX table when VA mode was enabled, in which case the VA==IOVA address. Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_bus.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v2 23/30] net/dpaa2: add dprtc sub-module

2019-08-29 Thread Sachin Saxena
From: Priyanka Jain This patch add support for dprtc (Data Path Real Time Clock) sub-module based on MC 10.16.0 flib. It provides interface for PTP stack software to access physical IEEE 1588 Real Time Clock. Signed-off-by: Priyanka Jain --- drivers/net/dpaa2/Makefile | 1 + drive

[dpdk-dev] [PATCH v2 24/30] net/dpaa2: add ptp driver

2019-08-29 Thread Sachin Saxena
From: Priyanka Jain This patch adds the support for PTP driver for DPAA2 devices. To enable set CONFIG_RTE_LIBRTE_IEEE1588=y in config/defconfig_arm64-dpaa2-linuxapp-gc Signed-off-by: Priyanka Jain --- config/defconfig_arm64-dpaa2-linuxapp-gcc| 2 +- drivers/bus/fslmc/fslmc_bus.c

[dpdk-dev] [PATCH v2 27/30] bus/fslmc: support multi vfio group

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal DPAA2 support VFIO device passthrough in VM. However in this case, each device is associated with different vfio group. This code required different container id for each group. On using the same container fd the second time, ioctl calls are returning error. Signed-off-by:

[dpdk-dev] [PATCH v2 26/30] bus/fslmc: check for Dma map in primary process only

2019-08-29 Thread Sachin Saxena
From: Shreyansh Jain DMA mapping is a property of primary process - SMMU population done once by primary doesn't need to be populated again in secondary Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_bus.c | 15 +-- 1 file chang

[dpdk-dev] [PATCH v2 29/30] net/dpaa2: add support for soft parser in MC

2019-08-29 Thread Sachin Saxena
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori Reviewed-by: Sachin Saxena --- drivers/net/dpaa2/mc/dpni.c | 117 drivers/net/dpaa2/mc/fsl_dpni.h | 133 drivers/net/dpaa2/mc/fsl_dpni_cmd.h | 43 - 3 files

[dpdk-dev] [PATCH v2 30/30] net/dpaa2: add soft parser driver

2019-08-29 Thread Sachin Saxena
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa2/Makefile| 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 24 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 4 + drivers/net/dpaa2/dpaa2_sparser.c | 269 ++ drivers/net/dpaa2/dpaa2_sparser.h

[dpdk-dev] [PATCH v2 28/30] net/dpaa2: support separate MC portal per process

2019-08-29 Thread Sachin Saxena
used as part of the DPNI configuration. By using the process_private member of the rte_eth_dev, it is possible to keep separate handles per process. Without worry of overwriting when secondary process accesses the dev_private. Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers

[dpdk-dev] [PATCH v1 0/2] Update MC firmware version for FSLMC bus and DPAA2 devices

2019-09-10 Thread Sachin Saxena
This patch add the support for new Management Complex Firmware version to 10.18.x. Sachin Saxena (2): bus/fslmc: update MC firmware version for FSLMC bus net/dpaa2: update MC firmware version for FSLMC bus drivers/bus/fslmc/mc/fsl_dpio_cmd.h| 4 +-- drivers/bus/fslmc/mc/fsl_dpmng.h

[dpdk-dev] [PATCH v1 1/2] bus/fslmc: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/mc/fsl_dpio_cmd.h | 4 ++-- drivers/bus/fslmc/mc

[dpdk-dev] [PATCH v1 2/2] net/dpaa2: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and net/DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 + drivers/net/dpaa2

Re: [dpdk-dev] [PATCH 01/10] bus/fslmc: fix global variable multiple definitions

2019-09-10 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:23 PM > To: Hemant Agrawal ; Sachin Saxena > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 01/10] bus/fslmc: fix global variable multiple definitio

Re: [dpdk-dev] [PATCH 05/10] crypto/dpaa2_sec: fix global variable multiple definitions

2019-09-10 Thread Sachin Saxena
Acked-by: Sachin Saxena

Re: [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch series introduce the enetfec ethernet driver, enetfec ethernet driver -> enetfec driver ENET fec (Fast Ethernet Controller) is a network poll mode driver for ENET fec ->enetfec Also, please use "enetfec" consistently at all places. the

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
c driver with probe and patch add -> patch adds uintialisation functions uintialisation-> remove functionality Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 121 doc/guides/nics/features/enetfec.ini | 8 +

Re: [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added

2021-07-03 Thread Sachin Saxena (OSS)
and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheble memory for BD. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 204 ++ drivers/net/enetfec/enet_

Re: [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch added RX/TX queue configuration setup operations. added -> adds On packet Rx the respective BD Ring status bit is set which is then Suggestion:  Rx -> reception used for packet processing. Signed-off-by: Sachin Saxena Signed-

Re: [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support

2021-07-05 Thread Sachin Saxena (OSS)
c features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 4 + doc/guides/nics/features/enetfec.ini | 5 + drivers/net/enetfec/enet_ethdev.c| 212 +++- drivers/net/enetfec/e

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-12 Thread Sachin Saxena (OSS)
Hello David, I understood and agree with your suggestion. We are using GCC 11.3 where we were not seeing this warning. We will fix this on priority and submit the patch asap. regards, Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-14 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand wrote: GCC 12 raises the following warning: ../drivers/net/enetfec/enet_ethdev.c: In function ‘enetfec_rx_queue_setup’: ../drivers/net/enetfec/enet_ethdev.c:473:9

Re: Dpaa2 driver using system("echo...")

2023-04-28 Thread Sachin Saxena (OSS)
fine. When testing, found issue of memory corruption that I have fixed over your changes. I will send a 'v2' patch in context of your previous patch including this fix for dpaa2 platform. -- Thanks, Sachin Saxena (NXP)

[v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-02 Thread Sachin Saxena (OSS)
and therefore can not test this. Signed-off-by: Stephen Hemminger Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 45 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.27.0 Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.27.0 Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH] net/dpaa2: change threshold value

2023-05-15 Thread Sachin Saxena (OSS)
t;nb_rx_desc" based only. We will further review this suggestion and get back. -- Thanks, Sachin Saxena (NXP)

Re: [PATCH 04/33] doc: update dpaa guide

2023-03-22 Thread Sachin Saxena (OSS)
GPLv2), however they are used as BSD in DPDK in userspace. -Pre-Installation Configuration --- - +Configuration +- Environment Variables ~~~~~ Acked-by: Sachin Saxena -- Thanks, Sachin Saxena NXP

Re: [PATCH 06/33] doc: update enetc guide

2023-03-22 Thread Sachin Saxena (OSS)
-development-tools/layerscape-software-development-kit:LAYERSCAPE-SDK>`_ Driver compilation and testing -~~ +-- Follow instructions available in the document :ref:`compiling and testing a PMD for a NIC ` Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH 07/33] doc: update enetfec guide

2023-03-22 Thread Sachin Saxena (OSS)
C Features @@ -91,11 +96,6 @@ ENETFEC Features - Linux - ARMv8 -Supported ENETFEC SoCs --- - -- i.MX 8M Mini - Prerequisites - Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-22 Thread Sachin Saxena (OSS)
-use of PHY handling in enetfec-uio driver is point of objection. So, we are currently working on changing the design and most probably, we may design new driver w/o UIO support. --- Thanks, Sachin Saxena (NXP)

  1   2   >