[dpdk-dev] [PATCH] pktgen: fix checksum calculation logic

2019-09-06 Thread Rahul Lakkireddy
First commit for dpdk.org") Signed-off-by: Rahul Lakkireddy --- app/pktgen-ipv6.c | 11 +-- app/pktgen-tcp.c | 23 +-- app/pktgen-udp.c | 8 +--- 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/app/pktgen-ipv6.c b/app/pktgen-ipv6.c index 2e16b6

Re: [dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-27 Thread Rahul Lakkireddy
On Friday, September 09/27/19, 2019 at 20:07:20 +0530, Ferruh Yigit wrote: > On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote: > > Remove compile time flags and use dynamic logging for debug prints. > > > > Signed-off-by: Rahul Lakkireddy > > --- > > conf

[dpdk-dev] [PATCH v2 00/12] net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

2019-09-27 Thread Rahul Lakkireddy
--- v2: - Remove rarely used compile time enabled debug logs from datapath in patch 7. - In cxgbe.rst doc, use ^ (instead of -) to represent common and vf-only devargs as subsection of Runtime Options in patch 8. Rahul Lakkireddy (12): net/cxgbe: add cxgbe_ prefix to global functions net

[dpdk-dev] [PATCH v2 01/12] net/cxgbe: add cxgbe_ prefix to global functions

2019-09-27 Thread Rahul Lakkireddy
API to program hardware layer 2 table") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_filter.c | 30 -- drivers/net/cxgbe/cxgbe_filter.h | 19 +-- drivers/net/cxgbe/cxgbe_flow.c | 6 +++--- drivers/net/cxgbe/cxgbe_mai

[dpdk-dev] [PATCH v2 04/12] net/cxgbe: fix parsing VLAN ID rewrite action

2019-09-27 Thread Rahul Lakkireddy
: 1decc62b1cbe ("net/cxgbe: add flow operations to offload VLAN actions") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_flow.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers

[dpdk-dev] [PATCH v2 06/12] net/cxgbe: avoid polling link status before device start

2019-09-27 Thread Rahul Lakkireddy
cxgbe: add link up and down ops") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 5d74f8ba3..5df8d746c 100644 --- a/dr

[dpdk-dev] [PATCH v2 05/12] net/cxgbe: fix prefetch for non-coalesced Tx packets

2019-09-27 Thread Rahul Lakkireddy
Move prefetch code out of Tx coalesce path to allow prefetching for non-coalesced Tx packets, as well. Cc: sta...@dpdk.org Fixes: bf89cbedd2d9 ("cxgbe: optimize forwarding performance for 40G") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_et

[dpdk-dev] [PATCH v2 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-27 Thread Rahul Lakkireddy
Remove compile time flags and use dynamic logging for debug prints. Also remove rarely used debug logs in register access and datapath. Signed-off-by: Rahul Lakkireddy --- v2: - Remove rarely used CXGBE_DEBUG_REG, CXGBE_DEBUG_TX, and CXGBE_DEBUG_RX debug logs. config/common_base

[dpdk-dev] [PATCH v2 03/12] net/cxgbe: fix slot allocation for IPv6 flows

2019-09-27 Thread Rahul Lakkireddy
1e209cfc ("net/cxgbe: add Compressed Local IP region") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_filter.c | 193 +++ drivers/net/cxgbe/cxgbe_filter.h | 5 +- drivers/net/cxgbe/cxgbe_flow.c | 15 ++- 3 files changed, 8

[dpdk-dev] [PATCH v2 02/12] net/cxgbe: fix NULL access when allocating CLIP entry

2019-09-27 Thread Rahul Lakkireddy
Pass correct arguments to CLIP allocation code to avoid NULL pointer dereference. Cc: sta...@dpdk.org Fixes: 3f2c1e209cfc ("net/cxgbe: add Compressed Local IP region") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_filter.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v2 08/12] net/cxgbe: separate VF only devargs

2019-09-27 Thread Rahul Lakkireddy
Rework devargs parsing logic to separate VF only args. Signed-off-by: Rahul Lakkireddy --- v2: - In cxgbe.rst doc, use ^ (instead of -) to represent common and vf-only devargs as subsection of Runtime Options. doc/guides/nics/cxgbe.rst | 6 +++ drivers/net/cxgbe/base/adapter.h

[dpdk-dev] [PATCH v2 11/12] net/cxgbe: add rte_flow support for matching VLAN

2019-09-27 Thread Rahul Lakkireddy
ader, when parsing incoming packet against VLAN pattern. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/base/t4_regs_values.h | 9 ++ drivers/net/cxgbe/cxgbe_filter.c| 11 +- drivers/net/cxgbe/cxgbe_flow.c | 145 +++- drivers

[dpdk-dev] [PATCH v2 10/12] net/cxgbe: fetch max Tx coalesce limit from firmware

2019-09-27 Thread Rahul Lakkireddy
Query firmware for max number of packets that can be coalesced by Tx. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. doc/guides/nics/cxgbe.rst | 18 ++-- drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4fw_interface.h | 3 +- drivers/net

[dpdk-dev] [PATCH v2 09/12] net/cxgbe: add devarg to control Tx coalescing

2019-09-27 Thread Rahul Lakkireddy
Remove compile time option to control Tx coalescing Latency vs Throughput behavior. Add tx_mode_latency devarg instead, to dynamically control Tx coalescing behavior. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. config/common_base | 1 - doc/guides/nics/cxgbe.rst

[dpdk-dev] [PATCH v2 12/12] net/cxgbe: add rte_flow support for setting VLAN PCP

2019-09-27 Thread Rahul Lakkireddy
Add support for setting VLAN PCP field via rte_flow API. Hardware overwrites the entire 16-bit VLAN TCI field. So, both VLAN VID and PCP actions must be specified. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_flow.c | 27 +++ 1 file

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Rahul Lakkireddy
Hi Thomas, On Monday, November 11/28/16, 2016 at 16:33:06 +0530, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. > > Reminder of what Konstantin suggested: > " > - if the PMD supports TX offloads AND > - if to be able use any of these offloads the upper layer SW

[dpdk-dev] [PATCH 4/9] eal/linux: move back interrupt thread init before setting affinity

2016-02-02 Thread Rahul Lakkireddy
Hi David, On Friday, January 01/29/16, 2016 at 15:08:31 +0100, David Marchand wrote: > Now that virtio pci driver is initialized in a constructor, we only need to > move the interrupt thread init after loading the plugins. > This way, chelsio driver should be happy again [1]. > > [1] http://dpdk.

[dpdk-dev] [PATCH 4/9] eal/linux: move back interrupt thread init before setting affinity

2016-02-02 Thread Rahul Lakkireddy
Hi David, On Monday, February 02/01/16, 2016 at 23:13:55 -0800, David Marchand wrote: > Hello Rahul, > > On Tue, Feb 2, 2016 at 8:02 AM, Rahul Lakkireddy > wrote: > > On Friday, January 01/29/16, 2016 at 15:08:31 +0100, David Marchand wrote: > >> Now that virtio pci

[dpdk-dev] [PATCH 00/10] cxgbe: Add flow director support

2016-02-03 Thread Rahul Lakkireddy
operations on matched filters. Patch 8 adds the LE-TCAM (maskfull) filter support. Patch 9 adds the HASH (maskless) filter support. Patch 10 adds and implements the flow director filter operations. Also add the documentation. [1] http://comments.gmane.org/gmane.comp.networking.dpdk.devel/29986 R

[dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and new behavior switch to fdir

2016-02-03 Thread Rahul Lakkireddy
new ip and port addresses to rewrite the fields of packets matching a filter rule before NAT'ing. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/rel_notes/release_2_3.rst | 3 +++ lib/librte_ether/rte_eth_ctrl.h | 15 ++- 2 files change

[dpdk-dev] [PATCH 02/10] examples/test-cxgbe-filters: add example to test cxgbe fdir support

2016-02-03 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- MAINTAINERS| 2 + doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/test_cxgbe_filters.rst| 694 + examples/Makefile

[dpdk-dev] [PATCH 03/10] cxgbe: add skeleton to add support for T5 hardware filtering

2016-02-03 Thread Rahul Lakkireddy
Update base to get info about supported filtering features. Add TID table that holds filter state and add filter specification that provide a skeleton to add LE-TCAM (Maskfull) and Hash (Maskless) T5 filtering capabilities. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi

[dpdk-dev] [PATCH 04/10] cxgbe: add control txq for communicating filtering info

2016-02-03 Thread Rahul Lakkireddy
Add a control txq with its own mempool to create control packets containing filtering information to be communicated with firmware. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/adapter.h| 15 +++ drivers/net/cxgbe/base/common.h | 2

[dpdk-dev] [PATCH 05/10] cxgbe: add compressed local IP table for matching IPv6 addresses

2016-02-03 Thread Rahul Lakkireddy
Add Compressed Local IP (CLIP) table that holds IPv6 addresses to be matched against packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/Makefile | 1 + drivers/net/cxgbe/base/adapter.h| 52 drivers/net/cxgbe/base

[dpdk-dev] [PATCH 06/10] cxgbe: add layer 2 table for switch action filter

2016-02-03 Thread Rahul Lakkireddy
Add Layer 2 Table (L2T) that holds destination mac addresses and vlan ids to be modified on a packet that matches a corresponding set 'switch' action filter. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/Makefile | 1 + drivers/net/

[dpdk-dev] [PATCH 07/10] cxgbe: add source mac table for switch action filter

2016-02-03 Thread Rahul Lakkireddy
Add Source MAC Table (SMT) that holds source mac addresses to be modified on a packet that matches a corresponding set 'switch' action filter. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/Makefile | 1 + drivers/net/cxgbe/base/adapt

[dpdk-dev] [PATCH 08/10] cxgbe: add LE-TCAM filtering support

2016-02-03 Thread Rahul Lakkireddy
filters with a higher index are ignored and the action is taken immediately. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/Makefile | 1 + drivers/net/cxgbe/base/adapter.h| 21 + drivers/net/cxgbe/base/common.h | 2 + drivers

[dpdk-dev] [PATCH 09/10] cxgbe: add HASH filtering support

2016-02-03 Thread Rahul Lakkireddy
prio bit in the filter specification. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/adapter.h| 11 + drivers/net/cxgbe/base/common.h | 7 + drivers/net/cxgbe/base/t4_msg.h | 198 drivers/net/cxgbe/base/t4_regs.h

[dpdk-dev] [PATCH 10/10] cxgbe: add flow director support and update documentation

2016-02-03 Thread Rahul Lakkireddy
umber of remaining free entries, and number of successful and failed added/deleted filters. Add documentation explaining the usage of CXGBE Flow Director support. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/cxgbe.rst| 166 doc/guides/rel_

[dpdk-dev] [PATCH] cxgbe: fix memory leak when device initialization fails

2016-02-12 Thread Rahul Lakkireddy
Add missing code to free adapter when the device initialization fails. Fixes: 8318984927ff ("cxgbe: add pmd skeleton") Reported-by: Seth Arnold Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe_ethdev.c | 7 ++- 1 file changed, 6 insert

[dpdk-dev] [PATCH v8 2/4] ethdev: Fill speed capability bitmaps in the PMDs

2016-02-15 Thread Rahul Lakkireddy
Hi Marc, On Sunday, February 02/14/16, 2016 at 23:17:37 +0100, Marc Sune wrote: > Added speed capabilities to all pmds supporting physical NICs: > > * e1000 > * ixgbe > * i40 > * bnx2x > * cxgbe > * mlx4 > * mlx5 > * nfp > * fm10k > > Signed-off-by: Marc Sune > --- > drivers/net/bnx2x/bnx2x_et

[dpdk-dev] [PATCH v2] doc: introduce networking driver matrix

2016-02-16 Thread Rahul Lakkireddy
Hi Thomas, Got a couple of questions on how to mark some of the features for CXGBE below. On Wednesday, January 01/27/16, 2016 at 21:07:09 +0100, Thomas Monjalon wrote: > In order to better compare the drivers and check what is missing > for a common baseline, we need to fill a matrix. > > A CSS

[dpdk-dev] [PATCH v2] doc: introduce networking driver matrix

2016-02-17 Thread Rahul Lakkireddy
Hi Thomas, On Tuesday, February 02/16/16, 2016 at 05:42:30 -0800, Thomas Monjalon wrote: > 2016-02-16 17:05, Rahul Lakkireddy: > > Hi Thomas, > > > > Got a couple of questions on how to mark some of the features for CXGBE > > below. > > > > On Wednesday, J

[dpdk-dev] [PATCH 0/5] cxgbe: add features to CXGBE PMD

2016-05-06 Thread Rahul Lakkireddy
4 sec. Patch 4 adds support to get/set EEPROM. Patch 5 adds support to get register dump. Rahul Lakkireddy (5): pci: fix access to PCI config space in bsd cxgbe: add support to access PCI config space cxgbe: set default PCIe completion timeout cxgbe: add support to get/set EEPROM cxgbe

[dpdk-dev] [PATCH 1/5] pci: fix access to PCI config space in bsd

2016-05-06 Thread Rahul Lakkireddy
PCIOCREAD and PCIOCWRITE ioctls to read/write PCI config space fail with EPERM due to missing write permission. Fix by opening /dev/pci/ with O_RDWR instead. Fixes: 632b2d1deeed ("eal: provide functions to access PCI config") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kum

[dpdk-dev] [PATCH 2/5] cxgbe: add support to access PCI config space

2016-05-06 Thread Rahul Lakkireddy
Add helper functions to access PCI config space. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/adapter.h | 129 ++- 1 file changed, 128 insertions(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/base/adapter.h b

[dpdk-dev] [PATCH 3/5] cxgbe: set default PCIe completion timeout

2016-05-06 Thread Rahul Lakkireddy
Program the PCIe completion timeout to 4 sec to give enough time to allow completions to be received successfully in some older systems. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/adapter.h | 2 ++ drivers/net/cxgbe/base/t4_hw.c | 19

[dpdk-dev] [PATCH 4/5] cxgbe: add support to get/set EEPROM

2016-05-06 Thread Rahul Lakkireddy
Add operations to get/set EEPROM. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/overview.rst | 2 +- drivers/net/cxgbe/base/adapter.h | 7 ++ drivers/net/cxgbe/base/common.h | 5 +- drivers/net/cxgbe/base/t4_hw.c | 182

[dpdk-dev] [PATCH 5/5] cxgbe: add support to get register dump

2016-05-06 Thread Rahul Lakkireddy
Add operations to get register dump. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/overview.rst | 2 +- drivers/net/cxgbe/base/common.h | 6 + drivers/net/cxgbe/base/t4_hw.c | 846 +++ drivers/net/cxgbe

[dpdk-dev] [PATCH] net/cxgbe: accept VLAN flow items without ethertype

2020-12-20 Thread Rahul Lakkireddy
org Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c index f7c4f3696..520a5a5c9 100644 --- a/drivers/net/cxgbe/cxg

[dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array

2020-12-20 Thread Rahul Lakkireddy
From: Karra Satwik Start from index 0 when going through the FEC array. This will allow "off" to get printed for RTE_ETH_FEC_NOFEC mode. Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkiredd

[dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps

2020-12-20 Thread Rahul Lakkireddy
From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- app/test-pmd/cmdline.c | 29 - 1 file changed, 20 insertions(+), 9 deletions

[dpdk-dev] [PATCH 0/3] net/cxgbe: rework link config and add FEC support

2020-12-20 Thread Rahul Lakkireddy
This series of patches rework link handling and add support to configure Forward Error Correction (FEC) capability. Patch 1 removes legacy 16-bit link capabilities infrastructure and always enables 32-bit link capabilities in firmware. Patch 2 simplifies link handling in preparation for FEC suppo

[dpdk-dev] [PATCH 1/3] net/cxgbe: remove legacy 16-bit link capabilities

2020-12-20 Thread Rahul Lakkireddy
From: Karra Satwik Remove legacy 16-bit link capabilities and always request for the 32-bit link capabilities from firmware. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 14 +- drivers/net/cxgbe/base/common.h | 9

[dpdk-dev] [PATCH 2/3] net/cxgbe: rework and simplify link handling code

2020-12-20 Thread Rahul Lakkireddy
From: Karra Satwik Rework and simplify link handling code. Remove redundant variables in link configuration structure and directly extract information from the 32-bit link capabilities. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h

[dpdk-dev] [PATCH 3/3] net/cxgbe: implement ethdev ops to configure link FEC

2020-12-20 Thread Rahul Lakkireddy
From: Karra Satwik Add ethdev ops to query and configure link FEC. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 2 + drivers/net/cxgbe/base/t4_hw.c | 79 ++ drivers/net/cxgbe/base/t4fw_interface.h | 6

[dpdk-dev] [PATCH v2] app/testpmd: increase array for fetching supported FEC caps

2020-12-23 Thread Rahul Lakkireddy
From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyun Li --- v2: - Replace if (!speed_fec_capa) with if (speed_fec_capa == NULL) app/test-pmd

Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array

2020-12-23 Thread Rahul Lakkireddy
On Monday, December 12/21/20, 2020 at 17:07:21 +0800, Min Hu (Connor) wrote: > > > 在 2020/12/21 6:47, Rahul Lakkireddy 写道: > >From: Karra Satwik > > > >Start from index 0 when going through the FEC array. This will allow > >"off" to get print

[dpdk-dev] [PATCH v3] app/testpmd: increase array for fetching supported FEC caps

2020-12-24 Thread Rahul Lakkireddy
From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyun Li --- v3: - Use unsigned int num, instead of int num v2: - Replace if (!speed_fec_capa

Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array

2020-12-25 Thread Rahul Lakkireddy
+dev@dpdk.org which seems to have been dropped by accident. On Friday, December 12/25/20, 2020 at 09:03:43 +0800, Min Hu (Connor) wrote: > > > 在 2020/12/24 19:25, Rahul Lakkireddy 写道: > >On Thursday, December 12/24/20, 2020 at 17:36:27 +0800, Min Hu (Connor) > >wrote: &g

[dpdk-dev] [PATCH 0/2] net/cxgbe: minor fixes for link related changes

2021-01-15 Thread Rahul Lakkireddy
fixes issue with link FEC retraining during probe. If firmware had already saved FEC before probe is completed, then use the saved FEC for further link configuration, instead of triggering link retraining. Also simplifies get fec ops. Thanks, Rahul Rahul Lakkireddy (2): net/cxgbe: do not link

[dpdk-dev] [PATCH 1/2] net/cxgbe: do not link down for every link config change

2021-01-15 Thread Rahul Lakkireddy
tatus coming in firmware's link config change reply. Fixes: 61570952b138 ("net/cxgbe: rework and simplify link handling code") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH 2/2] net/cxgbe: avoid link FEC retraining during probe

2021-01-15 Thread Rahul Lakkireddy
, there can only be 1 active FEC at any time. So, simplify the FEC get ops. If FEC is supported and if none of the supported FEC caps are set, then assume NOFEC by default, instead of AUTO. Fixes: b99a547371e3 ("net/cxgbe: support configuring link FEC") Signed-off-by: Rahul Lakkireddy --

[dpdk-dev] [PATCH 0/2] net/cxgbe: release port resources during port close

2020-09-01 Thread Rahul Lakkireddy
Patch 1 fixes queue DMA ring leaks seen during port close. Patch 2 enables RTE_ETH_DEV_CLOSE_REMOVE and reworks resources release logic for port close. Thanks, Rahul Rahul Lakkireddy (2): net/cxgbe: fix queue DMA ring leaks during port close net/cxgbe: release port resources during port

[dpdk-dev] [PATCH 1/2] net/cxgbe: fix queue DMA ring leaks during port close

2020-09-01 Thread Rahul Lakkireddy
d freelist queue. So, remove check that tries to give memzone name for a non-existent freelist queue. Also, add a missing free for the control queue mempools. Fixes: 0462d115441d ("cxgbe: add device related operations") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/

[dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close

2020-09-01 Thread Rahul Lakkireddy
all ports under the PF, in PCI remove too. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 28 drivers/net/cxgbe/cxgbe_main.c | 12 ++-- drivers/net/cxgbe/cxgbevf_ethdev.c | 8 +--- drivers/net/cxgbe/cxgbevf_main.c | 2 ++ 4

[dpdk-dev] [PATCH] net/cxgbe: fix duplicate MAC addresses in MPS TCAM

2020-09-01 Thread Rahul Lakkireddy
table") Cc: sta...@dpdk.org Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/mps_tcam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/cxgbe/mps_tcam.c b/drivers/net/cxgbe/mps_tcam.c index 5302d1343..6e5fae992 100644 --- a/drivers/net/cxgbe/

[dpdk-dev] [PATCH] net/cxgbe: fix segfault when accessing empty Tx mbuf list

2020-09-01 Thread Rahul Lakkireddy
Ensure packets are available before accessing the mbuf list in Tx burst function. Otherwise, just reclaim completed Tx descriptors and exit. Fixes: b1df19e43e1d ("net/cxgbe: fix prefetch for non-coalesced Tx packets") Cc: sta...@dpdk.org Reported-by: Brian Poole Signed-off-by: Rahul

[dpdk-dev] [PATCH v2] net/cxgbe: fix duplicate MAC addresses in MPS TCAM

2020-09-11 Thread Rahul Lakkireddy
table") Cc: sta...@dpdk.org Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- v2: - Fix spelling Othewise to Otherwise in commit message. drivers/net/cxgbe/mps_tcam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/cxgbe/mps_tcam.c b/drivers/net/cxgbe/mps_tc

[dpdk-dev] [PATCH 1/3] net/cxgbe: rework queue allocation between ports

2020-09-11 Thread Rahul Lakkireddy
, remove the equal distribution scheme and allow the ports to allocate as many queues as they need. Also remove the hardcoded 64 max limit on queue allocation. Instead, use the max limit given by firmware. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h | 12 +-- drivers/net

[dpdk-dev] [PATCH 0/3] net/cxgbe: rework queue allocation and add RSS reta update

2020-09-11 Thread Rahul Lakkireddy
ber/179131.html Thanks, Rahul Rahul Lakkireddy (3): net/cxgbe: rework queue allocation between ports net/cxgbe: improve Rx congestion control net/cxgbe: add support to update RSS redirection table doc/guides/nics/features/cxgbe.ini | 1 + drivers/net/cxgbe/base/adapter.h | 23 +++-- d

[dpdk-dev] [PATCH 2/3] net/cxgbe: improve Rx congestion control

2020-09-11 Thread Rahul Lakkireddy
Chelsio T6 NIC can support up to 8 priority channels to manage congestion. So, increase to 8 congestion channels for T6. Also, add Rxq state to avoid unnecessarily ringing doorbell and polling the hardware for more traffic when the Rxq is stopped. Signed-off-by: Rahul Lakkireddy --- drivers/net

[dpdk-dev] [PATCH 3/3] net/cxgbe: add support to update RSS redirection table

2020-09-11 Thread Rahul Lakkireddy
Implement eth_dev_ops to manipulate RSS redirection table. Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/features/cxgbe.ini | 1 + drivers/net/cxgbe/cxgbe_ethdev.c | 65 ++ 2 files changed, 66 insertions(+) diff --git a/doc/guides/nics/features/cxgbe.ini b

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-14 Thread Rahul Lakkireddy
On Monday, September 09/14/20, 2020 at 00:16:17 +0200, Thomas Monjalon wrote: > The patches for removing RTE_ETH_DEV_CLOSE_REMOVE are sent: > https://patches.dpdk.org/project/dpdk/list/?series=12173 > > 11 drivers are not supporting the new behaviour correctly: > bnx2x, cxgbe, dpaa, dp

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close

2020-09-18 Thread Rahul Lakkireddy
On Thursday, September 09/17/20, 2020 at 13:46:24 +0100, Ferruh Yigit wrote: > On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote: > >Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports > >enumerated under the PF. Free up the underlying port Virtual > >Identifier (VI) and

[dpdk-dev] [PATCH] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-16 Thread Rahul Lakkireddy
. The fix is to use uint64_t for offset and size. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal

[dpdk-dev] [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.

2015-06-18 Thread Rahul Lakkireddy
file. > > Please merge also the maintainer infos. > Will merge build config and maintainers with the Makefile patch > 2015-06-01 23:00, Rahul Lakkireddy: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) > > RTE_DIM may be used Will fix this in v3. Thanks, Rahul

[dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-06-18 Thread Rahul Lakkireddy
; incrementally, adding features to the cxgbe poll mode driver. - Replace bitwise operations in finding last (most significant) bit set with gcc's __builtin_clz. - Fix the return value returned by link update eth_dev operation. - Few bug fixes and code cleanup. Rahul Lakkireddy (9): cxgbe

[dpdk-dev] [PATCH v3 1/9] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-06-18 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under drivers/net/cxgbe/base directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes v2: - Move files to new directory under drivers/net/cxgbe/base and update commit log. - Few bug fixes related

[dpdk-dev] [PATCH v3 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-18 Thread Rahul Lakkireddy
. drivers/net/Makefile to add cxgbe pmd to the compile list. 3. mk/rte.app.mk to add cxgbe pmd to link. Update MAINTAINERS file to claim responsibility for the cxgbe PMD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - Merge patches 10 and 11 with this patch to enable

[dpdk-dev] [PATCH v3 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds RX support for the cxgbe poll mode driver. This patch: 1. Adds rx queue related eth_dev_ops. 2. Adds RSS support. 3. Adds dev_configure() and dev_infos_get() eth_dev_ops. 4. Adds rx_pkt_burst for receiving packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No

[dpdk-dev] [PATCH v3 5/9] cxgbe: add device related operations for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds dev_start(), dev_stop(), and dev_close() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Few changes related to tx bug fixes. drivers/net/cxgbe/cxgbe.h

[dpdk-dev] [PATCH v3 4/9] cxgbe: add TX support for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds TX support for the cxgbe poll mode driver. This patch: 1. Adds tx queue related eth_dev_ops. 2. Adds tx_pkt_burst for transmitting packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Few

[dpdk-dev] [PATCH v3 7/9] cxgbe: add link related functions for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds link update, promiscuous and multicast related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Update cxgbe_dev_link_update() to return correct value

[dpdk-dev] [PATCH v3 6/9] cxgbe: add port statistics for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds stats_get() and stats_reset() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe.h| 2 + drivers/net/cxgbe/cxgbe_ethdev.c

[dpdk-dev] [PATCH v3 9/9] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-06-18 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v3 8/9] cxgbe: add flow control functions for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds flow control related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe_ethdev.c | 54 1

[dpdk-dev] [PATCH] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-18 Thread Rahul Lakkireddy
Hi Thomas, On Wed, Jun 17, 2015 at 14:09:35 +0200, Thomas Monjalon wrote: > Hi Rahul, > > 2015-06-16 19:46, Rahul Lakkireddy: > > After the commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X > > tables), > > Please show this information before the S

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-23 Thread Rahul Lakkireddy
ow to map BARs with MSI-X tables") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - For fixing 32-bit build failure, rather than converting uint32_t var to uint64_t as done in v1, taking a different approach instead to revert a part of above commit-id so as to use th

<    1   2   3   4   5