[dpdk-dev] [PATCH] i40e: bug fix of compile error

2014-12-02 Thread Qiu, Michael
On 12/2/2014 8:36 AM, Zhang, Helin wrote: > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Monday, December 1, 2014 7:13 PM >> To: Zhang, Helin >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error >> >> 2014-

[dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h

2014-12-02 Thread Qiu, Michael
On 11/28/2014 10:22 PM, Thomas Monjalon wrote: > 2014-11-28 02:09, Qiu, Michael: >> I have no comments on this issue, but I indeed see many places do have >> this kernel issue(before/now/future), so can solve this issue globally? >> >> Thus, we do not need to fix t

[dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h

2014-12-02 Thread Qiu, Michael
On 11/28/2014 10:56 PM, Neil Horman wrote: > On Fri, Nov 28, 2014 at 02:09:40AM +0000, Qiu, Michael wrote: >> Hi all, >> >> I have no comments on this issue, but I indeed see many places do have >> this kernel issue(before/now/future), so can solve this issue globally?

[dpdk-dev] Error running dpdk app: cannot open /dev/uio

2014-12-03 Thread Qiu, Michael
Hi Malveeka, To be sure that you should have [uio, igb_uio] or [uio, uio_pci_generic] or [vfio] module loaded. Thanks, Michael On 12/3/2014 5:44 AM, Malveeka Tewari wrote: > Hi > > I am trying to run the testpmd app as but I get the following errors: > EAL: VFIO could not be initialized > EAL: Ca

[dpdk-dev] Error running dpdk app: cannot open /dev/uio

2014-12-03 Thread Qiu, Michael
ion > 3.6). Thanks, Michael > > Thanks! > Malveeka > > > > On Tue, Dec 2, 2014 at 5:12 PM, Qiu, Michael <mailto:michael.qiu at intel.com>> wrote: > > Hi Malveeka, > > To be sure that you should have [uio, igb_uio] or [uio, > uio_pci_generic]

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-03 Thread Qiu, Michael
Hi all, Any comments on this patch? It is really a big issue in dpdk1.8-rc2 and blocked the testing on i686 platform. Thanks, Michael On 12/3/2014 4:11 PM, Michael Qiu wrote: > lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison > is always false due to limited range of data type [

[dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error

2014-12-03 Thread Qiu, Michael
On 2014/12/3 22:51, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 01:59:58PM +0000, Qiu, Michael wrote: >> On 2014/12/3 19:43, Richardson, Bruce wrote: >>> On Wed, Dec 03, 2014 at 07:28:19PM +0800, Michael Qiu wrote: >>>> app/test-pmd/csumonly.c: In function ?ge

[dpdk-dev] [PATCH] test-pmd: Fix "__BYTE_ORDER__" not defined error

2014-12-03 Thread Qiu, Michael
Hi all, What about this patch? It may be some network or mail client issue of me, so not sure this patch posted to mail list successful. If failed, I will re-post it later. Thanks, Michael On 2014/12/3 19:28, Michael Qiu wrote: > app/test-pmd/csumonly.c:84:5: error: "__BYTE_ORDER__" is not def

[dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error

2014-12-03 Thread Qiu, Michael
On 2014/12/3 19:43, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 07:28:19PM +0800, Michael Qiu wrote: >> app/test-pmd/csumonly.c: In function ?get_psd_sum?: >> build/include/rte_ip.h:161: error: dereferencing pointer ?u16? >> does break strict-aliasing rules >> build/include/rte_ip.h:157

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:26 AM, Thomas Monjalon wrote: > There is no standard to check endianness. > So we need to try different checks. > Previous trials were done in testpmd (see commits > 51f694dd40f56 and 64741f237cf29) without full success. > This one is not guaranteed to work everywhere so it could > e

[dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error

2014-12-04 Thread Qiu, Michael
On 12/3/2014 11:36 PM, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 03:19:34PM +0000, Qiu, Michael wrote: >> On 2014/12/3 22:51, Richardson, Bruce wrote: >>> On Wed, Dec 03, 2014 at 01:59:58PM +, Qiu, Michael wrote: >>>> On 2014/12/3 19:43, Richardson, Bru

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-04 Thread Qiu, Michael
On 12/3/2014 11:40 PM, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 04:10:23PM +0800, Michael Qiu wrote: >> lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison >> is always false due to limited range of data type [-Werror=type-limits] >> || (hugepage_sz == RTE_PGSIZE_16G)) {

[dpdk-dev] [question] DPDK-2.0 support broadcom driver

2014-12-04 Thread Qiu, Michael
On 12/4/2014 3:18 AM, Thomas Monjalon wrote: > 2014-12-03 10:04, Stephen Hemminger: >> On Wed, 3 Dec 2014 09:48:57 +0800 >> "Zhang Haoyu" wrote: >>> I see that broadcom driver will be supported in DPDK-2.0 from >>> DPDK roadmap(http://dpdk.org/dev/roadmap), >>> any details about the progress? >>

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

2014-12-04 Thread Qiu, Michael
Hi Mark, I think Huawei (huawei.xie at intel.com) has one patch set to fix this issue. If your patch is totally different with him: [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix please ignore my comments :) But you both calculation are different. Thanks, Michael On 12/4/2

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:05 PM, Thomas Monjalon wrote: > 2014-12-04 02:49, Qiu, Michael: >> On 12/3/2014 11:40 PM, Richardson, Bruce wrote: >>> On Wed, Dec 03, 2014 at 04:10:23PM +0800, Michael Qiu wrote: >>>> lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparis

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:01 PM, Thomas Monjalon wrote: > 2014-12-04 02:28, Qiu, Michael: >> On 12/4/2014 5:26 AM, Thomas Monjalon wrote: >>> There is no standard to check endianness. >>> So we need to try different checks. >>> Previous trials were done in testpm

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 8:20 PM, Thomas Monjalon wrote: > 2014-12-04 10:28, Qiu, Michael: >> On 12/4/2014 5:01 PM, Thomas Monjalon wrote: >>> 2014-12-04 02:28, Qiu, Michael: >>>> On 12/4/2014 5:26 AM, Thomas Monjalon wrote: >>>>> There is no standard to check

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Qiu, Michael
On 12/4/2014 9:12 PM, Burakov, Anatoly wrote: > Hi Michael > >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >>

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-05 Thread Qiu, Michael
On 12/5/2014 12:31 AM, Burakov, Anatoly wrote: > Hi Michael > >> But indeed, when try to unload both vfio and vfio_iommu_type1, >> /dev/vfio/vfio still there, I'm also surprise. >> >> My ENV is fedora20, kernel version 3.6.7-200 X86_64. >> >> Believe or not, you can have a try, it seems a kernel is

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-05 Thread Qiu, Michael
Any comments about this version? a new workaround solution :) Thanks, Michael On 12/4/2014 9:35 PM, Michael Qiu wrote: > app/test-pmd/csumonly.c: In function ?get_psd_sum?: > build/include/rte_ip.h:161: error: dereferencing pointer ?u16? > does break strict-aliasing rules > build/include/r

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-05 Thread Qiu, Michael
Hi Chao Would you please take a look at this patch? It's solved issue introduce by Power Arch support patch. Your comments are very precious :) Thanks, Michael On 12/5/2014 2:03 PM, Michael Qiu wrote: > lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison > is always false due to l

[dpdk-dev] [PATCH] ixgbe: fix multi-process support

2014-12-05 Thread Qiu, Michael
On 12/4/2014 7:49 PM, Bruce Richardson wrote: > When using multiple processes, the TX function used in all processes > should be the same, otherwise the secondary processes cannot transmit > more than tx-ring-size - 1 packets. > To achieve this, we extract out the code to select the ixgbe TX functi

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-08 Thread Qiu, Michael
On 12/4/2014 9:35 PM, Michael Qiu wrote: > app/test-pmd/csumonly.c: In function ?get_psd_sum?: > build/include/rte_ip.h:161: error: dereferencing pointer ?u16? > does break strict-aliasing rules > build/include/rte_ip.h:157: note: initialized from here > ... > > The root cause is th

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-08 Thread Qiu, Michael
On 12/5/2014 5:26 PM, Thomas Monjalon wrote: > 2014-12-05 05:34, Qiu, Michael: >> Any comments about this version? a new workaround solution :) > Yes, one comment: I think it's ugly :) > These aliasing errors are not reliable so I think we can disable it (like > Linux d

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/5/2014 11:25 PM, Neil Horman wrote: > On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: >> On Fri, Dec 05, 2014 at 09:22:05AM -0500, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 04:31:47PM +0800, Chao Zhu wrote: On 2014/12/4 17:12, Michael Qiu wrote: > lib/librte_ea

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/8/2014 11:00 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 02:46:51AM +0000, Qiu, Michael wrote: >> On 12/5/2014 11:25 PM, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: >>>> On Fri, Dec 05, 2014 at 09:22:05AM -050

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/8/2014 11:39 AM, Qiu, Michael wrote: > On 12/8/2014 11:00 AM, Neil Horman wrote: >> On Mon, Dec 08, 2014 at 02:46:51AM +0000, Qiu, Michael wrote: >>> On 12/5/2014 11:25 PM, Neil Horman wrote: >>>> On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote:

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 12/5/2014 6:00 PM, Burakov, Anatoly wrote: > Hi Michael, > > Few nitpicks :-) (wording of the log message I guess is up to Thomas, I won't > comment on that) > >> lib/librte_eal/common/eal_private.h| 36 >> ++ >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Qiu, Michael
Hi all, My platform is: uname -a Linux suse-11-sp3 3.0.77-0.11-xen #1 SMP Tue Mar 11 16:48:56 CST 2014 x86_64 x86_64 x86_64 GNU/Linux gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/4.5/lto-wrapper Target: x86_64-suse-linux Configured with: ../con

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 12/8/2014 5:54 PM, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL: unsuppo

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 2014/12/8 19:38, Neil Horman wrote: > On Mon, Dec 08, 2014 at 03:37:19AM +0000, Qiu, Michael wrote: >> On 12/8/2014 11:00 AM, Neil Horman wrote: >>> On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: >>>> On 12/5/2014 11:25 PM, Neil Horman wrote: >&

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Qiu, Michael
On 2014/12/8 19:00, Wodkowski, PawelX wrote: >> lib/librte_pmd_enic/enic_main.c: In function ?enic_set_rsskey?: >> lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not used >> >> I dig out that, it was ome issue of the macros rte_memcpy() >> #define rte_memcpy(dst, src, n)

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 2014/12/8 20:19, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL: unsupport

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-09 Thread Qiu, Michael
On 12/9/2014 2:47 AM, Burakov, Anatoly wrote: > Hi Michael > >> I don't think so, if we check module "vfio", but if given module name is >> "vfio_xx", it will also correct if use strncmp. > Sorry I missed this the last time. I don't think that is the case. If you do > strncmp on sizeof(buffer), s

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

2014-12-09 Thread Qiu, Michael
On 12/9/2014 9:11 AM, Ouyang, Changchun wrote: > Hi Thomas, > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Monday, December 8, 2014 5:31 PM >> To: Ouyang, Changchun >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single vi

[dpdk-dev] error: value computed is not used

2014-12-09 Thread Qiu, Michael
Any other comments on this issue? Thanks, Michael On 12/8/2014 5:07 PM, Qiu, Michael wrote: > Hi all, > My platform is: > > uname -a > Linux suse-11-sp3 3.0.77-0.11-xen #1 SMP Tue Mar 11 16:48:56 CST 2014 > x86_64 x86_64 x86_64 GNU/Linux > > gcc -v > Using built-

[dpdk-dev] [PATCH v3 03/28] eal/pci: Replace pci address comparison code by eal_compare_pci_addr

2014-12-09 Thread Qiu, Michael
On 2014/12/9 14:32, Tetsuya Mukawa wrote: > This patch replaces pci_addr_comparison() and memcmp() of pci addresses by > eal_compare_pci_addr(). > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 16 +--- > lib/librte_eal/common/eal_common_pci.c|

[dpdk-dev] [PATCH v3 07/28] ethdev: Add functions to know which port is attached or detached

2014-12-09 Thread Qiu, Michael
On 2014/12/9 14:32, Tetsuya Mukawa wrote: > The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). > rte_eth_dev_save() is used for saving current rte_eth_dev structures. > rte_eth_dev_get_changed_port() receives the rte_eth_dev structures, then > compare these with current values to

[dpdk-dev] [PATCH v3 13/28] eal/pci: Prevent double registration for devargs_list

2014-12-09 Thread Qiu, Michael
On 2014/12/9 14:33, Tetsuya Mukawa wrote: > The patch fixes rte_eal_devargs_add() not to register same device twice. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_devargs.c | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git a/lib

[dpdk-dev] [PATCH v3 14/28] eal/pci: Add rte_eal_devargs_remove

2014-12-09 Thread Qiu, Michael
I don't know if other reviewers ask you to split so many patches. But I would like merge some of them, because some are doing same affairs(just using different args), others should be add/remove affairs. Those could be merge to one patch, although it is much more easier for review. Actually, it is

[dpdk-dev] [PATCH v3 15/28] eal/pci: Add probe and close function for virtual drivers

2014-12-09 Thread Qiu, Michael
On 2014/12/9 14:33, Tetsuya Mukawa wrote: > The patch adds rte_eal_dev_init_one() and rte_eal_dev_close_one(). > These are used for attaching and detaching virtual devices. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_dev.c | 66 > +

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

2014-12-09 Thread Qiu, Michael
PATCH 00/17] Single virtio implementation >> >> On Tue, Dec 09, 2014 at 06:40:23AM +, Ouyang, Changchun wrote: >>> >>>> -Original Message- >>>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >>>> Sent: Tuesday, D

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

2014-12-10 Thread Qiu, Michael
On 12/10/2014 8:17 AM, Xie, Huawei wrote: > Hi Michael: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael >> Sent: Monday, December 08, 2014 8:28 AM >> To: Burakov, Anatoly; dev at dpdk.org >> Subject: Re:

[dpdk-dev] [PATCH] igb_uio: kernel version check for using kstrtoul or strict_strtoul

2014-12-10 Thread Qiu, Michael
On 12/10/2014 11:02 AM, Zhang, Helin wrote: > Hi Jincheng > > Did you attach anything? I can see the text only. > Could you forward your patch mail to me directly? Thanks a lot! Hi Helin, I indeed ever saw one patch that was similar this one :) but not sure if it is post by Jincheng. You can go

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-10 Thread Qiu, Michael
Hi Thomas, What's going on with this patch? I really do not have other better solution. Thanks, Michael On 12/8/2014 9:30 AM, Qiu, Michael wrote: > On 12/4/2014 9:35 PM, Michael Qiu wrote: >> app/test-pmd/csumonly.c: In function ?get_psd_sum?: >> build/include/rte_ip.h:161:

[dpdk-dev] Accessing a Virtual Function Driver in Guest Machine via VFIO

2014-12-10 Thread Qiu, Michael
On 12/6/2014 3:01 AM, Aashima Arora wrote: > Hi, > I was trying to access the pci config space(BAR) of the virtual function > device visible in the virtual machine, similar to what DPDK does on host > via both UIO and VFIO. Did the following steps. > > 1. Bound PF Drivers to ixgbe and spawned virtu

[dpdk-dev] error: value computed is not used

2014-12-10 Thread Qiu, Michael
Hi all, Any idea? Leave this issue in DPDK? Thanks, Michael On 12/8/2014 5:07 PM, Qiu, Michael wrote: > Hi all, > My platform is: > > uname -a > Linux suse-11-sp3 3.0.77-0.11-xen #1 SMP Tue Mar 11 16:48:56 CST 2014 > x86_64 x86_64 x86_64 GNU/Linux > > gcc -

[dpdk-dev] [PATCH] Avoid possible memory cpoy when sort hugepages

2014-12-10 Thread Qiu, Michael
On 12/10/2014 6:41 PM, Richardson, Bruce wrote: > On Wed, Dec 10, 2014 at 10:25:41AM +0800, Michael Qiu wrote: >> When the first address is the compared address in the loop, >> it will also do memory copy, which is meaningless, >> worse more, when hugepg_tbl is mostly in order. This should >> be a

[dpdk-dev] [PATCH v5] VFIO: Avoid to enable vfio while the module not loaded

2014-12-10 Thread Qiu, Michael
On 12/10/2014 5:21 PM, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL: unsupp

[dpdk-dev] [PATCH] Avoid possible memory cpoy when sort hugepages

2014-12-11 Thread Qiu, Michael
On 12/11/2014 5:37 AM, Jay Rolette wrote: > On Wed, Dec 10, 2014 at 12:39 PM, Ananyev, Konstantin < > konstantin.ananyev at intel.com> wrote: > >>> I just got through replacing that entire function in my repo with a call >> to qsort() from the standard library last night myself. Faster >>> (althoug

[dpdk-dev] [PATCH v3 18/28] eal/pci: Prevent double registrations for pci_device_list

2014-12-11 Thread Qiu, Michael
If you modify one function, make sure all places, where call the function, have been modified accordingly in same patch. Please do not split it. Because we must make sure every patch could make dpdk work( I think without this patch, it will have some issue after you applied "Replace pci address c

[dpdk-dev] [PATCH v3 07/28] ethdev: Add functions to know which port is attached or detached

2014-12-11 Thread Qiu, Michael
On 12/11/2014 11:12 AM, Tetsuya Mukawa wrote: > Hi Michael, > > (2014/12/09 23:39), Qiu, Michael wrote: >> On 2014/12/9 14:32, Tetsuya Mukawa wrote: >>> The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). >>> rte_eth_dev_save() is used for savi

[dpdk-dev] [PATCH v3 20/28] eal/pci: Add rte_eal_pci_close_one_driver

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: > The function is used for closing the specified driver and device. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_private.h | 15 + > lib/librte_eal/linuxapp/eal/eal_pci.c | 61 > +++ > 2

[dpdk-dev] [PATCH v3 21/28] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > pci_close_all_drivers() will be implemented after the patch. > To share a part of code between thses 2 functions, The patch fixes > pci_probe_all_drivers() first. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c | 28 ++

[dpdk-dev] [PATCH v3 21/28] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-12-11 Thread Qiu, Michael
On 12/11/2014 11:52 AM, Qiu, Michael wrote: > On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: >> pci_close_all_drivers() will be implemented after the patch. >> To share a part of code between thses 2 functions, The patch fixes >> pci_probe_all_drivers() first. >> >&

[dpdk-dev] [PATCH v3 22/28] eal/pci: Add pci_close_all_drivers

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: > The function tries to find a driver for the specified device, and then > close the driver. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/l

[dpdk-dev] [PATCH v3 23/28] eal/pci: Add rte_eal_pci_probe_one and rte_eal_pci_close_one

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > The functions are used for probe and close a device. > First the function tries to find a device that has the specfied PCI address. > Then, probe or close the device. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c |

[dpdk-dev] [PATCH v3 25/28] eal/pci: Remove pci_probe/close_all_drivers()

2014-12-11 Thread Qiu, Michael
Why you do not call pci_invoke_all_drivers() directly in former patches? What you do is first modify then remove Thanks, Michael On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > These functions are actually wrappers of pci_invoke_all_drivers(). > Just call it directly. > > Signed-off-by: Tetsuy

[dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform

2014-12-11 Thread Qiu, Michael
On 2014/12/11 21:26, Neil Horman wrote: > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: >>> These two issues are both introuduced by commit b77b5639: >>> mem: add huge page sizes for IBM Power >>> >>> Michael Qiu (2): >>> Fix compile issue with hugepage_sz in 32-bit sys

[dpdk-dev] [PATCH v3 20/28] eal/pci: Add rte_eal_pci_close_one_driver

2014-12-11 Thread Qiu, Michael
On 2014/12/11 17:56, Richardson, Bruce wrote: > On Thu, Dec 11, 2014 at 03:41:06AM +0000, Qiu, Michael wrote: >> On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: >>> The function is used for closing the specified driver and device. >>> >>> Signed-off-by: Tetsuya

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-12 Thread Qiu, Michael
On 2014/12/12 1:51, r k wrote: Thomas, Michael, Wouldn't it cause unaligned memory access (new changes as well as the previous code)? Wondering if get_unaligned/put_unaligned macros similar to the ones used in kernel be ported to user-space? I think it will not, as all buf point to are struct

[dpdk-dev] error: value computed is not used

2014-12-16 Thread Qiu, Michael
On 12/15/2014 6:55 PM, Thomas Monjalon wrote: > 2014-12-08 15:26, Wodkowski, PawelX: >> From: Qiu, Michael >>> On 2014/12/8 19:00, Wodkowski, PawelX wrote: >>>>> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsskey': >>>>> lib/l

[dpdk-dev] [PATCH] fix rte_memcpy() macro: avoid unused value warning

2014-12-16 Thread Qiu, Michael
ble side effects are welcome an tests are welcome. > > Reported-by: Qiu, Michael > Signed-off-by: Pawel Wodkowski > --- > .../common/include/arch/x86/rte_memcpy.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/c

[dpdk-dev] [RFC PATCH 1/7] eal: add linear thread id as pthread-local variable

2014-12-16 Thread Qiu, Michael
On 12/11/2014 10:05 AM, Cunming Liang wrote: > Signed-off-by: Cunming Liang > --- > lib/librte_eal/common/include/rte_eal.h | 5 ++ > lib/librte_eal/common/include/rte_lcore.h | 12 > lib/librte_eal/linuxapp/eal/eal_thread.c | 115 > -- > 3 files changed, 1

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Qiu, Michael
On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: > On 16/12/14 4:54 am, "Thomas Monjalon" wrote: > >> 2014-12-12 13:48, Sujith Sankar: >>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver. >> Please, could you explain why the flag VFIO_PRESENT was not well used? > Withou

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Qiu, Michael
On 12/17/2014 7:01 PM, Ananyev, Konstantin wrote: > Hi Jay, > > From: Jay Rolette [mailto:rolette at infiniteio.com] > Sent: Tuesday, December 16, 2014 7:21 PM > To: Ananyev, Konstantin > Cc: Dev > Subject: Re: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() > with qsort() from stand

[dpdk-dev] [PATCH] ixgbe: fix segmentation fault when start secondary process

2014-12-18 Thread Qiu, Michael
On 12/18/2014 6:17 PM, Qiu, Michael wrote: > EAL: probe driver: 8086:10fb rte_ixgbe_pmd > EAL: PCI memory mapped at 0x7f18c2a0 > EAL: PCI memory mapped at 0x7f18c2a8 > Segmentation fault (core dumped) > > This is introduced by commit: 46bc9d75 > ixgbe: fix

[dpdk-dev] [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call

2014-12-18 Thread Qiu, Michael
Hi Neil, I think if you could add the commit author in the cc list will be better. Because this could let him know about his code's issue and he is the always the best person to review the patch. Thanks, Michael On 2014/12/18 19:32, Neil Horman wrote: > Back in: > > commit aaa662e75c23c61a1d79b

[dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call

2014-12-18 Thread Qiu, Michael
On 2014/12/18 19:26, Neil Horman wrote: > On Wed, Dec 17, 2014 at 11:20:26PM +0100, Thomas Monjalon wrote: >> Hi Neil, >> >> 2014-12-17 12:03, Neil Horman: >>> Back in: >>> >>> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db >>> Author: Alan Carew >>> Date: Fri Dec 5 15:19:07 2014 +0100 >>> >>>

[dpdk-dev] [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call

2014-12-19 Thread Qiu, Michael
On 12/19/2014 4:54 AM, Neil Horman wrote: > On Thu, Dec 18, 2014 at 01:45:54PM +0000, Qiu, Michael wrote: >> Hi Neil, >> >> I think if you could add the commit author in the cc list will be better. >> > The commit author is me, and its recorded by the Sign

[dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded

2014-12-19 Thread Qiu, Michael
Hi Thomas, Will you plan to merge this patch? If yes, you plan to merge it into 1.8 or 2.0? Thanks, Michael On 12/10/2014 7:48 PM, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description.

[dpdk-dev] [dts] DPDK Test Suite 1.0 Release

2014-12-19 Thread Qiu, Michael
Great, this tool will help all DPDK developers. And reduce the bugs of DPDK. Thanks, Michael On 12/19/2014 1:44 PM, Cao, Waterman wrote: > DPDK Test Suite 1.0 Release Announcement > > We are very pleased to announce that DPDK Test Suite 1.0 (DTS) is released > by intel now. DTS is an automation

[dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded

2014-12-22 Thread Qiu, Michael
On 12/19/2014 4:24 PM, Thomas Monjalon wrote: > 2014-12-19 07:09, Qiu, Michael: >> Hi Thomas, >> >> Will you plan to merge this patch? If yes, you plan to merge it into >> 1.8 or 2.0? > It won't be in 1.8 for 2 reasons: > - there is a risk to break someth

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-24 Thread Qiu, Michael
Hi Bruce, I haven't seen the third patch of you patch set. Just want to know if only me missed. Thanks, Michael On 12/23/2014 12:48 AM, Bruce Richardson wrote: > This RFC is for a small addition to the ethdev library, to add in support for > callbacks at the RX and TX stages. This allows packet

[dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API

2014-12-25 Thread Qiu, Michael
Hi Jingjing, Would you mind to tell me why need new APIs? Any functional or performance increase? Better to state in commit log. You know it should be careful to change APIs, especially for user interface. Thanks, Michael On 12/25/2014 11:14 AM, Jingjing Wu wrote: > The patch set uses new filte

[dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API

2014-12-25 Thread Qiu, Michael
t to the commit log, it could be better for other to understand why :) Thanks, Michael > Jingjing > > >> -Original Message- >> From: Qiu, Michael >> Sent: Thursday, December 25, 2014 11:27 AM >> To: Wu, Jingjing; dev at dpdk.org >> Subject: Re: [dpdk-de

[dpdk-dev] How do you setup a VM in Promiscuous Mode using PCI Pass-Through (SR-IOV)?

2015-05-18 Thread Qiu, Michael
Hi, Sami Could you mind to supply the syslog? Especially iommu related parts. Also you could update the qemu or kernel to see if this issue still exists. Thanks, Michael On 5/16/2015 3:31 AM, Assaad, Sami (Sami) wrote: > On Fri, May 15, 2015 at 12:54:19PM +, Assaad, Sami (Sami) wrote: >> T

[dpdk-dev] How do you setup a VM in Promiscuous Mode using PCI Pass-Through (SR-IOV)?

2015-05-20 Thread Qiu, Michael
5-19T19:10:12.674155Z qemu-kvm: -device > vfio-pci,host=04:00.0,id=hostdev0,bus=pci.0,addr=0x9: Device 'vfio-pci' could > not be initialized > > May 19 15:10:12 ni-nfvhost01 kvm: 0 guests now active > May 19 15:10:12 ni-nfvhost01 systemd-machined: Machine qemu-vNIDS-VM1 > ter

[dpdk-dev] How do you setup a VM in Promiscuous Mode using PCI Pass-Through (SR-IOV)?

2015-05-20 Thread Qiu, Michael
ay 19 15:10:12 ni-nfvhost01 kvm: 0 guests now active > May 19 15:10:12 ni-nfvhost01 systemd-machined: Machine qemu-vNIDS-VM1 > terminated. > May 19 15:11:01 ni-nfvhost01 systemd: Created slice user-0.slice. > May 19 15:11:01 ni-nfvhost01 systemd: Starting Session 329 of user root. >

[dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize

2015-05-20 Thread Qiu, Michael
Any comments about this patch? Thanks, Michael On 5/8/2015 4:14 PM, Michael Qiu wrote: > From: Michael Qiu > > When initialize the hardware, the stat should be reset. > Otherwise when detach then attach port, the stat will not > be re-init to zero. > > Signed-off-by: Michael Qiu > --- > lib/li

[dpdk-dev] [PATCH] pci: rename passthrough driver to kernel driver

2015-04-01 Thread Qiu, Michael
On 4/1/2015 6:07 AM, Thomas Monjalon wrote: > Kernel driver (kdrv) seems easier to understand than > passthrough driver (pt_driver). It's also more generic > as a PMD could run on top of any PCI kernel driver if > it would offer such support. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Mic

[dpdk-dev] [PATCH 1/2] pci: cleanup whitespace

2015-04-14 Thread Qiu, Michael
On 4/14/2015 6:11 AM, Stephen Hemminger wrote: > Fix whitespace errors reported by checkpatch, including > missing space around operators and places where tab should > be used instead of space. > > Signed-off-by: Stephen Hemminger Acked-by: Michael Qiu > --- > lib/librte_eal/linuxapp/eal/eal_p

[dpdk-dev] [PATCH 2/2] pci: rearrange logic from compare loop

2015-04-14 Thread Qiu, Michael
On 4/14/2015 6:11 AM, Stephen Hemminger wrote: > Do some cleanup of pci scan loop. > * check errors first > * don't initialize variables where not necessary Why? It should be better to initialize variables when define it. Thanks, Michael > * cuddle else (follow existing style) > * chop of

[dpdk-dev] [RFC PATCH] librte_pmd_ixgbe: changes to support PCI Port Hotplug

2015-04-22 Thread Qiu, Michael
On 4/8/2015 6:03 PM, Bernard Iremonger wrote: > This patch depends on the Port Hotplug Framework. > It implements the eth_dev_uninit functions for rte_ixgbe_pmd and > rte_ixgbevf_pmd.pmd. > > Signed-off-by: Bernard Iremonger > --- Tested-by: Michael Qiu > lib/librte_pmd_ixgbe/ixgbe_ethdev.c |

[dpdk-dev] What to do about UIO breakage in 2.0

2015-04-28 Thread Qiu, Michael
On 4/28/2015 6:06 AM, Stephen Hemminger wrote: > I raised the issue, but people seem to be ignoring that fact that igb_uio > was broken by the introduction of UIO PCI generic in 2.0. What do you mean about igb_uio broken? Thanks, Michael > > There are three options: > 1. Remove IGB_UIO only use

[dpdk-dev] [RFC] examples: remove l3fwd-vf example

2015-08-04 Thread Qiu, Michael
Actually, l3fwd works fine with fm10k vf. I don't know what's the exact reason of l3fwd-vf still in DPDK, at least we could make full support for vf in l3fwd instead of another sample with most code are the same compare with l3fwd. Thanks, Michael On 2015/7/22 7:51, Zhang, Helin wrote: Marvin

[dpdk-dev] how to build dpdk in debug mode?

2015-08-04 Thread Qiu, Michael
Please refer dec/build-sdk-quick.txt EXTRA_CFLAGS=-g should work. Thanks, Michael On 2015/8/3 9:29, Thomas Monjalon wrote: > 2015-08-03 16:16, Montorsi, Francesco: >> Hi all, >> I have searched the archives for this, without much success. >> >> Is it possible to build dpdk user-space libraries

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:05, De Lara Guarch, Pablo wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, August 07, 2015 4:29 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwardi

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:06, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Thursday, August 6, 2015 8:29 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >> >> For some ethn

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 13:37, Zhang, Helin wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Friday, August 7, 2015 11:53 AM >> To: Zhang, Helin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >>

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-10 Thread Qiu, Michael
On 2015/8/7 17:13, Ouyang, Changchun wrote: > >> [.../...] >> >> eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *); >> +ether_addr_copy(&peer_eth_addrs[fs->peer_addr], >> +ð_hdr->d_addr); >> +ether_addr_copy(&ports[fs->tx_port].eth_

[dpdk-dev] [PATCH]doc: Add performance tuning guide about how to get DPDK high perf on Intel platform.

2015-08-10 Thread Qiu, Michael
On 2015/8/10 9:11, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Monday, August 10, 2015 6:38 AM >> To: Xu, Qian Q >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH]doc: Add performance tuning guide abo

[dpdk-dev] [PATCH 1/6] ixgbe: Support VMDq RSS in non-SRIOV environment

2015-08-24 Thread Qiu, Michael
On 5/21/2015 3:50 PM, Ouyang Changchun wrote: > In non-SRIOV environment, VMDq RSS could be enabled by MRQC register. > In theory, the queue number per pool could be 2 or 4, but only 2 queues are > available due to HW limitation, the same limit also exist in Linux ixgbe > driver. > > Signed-off-by

[dpdk-dev] [PATCH v2] lib/librte_sched: Fix compile with gcc 4.3.4

2015-12-02 Thread Qiu, Michael
I will make v3 patch to fix the issue. Thanks, Michael On 2015/12/2 10:19, Thomas Monjalon wrote: > 2015-12-02 10:09, Michael Qiu: >> gcc 4.3.4 does not include "immintrin.h", and will post below error: >> lib/librte_sched/rte_sched.c:56:23: error: >> immintrin.h: No such file or director

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
Hi, Thomas I see you recently merged one commit: commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 Author: Thomas Monjalon Date: Tue Dec 8 01:50:17 2015 +0100 mk: fix external library build when combine is enabled The object files are copied to prepare the internal combined library.

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
My mistake. please ignore this issue. Thanks, Michael On 2015/12/8 15:08, Qiu, Michael wrote: > Hi, Thomas > > I see you recently merged one commit: > > commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 > Author: Thomas Monjalon > Date: Tue Dec 8 01:50:17 2015 +0100 >

[dpdk-dev] [PATCH] ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Qiu, Michael
Sorry please ignore this :) Thanks, Michael -Original Message- From: Qiu, Michael Sent: Wednesday, December 9, 2015 4:40 PM To: dev at dpdk.org Cc: Singh, Jasvinder; Dumitrescu, Cristian; root; Qiu, Michael Subject: [PATCH] ip_pipeline: Fix compile issue with strict-aliasing From: root

[dpdk-dev] Issue with patch "app/testpmd: detect numa socket count"

2015-12-19 Thread Qiu, Michael
gt; > Which would indicate that EAL was able to detect a higher max socket even > though it's not enabled. > > Is there a reason we're not CCing the mailing list? > > > -- Stephen Hurd > > > -Original Message- > From: Qiu, Michael [mailto:

[dpdk-dev] [PATCH v3] mem: calculate space left in a hugetlbfs

2015-12-21 Thread Qiu, Michael
On 2015/11/18 17:42, Jianfeng Tan wrote: > Currently DPDK does not respect the quota of a hugetblfs mount. > It will fail to init the EAL because it tries to map the number of > free hugepages in the system rather than using the number specified > in the quota for that mount. > > To solve this issu

[dpdk-dev] [PATCH] librte_ether: fix crashes in rte_ethdev functions.

2015-12-21 Thread Qiu, Michael
On 2015/12/18 1:24, Bernard Iremonger wrote: > The nb_rx_queues and nb_tx_queues are initialised before > the tx_queue and rx_queue arrays are allocated. The arrays > are allocated when the ethdev port is started. > > If any of the following functions are called before the ethdev > port is started

  1   2   3   4   >