[dpdk-dev] [PATCH v9 02/10] drivers: fix indent of directory list

2020-07-24 Thread Parav Pandit
From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

[dpdk-dev] [PATCH v9 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-24 Thread Parav Pandit
x5_class - Changed logic to parse device arguments only once during probe() - Added check to fail driver probe if multiple classes register with DMA ops - Renamed function to parse_class_options - Migreate API from rte_driver to rte_pci_driver Parav Pandit (8): eal: introduce macro for bit

[dpdk-dev] [PATCH v9 01/10] eal: introduce macro for bit definition

2020-07-24 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v4->v5: - Addressed comments from Mor

[dpdk-dev] [PATCH v9 03/10] drivers: relax dependency order

2020-07-24 Thread Parav Pandit
From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v9 04/10] common/mlx5: fix void parameters in glue wrappers

2020-07-24 Thread Parav Pandit
n't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav

[dpdk-dev] [PATCH v9 05/10] regex/mlx5: fix segmentation fault during error unwinding

2020-07-24 Thread Parav Pandit
When fail to initialize the device, avoid segmentation fault while accessing unintialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v7->v8: - Rebased - new patch --- drivers/regex/mlx5/mlx5_regex.c | 7 --- 1 fi

[dpdk-dev] [PATCH v9 07/10] common/mlx5: change class values as bits

2020-07-24 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad

[dpdk-dev] [PATCH v9 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-24 Thread Parav Pandit
Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v8->v9: - Added missing LDFLAG for pci bus - Fixed white spaces at st

[dpdk-dev] [PATCH v9 09/10] common/mlx5: register class drivers through common layer

2020-07-24 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drivers/common/mlx5/mlx5_common_pci.c | 6 ++ drivers/net/m

[dpdk-dev] [PATCH v9 06/10] common/mlx5: avoid using class constructor priority

2020-07-24 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new pa

[dpdk-dev] [PATCH v9 10/10] common/mlx5: remove class check from class drivers

2020-07-24 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

Re: [dpdk-dev] [PATCH v9 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-24 Thread Parav Pandit
> From: Parav Pandit > Sent: Friday, July 24, 2020 7:54 PM > > This series introduces mlx5 common driver layer to support multiple class of > devices for a single PCI device. > [..] > > Changelog: > v8->v9: > - Updated commit message > - Fixed LD

[dpdk-dev] [PATCH v10 02/10] drivers: fix indent of directory list

2020-07-24 Thread Parav Pandit
From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

[dpdk-dev] [PATCH v10 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-24 Thread Parav Pandit
API from rte_driver to rte_pci_driver Parav Pandit (8): eal: introduce macro for bit definition common/mlx5: fix void parameters in glue wrappers regex/mlx5: fix segmentation fault during error unwinding common/mlx5: avoid using class constructor priority common/mlx5: change class values as b

[dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

2020-07-24 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v4->v5: - Addressed comments from Mor

[dpdk-dev] [PATCH v10 03/10] drivers: relax dependency order

2020-07-24 Thread Parav Pandit
From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v10 05/10] regex/mlx5: fix segmentation fault during error unwinding

2020-07-24 Thread Parav Pandit
When fail to initialize the device, avoid segmentation fault while accessing unintialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v9->v10: - Corrected type in commit log v7->v8: - Rebased - new patch --- dr

[dpdk-dev] [PATCH v10 04/10] common/mlx5: fix void parameters in glue wrappers

2020-07-24 Thread Parav Pandit
n't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav

[dpdk-dev] [PATCH v10 07/10] common/mlx5: change class values as bits

2020-07-24 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad

[dpdk-dev] [PATCH v10 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-24 Thread Parav Pandit
Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v9->v10: - Fixed alignment v8->v9: - Added missing LDFLAG for p

[dpdk-dev] [PATCH v10 06/10] common/mlx5: avoid using class constructor priority

2020-07-24 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new pa

[dpdk-dev] [PATCH v10 09/10] common/mlx5: register class drivers through common layer

2020-07-24 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drivers/common/mlx5/mlx5_common_pci.c | 6 ++ drivers/net/m

[dpdk-dev] [PATCH v10 10/10] common/mlx5: remove class check from class drivers

2020-07-24 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order

2020-07-24 Thread Parav Pandit
> From: Bruce Richardson > Sent: Friday, July 24, 2020 8:20 PM > > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > > 24/07/2020 15:48, Parav Pandit: > > > Hi Bruce, > > > > > > > From: Bruce Richardson > > > > Sen

[dpdk-dev] [PATCH v11 02/10] drivers: fix indent of directory list

2020-07-26 Thread Parav Pandit
From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

[dpdk-dev] [PATCH v11 01/10] eal: introduce macro for bit definition

2020-07-26 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v4->v5: - Addressed comments from Mor

[dpdk-dev] [PATCH v11 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-26 Thread Parav Pandit
to fail driver probe if multiple classes register with DMA ops - Renamed function to parse_class_options - Migreate API from rte_driver to rte_pci_driver Parav Pandit (8): eal: introduce macro for bit definition common/mlx5: fix void parameters in glue wrappers regex/mlx5: fix segmentati

[dpdk-dev] [PATCH v11 03/10] drivers: relax dependency order

2020-07-26 Thread Parav Pandit
From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v11 04/10] common/mlx5: fix void parameters in glue wrappers

2020-07-26 Thread Parav Pandit
n't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav

[dpdk-dev] [PATCH v11 06/10] common/mlx5: avoid using class constructor priority

2020-07-26 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new pa

[dpdk-dev] [PATCH v11 05/10] regex/mlx5: fix segmentation fault during error unwinding

2020-07-26 Thread Parav Pandit
When fail to initialize the device, avoid segmentation fault while accessing uninitialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v9->v10: - Corrected type in commit log v7->v8: - Rebased - new patch --- dr

[dpdk-dev] [PATCH v11 07/10] common/mlx5: change class values as bits

2020-07-26 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad

[dpdk-dev] [PATCH v11 10/10] common/mlx5: remove class check from class drivers

2020-07-26 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

[dpdk-dev] [PATCH v11 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-26 Thread Parav Pandit
Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved class combination hunk from next patch to this one

[dpdk-dev] [PATCH v11 09/10] common/mlx5: register class drivers through common layer

2020-07-26 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved new class combinations to previous patch v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drive

Re: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

2020-07-27 Thread Parav Pandit
01/10] eal: introduce macro for bit > > definition > > > > > > There are several drivers which duplicate bit generation macro. > > > Introduce a generic bit macros so that such drivers avoid redefining > > same in > > > multiple drivers.

[dpdk-dev] [PATCH v12 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-27 Thread Parav Pandit
ror message string - Use uint32_t datatype instead of enum mlx5_class - Changed logic to parse device arguments only once during probe() - Added check to fail driver probe if multiple classes register with DMA ops - Renamed function to parse_class_options - Migreate API from rte_driver to rte_pci

[dpdk-dev] [PATCH v12 06/10] common/mlx5: avoid using class constructor priority

2020-07-27 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new pa

[dpdk-dev] [PATCH v12 05/10] regex/mlx5: fix segmentation fault during error unwinding

2020-07-27 Thread Parav Pandit
When fail to initialize the device, avoid segmentation fault while accessing uninitialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v9->v10: - Corrected type in commit log v7->v8: - Rebased - new patch --- dr

[dpdk-dev] [PATCH v12 04/10] common/mlx5: fix void parameters in glue wrappers

2020-07-27 Thread Parav Pandit
n't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav

[dpdk-dev] [PATCH v12 01/10] eal: introduce macro for bit definition

2020-07-27 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v11->v12: - Define RTE_BIT32 macro as w

[dpdk-dev] [PATCH v12 02/10] drivers: fix indent of directory list

2020-07-27 Thread Parav Pandit
From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

[dpdk-dev] [PATCH v12 03/10] drivers: relax dependency order

2020-07-27 Thread Parav Pandit
From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v12 07/10] common/mlx5: change class values as bits

2020-07-27 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad

[dpdk-dev] [PATCH v12 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-27 Thread Parav Pandit
Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v11->v12: - Added releases note back v10->v11: - Moved class combi

[dpdk-dev] [PATCH v12 09/10] common/mlx5: register class drivers through common layer

2020-07-27 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved new class combinations to previous patch v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drive

[dpdk-dev] [PATCH v12 10/10] common/mlx5: remove class check from class drivers

2020-07-27 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

<    1   2