[RFC PATCH 2/2] graph: add ip4 output feature arc

Signed-off-by: Nitin Saxena Change-Id: I80021403c343354c7e494c6bc79b83b0d0fe6b7c --- lib/node/ip4_rewrite.c | 278 lib/node/ip4_rewrite_priv.h | 10 +- lib/node/node_private.h | 10 +- lib/node/rte_node_ip4_api.h | 3 + 4 files changed, 233

[RFC PATCH 1/2] graph: add feature arc support

Signed-off-by: Nitin Saxena Change-Id: I8ca9d6285aaeedabc75131af8d28f8b2f63f614b --- lib/graph/graph_feature_arc.c| 834 +++ lib/graph/meson.build| 2 + lib/graph/rte_graph_feature_arc.h| 310 + lib/graph

[RFC PATCH 0/2] add feature arc in rte_graph

rst and then to ipv4 lookup node. This patch series adds feature arc library in rte_graph and also adds "ipv4-output" feature arc handling in "ipv4-rewrite" node. Nitin Saxena (2): graph: add feature arc support graph: add ip4 output feature arc lib/gr

[RFC PATCH 0/3] add feature arc in rte_graph

rst and then to ipv4 lookup node. This patch series adds feature arc library in rte_graph and also adds "ipv4-output" feature arc handling in "ipv4-rewrite" node. Nitin Saxena (3): graph: add feature arc support graph: add feature arc option in graph create graph: add IPv

[RFC PATCH 1/3] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- lib/graph/graph_feature_arc.c| 959 +++ lib/graph/meson.build| 2

[RFC PATCH 2/3] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh --- lib/graph/graph.c | 1 + lib/graph/graph_populate.c

[RFC PATCH 3/3] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 9 +- lib/node

[RFC PATCH 1/3] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- lib/graph/graph_feature_arc.c| 959 +++ lib/graph/meson.build| 2

[RFC PATCH 3/3] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 9 +- lib/node

[RFC PATCH 0/3] add featur arc in rte_graph

rst and then to ipv4 lookup node. This patch series adds feature arc library in rte_graph and also adds "ipv4-output" feature arc handling in "ipv4-rewrite" node. Nitin Saxena (3): graph: add feature arc support graph: add feature arc option in graph create graph: add IPv

[RFC PATCH 2/3] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh --- lib/graph/graph.c | 1 + lib/graph/graph_populate.c

[dpdk-dev] [PATCH] net/thunderx: fix MTU configuration for jumbo pkts

lls rte_eth_dev_set_mtu() before rte_eth_dev_start() by putting appropriate check for dev->data->dev_started Fixes: 65d9804edc05 ("net/thunderx: support MTU configuration") Signed-off-by: Nitin Saxena --- drivers/net/thunderx/base/nicvf_hw_defs.h | 5 - d

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

t/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.com/ Could you help merge this patch series in rc2 otherwise it has to wait for next LTS Thanks, Nitin > -Original Message- > From: David Marchand > Sent: Tuesday, October 8, 2024 1:34 PM > To: Nitin Saxena > Cc

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

Hi David, I just sent v2 version for this patch series. Will add Robin and Christophe from next version onwards Thanks, Nitin > -Original Message- > From: David Marchand > Sent: Tuesday, October 8, 2024 1:34 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kum

[RFC PATCH v2 1/5] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 11 +- lib/graph/graph_feature_arc.c| 1223

[RFC PATCH v2 3/5] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

[RFC PATCH v2 2/5] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- lib/graph/graph.c | 1

[RFC PATCH v2 0/5] add feature arc in rte_graph

Is rte_graph_feature_arc_feature_to_node(), rte_graph_feature_arc_feature_to_name(), rte_graph_feature_arc_num_features() - Added programming guide for feature arc - Added release notes for feature arc Nitin Saxena (5): graph: add feature arc support graph: add feature arc option in graph create g

[RFC PATCH v2 4/5] test/graph_feature_arc: add functional tests

Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v3 1/5] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1223

[PATCH v3 2/5] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes

[PATCH v3 0/5] add feature arc in rte_graph

graph_feature_arc_num_features() - Added programming guide for feature arc - Added release notes for feature arc Nitin Saxena (5): graph: add feature arc support graph: add feature arc option in graph create graph: add IPv4 output feature arc test/graph_feature_arc: add functional tests doc

[PATCH v3 4/5] test/graph_feature_arc: add functional tests

Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v3 3/5] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

[PATCH v4 0/5] add feature arc in rte_graph

found in testing - Added new public APIs rte_graph_feature_arc_feature_to_node(), rte_graph_feature_arc_feature_to_name(), rte_graph_feature_arc_num_features() - Added programming guide for feature arc - Added release notes for feature arc Nitin Saxena (5): graph: add feature arc support graph: add fe

[PATCH v4 1/5] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236

[PATCH v4 2/5] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes

[PATCH v4 4/5] test/graph_feature_arc: add functional tests

Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v4 3/5] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

RE: [EXTERNAL] graph: make the in-built nodes better reusable

swan, FRR etc 8. VLAN nodes (Not immediate item for us but in roadmap) Also see inline comments below. [0]: https://patches.dpdk.org/project/dpdk/cover/20241014143401.3135897-1-nsax...@marvell.com/ > -Original Message- > From: Robin Jarry > Sent: Monday, October 21, 2024 6:2

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

Hi Robin, See inline comments Thanks, Nitin On Thu, Oct 17, 2024 at 1:20 PM Robin Jarry wrote: > > Hi Nitin, all, > > Nitin Saxena, Oct 17, 2024 at 09:03: > > Hi Robin/David and all, > > > > We realized the feature arc patch series is difficult to unders

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

which I can share, when ready, to discuss. If needed, I can also plan to present that in one of the DPDK community meetings. Their we can also discuss if there are any alternatives of achieving above objectives Thanks, Nitin . On Wed, Oct 16, 2024 at 7:20 PM Nitin Saxena wrote: > > Hi

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

Hi Robin, Thanks for the review Please see my replies inline Thanks, Nitin On Wed, Oct 16, 2024 at 3:08 PM Robin Jarry wrote: > > Hi folks, > > David Marchand, Oct 16, 2024 at 11:24: > > On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote: > >> I had pushed non R

Re: [EXTERNAL] [RFC PATCH 0/3] add feature arc in rte_graph

ature arc: we need to configure > it per interface, and this is independent of the main graph. > There would be more protocols which need to be enabled per interface > WDYT? > Christophe > > > On 17 Oct 2024, at 09:50, Robin Jarry wrote: > > > > Hi Nitin, all,

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

Hi Christophe, Thanks for the review. See my comments inline Thanks, Nitin > -Original Message- > From: Christophe Fontaine > Sent: Wednesday, October 9, 2024 7:51 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram >

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

Thanks Stephen. Will fix compilation in next version. Thanks, Nitin > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 9, 2024 11:08 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhiru

RE: [RFC PATCH 1/3] graph: add feature arc support

Hi Kiran, See my inline comments. Somehow I forgot to respond earlier Thanks, Nitin > -Original Message- > From: Kiran Kumar Kokkilagadda > Sent: Wednesday, September 11, 2024 10:11 AM > To: Nitin Saxena ; Jerin Jacob ; > Nithin Kumar Dabilpuram ; Zhirun Yan >

[PATCH v5 1/5] graph: add feature arc support

add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236

[PATCH v5 4/5] test/graph_feature_arc: add functional tests

Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v5 3/5] graph: add IPv4 output feature arc

add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

[PATCH v5 5/5] docs: add programming guide for feature arc

Updated graph library guide with feature arc Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 288 +++ doc/guides/prog_guide/img/feature_arc-1.svg | 277 +++ doc/guides/prog_guide/img/feature_arc-2.svg | 511 doc/guides

[PATCH v5 0/5] add feature arc in rte_graph

machine - Updated images in .png format - Added ABI change section in release notes - Fixed DPDK CI failures Changes in v4: - Fixed clang build compilations - Captured `feat_arc_proc` function in ABI change section of release notes Changes in v5: - Updated images in .svg format Nitin Saxena (5):

[PATCH v5 2/5] graph: add feature arc option in graph create

Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes

[PATCH v6 0/4] add feature arc in rte_graph

ion - Changed design to handle fast path synchronization via RCU mechanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future version

[PATCH v6 1/4] graph: add API to override node process function

New API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_private.h

[PATCH v6 2/4] graph: add feature arc abstraction

anner Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|2 + doc/guides/rel_notes/release_25_03.rst | 10 + lib/graph/graph_feature_arc.c| 1780 ++ lib/graph/graph_private.h|4 + lib/graph/meson.

[PATCH v6 3/4] ip4: add ip4 output feature arc

Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction Signed-off-by: Nitin Saxena --- lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 133 lib/node/interface_tx_feature_priv.h | 33 +++ lib/node/ip4_rewrite.c

[PATCH v6 4/4] app/graph: add custom feature nodes for ip4 output arc

at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 ++ app/graph/f

Re: Feature arc slides

Hi Stephen, On Mon, Jan 6, 2025 at 5:45 AM Stephen Hemminger wrote: > > On Fri, 3 Jan 2025 20:29:15 +0530 > Nitin Saxena wrote: > > > Sending to DPDK community again > > > > Thanks, > > Nitin > > Why not convert the slides into useful long term docum

Re: [EXTERNAL] [PATCH v6 0/4] add feature arc in rte_graph

a sites: Dial * then 972 0427 1800 External: Dial 97204271...@zoomcrc.com OR: Dial 144.195.19.161 (US West), enter 972 0427 1800 and # when prompted. International H323 IP addresses == Thanks, Nitin On Fri, Jan 10, 2025 at 7:29 PM Robin Jarry wrote: > > Nitin Saxena, Jan 0

[PATCH v3 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v3 1/2] node: add global node mbuf dynfield

are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v3 0/2] node: add mbuf dynamic field for nodes

usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node/ip4_rewrite.c

Re: [PATCH 1/2] node: add global node mbuf dynfield

Hi Stephen, Thanks for commenting. See response inline. Regards, Nitin On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger wrote: > > On Tue, 1 Apr 2025 09:50:46 +0530 > Nitin Saxena wrote: > > > +int rte_node_mbuf_dynfield_register(void) > > +{ > > + struct n

[PATCH v2 1/2] node: add global node mbuf dynfield

are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v2 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH 1/2] node: add global node mbuf dynfield

are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH 0/2] node: add mbuf dynamic field for nodes

overlaodable mbuf dynamic fields. Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node

[PATCH 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v2 0/2] node: add mbuf dynamic field for nodes

overlaodable mbuf dynamic fields. Changes in v2: - removed usage of memzone for saving mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add

Re: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

> > Regards, > > > Nitin > > > > > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > > > Nitin Saxena wrote: > > > > > > > > >

[PATCH v4 1/2] node: add global node mbuf dynfield

are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v4 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v4 0/2] node: add mbuf dynamic field for nodes

can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node

Re: [PATCH v4 0/2] node: add mbuf dynamic field for nodes

Hi David, Thanks, Nitin On Tue, Apr 8, 2025 at 1:05 PM David Marchand wrote: > > Hello Nitin, > > On Mon, Apr 7, 2025 at 9:48 AM Nitin Saxena wrote: > > > > Currently each rte_node registers separate mbuf dynamic fields for their > > own purpose. This leads to

[PATCH v5 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v5 1/2] node: add global node mbuf dynfield

are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v5 0/2] node: add mbuf dynamic field for nodes

mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api