].
Unfortunately, we do not have the human resources to implement the
improvements that are necessary for ivshmem in DPDK, however we could
provide some feedback and testing for possible patches.
Best Regards,
Mauricio Vasquez.
[1]
https://www.researchgate.net/publication
Hi Kevin,
On 08/04/2016 08:55 AM, Kevin Wilson wrote:
> Hi,
> I am trying to use DPDK SRIOV passthrough with DPDK on Intel NICs.
> I am following the instructions in "Network Interface Controller Drivers", in
> http://fast.dpdk.org/doc/pdf-guides/nics-16.07.pdf
>
> I saw in "11.2 Setting Up a KVM
On 08/04/2016 10:27 AM, Kevin Wilson wrote:
> Hi Mauricio,
> Thanks!
>
>> be sure that kvm is enabled by
>> setting "accel=kvm" in the qemu command line.
> Isn't "--enable-kvm" intended for that ?
Sorry, I meant "-machine accel=kvm".
I don't know what is the exact difference but enable-kvm shoul
Dear Ferruh,
You are right, I messed up the brackets.
I already sent v3.
Thanks,
Mauricio.
On 11/02/2016 08:15 AM, Ferruh Yigit wrote:
> On 11/2/2016 12:49 PM, Fulvio Risso wrote:
>> Dear Ferruh,
>> Maybe I'm wrong, but I cannot see your point.
>> The code is absolutely the same, only the fo
Hello,
While performing a series of throughput testing I found a limitation
while generating traffic.
I have a server equipped with two 10G NICs that are connected using a
Ethernet wire. MoonGen is used to generate traffic on these interfaces,
it shows a performance of 22.52 Mpps. Theoreticall
Previous patch updated the functions without updating all the comments.
Fixes: 591a9d7985c1 ("add FILE argument to debug functions")
Signed-off-by: Mauricio Vasquez B
---
lib/librte_eal/common/include/rte_malloc.h | 2 +-
lib/librte_eal/common/include/rte_memory.h | 2 +-
lib/
flake8 checks were run for both python 2.7 and 3.4
There were some style issues as:
- Line width > 79
- No double blank line before function definition
- No double blank space before inline comment
- Some other minor issues
Signed-off-by: Mauricio Vasquez B
---
v2:
fix still existing warn
Section numbers were "hard-coded". This patch adds them as hyperlinks.
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/vhost.rst | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/vhost.rst
b/doc/guides/sample_app_ug
MANY references in the sample applications user guide are wrong because
they are hard-coded and section numbers have changed over the time.
This patch set changes thoses references to dynamic ones, in this way if
section numbers change the reference get updated automatically.
Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/dist_app.rst| 10 +-
doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 10 ++
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/doc/guides/sample_app_ug/dist_app.rst
b/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/vhost.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/vhost.rst
b/doc/guides/sample_app_ug/vhost.rst
index e5d1326..751656c 100644
--- a/doc/guides/sample_app_ug/vhost.rst
+++ b
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/exception_path.rst | 5 ++---
doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 4
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/exception_path.rst
b/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/intel_quickassist.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/intel_quickassist.rst
b/doc/guides/sample_app_ug/intel_quickassist.rst
index a80d4ca..04d1593 100644
--- a/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/ip_frag.rst | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/ip_frag.rst
b/doc/guides/sample_app_ug/ip_frag.rst
index 0c18fff..0c8da19 100644
--- a/doc/guides/sample_app_ug/ip_frag.rst
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst
b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst
index 12f0d27..2a576f3
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/ipv4_multicast.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst
b/doc/guides/sample_app_ug/ipv4_multicast.rst
index ec76087..67ea944 100644
--- a/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/keep_alive.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/keep_alive.rst
b/doc/guides/sample_app_ug/keep_alive.rst
index 080811b..b00f43b 100644
--- a/doc/guides/sample_app_ug
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/ip_reassembly.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/ip_reassembly.rst
b/doc/guides/sample_app_ug/ip_reassembly.rst
index 6bf5938..3c5cc70 100644
--- a/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/l3_forward.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/l3_forward.rst
b/doc/guides/sample_app_ug/l3_forward.rst
index 4ce734b..1aac7dd 100644
--- a/doc/guides/sample_app_ug
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 1 +
doc/guides/sample_app_ug/l3_forward.rst | 2 ++
doc/guides/sample_app_ug/l3_forward_virtual.rst | 7 +++
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/doc
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/kernel_nic_interface.rst | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/kernel_nic_interface.rst
b/doc/guides/sample_app_ug/kernel_nic_interface.rst
index 985c664..2ae9b70 100644
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/l3_forward_power_man.rst | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst
b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index ac688f8..ea9c404 100644
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/vm_power_management.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst
b/doc/guides/sample_app_ug/vm_power_management.rst
index da8be12..7f299e0 100644
--- a
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
index dbf47c7..4049e01
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
index 9140a22..e9ced9f 100644
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/link_status_intr.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/link_status_intr.rst
b/doc/guides/sample_app_ug/link_status_intr.rst
index de0dff8..a4dbb54 100644
--- a/doc
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/multi_process.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/multi_process.rst
b/doc/guides/sample_app_ug/multi_process.rst
index 6c3f3d2..ffe7ee6 100644
--- a/doc/guides
Signed-off-by: Mauricio Vasquez B
---
doc/guides/sample_app_ug/tep_termination.rst | 8
doc/guides/sample_app_ug/vhost.rst | 7 +++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/doc/guides/sample_app_ug/tep_termination.rst
b/doc/guides/sample_app_ug
e rte_eth_from_rings function.
Signed-off-by: Mauricio Vasquez B
---
drivers/net/ring/rte_eth_ring.c | 82 -
1 file changed, 56 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index d92b088..
A previous patch modified the CLIs witout updating the examples.
Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands")
Signed-off-by: Mauricio Vasquez B
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -
When freeing the device, it is also necessary to free rx_queues and tx_queues
Signed-off-by: Mauricio Vasquez B
---
drivers/net/ring/rte_eth_ring.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 9a31bce..e091e4f
When freeing the device it is also neccesary to free
rx_queues and tx_queues
Signed-off-by: Mauricio Vasquez B
---
v2:
Added extra control before freeing members of eth_dev->data
drivers/net/ring/rte_eth_ring.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/driv
The rte_eth_dev_count() function will never return a value greater
than RTE_MAX_ETHPORTS, so that checking is useless.
Signed-off-by: Mauricio Vasquez B
---
v2:
Add missed case in examples/kni/main.c
app/proc_info/main.c | 4
app/test/test_pmd_perf.c
The memory zone could be freed just after adding it to the metadata
file and just before marking it as not freeable.
This patch changes the locking logic in order to prevent it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
lib/libr
The memory zone could be freed just after adding it to the metadata
file and just before marking it as not freeable.
This patch changes the locking logic in order to prevent it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
lib/libr
although previous implementation returned an error when trying to release a
memzone assigned to an ivshmem device, it stills freed it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
lib/librte_eal/common/eal_common_memzone.c | 12 ++
although previous implementation returned an error when trying to release a
memzone assigned to an ivshmem device, it stills freed it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
v2:
solved compilation problem when ivshmem is disabled
lib/
The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places
to check if a port id is valid or not. This commit makes use of it in
some new parts of the code.
Signed-off-by: Mauricio Vasquez B
---
lib/librte_ether/rte_ethdev.c | 39 +--
1 file changed, 9
The rte_eth_dev_count() function will never return a value greater
than RTE_MAX_ETHPORTS, so that checking is useless.
Signed-off-by: Mauricio Vasquez B
---
app/proc_info/main.c | 4
app/test/test_pmd_perf.c | 3 ---
doc/guides
The example only had as return type struct, it is actually struct rte_acl_ctx *
Signed-off-by: Mauricio Vasquez B
---
doc/guides/contributing/versioning.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/guides/contributing/versioning.rst
b/doc/guides/contributing
flake8 checks were run for both python 2.7 and 3.4
There were some style issues as:
- Line width > 79
- No double blank line before function definition
- No double blank space before inline comment
- Some other minor issues
Signed-off-by: Mauricio Vasquez B
---
tools/dpdk_nic_bind.py |
The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places
to check if a port id is valid or not. This commit makes use of it in
some new parts of the code.
Signed-off-by: Mauricio Vasquez B
---
v2:
- add missed case
- change also cases in examples/ethtool/lib/rte_ethtool.c
examples
The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places
to check if a port id is valid or not. This commit makes use of it in
some new parts of the code.
Signed-off-by: Mauricio Vasquez B
---
v3:
- use it also in rte_eth_add_rx_callback and rte_eth_add_tx_callback
v2:
- add missed
internals->data will never be NULL, so the check is not necessary.
Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
Coverity issue: 137873
Signed-off-by: Mauricio Vasquez B
---
drivers/net/ring/rte_eth_ring.c | 20 +---
1 file changed, 9 insertions(+),
Coverity detected this as an issue because internals->data will never be NULL,
then the check is not necessary.
Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
Coverity issue: 137873
Signed-off-by: Mauricio Vasquez B
---
drivers/net/ring/rte_eth_ring.c | 20 +-
Coverity detected this as an issue because internals->data will never be NULL,
then the check is not necessary.
Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
Coverity issue: 137873
Signed-off-by: Mauricio Vasquez B
---
drivers/net/ring/rte_et
46 matches
Mail list logo
