[PATCH] lib/bpf: Rename 'bpf_validate' to avoid potential conflict with libpcap

2023-03-03 Thread Martzki
an internal function, I think adding an 'rte' prefix is not a good idea and rename it to 'bpf_do_validate' instead. Signed-off-by: Martzki --- lib/bpf/bpf_impl.h | 2 +- lib/bpf/bpf_load.c | 2 +- lib/bpf/bpf_validate.c | 2 +- 3 files changed, 3 insertions(+), 3 delet

[PATCH v2] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-06 Thread Martzki
Thanks for your review. In this v2 patch I renamed all functions in bpf_impl.h. Signed-off-by: Martzki --- v2: * Rename all functions in bpf_impl.h. * Adjust the commit message. --- lib/bpf/bpf.c | 6 +++--- lib/bpf/bpf_convert.c | 3 --- lib/bpf/bpf_impl.h | 10

[PATCH v3] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-06 Thread Martzki
The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. Signed-off-by: Martzk

[PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-11 Thread J.J. Martzki
The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. Signed-off-by: J.J. Martzk

Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-13 Thread J.J. Martzki
I've read the libbpf code again and I found some other functions with pure 'bpf_' prefix. Should we rename all the functions whose names start with pure 'bpf_'? Konstantin Ananyev 于2023年3月12日周日 22:02写道: > > 12/03/2023 06:20, J.J. Martzki пишет: > > T

[PATCH v5] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-14 Thread J.J. Martzki
The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. Signed-off-by: J.J. Martzk