[dpdk-dev] [PATCH 3/4] net/ena: cleanup if refilling of Rx descriptors fails

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk If wrong number of descriptors for refilling was passed to the Rx repopulate function, there was memory leak which caused memory pool to run out of resources in longer go. In case of fail when refilling Rx descriptors, all additional mbufs have to be released. Fixes: 1173f

[dpdk-dev] [PATCH 2/4] net/ena: fix delayed cleanup of Rx descriptors

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk On RX path, after receiving bunch of packets, variable tracking available descriptors in HW queue was not updated. To fix this issue, additional variable was added which is storing number of depleted descriptors updated by number of descriptors used in this cycle. Finally

[dpdk-dev] [PATCH 1/4] net/ena: fix incorrect Rx descriptors allocation

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk When application tried to allocate 1024 descriptors, device was not initializing properly. This patch solves it by avoiding allocation of all descriptors in the ring in one attempt. At least one descriptor must remain unused in the HW ring. Fixes: 1173fca25af9 ("ena: add p

[dpdk-dev] [PATCH 0/4] Ena PMD fixes

2017-04-07 Thread Marcin Wojtas
Hi, I sent 4 various fixes for ena PMD. 3 of them fix descriptors handling and the last one adjusts to the device firmware issue. We are looking forward to any comments or remarks. Best regards, Marcin Michal Krawczyk (4): net/ena: fix incorrect Rx descriptors allocation net/ena: fix delaye

[dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk When TSO is disabled we still have to calculate partial checksum if DF bit if turned off. This is caused by firmware bug. If application will not set m2_len field, we assume we that it was Ethernet frame because we have to look inside the packet to check for the DF flag. To

[dpdk-dev] [PATCH v2 0/4] Ena PMD fixes

2017-04-10 Thread Marcin Wojtas
Hi, I sent second version of a patchset with various fixes for ena PMD. All remarks after v1 review have been taken into account. Details can be found in the changelog below. We are looking forward to any comments or remarks. Best regards, Marcin Changelog: v1 -> v2 * 1/4: - Part of the c

[dpdk-dev] [PATCH v2 2/4] net/ena: fix delayed cleanup of Rx descriptors

2017-04-10 Thread Marcin Wojtas
From: Michal Krawczyk On RX path, after receiving bunch of packets, variable tracking available descriptors in HW queue was not updated. To fix this issue, variable tracking used descriptors must be updated after receiving packets - it must be reduced by the amount of received descriptors in cur

[dpdk-dev] [PATCH v2 1/4] net/ena: fix incorrect Rx descriptors allocation

2017-04-10 Thread Marcin Wojtas
From: Michal Krawczyk When application tried to allocate 1024 descriptors, device was not initializing properly. This patch solves it by avoiding allocation of all descriptors in the ring in one attempt. At least one descriptor must remain unused in the HW ring. Fixes: 1173fca25af9 ("ena: add p

[dpdk-dev] [PATCH v2 3/4] net/ena: cleanup if refilling of rx descriptors fails

2017-04-10 Thread Marcin Wojtas
From: Michal Krawczyk If wrong number of descriptors for refilling was passed to the Rx repopulate function, there was memory leak which caused memory pool to run out of resources in longer go. In case of fail when refilling Rx descriptors, all additional mbufs have to be released. Fixes: 1173f

[dpdk-dev] [PATCH v2 4/4] net/ena: calculate partial checksum if DF bit is disabled

2017-04-10 Thread Marcin Wojtas
From: Michal Krawczyk When TSO is disabled we still have to calculate partial checksum if DF bit if turned off. This is caused by firmware bug. First of all, we must make sure that we are dealing with IPV4 packet. If not, we will just skip further checking of this packet and move to the next one

[dpdk-dev] [PATCH] maintainers: update for ena PMD

2017-04-12 Thread Marcin Wojtas
Following changes of the ENA driver ownership in Amazon and Semihalf (Jakub and Jan no longer work in the company), update driver's maintainers list. Special thanks to Jan Medala and Jakub Palider for their support and development. Signed-off-by: Marcin Wojtas --- MAINTAINERS | 6 +++-

Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-21 Thread Marcin Wojtas
+ Ferruh and Michal 2018-06-20 18:32 GMT+02:00 Daria Kolistratova : > When he number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. > Fixed adding zero check before division. > > Signed-off-by: Daria Kolistratova > --- > drivers/net/ena/ena_ethdev.c |

Re: [dpdk-dev] [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09

2018-09-24 Thread Marcin Wojtas
Hi Ferruh, pon., 24 wrz 2018 o 13:38 Ferruh Yigit napisał(a): > > On 9/23/2018 11:40 PM, Thomas Monjalon wrote: > > 19/09/2018 19:15, Ferruh Yigit: > >> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: > >>> From: Natalie Samsonov > >>> --- a/doc/guides/nics/mvpp2.rst > >>> +++ b/doc/guides/nics/mvp

Re: [dpdk-dev] [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09

2018-09-24 Thread Marcin Wojtas
pon., 24 wrz 2018 o 14:44 Thomas Monjalon napisał(a): > > 24/09/2018 13:36, Ferruh Yigit: > > On 9/23/2018 11:40 PM, Thomas Monjalon wrote: > > > As a consequence, next-net cannot be pulled! > > > > Got it, should I drop the patchset from tree? > > Yes I think it's better to re-consider this patch

Re: [dpdk-dev] [PATCH v2 0/4] add net mrvl pmd driver

2017-09-28 Thread Marcin Wojtas
Hi Amit, 2017-09-28 13:40 GMT+02:00 Amit Tomer : > > >> This patch series introduces the net driver for Marvell Armada 7k/8k > >> SoCs along with documentation. > > Wondering, if it could be tested on Marvell Armada 3700 based > ESPRESSObin board ? > Different SoC. This one is intended to work wi

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Marcin Wojtas
2017-10-09 21:02 GMT+02:00 Ferruh Yigit : > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: >> Signed-off-by: Jacek Siuda >> Signed-off-by: Tomasz Duszynski > > Congratulations!, > > this is the 3. patch in patchwork: > http://dpdk.org/dev/patchwork/patch/3/ There's no other option now, bu

Re: [dpdk-dev] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case

2020-08-13 Thread Marcin Wojtas
: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features") > CC: sta...@dpdk.org > > Signed-off-by: Michal Krawczyk > [Extracted from a bigger patch] > Signed-off-by: Artur Rojek Reviewed-by: Marcin Wojtas > --- > drivers/net/ena/base/ena_eth_com.h | 3 ++- >