Thank you for the feedback. I will re-implement the test by not checking
port-flow-queue combination and generally clean-up the code based on your
comments.
On Tue, 2024-12-10 at 11:37 +0100, Mattias Rönnblom wrote:
>
> > +{
> > + struct rte_event_dev_info dev_info;
> > +
> > + rte_
From 2e55ecd0e522f50cbb3635f53b025e165db7cf3e Mon Sep 17 00:00:00 2001
In-Reply-To: <228d44a6f2f1f6a4fb5519d9a91c99973f8d7352.ca...@ericsson.com>
References: <228d44a6f2f1f6a4fb5519d9a91c99973f8d7352.ca...@ericsson.com>
From: Luka Jankovic
Date: Thu, 19 Dec 2024 13:31:26 +
Subjec
On Tue, 2024-12-10 at 11:37 +0100, Mattias Rönnblom wrote:
>
> > +{
> > + struct rte_event_dev_info dev_info;
> > +
> > + rte_event_dev_info_get(dev_id, &dev_info);
> > + return (dev_info.event_dev_cap &
> > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE) ?
> > + true :
From 753273ab9af49e16d7f7b577d6263e3db51257d7 Mon Sep 17 00:00:00 2001
From: Luka Jankovic
Date: Thu, 5 Dec 2024 13:05:35 +
Subject: [RFC] eventdev: add atomic queue to test-eventdev app
Add an atomic queue test based on the order queue test but use exclusively
atomic queues.
This makes it
t; The test will fail if a port attempts to take a lock which is already taken.
> >
> > Signed-off-by: Luka Jankovic
> > ---
> > v5:
> > * Updated documentation for dpdk-test-eventdev
> > v4:
> > * Fix code style issues.
> > * Remove unused im
is used for each combination of queue and flow.
It is acquired whenever an event is dequeued for processing and
released when processing is finished.
The test will fail if a port attempts to acquire a lock which is already held.
Signed-off-by: Luka Jankovic
---
v6:
* Revert the use of event.u64
Add relevant documentation to the tools/testeventdev page.
Signed-off-by: Luka Jankovic
---
.../tools/img/eventdev_atomic_queue_test.svg | 1701 +
doc/guides/tools/testeventdev.rst | 92 +
2 files changed, 1793 insertions(+)
create mode 100644 doc/guides/tools
queue and
flow.
It is taken whenever an event is dequeued for processing and released when
processing is finished.
The test will fail if a port attempts to take a lock which is already taken.
Signed-off-by: Luka Jankovic
---
v4:
* Fix code style issues.
* Remove unused imports.
v3:
* Use
queue and
flow.
It is taken whenever an event is dequeued for processing and released when
processing is finished.
The test will fail if a port attempts to take a lock which is already taken.
Signed-off-by: Luka Jankovic
---
v5:
* Updated documentation for dpdk-test-eventdev
v4:
* Fix code
Signed-off-by: Luka Jankovic
---
.../tools/img/eventdev_atomic_queue_test.svg | 1701 +
doc/guides/tools/testeventdev.rst | 92 +
2 files changed, 1793 insertions(+)
create mode 100644 doc/guides/tools/img/eventdev_atomic_queue_test.svg
diff --git a/doc/guides
On Mon, 2024-12-23 at 12:16 +0100, Mattias Rönnblom wrote:
>
> > +static __rte_always_inline void
>
> Why is this __rte_always_inline?
>
The stage functions are based on the ones defined in test_order_queue.c and the
test_order_common.h respectively, where they were defined with
__rte_always_
; > released when processing is finished.
> >
> > The test will fail if a port attempts to acquire a lock which is already
> > held.
> >
> > Signed-off-by: Luka Jankovic
>
> It would be great if you could add atomic-atq test too.
I will add atomic-atq, but I only have access to sw and dsw, so I am unable to
test it locally.
Introduce changes required for atomic tests to run atomic tests.
- Producer port maintenance
- Common spinlock implementation
Signed-off-by: Luka Jankovic
---
app/test-eventdev/evt_common.h | 9 ++
app/test-eventdev/meson.build | 1 +
app/test-eventdev/test_atomic_common.c
Add an atomic queue test to the test-eventdev app, which is based on the
order queue test that exclusively uses atomic queues.
Signed-off-by: Luka Jankovic
---
app/test-eventdev/meson.build | 1 +
app/test-eventdev/test_atomic_queue.c | 230 ++
2 files changed
each combination of stage and flow.
It is acquired whenever an event is dequeued for processing and released when
processing is finished.
The tests will fail if a port attempts to acquire a lock which is already held.
Luka Jankovic (4):
eventdev: atomic common for test-eventdev app
eventdev
Add an atomic atq test to the test-eventdev app. The test works
in the same way as atomic queue, the difference being that only one
queue capable of all types for both stages.
Signed-off-by: Luka Jankovic
---
app/test-eventdev/meson.build | 1 +
app/test-eventdev/test_atomic_atq.c | 216
I accidentally sent the last version (v9) with an incorrect git name, but the
commits are signed correctly. Will this be an issue or should I upload a new
version with the correct name?
Add an atomic atq test to the test-eventdev app. The test works
in the same way as atomic queue, the difference being that only one
queue capable of all types for both stages.
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/meson.build |1
each combination of stage and flow.
It is acquired whenever an event is dequeued for processing and released when
processing is finished.
The tests will fail if a port attempts to acquire a lock which is already held.
Luka Jankovic (3):
eventdev: atomic common for test-eventdev app
eventdev
Add an atomic queue test to the test-eventdev app, which is based on the
order queue test that exclusively uses atomic queues.
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/meson.build |1 +
app/test-eventdev/test_atomic_queue.c
Introduce changes required for atomic tests to run atomic tests.
- Producer port maintenance
- Common spinlock implementation
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/evt_common.h | 9 ++
app/test-eventdev/meson.build | 1 +
app/test
Add an atomic queue test to the test-eventdev app, which is based on the
order queue test that exclusively uses atomic queues.
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/meson.build |1 +
app/test-eventdev/test_atomic_queue.c
Add an atomic atq test to the test-eventdev app. The test works
in the same way as atomic queue, the difference being that only one
queue capable of all types for both stages.
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/meson.build |1
each combination of stage and flow.
It is acquired whenever an event is dequeued for processing and released when
processing is finished.
The tests will fail if a port attempts to acquire a lock which is already held.
Luka Jankovic (3):
eventdev: atomic common for test-eventdev app
eventdev
Introduce changes required for atomic tests to run atomic tests.
- Producer port maintenance
- Common spinlock implementation
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/evt_common.h | 9 ++
app/test-eventdev/meson.build | 1 +
app/test
Update atomic_init_locks to immediately return if memory allocation
fails. Atomic queue and atq tests updated to handle atomic locks being
null.
Coverity issue: 457876
Fixes: 9d619f82321b ("app/eventdev: introduce atomic tests")
Signed-off-by: Luka Jankovic
---
app/tes
26 matches
Mail list logo
