Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

Hey I'm taking paternity leave now so late on response. The v1 was different from what Thomas asked for and (hw->adapter_stopped == 0) was ignored (see cited below). So we felt uncomfortable about that as there is no guarantee that the device has been closed before calling uninit. Now that you

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++-- 1 file c

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

4/30/2018 11:20 PM, Louis Luo wrote: > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethdev: introduce Rx queue offloads API") > > This patch adopts the new RX Offload API in vmxnet3 driver. > > Signed-off-by: Louis Luo

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_eth

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_eth

Re: [dpdk-dev] vmxnet3 Maintainer?

Hi Dave, The previous maintainer, Shri, has left VMware. Now Yong is taking the maintainer's role and I will work on the vmxnet3 driver. I haven't heard from Shri about the issue before. We can setup a testbed to reproduce the issue. Can you describe your setup? The issue reported by Paul in th

Re: [dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

Hi Luca, When eth_vmxnet3_dev_uninit() is called, is it guaranteed that vmxnet3_dev_close/ vmxnet3_dev_stop must have been called? I'm not familiar with the hot-plug procedure, so just wonder if there is any chance that eth_vmxnet3_dev_uninit() is called without calling vmxnet3_dev_close/ vmxn

Re: [dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

46679d7608d61d68bf9a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636728733078700911&sdata=qBx7zyOJhTmVH0c2ZEBohmIHL6PkYwB6XPaw2epgS0E%3D&reserved=0 On Mon, 2018-09-17 at 19:06 +, Louis Luo wrote: > Hi Luca, > > When eth_vmxnet3_dev_uninit() is called, is it guaranteed that > vmx

Re: [dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

the application doesn't call close before calling uninit), I prefer keeping the check (and log some warning) in case any buggy application exists. Thanks, Louis On 9/18/18, 11:29 AM, "Luca Boccassi" wrote: On Tue, 2018-09-18 at 18:14 +, Louis Luo wrote: > Hi Luca,

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa

Hi Maxime, Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine. Thanks, Louis On 8/13/19, 6:30 AM, "Maxime Leroy" wrote: The vmxnet3_prep_pkts function