[dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-09 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Spotted by Coverity: CID 27441 Signed-off-by: Li Qiang --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool

2019-04-09 Thread Li Qiang
When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing 'bp' thus leading resource leak. This patch avoids this. Spotted by Coverity: CID 337679 Signed-off-by: Li Qiang --- drivers/mempool/dpaa/dpaa_mempool.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

Re: [dpdk-dev] [PATCH] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool

2019-04-09 Thread Li Qiang
Sorry this patch has an error, please see the v2. Thanks, Li Qiang Li Qiang 于2019年4月9日周二 下午10:33写道: > When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing > 'bp' thus leading resource leak. This patch avoids this. > > Spotted by Coverity: CID 33

[dpdk-dev] [PATCH v2] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool

2019-04-09 Thread Li Qiang
When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing 'bp' thus leading resource leak. This patch avoids this. Spotted by Coverity: CID 337679 Signed-off-by: Li Qiang --- drivers/mempool/dpaa/dpaa_mempool.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[dpdk-dev] [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-10 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Spotted by Coverity: CID 27441 Signed-off-by: Li Qiang --- Changes since v1: fill ret before goto close_fd per Rosen's review

[dpdk-dev] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-16 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Coverity issue: 279441 Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Li Q

[dpdk-dev] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-16 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Coverity issue: 279441 Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Li Q