[PATCH] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
uot;) Signed-off-by: Kevin Laatz --- drivers/bus/pci/pci_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7f598667fe..330a41ed12 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common

[PATCH v2] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
uot;) Signed-off-by: Kevin Laatz --- v2: remove redundant NULL checks --- drivers/bus/pci/pci_common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7f598667fe..71cd3f59ad 100644 --- a/drivers/bus/pci/pci_common

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 16/12/2022 10:21, Robin Jarry wrote: Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cp

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 10:21, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 18 January 2023 10.42 To: Robin Jarry; dev@dpdk.org Cc: Tyler Retzlaff; Morten Brørup Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry On 16/12/2022 10:21, Robin Jarry wrote

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 14:45, Robin Jarry wrote: Kevin Laatz, Jan 18, 2023 at 10:42: Hi Robin, Thanks for taking the time to work on this. It is a good implementation for debug use-cases. I have 2 suggestions which would improve the usability of the data: 1. Could we make the lcore_id paramater on

Re: [PATCH v6 1/5] eal: add lcore info in telemetry

2023-01-19 Thread Kevin Laatz
ket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-by: Robin Jarry Acked-by: Morten Brørup --- Notes: v5 -> v6: No change lib/eal/common/eal_common_lcore.c | 96 +++ 1 file changed, 96 insertions(+) Reviewed-by: Kevin Laatz

Re: [PATCH v6 2/5] eal: allow applications to report their cpu usage

2023-01-19 Thread Kevin Laatz
35 lib/eal/version.map | 1 + 3 files changed, 78 insertions(+), 3 deletions(-) Reviewed-by: Kevin Laatz

Re: [PATCH v6 3/5] testpmd: add dump_lcores command

2023-01-19 Thread Kevin Laatz
-by: Kevin Laatz

Re: [PATCH v6 4/5] testpmd: report lcore usage

2023-01-19 Thread Kevin Laatz
++ app/test-pmd/rxonly.c | 5 +++-- app/test-pmd/shared_rxq_fwd.c | 5 +++-- app/test-pmd/testpmd.c| 39 ++- app/test-pmd/testpmd.h| 14 + app/test-pmd/txonly.c | 7 --- 13 files changed, 81 insertions(+), 27 deletions(-) Reviewed-by: Kevin Laatz

Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Kevin Laatz
{ "lcore_ids": [ 4, 5 ], "total_cycles": [ 23846845590, 23900558914 ], "busy_cycles": [ 21043446682, 21448837316 ] } } Cc: Kevin Laatz Cc: Morten Brørup Signed-off-by: Robin Jarry

[dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure

2021-06-17 Thread Kevin Laatz
/ioat: report status of completed jobs") Signed-off-by: Kevin Laatz --- drivers/raw/ioat/ioat_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/ioat/ioat_common.c b/drivers/raw/ioat/ioat_common.c index d01c1ee367..f4771745cc 100644 --- a/drivers/raw/ioat/ioat_common

[dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset

2021-06-17 Thread Kevin Laatz
ce configure. Fixes: 74464005a2af ("raw/ioat: rework SW ring layout") Signed-off-by: Kevin Laatz --- drivers/raw/ioat/ioat_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/ioat/ioat_common.c b/drivers/raw/ioat/ioat_common.c index f4771745cc..60de41152a

[PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Kevin Laatz
r bus maintainers to add the relevant cleanup for their buses since they have the domain expertise. Signed-off-by: Kevin Laatz Acked-by: Morten Brørup Reviewed-by: Bruce Richardson --- v7: * free rte_pci_device structs during cleanup * free rte_vdev_device structs during cleanup v6: * fix units i

Re: [PATCH v6] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Kevin Laatz
On 02/06/2022 03:06, lihuisong (C) wrote: Hi Kevin, 在 2022/6/2 1:02, Kevin Laatz 写道: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up

Re: [PATCH] dma/idxd: fix return value for pci device commands

2022-06-08 Thread Kevin Laatz
negated before being returned by the function, meaning error codes cannot be checked against the HW specification. This patch fixes the return values of the function by removing the negation. Signed-off-by: Kevin Laatz Acked-by: Conor Walsh Fixes: 9449330a8458 ("dma/idxd: create d

[PATCH v2 0/3] Fix IDXD PCI device close

2022-07-03 Thread Kevin Laatz
nsure the cleanup is completed correctly. Depends-on: patch-112376 ("eal: add device removal in rte cleanup") --- v2: * remove changes to applications (no longer needed with EAL changes) * add fix for NULL pointer dereference in pci remove Kevin Laatz (3): dma/idxd: fix memory leak in pc

[PATCH v2 1/3] dma/idxd: fix memory leak in pci close

2022-07-03 Thread Kevin Laatz
.org Cc: bruce.richard...@intel.com Reported-by: Xingguang He Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_common.c | 2 ++ drivers/dma/idxd/idxd_internal.h | 2 ++ drivers/dma/idxd/idxd_pci.c | 34 +--- 3 files changed, 31 insertions(+), 7 deletion

[PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer

2022-07-03 Thread Kevin Laatz
ak by calling free on the correct pointer. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove

2022-07-03 Thread Kevin Laatz
aring 'info' as a variable and passing its address to 'rte_dma_info_get'. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_pci.c | 8 1 file changed, 4 insertions(+)

Re: [PATCH v2 1/3] dma/idxd: fix memory leak in pci close

2022-07-04 Thread Kevin Laatz
On 04/07/2022 14:19, Bruce Richardson wrote: On Sun, Jul 03, 2022 at 01:22:41PM +0100, Kevin Laatz wrote: ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev' struct. This is fixed by free'ing the struct when the last queue on the PCI devic

Re: [PATCH] doc: announce marking bus object as internal

2022-07-04 Thread Kevin Laatz
RFC series of the intended changes is available at: https://patches.dpdk.org/project/dpdk/list/?series=23811&state=%2A&archive=both --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) Acked-by: Kevin Laatz

[PATCH v3 0/3] Fix IDXD PCI device close

2022-07-04 Thread Kevin Laatz
ULL pointer dereference in pci remove Kevin Laatz (3): dma/idxd: fix memory leak in pci close dma/idxd: fix memory leak due to free on incorrect pointer dma/idxd: fix null pointer dereference during pci remove drivers/dma/idxd/idxd_internal.h | 2 ++ drivers

[PATCH v3 1/3] dma/idxd: fix memory leak in pci close

2022-07-04 Thread Kevin Laatz
.org Cc: bruce.richard...@intel.com Reported-by: Xingguang He Signed-off-by: Kevin Laatz -- v3: move ref_count increment to pci probe --- drivers/dma/idxd/idxd_internal.h | 2 ++ drivers/dma/idxd/idxd_pci.c | 35 +--- 2 files changed, 30 insertions(+), 7 deletion

[PATCH v3 2/3] dma/idxd: fix memory leak due to free on incorrect pointer

2022-07-04 Thread Kevin Laatz
0a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_pc

[PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove

2022-07-04 Thread Kevin Laatz
laring 'info' on the stack and passing its address to 'rte_dma_info_get'. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/idxd_pci.c | 8 1

Re: [PATCH v2 4/4] test_dmadev: increase iterations of capacity test case

2022-01-11 Thread Kevin Laatz
(+), 3 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 2/4] dma/idxd: fix paths to driver sysfs directory

2022-01-11 Thread Kevin Laatz
include example configuration script") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/dma/idxd/dpdk_idxd_cfg.py | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 3/4] dma/idxd: fix wrap-around in burst capacity calculation

2022-01-11 Thread Kevin Laatz
++ 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Kevin Laatz

[dpdk-dev] [PATCH v7 00/16] add dmadev driver for idxd devices

2021-10-13 Thread Kevin Laatz
dpdk_idxd_cfg.py from raw to dma Kevin Laatz (14): dma/idxd: add skeleton for VFIO based DSA device dma/idxd: add bus device probing dma/idxd: create dmadev instances on bus probe dma/idxd: create dmadev instances on pci probe dma/idxd: add datapath structures dma/idxd: add configure and

[dpdk-dev] [PATCH v7 01/16] raw/ioat: only build if dmadev not present

2021-10-13 Thread Kevin Laatz
r. A note is also added to the documentation to inform users of this change. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v7: add meson reason for not building rawdev --- doc/guides/rawdevs/ioat.rst | 8 drivers/meson.build

[dpdk-dev] [PATCH v7 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-13 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- MAINTAINERS| 10

[dpdk-dev] [PATCH v7 03/16] dma/idxd: add bus device probing

2021-10-13 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v7 04/16] dma/idxd: create dmadev instances on bus probe

2021-10-13 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 19

[dpdk-dev] [PATCH v7 05/16] dma/idxd: create dmadev instances on pci probe

2021-10-13 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_hw_defs.h | 71 drivers/dma

[dpdk-dev] [PATCH v7 06/16] dma/idxd: add datapath structures

2021-10-13 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 ++ drivers/dma/idxd/idxd_hw_defs.h | 60

[dpdk-dev] [PATCH v7 07/16] dma/idxd: add configure and info_get functions

2021-10-13 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Documentation is also updated to add device configuration usage info. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v7 08/16] dma/idxd: add start and stop functions for pci devices

2021-10-13 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs

[dpdk-dev] [PATCH v7 09/16] dma/idxd: add data-path job submission functions

2021-10-13 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Documentation updates are included for dmadev library and IDXD driver docs as appropriate. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst

[dpdk-dev] [PATCH v7 10/16] dma/idxd: add data-path job completion functions

2021-10-13 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst | 32 - drivers/dma/idxd/idxd_common.c | 234 +++ drivers/dma/idxd

[dpdk-dev] [PATCH v7 11/16] dma/idxd: add operation statistic tracking

2021-10-13 Thread Kevin Laatz
Add statistic tracking for DSA devices. The dmadev library documentation is also updated to add a generic section for using the library's statistics APIs. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Chengwen Feng --- doc/guides/prog_

[dpdk-dev] [PATCH v7 12/16] dma/idxd: add vchan status function

2021-10-13 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd

[dpdk-dev] [PATCH v7 13/16] dma/idxd: add burst capacity API

2021-10-13 Thread Kevin Laatz
Add support for the burst capacity API. This API will provide the calling application with the remaining capacity of the current burst (limited by max HW batch size). Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson --- drivers/dma/idxd/idxd_common.c | 21

[dpdk-dev] [PATCH v7 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-10-13 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/dpdk_idxd_cfg.py

[dpdk-dev] [PATCH v7 15/16] devbind: add dma device class

2021-10-13 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson Reviewed-by: Chengwen Feng --- usertools/dpdk-devbind.py | 8 +++- 1 file changed, 7 insertions

[dpdk-dev] [PATCH v7 16/16] devbind: move idxd device ID to dmadev class

2021-10-13 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Acked-by: Bruce Richardson --- usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v4 0/8] port ioatfwd app to dmadev

2021-10-14 Thread Kevin Laatz
control stats print frequency - documentation updates - small miscellaneous changes from review feedback Kevin Laatz (5): examples/ioat: add cmd line option to control stats print interval examples/ioat: add signal-triggered device dumps examples/ioat: port application to dmadev APIs e

[dpdk-dev] [PATCH v4 1/8] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-10-14 Thread Kevin Laatz
rt of more apples to apples comparison with sw copy. c) from my testing things are faster that way. Documentation updates to reflect these changes are also included. Signed-off-by: Konstantin Ananyev Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst

[dpdk-dev] [PATCH v4 2/8] examples/ioat: add cmd line option to control DMA batch size

2021-10-14 Thread Kevin Laatz
From: Konstantin Ananyev Add a commandline options to control the HW copy batch size in the application. Signed-off-by: Konstantin Ananyev Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 40

[dpdk-dev] [PATCH v4 3/8] examples/ioat: add cmd line option to control max frame size

2021-10-14 Thread Kevin Laatz
From: Konstantin Ananyev Add command line option for setting the max frame size. Signed-off-by: Konstantin Ananyev Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 25 +++-- 2 files

[dpdk-dev] [PATCH v4 5/8] examples/ioat: add signal-triggered device dumps

2021-10-14 Thread Kevin Laatz
Enable dumping device info via the signal handler. With this change, when a SIGUSR1 is issued, the application will print a dump of all devices being used by the application. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- examples/ioat/ioatfwd.c | 17 + 1 file changed

[dpdk-dev] [PATCH v4 4/8] examples/ioat: add cmd line option to control stats print interval

2021-10-14 Thread Kevin Laatz
Add a command line option to control the interval between stats prints. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 31 +++ 2 files changed, 26 insertions(+), 9 deletions

[dpdk-dev] [PATCH v4 6/8] examples/ioat: port application to dmadev APIs

2021-10-14 Thread Kevin Laatz
: Kevin Laatz Reviewed-by: Conor Walsh --- v4: update macro name after rebasing --- examples/ioat/ioatfwd.c | 247 -- examples/ioat/meson.build | 8 +- 2 files changed, 107 insertions(+), 148 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat

[dpdk-dev] [PATCH v4 7/8] examples/ioat: update naming to match change to dmadev

2021-10-14 Thread Kevin Laatz
Existing functions, structures, defines etc need to be updated to reflect the change to using the dmadev APIs. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- examples/ioat/ioatfwd.c | 189 1 file changed, 94 insertions(+), 95 deletions(-) diff

[dpdk-dev] [PATCH v4 8/8] examples/ioat: rename application to dmafwd

2021-10-14 Thread Kevin Laatz
Since the APIs have been updated from rawdev to dmadev, the application should also be renamed to match. This patch also includes the documentation updates for the renaming. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- .../sample_app_ug/{ioat.rst => dma.rst} |

Re: [dpdk-dev] [PATCH v7 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-18 Thread Kevin Laatz
On 18/10/2021 11:32, Thomas Monjalon wrote: 13/10/2021 18:30, Kevin Laatz: Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. It seems there is a compilation issue with this patch

[dpdk-dev] [PATCH v8 00/16] add dmadev driver for idxd devices

2021-10-18 Thread Kevin Laatz
coverity scan Bruce Richardson (1): raw/ioat: only build if dmadev not present Conor Walsh (1): dma/idxd: move dpdk_idxd_cfg.py from raw to dma Kevin Laatz (14): dma/idxd: add skeleton for VFIO based DSA device dma/idxd: add bus device probing dma/idxd: create dmadev instances on bus probe

[dpdk-dev] [PATCH v8 01/16] raw/ioat: only build if dmadev not present

2021-10-18 Thread Kevin Laatz
r. A note is also added to the documentation to inform users of this change. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/rawdevs/ioat.rst | 8 drivers/meson.build | 4 ++-- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v8 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-18 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v8: fix compile issue --- MAINTAINERS

[dpdk-dev] [PATCH v8 03/16] dma/idxd: add bus device probing

2021-10-18 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v8 04/16] dma/idxd: create dmadev instances on bus probe

2021-10-18 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 19

[dpdk-dev] [PATCH v8 05/16] dma/idxd: create dmadev instances on pci probe

2021-10-18 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_hw_defs.h | 63 drivers/dma

[dpdk-dev] [PATCH v8 06/16] dma/idxd: add datapath structures

2021-10-18 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 + drivers/dma/idxd/idxd_hw_defs.h

[dpdk-dev] [PATCH v8 07/16] dma/idxd: add configure and info_get functions

2021-10-18 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Documentation is also updated to add device configuration usage info. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v8 08/16] dma/idxd: add start and stop functions for pci devices

2021-10-18 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs

[dpdk-dev] [PATCH v8 09/16] dma/idxd: add data-path job submission functions

2021-10-18 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Documentation updates are included for dmadev library and IDXD driver docs as appropriate. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst

[dpdk-dev] [PATCH v8 10/16] dma/idxd: add data-path job completion functions

2021-10-18 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst | 32 - drivers/dma/idxd/idxd_common.c | 236 +++ drivers/dma/idxd

[dpdk-dev] [PATCH v8 11/16] dma/idxd: add operation statistic tracking

2021-10-18 Thread Kevin Laatz
Add statistic tracking for DSA devices. The dmadev library documentation is also updated to add a generic section for using the library's statistics APIs. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Chengwen Feng --- doc/guides/prog_

[dpdk-dev] [PATCH v8 12/16] dma/idxd: add vchan status function

2021-10-18 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd

[dpdk-dev] [PATCH v8 13/16] dma/idxd: add burst capacity API

2021-10-18 Thread Kevin Laatz
Add support for the burst capacity API. This API will provide the calling application with the remaining capacity of the current burst (limited by max HW batch size). Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson --- drivers/dma/idxd/idxd_common.c | 21

[dpdk-dev] [PATCH v8 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-10-18 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/dpdk_idxd_cfg.py

[dpdk-dev] [PATCH v8 15/16] devbind: add dma device class

2021-10-18 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson Reviewed-by: Chengwen Feng --- usertools/dpdk-devbind.py | 8 +++- 1 file changed, 7 insertions

[dpdk-dev] [PATCH v8 16/16] devbind: move idxd device ID to dmadev class

2021-10-18 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Acked-by: Bruce Richardson --- usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v9 00/16] add dmadev driver for idxd devices

2021-10-19 Thread Kevin Laatz
* fixed issue identified by internal coverity scan Bruce Richardson (1): raw/ioat: only build if dmadev not present Conor Walsh (1): dma/idxd: move dpdk_idxd_cfg.py from raw to dma Kevin Laatz (14): dma/idxd: add skeleton for VFIO based DSA device dma/idxd: add bus device probing dma

[dpdk-dev] [PATCH v9 01/16] raw/ioat: only build if dmadev not present

2021-10-19 Thread Kevin Laatz
r. A note is also added to the documentation to inform users of this change. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/rawdevs/ioat.rst | 8 drivers/meson.build | 4 ++-- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v9 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-19 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v8: fix compile issue v9: add meson check for x86

[dpdk-dev] [PATCH v9 03/16] dma/idxd: add bus device probing

2021-10-19 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v9 04/16] dma/idxd: create dmadev instances on bus probe

2021-10-19 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 19

[dpdk-dev] [PATCH v9 05/16] dma/idxd: create dmadev instances on pci probe

2021-10-19 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_hw_defs.h | 63 drivers/dma

[dpdk-dev] [PATCH v9 06/16] dma/idxd: add datapath structures

2021-10-19 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 + drivers/dma/idxd/idxd_hw_defs.h

[dpdk-dev] [PATCH v9 07/16] dma/idxd: add configure and info_get functions

2021-10-19 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Documentation is also updated to add device configuration usage info. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v9 08/16] dma/idxd: add start and stop functions for pci devices

2021-10-19 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs

[dpdk-dev] [PATCH v9 09/16] dma/idxd: add data-path job submission functions

2021-10-19 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Documentation updates are included for dmadev library and IDXD driver docs as appropriate. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst

[dpdk-dev] [PATCH v9 10/16] dma/idxd: add data-path job completion functions

2021-10-19 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst | 32 - drivers/dma/idxd/idxd_common.c | 236 +++ drivers/dma/idxd

[dpdk-dev] [PATCH v9 11/16] dma/idxd: add operation statistic tracking

2021-10-19 Thread Kevin Laatz
Add statistic tracking for DSA devices. The dmadev library documentation is also updated to add a generic section for using the library's statistics APIs. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Chengwen Feng --- doc/guides/prog_

[dpdk-dev] [PATCH v9 12/16] dma/idxd: add vchan status function

2021-10-19 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd

[dpdk-dev] [PATCH v9 13/16] dma/idxd: add burst capacity API

2021-10-19 Thread Kevin Laatz
Add support for the burst capacity API. This API will provide the calling application with the remaining capacity of the current burst (limited by max HW batch size). Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson --- drivers/dma/idxd/idxd_common.c | 21

[dpdk-dev] [PATCH v9 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-10-19 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/dpdk_idxd_cfg.py

[dpdk-dev] [PATCH v9 15/16] devbind: add dma device class

2021-10-19 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson Reviewed-by: Chengwen Feng --- usertools/dpdk-devbind.py | 8 +++- 1 file changed, 7 insertions

[dpdk-dev] [PATCH v9 16/16] devbind: move idxd device ID to dmadev class

2021-10-19 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Acked-by: Bruce Richardson --- usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v10 04/16] dma/idxd: create dmadev instances on bus probe

2021-10-19 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 19

[dpdk-dev] [PATCH v10 03/16] dma/idxd: add bus device probing

2021-10-19 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v10 16/16] devbind: move idxd device ID to dmadev class

2021-10-19 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Acked-by: Bruce Richardson --- usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v10 00/16] add dmadev driver for idxd devices

2021-10-19 Thread Kevin Laatz
device being idle * added devbind updates for DMA devices * fixed issue identified by internal coverity scan Bruce Richardson (1): raw/ioat: only build if dmadev not present Conor Walsh (1): dma/idxd: move dpdk_idxd_cfg.py from raw to dma Kevin Laatz (14): dma/idxd: add skeleton for VFIO

[dpdk-dev] [PATCH v10 01/16] raw/ioat: only build if dmadev not present

2021-10-19 Thread Kevin Laatz
r. A note is also added to the documentation to inform users of this change. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/rawdevs/ioat.rst | 8 drivers/meson.build | 4 ++-- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v10 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-19 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v8: fix compile issue v9: add meson check for x86

[dpdk-dev] [PATCH v10 05/16] dma/idxd: create dmadev instances on pci probe

2021-10-19 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_hw_defs.h | 63 drivers/dma

[dpdk-dev] [PATCH v10 06/16] dma/idxd: add datapath structures

2021-10-19 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 + drivers/dma/idxd/idxd_hw_defs.h

[dpdk-dev] [PATCH v10 07/16] dma/idxd: add configure and info_get functions

2021-10-19 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Documentation is also updated to add device configuration usage info. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v10 08/16] dma/idxd: add start and stop functions for pci devices

2021-10-19 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs

[dpdk-dev] [PATCH v10 09/16] dma/idxd: add data-path job submission functions

2021-10-19 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Documentation updates are included for dmadev library and IDXD driver docs as appropriate. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst

  1   2   3   4   5   6   7   8   >