RE: [EXT] Re: [PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets

2023-12-20 Thread Anoob Joseph
Hi Stephen, Please see inline. Thanks, Anoob > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, December 19, 2023 10:49 PM > To: Anoob Joseph > Cc: Radu Nicolau ; Akhil Goyal > ; Konstantin Ananyev > ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org >

[PATCH] examples/ipsec-secgw: use bulk free

2023-12-20 Thread Anoob Joseph
Use rte_pktmbuf_free_bulk() API instead of looping through the packets and freeing individually. Signed-off-by: Anoob Joseph Suggested-by: Stephen Hemminger --- examples/ipsec-secgw/ipsec-secgw.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/examples/ipsec-secgw/ipsec

[PATCH 00/24] Fixes and improvements in crypto cnxk

2023-12-21 Thread Anoob Joseph
len input Akhil Goyal (1): common/cnxk: fix memory leak Anoob Joseph (6): crypto/cnxk: use common macro crypto/cnxk: return microcode completion code common/cnxk: update opad-ipad gen to handle TLS common/cnxk: add TLS record contexts crypto/cnxk: separate IPsec from security common

[PATCH 01/24] common/cnxk: fix memory leak

2023-12-21 Thread Anoob Joseph
From: Akhil Goyal dev_init() acquires some resources which need to be cleaned in case a failure is observed afterwards. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_cpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[PATCH 02/24] crypto/cnxk: use common macro

2023-12-21 Thread Anoob Joseph
Having different macros for same purpose may cause issues if one is updated without updating the other. Use same macro by including the header. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 03/24] crypto/cnxk: fallback to SG if headroom is not available

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Falling back to SG mode for cn9k lookaside IPsec if headroom is not available. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/

[PATCH 04/24] crypto/cnxk: return microcode completion code

2023-12-21 Thread Anoob Joseph
Return microcode completion code in case of errors. This allows applications to check the failure reasons in more granularity. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk

[PATCH 05/24] crypto/cnxk: fix ECDH pubkey verify in cn9k

2023-12-21 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Fix ECDH pubkey verify in cn9k. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/cr

[PATCH 06/24] crypto/cnxk: enable digest gen for zero len input

2023-12-21 Thread Anoob Joseph
From: Aakash Sasidharan With zero length input, digest generation fails with incorrect value. Fix this by completely avoiding the gather component when the input packet has zero data length. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(

[PATCH 07/24] crypto/cnxk: enable Rx inject in security lookaside

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add Rx inject fastpath API. Add devargs to specify an LF to be used for Rx inject. When the RX inject feature flag is enabled: 1. Reserve a CPT LF to use for RX Inject mode. 2. Enable RXC and disable full packet mode for that LF. Signed-off-by: Anoob Joseph Signed

[PATCH 08/24] common/cnxk: add Rx inject configs

2023-12-21 Thread Anoob Joseph
From: Rahul Bhansali Add Rx inject config for feature enable/disable, and store Rx chan value per port. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_idev.c | 44 + drivers/common/cnxk/roc_idev.h | 5 drivers/common/cnxk/roc_idev_priv.h |

[PATCH 09/24] crypto/cnxk: Rx inject config update

2023-12-21 Thread Anoob Joseph
From: Rahul Bhansali - Update chan in CPT inst from port's Rx chan - Set Rx inject config in Idev struct Signed-off-by: Rahul Bhansali --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +++- drivers/crypto/cnxk/cn10k_ipsec.c | 3 +++ drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + dri

[PATCH 10/24] crypto/cnxk: enable Rx inject for 103

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Enable Rx inject feature for 103XX Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.c b/drivers/crypto/cnxk/cnxk_cryptodev.c index b168

[PATCH 11/24] crypto/cnxk: rename security caps as IPsec security caps

2023-12-21 Thread Anoob Joseph
IPsec and TLS Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 13 ++-- drivers/common/cnxk/cnxk_security.h | 17 +++-- drivers/common/cnxk/version.map | 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c

[PATCH 12/24] common/cnxk: update opad-ipad gen to handle TLS

2023-12-21 Thread Anoob Joseph
For TLS opcodes, ipad is at the offset 64 as compared to the packed implementation for IPsec. Extend the function to handle TLS contexts as well. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 15 --- drivers/common/cnxk

[PATCH 13/24] common/cnxk: add TLS record contexts

2023-12-21 Thread Anoob Joseph
Add TLS record read and write contexts. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_cpt.h | 4 +- drivers/common/cnxk/roc_ie_ot_tls.h | 199 drivers/common/cnxk/roc_se.h| 11 ++ 3 files changed, 211

[PATCH 14/24] crypto/cnxk: separate IPsec from security common code

2023-12-21 Thread Anoob Joseph
The current structs and functions assume only IPsec offload. Separate it out to allow for addition of TLS. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev.c | 2 +- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 127

[PATCH 15/24] crypto/cnxk: add TLS record session ops

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS record session ops for creating and destroying security sessions. Add support for both read and write sessions. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 8 + drivers/crypto/cnxk

[PATCH 16/24] crypto/cnxk: add TLS record datapath handling

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS record handling in datapath. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 57 +++- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 7 + drivers/crypto/cnxk/cn10k_tls_ops.h

[PATCH 18/24] crypto/cnxk: add PMD APIs for raw submission to CPT

2023-12-21 Thread Anoob Joseph
Add PMD APIs to allow applications to directly submit CPT instructions to hardware. Signed-off-by: Anoob Joseph --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/rel_notes/release_24_03.rst| 1 + drivers/crypto/cnxk

[PATCH 19/24] crypto/cnxk: replace PDCP with PDCP chain opcode

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Replacing PDCP opcode with PDCP chain opcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 331 +- drivers/common/cnxk/roc_se.h | 18 +- drivers/crypto/cnxk/cnxk_se.h | 96 +- 3 files changed, 135 insertions

[PATCH 17/24] crypto/cnxk: add TLS capability

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.2 record read and write capability. Add DTLS 1.2 record read and write capability. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 2 + drivers/common/cnxk/hw/cpt.h

[PATCH 22/24] crypto/cnxk: add support for TLS 1.3

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 50 +-- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 159 +- 3 files changed, 136

[PATCH 20/24] crypto/cnxk: validate the combinations supported in TLS

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Validate the cipher and auth combination to allow only the ones supported by hardware. Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_tls.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 23/24] crypto/cnxk: add TLS 1.3 capability

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.3 record read and write capability Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 4 +- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 92 +++ 2 files changed, 94 insertions(+), 2 deletions(-) diff

[PATCH 21/24] crypto/cnxk: use a single function for opad ipad

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Use a single function for opad and ipad generation for IPsec, TLS and flexi crypto. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 65 ++--- drivers/common/cnxk/cnxk_security.h | 5 --- drivers/common/cnxk/roc_s

[PATCH 24/24] crypto/cnxk: add CPT SG mode debug

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Adding CPT SG mode debug dump. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 135 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 7 ++ 2 files changed, 141 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnx

[PATCH v2 00/24] Fixes and improvements in crypto cnxk

2024-01-01 Thread Anoob Joseph
v2 - Addressed checkpatch issue - Addressed build error with stdatomic Aakash Sasidharan (1): crypto/cnxk: enable digest gen for zero len input Akhil Goyal (1): common/cnxk: fix memory leak Anoob Joseph (6): crypto/cnxk: use common macro crypto/cnxk: return microcode completion code

[PATCH v2 01/24] common/cnxk: fix memory leak

2024-01-01 Thread Anoob Joseph
From: Akhil Goyal dev_init() acquires some resources which need to be cleaned in case a failure is observed afterwards. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_cpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[PATCH v2 02/24] crypto/cnxk: use common macro

2024-01-01 Thread Anoob Joseph
Having different macros for same purpose may cause issues if one is updated without updating the other. Use same macro by including the header. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 03/24] crypto/cnxk: fallback to SG if headroom is not available

2024-01-01 Thread Anoob Joseph
From: Tejasree Kondoj Falling back to SG mode for cn9k lookaside IPsec if headroom is not available. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/

[PATCH v2 04/24] crypto/cnxk: return microcode completion code

2024-01-01 Thread Anoob Joseph
Return microcode completion code in case of errors. This allows applications to check the failure reasons in more granularity. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk

[PATCH v2 05/24] crypto/cnxk: fix ECDH pubkey verify in cn9k

2024-01-01 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Fix ECDH pubkey verify in cn9k. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/cr

[PATCH v2 06/24] crypto/cnxk: enable digest gen for zero len input

2024-01-01 Thread Anoob Joseph
From: Aakash Sasidharan With zero length input, digest generation fails with incorrect value. Fix this by completely avoiding the gather component when the input packet has zero data length. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(

[PATCH v2 07/24] crypto/cnxk: enable Rx inject in security lookaside

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add Rx inject fastpath API. Add devargs to specify an LF to be used for Rx inject. When the RX inject feature flag is enabled: 1. Reserve a CPT LF to use for RX Inject mode. 2. Enable RXC and disable full packet mode for that LF. Signed-off-by: Anoob Joseph Signed

[PATCH v2 08/24] common/cnxk: add Rx inject configs

2024-01-01 Thread Anoob Joseph
From: Rahul Bhansali Add Rx inject config for feature enable/disable, and store Rx chan value per port. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_idev.c | 44 + drivers/common/cnxk/roc_idev.h | 5 drivers/common/cnxk/roc_idev_priv.h |

[PATCH v2 09/24] crypto/cnxk: Rx inject config update

2024-01-01 Thread Anoob Joseph
From: Rahul Bhansali - Update chan in CPT inst from port's Rx chan - Set Rx inject config in Idev struct Signed-off-by: Rahul Bhansali --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +++- drivers/crypto/cnxk/cn10k_ipsec.c | 3 +++ drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + dri

[PATCH v2 10/24] crypto/cnxk: enable Rx inject for 103

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Enable Rx inject feature for 103XX Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.c b/drivers/crypto/cnxk/cnxk_cryptodev.c index b168

[PATCH v2 11/24] crypto/cnxk: rename security caps as IPsec security caps

2024-01-01 Thread Anoob Joseph
IPsec and TLS Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 13 ++-- drivers/common/cnxk/cnxk_security.h | 17 +++-- drivers/common/cnxk/version.map | 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c

[PATCH v2 12/24] common/cnxk: update opad-ipad gen to handle TLS

2024-01-01 Thread Anoob Joseph
For TLS opcodes, ipad is at the offset 64 as compared to the packed implementation for IPsec. Extend the function to handle TLS contexts as well. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 15 --- drivers/common/cnxk

[PATCH v2 13/24] common/cnxk: add TLS record contexts

2024-01-01 Thread Anoob Joseph
Add TLS record read and write contexts. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_cpt.h | 4 +- drivers/common/cnxk/roc_ie_ot_tls.h | 199 drivers/common/cnxk/roc_se.h| 11 ++ 3 files changed, 211

[PATCH v2 14/24] crypto/cnxk: separate IPsec from security common code

2024-01-01 Thread Anoob Joseph
The current structs and functions assume only IPsec offload. Separate it out to allow for addition of TLS. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev.c | 2 +- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 127

[PATCH v2 15/24] crypto/cnxk: add TLS record session ops

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS record session ops for creating and destroying security sessions. Add support for both read and write sessions. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 8 + drivers/crypto/cnxk

[PATCH v2 16/24] crypto/cnxk: add TLS record datapath handling

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS record handling in datapath. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 57 +++- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 7 + drivers/crypto/cnxk/cn10k_tls_ops.h

[PATCH v2 17/24] crypto/cnxk: add TLS capability

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.2 record read and write capability. Add DTLS 1.2 record read and write capability. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 2 + drivers/common/cnxk/hw/cpt.h

[PATCH v2 18/24] crypto/cnxk: add PMD APIs for raw submission to CPT

2024-01-01 Thread Anoob Joseph
Add PMD APIs to allow applications to directly submit CPT instructions to hardware. Signed-off-by: Anoob Joseph --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/rel_notes/release_24_03.rst| 1 + drivers/crypto/cnxk

[PATCH v2 19/24] crypto/cnxk: replace PDCP with PDCP chain opcode

2024-01-01 Thread Anoob Joseph
From: Tejasree Kondoj Replacing PDCP opcode with PDCP chain opcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 331 +- drivers/common/cnxk/roc_se.h | 18 +- drivers/crypto/cnxk/cnxk_se.h | 96 +- 3 files changed, 135 insertions

[PATCH v2 20/24] crypto/cnxk: validate the combinations supported in TLS

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Validate the cipher and auth combination to allow only the ones supported by hardware. Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_tls.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v2 21/24] crypto/cnxk: use a single function for opad ipad

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Use a single function for opad and ipad generation for IPsec, TLS and flexi crypto. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 65 ++--- drivers/common/cnxk/cnxk_security.h | 5 --- drivers/common/cnxk/roc_s

[PATCH v2 22/24] crypto/cnxk: add support for TLS 1.3

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 50 +-- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 159 +- 3 files changed, 136

[PATCH v2 23/24] crypto/cnxk: add TLS 1.3 capability

2024-01-01 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.3 record read and write capability Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 4 +- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 92 +++ 2 files changed, 94 insertions(+), 2 deletions(-) diff

[PATCH v2 24/24] crypto/cnxk: add CPT SG mode debug

2024-01-01 Thread Anoob Joseph
From: Tejasree Kondoj Adding CPT SG mode debug dump. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 135 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 7 ++ 2 files changed, 141 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnx

RE: [EXT] [PATCH] app/test-crypto-perf: fix invalid mbuf next operation

2024-01-03 Thread Anoob Joseph
Hi Suanming, Good catch. Please see inline. Thanks, Anoob > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 3, 2024 9:24 AM > To: Ciara Power > Cc: dev@dpdk.org > Subject: [EXT] [PATCH] app/test-crypto-perf: fix invalid mbuf next operation > > External Email > > --

RE: [EXT] [PATCH 1/2] app/test-crypto-perf: fix invalid memcmp results

2024-01-03 Thread Anoob Joseph
is commit converts the return value to be zero or greater than zero. That > will > make sure the sum of results be correct. > > Fixes: df52cb3b6e13 ("app/crypto-perf: move verify as single test type") > > Signed-off-by: Suanming Mou Acked-by: Anoob Joseph

RE: [EXT] [PATCH] app/test-crypto-perf: fix invalid mbuf next operation

2024-01-03 Thread Anoob Joseph
Hi Suanming, Please see inline. Thanks, Anoob > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 3, 2024 6:06 PM > To: Anoob Joseph > Cc: dev@dpdk.org; Ciara Power > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: fix invalid mbuf next &

RE: [EXT] [PATCH v2] app/test-crypto-perf: fix invalid mbuf next operation

2024-01-03 Thread Anoob Joseph
gt; Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool") > > Signed-off-by: Suanming Mou Acked-by: Anoob Joseph

RE: [EXT] [PATCH 2/2] app/test-crypto-perf: fix encrypt operation verify

2024-01-03 Thread Anoob Joseph
Hi Suanming, Please see inline. Thanks, Anoob > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 3, 2024 9:26 AM > To: Ciara Power > Cc: dev@dpdk.org > Subject: [EXT] [PATCH 2/2] app/test-crypto-perf: fix encrypt operation verify > > External Email > > -

RE: [EXT] [PATCH v2 2/2] app/test-crypto-perf: fix encrypt operation verify

2024-01-04 Thread Anoob Joseph
verify as single test type") > > Signed-off-by: Suanming Mou Acked-by: Anoob Joseph

RE: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-01-08 Thread Anoob Joseph
akash Shukla > Acked-by: Chengwen Feng Acked-by: Anoob Joseph

RE: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission fix

2024-01-10 Thread Anoob Joseph
Hi Suanming, Please see inline. Thanks, Anoob > -Original Message- > From: Suanming Mou > Sent: Friday, January 5, 2024 12:26 PM > To: Anoob Joseph ; ciara.po...@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] [PATCH] app/test-crypto-perf: add misse

[PATCH v3 00/24] Fixes and improvements in crypto cnxk

2024-01-17 Thread Anoob Joseph
Anoob Joseph (6): crypto/cnxk: use common macro crypto/cnxk: return microcode completion code common/cnxk: update opad-ipad gen to handle TLS common/cnxk: add TLS record contexts crypto/cnxk: separate IPsec from security common code crypto/cnxk: add PMD APIs for raw submission t

[PATCH v3 01/24] common/cnxk: fix memory leak

2024-01-17 Thread Anoob Joseph
From: Akhil Goyal dev_init() acquires some resources which need to be cleaned in case a failure is observed afterwards. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_cpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[PATCH v3 02/24] crypto/cnxk: use common macro

2024-01-17 Thread Anoob Joseph
Having different macros for same purpose may cause issues if one is updated without updating the other. Use same macro by including the header. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v3 03/24] crypto/cnxk: fallback to SG if headroom is not available

2024-01-17 Thread Anoob Joseph
From: Tejasree Kondoj Falling back to SG mode for cn9k lookaside IPsec if headroom is not available. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/

[PATCH v3 04/24] crypto/cnxk: return microcode completion code

2024-01-17 Thread Anoob Joseph
Return microcode completion code in case of errors. This allows applications to check the failure reasons in more granularity. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk

[PATCH v3 05/24] crypto/cnxk: fix ECDH pubkey verify in cn9k

2024-01-17 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Fix ECDH pubkey verify in cn9k. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/cr

[PATCH v3 06/24] crypto/cnxk: enable digest gen for zero len input

2024-01-17 Thread Anoob Joseph
From: Aakash Sasidharan With zero length input, digest generation fails with incorrect value. Fix this by completely avoiding the gather component when the input packet has zero data length. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(

[PATCH v3 08/24] common/cnxk: add Rx inject configs

2024-01-17 Thread Anoob Joseph
From: Rahul Bhansali Add Rx inject config for feature enable/disable, and store Rx chan value per port. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_idev.c | 44 + drivers/common/cnxk/roc_idev.h | 5 drivers/common/cnxk/roc_idev_priv.h |

[PATCH v3 10/24] crypto/cnxk: enable Rx inject for 103

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Enable Rx inject feature for 103XX Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.c b/drivers/crypto/cnxk/cnxk_cryptodev.c index b168

[PATCH v3 07/24] crypto/cnxk: enable Rx inject in security lookaside

2024-01-17 Thread Anoob Joseph
Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- doc/guides/cryptodevs/cnxk.rst | 12 ++ doc/guides/cryptodevs/features/cn10k.ini | 1 + doc/guides/rel_notes/release_24_03.rst | 4 + drivers/common/cnxk/hw/cpt.h | 9 ++ drivers/c

[PATCH v3 09/24] crypto/cnxk: Rx inject config update

2024-01-17 Thread Anoob Joseph
From: Rahul Bhansali - Update chan in CPT inst from port's Rx chan - Set Rx inject config in Idev struct Signed-off-by: Rahul Bhansali --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +++- drivers/crypto/cnxk/cn10k_ipsec.c | 3 +++ drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + dri

[PATCH v3 12/24] common/cnxk: update opad-ipad gen to handle TLS

2024-01-17 Thread Anoob Joseph
For TLS opcodes, ipad is at the offset 64 as compared to the packed implementation for IPsec. Extend the function to handle TLS contexts as well. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 15 --- drivers/common/cnxk

[PATCH v3 13/24] common/cnxk: add TLS record contexts

2024-01-17 Thread Anoob Joseph
Add TLS record read and write contexts. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_cpt.h | 4 +- drivers/common/cnxk/roc_ie_ot_tls.h | 199 drivers/common/cnxk/roc_se.h| 11 ++ 3 files changed, 211

[PATCH v3 15/24] crypto/cnxk: add TLS record session ops

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS record session ops for creating and destroying security sessions. Add support for both read and write sessions. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 8 + drivers/crypto/cnxk

[PATCH v3 11/24] crypto/cnxk: rename security caps as IPsec security caps

2024-01-17 Thread Anoob Joseph
IPsec and TLS Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 13 ++-- drivers/common/cnxk/cnxk_security.h | 17 +++-- drivers/common/cnxk/version.map | 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c

[PATCH v3 17/24] crypto/cnxk: add TLS capability

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.2 record read and write capability. Add DTLS 1.2 record read and write capability. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 2 + drivers/common/cnxk/hw/cpt.h

[PATCH v3 14/24] crypto/cnxk: separate IPsec from security common code

2024-01-17 Thread Anoob Joseph
The current structs and functions assume only IPsec offload. Separate it out to allow for addition of TLS. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev.c | 2 +- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 127

[PATCH v3 16/24] crypto/cnxk: add TLS record datapath handling

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS record handling in datapath. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 57 +++- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 7 + drivers/crypto/cnxk/cn10k_tls_ops.h

[PATCH v3 18/24] crypto/cnxk: add PMD APIs for raw submission to CPT

2024-01-17 Thread Anoob Joseph
Add PMD APIs to allow applications to directly submit CPT instructions to hardware. Signed-off-by: Anoob Joseph --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/rel_notes/release_24_03.rst| 1 + drivers/crypto/cnxk

[PATCH v3 19/24] crypto/cnxk: replace PDCP with PDCP chain opcode

2024-01-17 Thread Anoob Joseph
From: Tejasree Kondoj Replacing PDCP opcode with PDCP chain opcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 331 +- drivers/common/cnxk/roc_se.h | 18 +- drivers/crypto/cnxk/cnxk_se.h | 96 +- 3 files changed, 135 insertions

[PATCH v3 20/24] crypto/cnxk: validate the combinations supported in TLS

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Validate the cipher and auth combination to allow only the ones supported by hardware. Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_tls.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v3 21/24] crypto/cnxk: use a single function for opad ipad

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Use a single function for opad and ipad generation for IPsec, TLS and flexi crypto. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 65 ++--- drivers/common/cnxk/cnxk_security.h | 5 --- drivers/common/cnxk/roc_s

[PATCH v3 22/24] crypto/cnxk: add support for TLS 1.3

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 50 +-- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 159 +- 3 files changed, 136

[PATCH v3 23/24] crypto/cnxk: add TLS 1.3 capability

2024-01-17 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.3 record read and write capability Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 4 +- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 92 +++ 2 files changed, 94 insertions(+), 2 deletions(-) diff

[PATCH v3 24/24] crypto/cnxk: add CPT SG mode debug

2024-01-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding CPT SG mode debug dump. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 135 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 7 ++ 2 files changed, 141 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnx

RE: [EXT] [PATCH 7/9] pdcp: use C11 alignof

2024-01-24 Thread Anoob Joseph
> > External Email > > -- > Replace use of __alignof__(T) with C11 alignof(T) to improve portability > between toolchains. > > Signed-off-by: Tyler Retzlaff Acked-by: Anoob Joseph

[PATCH] common/cnxk: restore segregation of logs based on module

2024-04-23 Thread Anoob Joseph
50a1 ("dma/cnxk: rework DMA driver") Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst | 2 +- doc/guides/eventdevs/cnxk.rst | 4 ++-- doc/guides/mempool/cnxk.rst| 2 +- doc/guides/mldevs/cnxk.rst | 2 +- doc/guides/nics/cnxk.rst | 8

[PATCH v4 0/7] Add ODM DMA device

2024-05-27 Thread Anoob Joseph
CI - Moved update to usertools as separate patch Anoob Joseph (2): dma/odm: add framework for ODM DMA device dma/odm: add hardware defines Gowrishankar Muthukrishnan (3): dma/odm: add dev init and fini dma/odm: add device ops dma/odm: add stats Vidya Sagar Velumuri (2): dma/odm: add copy a

[PATCH v4 1/7] dma/odm: add framework for ODM DMA device

2024-05-27 Thread Anoob Joseph
Add framework for Odyssey ODM DMA device. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- MAINTAINERS | 6 +++ drivers/dma/meson.build | 1 + drivers/dma/odm/meson.build | 14 +++ drivers/dma/odm/odm.h

[PATCH v4 2/7] dma/odm: add hardware defines

2024-05-27 Thread Anoob Joseph
Add ODM registers and structures. Add mailbox structs as well. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm.h | 106 + drivers/dma/odm/odm_priv.h | 49

[PATCH v4 3/7] dma/odm: add dev init and fini

2024-05-27 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add ODM device init and fini. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/meson.build | 2 +- drivers/dma/odm/odm.c| 97 drivers

[PATCH v4 4/7] dma/odm: add device ops

2024-05-27 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add DMA device control ops. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm.c| 144 ++- drivers/dma/odm/odm.h| 54

[PATCH v4 5/7] dma/odm: add stats

2024-05-27 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add DMA dev stats. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm_dmadev.c | 63 ++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff

[PATCH v4 6/7] dma/odm: add copy and copy sg ops

2024-05-27 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add ODM copy and copy SG ops. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm_dmadev.c | 236 +++ 1 file changed, 236 insertions(+) diff --git a

[PATCH v4 7/7] dma/odm: add remaining ops

2024-05-27 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add all remaining ops such as fill, burst_capacity etc. Also update the documentation. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- MAINTAINERS| 1 + doc/guides/dmadevs

RE: [PATCH v2 0/3] cryptodev: add API to get used queue pair depth

2024-05-29 Thread Anoob Joseph
s is suppressed as the updated struct rte_crypto_fp_ops is an internal > structure and not to be used by application directly. > Series Acked-by: Anoob Joseph

RE: [PATCH] app/crypto-perf: support IPsec/TLS segmented buffers

2024-05-30 Thread Anoob Joseph
> > Added support to allow segmented buffers for IPsec and tls-record security > offload cases. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

RE: [PATCH] crypto/cnxk: fix ECDH pubkey verify

2024-06-16 Thread Anoob Joseph
> > Fix dequeue operation for ECDH pubkey verify. > > Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") > Fixes: 5c9025583167 ("crypto/cnxk: fix CN9K ECDH public key verification") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH v1 0/6] app/crypto-perf: add asymmetric crypto tests

2024-06-16 Thread Anoob Joseph
modex groups test > app/crypto-perf: remove redundant local varriable > app/crypto-perf: fix result location for asymmetric test > app/crypto-perf: add function to check asymmetric operation > app/crypto-perf: support ECDSA > Series Acked-by: Anoob Joseph

RE: [PATCH v1 0/4] test/crypto: enhance modex tests

2024-06-17 Thread Anoob Joseph
d variable in modex test data > test/crypto: use common test function for mod tests > test/crypto: add modex tests for zero padded operands Series Acked-by: Anoob Joseph

<    1   2   3   4   5   6   7   8   9   10   >