RE: [EXT] Re: [PATCH v3 21/22] pdcp: add thread safe processing

Hi Stephen, Please see inline. Thanks, Anoob > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 25, 2023 12:02 AM > To: Anoob Joseph > Cc: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Irem

RE: [EXT] Re: [PATCH v3 21/22] pdcp: add thread safe processing

Hi Stephen, Please see inline. Thanks, Anoob > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 25, 2023 8:56 PM > To: Anoob Joseph > Cc: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Irem

[PATCH v4 00/22] lib: add pdcp protocol

0 + Tests Executed :179 + Tests Unsupported: 48 + Tests Passed : 131 + Tests Failed : 0 + --- + Test OK Anoob Joseph (10): lib: add pdcp protocol pdcp: add pre and post-process pdcp: add packet group pdcp: add cr

[PATCH v4 01/22] net: add PDCP header

From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib

[PATCH v4 02/22] lib: add pdcp protocol

. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() Signed-off-by: Anoob Joseph Signed-off-by: Kiran

[PATCH v4 03/22] pdcp: add pre and post-process

lows skipping multiple checks that would come in datapath otherwise. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/rte_pdcp.h | 97 lib/pdcp/version.map | 3 ++ 2 files cha

[PATCH v4 04/22] pdcp: add packet group

entity. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build | 1 + lib/pdcp/rte_pdcp.h | 6 ++ lib/pdcp/rte_pdcp_group.h | 131 ++ lib/pdcp/version.map | 3 + 4 files changed

[PATCH v4 05/22] pdcp: add crypto session create and destroy

Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c |

[PATCH v4 06/22] pdcp: add pre and post process for UL

per PDCP specification). Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_entity.h | 24 +++ lib/pdcp/pdcp_process.c | 334 2 files changed, 358 insertions(+) diff --git a

[PATCH v4 07/22] pdcp: add pre and post process for DL

Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 383 lib/pdcp/pdcp_proce

[PATCH v4 08/22] pdcp: add IV generation routines

For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284

[PATCH v4 09/22] app/test: add lib pdcp tests

Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/meson.build | 5 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 732 ++ 3

[PATCH v4 10/22] test/pdcp: pdcp HFN tests in combined mode

From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test

[PATCH v4 11/22] doc: add PDCP library guide

Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst| 254

[PATCH v4 12/22] pdcp: add control PDU handling for status report

Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp

[PATCH v4 13/22] pdcp: implement t-Reordering and packet buffering

se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v4 14/22] test/pdcp: add in-order delivery cases

From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v4 15/22] pdcp: add timer callback handlers

when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v4 16/22] pdcp: add timer expiry handle

notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v4 17/22] test/pdcp: add timer expiry cases

From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test

[PATCH v4 18/22] test/pdcp: add timer restart case

From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff

[PATCH v4 19/22] pdcp: add support for status report

From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v4 20/22] pdcp: allocate reorder buffer alongside with entity

From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v4 21/22] pdcp: add thread safe processing

requires thread safe processing, the state variables need to be updated atomically. Add config option to select this option per entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 2 + lib/pdcp/pdcp_entity.h | 64 ++ lib/pdcp

[PATCH v4 22/22] test/pdcp: add PDCP status report cases

From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

RE: [EXT] Re: [PATCH v4 21/22] pdcp: add thread safe processing

Hi Stephen, Please see inline. Thanks, Anoob > -Original Message- > From: Stephen Hemminger > Sent: Saturday, May 27, 2023 3:42 AM > To: Anoob Joseph > Cc: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Volodymyr Fial

RE: [EXT] Re: [PATCH v4 21/22] pdcp: add thread safe processing

Hi Stephen, I've dropped this patch for now. Based on what we conclude on this thread, will post this as a separate patch as required. Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Saturday, May 27, 2023 10:55 AM > To: Stephen Hemminger > Cc: Tho

[PATCH v5 01/21] net: add PDCP header

From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib

[PATCH v5 04/21] pdcp: add packet group

entity. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build | 1 + lib/pdcp/rte_pdcp.h | 6 ++ lib/pdcp/rte_pdcp_group.h | 131 ++ lib/pdcp/version.map | 3 + 4 files changed

[PATCH v5 05/21] pdcp: add crypto session create and destroy

Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c |

[PATCH v5 09/21] app/test: add lib pdcp tests

Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + app/test/meson.build | 5 + app/test/test_pdcp.c | 732 +++ 3 files

[PATCH v5 11/21] doc: add PDCP library guide

Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc

[PATCH v5 13/21] pdcp: implement t-Reordering and packet buffering

se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v5 00/21] lib: add pdcp protocol

b Testsuites Passed : 5 + Sub Testsuites Failed : 0 + --- + + Tests Total : 179 + Tests Skipped : 0 + Tests Executed :179 + Tests Unsupported: 48 + Tests Passed : 131 + Tests Failed : 0 + --- + Test OK Anoob Jo

[PATCH v5 08/21] pdcp: add IV generation routines

For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284

[PATCH v5 03/21] pdcp: add pre and post-process

lows skipping multiple checks that would come in datapath otherwise. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/rte_pdcp.h | 97 lib/pdcp/version.map | 3 ++ 2 files cha

[PATCH v5 12/21] pdcp: add control PDU handling for status report

Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp

[PATCH v5 06/21] pdcp: add pre and post process for UL

per PDCP specification). Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_entity.h | 24 +++ lib/pdcp/pdcp_process.c | 334 2 files changed, 358 insertions(+) diff --git a

[PATCH v5 02/21] lib: add pdcp protocol

. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() Signed-off-by: Anoob Joseph Signed-off-by: Kiran

[PATCH v5 10/21] test/pdcp: pdcp HFN tests in combined mode

From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test

[PATCH v5 07/21] pdcp: add pre and post process for DL

Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 384 lib/pdcp/pdcp_proce

[PATCH v5 02/21] lib: add pdcp protocol

. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() Signed-off-by: Anoob Joseph Signed-off-by: Kiran

[PATCH v5 18/21] test/pdcp: add timer restart case

From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff

[PATCH v5 10/21] test/pdcp: pdcp HFN tests in combined mode

From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test

[PATCH v5 20/21] pdcp: allocate reorder buffer alongside with entity

From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v5 08/21] pdcp: add IV generation routines

For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284

[PATCH v5 11/21] doc: add PDCP library guide

Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc

[PATCH v5 01/21] net: add PDCP header

From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib

[PATCH v5 17/21] test/pdcp: add timer expiry cases

From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test

[PATCH v5 14/21] test/pdcp: add in-order delivery cases

From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v5 16/21] pdcp: add timer expiry handle

notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v5 04/21] pdcp: add packet group

entity. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build | 1 + lib/pdcp/rte_pdcp.h | 6 ++ lib/pdcp/rte_pdcp_group.h | 131 ++ lib/pdcp/version.map | 3 + 4 files changed

[PATCH v5 16/21] pdcp: add timer expiry handle

notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v5 05/21] pdcp: add crypto session create and destroy

Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c |

[PATCH v5 15/21] pdcp: add timer callback handlers

when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v5 12/21] pdcp: add control PDU handling for status report

Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp

[PATCH v5 07/21] pdcp: add pre and post process for DL

Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 384 lib/pdcp/pdcp_proce

[PATCH v5 00/21] lib: add pdcp protocol

b Testsuites Passed : 5 + Sub Testsuites Failed : 0 + --- + + Tests Total : 179 + Tests Skipped : 0 + Tests Executed :179 + Tests Unsupported: 48 + Tests Passed : 131 + Tests Failed : 0 + --- + Test OK Anoob Jo

[PATCH v5 03/21] pdcp: add pre and post-process

lows skipping multiple checks that would come in datapath otherwise. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/rte_pdcp.h | 97 lib/pdcp/version.map | 3 ++ 2 files cha

[PATCH v5 14/21] test/pdcp: add in-order delivery cases

From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v5 20/21] pdcp: allocate reorder buffer alongside with entity

From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v5 09/21] app/test: add lib pdcp tests

Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + app/test/meson.build | 5 + app/test/test_pdcp.c | 732 +++ 3 files

[PATCH v5 19/21] pdcp: add support for status report

From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v5 15/21] pdcp: add timer callback handlers

when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v5 21/21] test/pdcp: add PDCP status report cases

From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

[PATCH v5 06/21] pdcp: add pre and post process for UL

per PDCP specification). Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_entity.h | 24 +++ lib/pdcp/pdcp_process.c | 334 2 files changed, 358 insertions(+) diff --git a

[PATCH v5 17/21] test/pdcp: add timer expiry cases

From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test

[PATCH v5 19/21] pdcp: add support for status report

From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v5 13/21] pdcp: implement t-Reordering and packet buffering

se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v5 18/21] test/pdcp: add timer restart case

From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff

[PATCH v5 21/21] test/pdcp: add PDCP status report cases

From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

[PATCH v6 00/21] lib: add pdcp protocol

-- + Test OK Anoob Joseph (10): lib: add pdcp protocol pdcp: add pre and post-process pdcp: add packet group pdcp: add crypto session create and destroy pdcp: add pre and post process for UL pdcp: add pre and post process for DL pdcp: add

[PATCH v6 01/21] net: add PDCP header

From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib

[PATCH v6 02/21] lib: add pdcp protocol

. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() Signed-off-by: Anoob Joseph Signed-off-by: Kiran

[PATCH v6 03/21] pdcp: add pre and post-process

lows skipping multiple checks that would come in datapath otherwise. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/rte_pdcp.h | 96 lib/pdcp/version.map | 3 ++ 2 files cha

[PATCH v6 04/21] pdcp: add packet group

entity. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build | 1 + lib/pdcp/rte_pdcp.h | 6 ++ lib/pdcp/rte_pdcp_group.h | 131 ++ lib/pdcp/version.map | 3 + 4 files changed

[PATCH v6 05/21] pdcp: add crypto session create and destroy

Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c |

[PATCH v6 06/21] pdcp: add pre and post process for UL

per PDCP specification). Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_entity.h | 24 +++ lib/pdcp/pdcp_process.c | 334 2 files changed, 358 insertions(+) diff --git a

[PATCH v6 07/21] pdcp: add pre and post process for DL

Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 384 lib/pdcp/pdcp_proce

[PATCH v6 08/21] pdcp: add IV generation routines

For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284

[PATCH v6 09/21] app/test: add lib pdcp tests

Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + app/test/meson.build | 5 + app/test/test_pdcp.c | 732 +++ 3 files

[PATCH v6 10/21] test/pdcp: pdcp HFN tests in combined mode

From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test

[PATCH v6 11/21] doc: add PDCP library guide

Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc

[PATCH v6 12/21] pdcp: add control PDU handling for status report

Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp

[PATCH v6 13/21] pdcp: implement t-Reordering and packet buffering

se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v6 14/21] test/pdcp: add in-order delivery cases

From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v6 15/21] pdcp: add timer callback handlers

when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v6 16/21] pdcp: add timer expiry handle

notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v6 17/21] test/pdcp: add timer expiry cases

From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test

[PATCH v6 19/21] pdcp: add support for status report

From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v6 18/21] test/pdcp: add timer restart case

From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff

[PATCH v6 20/21] pdcp: allocate reorder buffer alongside with entity

From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v6 21/21] test/pdcp: add PDCP status report cases

From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

RE: [EXT] [PATCH v2] examples/ipsec-secgw: fix cryptodev to SA mapping

Hi Radu, Using same session across multiple devices would only work if the device instances are same. For example, if you use QAT device 0 & QAT device 1, then the sharing is okay. But if we have QAT and some SW crypto PMD, then the same session will not work. Is it possible to throw a warning

RE: [EXT] [PATCH v3] examples/ipsec-secgw: fix cryptodev to SA mapping

Hi Radu, Thanks for making the changes. I've one more question. Please see inline. Thanks, Anoob > -Original Message- > From: Radu Nicolau > Sent: Monday, February 26, 2024 3:56 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Radu Nicolau > ; sta...@dpdk.org; Volody

RE: [EXT] [PATCH v3] examples/ipsec-secgw: fix cryptodev to SA mapping

Hi Radu, Please see inline. Thanks, Anoob > -Original Message- > From: Radu Nicolau > Sent: Tuesday, February 27, 2024 3:41 PM > To: Anoob Joseph > Cc: sta...@dpdk.org; Volodymyr Fialko ; Ting-Kai Ku > ; Ciara Power ; Kai Ji > ; Akhil Goyal ; dev@dpdk.org > S

RE: [EXT] [PATCH v4] examples/ipsec-secgw: fix cryptodev to SA mapping

igned-off-by: Radu Nicolau > Tested-by: Ting-Kai Ku > Acked-by: Ciara Power > Acked-by: Kai Ji Acked-by: Anoob Joseph

RE: [PATCH] app/crypto-perf: support TLS record

> > Added support for latency and throughput measurement of TLS and DTLS > security ops. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

[PATCH 1/2] examples/ipsec-secgw: fix width of variables

c-secgw: update eth header during route lookup") Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 5 ++--- examples/ipsec-secgw/ipsec_worker.h | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/example

[PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets

Instead of freeing directly, use commonly used function which also updates stats. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c

<    1   2   3   4   5   6   7   8   9   10   >