[dpdk-dev] [PATCH] crypto/cnxk: reset feature flags on reconfigure

2021-07-08 Thread Anoob Joseph
Feature flag in dev would be updated during config. On reconfigure, the field need to be set again to original value. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev.c| 14 +- drivers/crypto/cnxk/cn9k_cryptodev.c | 13 + drivers/crypto/cnxk

Re: [dpdk-dev] [EXT] Re: [pull-request] next-crypto 21.08 rc1

2021-07-08 Thread Anoob Joseph
Hi Ali, David, Thanks for pointing it out. The suggestion from David should do. Should we submit a patch with fix on master? How do you suggest we proceed? Thanks, Anoob > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Friday, July 9, 2021 1:46 AM > To: Ali Alnubani

[dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k

2021-07-08 Thread Anoob Joseph
-off-by: Anoob Joseph --- config/arm/arm64_octeontx2_linux_gcc | 1 + drivers/crypto/cnxk/cn9k_cryptodev.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc index 9156ee5..8fbdd38 100644 --- a/config/arm

Re: [dpdk-dev] [EXT] Re: [pull-request] next-crypto 21.08 rc1

2021-07-09 Thread Anoob Joseph
rchand > Sent: Friday, July 9, 2021 12:13 PM > To: Anoob Joseph > Cc: Ali Alnubani ; Akhil Goyal > ; NBU-Contact-Thomas Monjalon > ; dev@dpdk.org; Tejasree Kondoj > > Subject: Re: [EXT] Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1 > > On Fri, Jul 9, 2021 at 6:25 A

[dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix member overlap

2021-07-13 Thread Anoob Joseph
The member 'dir' should not overlap with 'ip'. Usage of union for all members would mean dir would get corrupt. Fixes: e91b4f45ff54 ("net/octeontx2: support anti-replay for security session") Cc: adwiv...@marvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/

[dpdk-dev] [PATCH 2/3] net/octeontx2: add locking for inline IPsec tbl updates

2021-07-13 Thread Anoob Joseph
Add locking for IPsec table updates. Fixed error handling to clear SA entry if the SA population functions encounters any error. Signed-off-by: Anoob Joseph --- drivers/net/octeontx2/otx2_ethdev.h | 2 + drivers/net/octeontx2/otx2_ethdev_sec.c | 83 + 2

[dpdk-dev] [PATCH 3/3] net/octeontx2: clear SA valid during session destroy

2021-07-13 Thread Anoob Joseph
SA table entry would be reserved for inline inbound operations. Clear valid bit of the SA so that CPT would treat SA entry as invalid. Also, move setting of valid bit to the end in case of session_create() to eliminate possibility of hardware seeing partial data. Signed-off-by: Anoob Joseph

[dpdk-dev] [PATCH] common/cpt: allocate auth key mem dynamically

2021-07-14 Thread Anoob Joseph
Reduce session private data size by allocating auth_key dynamically as required. Added auth_key_iova to eliminate any impact on fastpath. Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_mcode_defines.h | 3 ++- drivers/common/cpt/cpt_ucode.h | 10

[dpdk-dev] [PATCH] common/cnxk: allocate auth key mem dynamically

2021-07-15 Thread Anoob Joseph
Reduce session private data size by allocating auth_key dynamically as required. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.c | 6 +- drivers/common/cnxk/roc_se.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 11 +++ drivers/crypto/cnxk

[dpdk-dev] [PATCH 0/2] Improvements to rte_security

2021-07-19 Thread Anoob Joseph
renegotiation. For cryptodevs which can track expiries, this operation can be offloaded. This patchset introduces ABI breakages and is intended for 21.11 release Anoob Joseph (2): lib/security: add IV generation lib/security: add SA lifetime configuration examples/ipsec-secgw/ipsec.c | 2

[dpdk-dev] [PATCH 1/2] lib/security: add IV generation

2021-07-19 Thread Anoob Joseph
Enable application to offload IV generation to PMD. In case of lookaside protocol offload, IV would be provided by application in rte_crypto_op. Allow offloading the same to PMD with such support. Signed-off-by: Anoob Joseph --- lib/security/rte_security.h | 14 ++ 1 file changed

[dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-19 Thread Anoob Joseph
not be IPsec processed and would result in error. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 7 +++ lib/security/rte_security.h | 28 ++-- 4 files changed, 35 insertions

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-19 Thread Anoob Joseph
4e9850171 [2] https://doc.dpdk.org/api/rte__crypto_8h_source.html Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Tuesday, July 20, 2021 11:16 AM > To: Akhil Goyal ; Declan Doherty > ; Fan Zhang ; > Konstantin Ananyev > Cc: Anoob Joseph ; Jerin Jacob Ko

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-28 Thread Anoob Joseph
For soft expiry, warning would work fine. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 28, 2021 6:29 PM > To: Ananyev, Konstantin ; Anoob Joseph > ; Doherty, Declan ; > Zhang, Roy Fan ; hemant.agra...@nxp.com > Cc: Jerin Jacob K

[dpdk-dev] [PATCH 21.11 0/3] Add lookaside IPsec tests

2021-07-29 Thread Anoob Joseph
g PMDs 1. crypto_octeontx2 2. crypto_cn10k Anoob Joseph (2): test/crypto: add lookaside IPsec tests test/crypto: add combined mode tests Tejasree Kondoj (1): test/crypto: add lookaside IPsec ICV corrupt test case app/test/meson.build | 1 + app/tes

[dpdk-dev] [PATCH 21.11 1/3] test/crypto: add lookaside IPsec tests

2021-07-29 Thread Anoob Joseph
Added test case for lookaside IPsec. Following tests are added, 1. Inbound known vector [AES-GCM 128, 192 & 256] 2. Outbound known vector [AES-GCM 128, 192 & 256] Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build |

[dpdk-dev] [PATCH 21.11 2/3] test/crypto: add combined mode tests

2021-07-29 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 74 +++-- app/test/test_cryptodev_security_ipsec.c | 107

[dpdk-dev] [PATCH 21.11 3/3] test/crypto: add lookaside IPsec ICV corrupt test case

2021-07-29 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-08-02 Thread Anoob Joseph
Hi Konstantin, > Subject: [EXT] RE: [PATCH 2/2] lib/security: add SA lifetime configuration > > External Email > > -- > Hi Anoob, > > > Now that we have an agreement on bitfields (hoping no one else has an > > objection), I wou

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

2021-08-02 Thread Anoob Joseph
dev@dpdk.org > Cc: Anoob Joseph ; radu.nico...@intel.com; > declan.dohe...@intel.com; abhijits.si...@intel.com; > daniel.m.buck...@intel.com; Archana Muniganti ; > Tejasree Kondoj ; hemant.agra...@nxp.com; > ma...@nvidia.com; konstantin.anan...@intel.com; Akhil Goyal > > Subject

[dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Anoob Joseph
One reserved byte in rte_crypto_op struct would be used to indicate warnings and other information from the crypto/security operation. This field will be used to communicate events such as soft expiry with IPsec in lookaside mode. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes

[dpdk-dev] [PATCH] doc: announce IPsec xform struct changes

2021-08-02 Thread Anoob Joseph
h a new structure to cover all lifetime cases with support for specifying both soft and hard lifetimes. ESN control introduced by: http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-radu.nico...@intel.com/ Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/deprecation.rst | 5 +

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-08-03 Thread Anoob Joseph
Hi Konstantin, > Subject: [EXT] RE: [PATCH 2/2] lib/security: add SA lifetime configuration > > Hi Anoob, > > > > > Now that we have an agreement on bitfields (hoping no one else has > > > > an objection), I would like to discuss one more topic. It is more > > > > related to > > > checksum offlo

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct

2021-08-04 Thread Anoob Joseph
; >``rte_security_get_userdata`` will be made inline functions and > > > additional > > >flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. > > > + > > > +* security: Hide stucture ``rte_security_session`` and expose an opaque > > > + pointer for the private data to the application which can be attached > > > + to the packet while enqueuing. > > > -- > > > > Acked-by: Konstantin Ananyev > Acked-by: Ajit Khaparde Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] doc: announce restructuring of crypto session structs

2021-08-04 Thread Anoob Joseph
exposed > + directly to application which can be attached to the ``rte_crypto_op``. > + > * security: The functions ``rte_security_set_pkt_metadata`` and >``rte_security_get_userdata`` will be made inline functions and additional >flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. > -- Acked-by: Anoob Joseph

Re: [dpdk-dev] [EXT] [PATCH 2/2] doc: announce rte_security_ipsec_xform structure changes

2021-08-05 Thread Anoob Joseph
structure that will hold the > + source and destination port for UDP encapsulation, mss to specify the > + IPsec payload Maximum Segment Size, esn structure for Extended > Sequence Number. > -- Acked-by: Anoob Joseph

[dpdk-dev] [PATCH v2 1/4] test/crypto: add lookaside IPsec tests

2021-08-11 Thread Anoob Joseph
Added test case for lookaside IPsec. Inbound known vector tests are added. Cipher list: AES-GCM 128, 192 & 256 Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build | 1 + app/test/test.h|

[dpdk-dev] [PATCH v2 0/4] Add lookaside IPsec tests

2021-08-11 Thread Anoob Joseph
protocol would require IV generated by PMD. The tests would be introduced with spec change to allow user to specify IV. - Added IV generation tests - Minor fixes in combined mode tests to handle multiple packets Anoob Joseph (2): test/crypto: add lookaside IPsec tests test/crypto: add combi

[dpdk-dev] [PATCH v2 2/4] test/crypto: add combined mode tests

2021-08-11 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev_security_ipsec.c | 107

[dpdk-dev] [PATCH v2 3/4] test/crypto: add lookaside IPsec ICV corrupt test case

2021-08-11 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test

[dpdk-dev] [PATCH v2 4/4] test/crypto: add IV gen tests

2021-08-11 Thread Anoob Joseph
From: Tejasree Kondoj Add test cases to verify IV generated by PMD. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 app/test/test_cryptodev_security_ipsec.c | 52 app/test

Re: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP

2021-11-10 Thread Anoob Joseph
Hi Pablo, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, November 10, 2021 4:54 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: Jerin Jacob Kollanukkara

[dpdk-dev] [PATCH v2] test/crypto: skip plain text compare for null cipher

2021-11-10 Thread Anoob Joseph
-by: Anoob Joseph --- Changes in v2: - Made the skip applicable for in place also (comment from Pablo) - Re-organized code as suggested by Pablo - Made same change in test_mixed_auth_cipher_sgl (comment from Pablo) app/test/test_cryptodev.c | 63 ++- 1 file c

RE: [EXT] [PATCH] test/crypto: fix unnecessary stats retrieval

2021-11-11 Thread Anoob Joseph
st: add cryptodev unit and performance tests") > Cc: declan.dohe...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Ciara Power Acked-by: Anoob Joseph

[PATCH] crypto/cnxk: fix kasumi input len calculation

2021-11-11 Thread Anoob Joseph
Fix kasumi input len calculation to consider encr_offset. Fixes: 546dff20a034 ("crypto/cnxk: add KASUMI decryption") Cc: ktejas...@marvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/c

[PATCH] common/cpt: fix kasumi input len calculation

2021-11-11 Thread Anoob Joseph
Fix kasumi input len calculation to consider encr_offset. Fixes: da39e3eccd3d ("common/cpt: support KASUMI") Cc: ssriniva...@caviumnetworks.com Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_ucode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

RE: query regarding IPsec inner IP header TTL

2021-11-17 Thread Anoob Joseph
Hi Gagandeep, There is an option(dec_ttl) in 'struct rte_security_ipsec_sa_options' to control this. Wouldn't that work? http://code.dpdk.org/dpdk/latest/source/lib/security/rte_security.h#L166 Thanks, Anoob From: Gagandeep Singh Sent: Thursday, November 18, 2021 9:41 AM To: Akhil Goyal ; de

RE: [PATCH] examples/ipsec-secgw: fix event dev start sequence

2021-12-05 Thread Anoob Joseph
@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Nithin Dabilpuram Acked-by: Anoob Joseph

[PATCH 00/13] Add new cases to lookaside IPsec tests

2021-12-05 Thread Anoob Joseph
. * Tunnel mode tests * IPv6 in IPv6 * IPv4 in IPv4 * IPv4 in IPv6 * IPv6 in IPv4 * IPv4 transport mode tests. * Security stats tests. * AES-CTR tests. * set/copy DF tests. Ankur Dwivedi (1): test/crypto: add security stats cases Anoob Joseph (5): test/crypto: add IPsec aes-cbc known

[PATCH 01/13] test/crypto: add IPsec aes-cbc known vectors

2021-12-05 Thread Anoob Joseph
Extend the framework to support chained operations and add AES-CBC 128 known vector tests. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 62 ++-- app/test/test_cryptodev_security_ipsec.c | 51 ++ app/test

[PATCH 02/13] test/crypto: add IPsec AES-CBC-HMAC-SHA256 known vectors

2021-12-05 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec AES-CBC-HMAC-SHA256 test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 12 ++- app/test/test_cryptodev_security_ipsec.h | 3 + .../test_cryptodev_security_ipsec_test_vectors.h | 109 +++

[PATCH 03/13] test/crypto: add chained operations in combined cases

2021-12-05 Thread Anoob Joseph
Extend lookaside IPsec combined mode cases to cover chained operations also. Currently covering combinations of, Ciphers, 1. AES-128-CBC Auth, 1. NULL 2. SHA2-256 [16B ICV] Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 11 +++-- app/test

[PATCH 04/13] test/crypto: add IPv6 tunnel mode cases

2021-12-05 Thread Anoob Joseph
From: Tejasree Kondoj Add IPv6 known vector and combined mode tests. Following modes are added: Tunnel IPv6 in IPv6 Tunnel IPv4 in IPv4 Tunnel IPv4 in IPv6 Tunnel IPv6 in IPv4 Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 102 ++- app/test/tes

[PATCH 05/13] test/crypto: add IPsec HMAC-SHA384/512 known vectors

2021-12-05 Thread Anoob Joseph
From: Tejasree Kondoj Add lookaside IPsec HMAC-SHA384/512 known vectors. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 20 ++ app/test/test_cryptodev_security_ipsec.h | 14 +- .../test_cryptodev_security_ipsec_test_vectors.h | 213 +++

[PATCH 06/13] test/crypto: add IPsec fragmented packet known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add fragmented plain packet known vector test case in IPsec outbound. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 22 + app/test/test_cryptodev_security_ipsec.c | 10 ++ app/test/test_cryptodev_security_ipsec.h

[PATCH 07/13] test/crypto: add transport mode cases

2021-12-06 Thread Anoob Joseph
Add transport mode tests with test cases for IPv4 packets. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 39 ++ app/test/test_cryptodev_security_ipsec.c | 71 +--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files

[PATCH 08/13] test/crypto: add security stats cases

2021-12-06 Thread Anoob Joseph
From: Ankur Dwivedi Adds security stats test cases in IPSEC protocol testsuite. Signed-off-by: Ankur Dwivedi --- app/test/test_cryptodev.c| 21 + app/test/test_cryptodev_security_ipsec.c | 29 + app/test/test_cryptodev_security_ip

[PATCH 09/13] test/crypto: add lookaside IPsec AES-CTR known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add known vectors for AES-CTR in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_security_ipsec.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/app/test/test_cryptodev_security_ipsec.h b/app/test/test_cryptodev_secu

[PATCH 10/13] test/crypto: add fragmented packet case

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add fragmented plain packet test case in combined mode. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 7 +++ 2 files changed, 23 insertions(+) diff --git a/app/test/test_

[PATCH 11/13] test/crypto: skip null auth in ICV corrupt case

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Skipping NULL auth in ICV corruption test case. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 744eb9f..0f7885c 100644 --- a/app/test/test_cr

[PATCH 12/13] test/crypto: add aes xcbc known vectors

2021-12-06 Thread Anoob Joseph
Add known vector test cases for NULL cipher + AES-XCBC. Also add both algos to the combined mode list of algos. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 38 +++-- app/test/test_cryptodev_security_ipsec.c | 2 + app/test

[PATCH 13/13] test/crypto: add copy and set DF cases

2021-12-06 Thread Anoob Joseph
Add test cases to verify copy DF and set DF options with lookaside IPsec offload. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 75 app/test/test_cryptodev_security_ipsec.c | 71 -- app/test

[PATCH v2 00/13] Add new cases to lookaside IPsec tests

2021-12-06 Thread Anoob Joseph
failure with last patch Ankur Dwivedi (1): test/crypto: add security stats cases Anoob Joseph (5): test/crypto: add IPsec aes-cbc known vectors test/crypto: add chained operations in combined cases test/crypto: add transport mode cases test/crypto: add aes xcbc known vectors test/crypto

[PATCH v2 01/13] test/crypto: add IPsec aes-cbc known vectors

2021-12-06 Thread Anoob Joseph
Extend the framework to support chained operations and add AES-CBC 128 known vector tests. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 62 ++-- app/test/test_cryptodev_security_ipsec.c | 51 ++ app/test

[PATCH v2 02/13] test/crypto: add IPsec AES-CBC-HMAC-SHA256 known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec AES-CBC-HMAC-SHA256 test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 12 ++- app/test/test_cryptodev_security_ipsec.h | 3 + .../test_cryptodev_security_ipsec_test_vectors.h | 109 +++

[PATCH v2 03/13] test/crypto: add chained operations in combined cases

2021-12-06 Thread Anoob Joseph
Extend lookaside IPsec combined mode cases to cover chained operations also. Currently covering combinations of, Ciphers, 1. AES-128-CBC Auth, 1. NULL 2. SHA2-256 [16B ICV] Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 11 +++-- app/test

[PATCH v2 04/13] test/crypto: add IPv6 tunnel mode cases

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add IPv6 known vector and combined mode tests. Following modes are added: Tunnel IPv6 in IPv6 Tunnel IPv4 in IPv4 Tunnel IPv4 in IPv6 Tunnel IPv6 in IPv4 Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 102 ++- app/test/tes

[PATCH v2 05/13] test/crypto: add IPsec HMAC-SHA384/512 known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add lookaside IPsec HMAC-SHA384/512 known vectors. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 20 ++ app/test/test_cryptodev_security_ipsec.h | 14 +- .../test_cryptodev_security_ipsec_test_vectors.h | 213 +++

[PATCH v2 06/13] test/crypto: add IPsec fragmented packet known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add fragmented plain packet known vector test case in IPsec outbound. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 22 + app/test/test_cryptodev_security_ipsec.c | 10 ++ app/test/test_cryptodev_security_ipsec.h

[PATCH v2 07/13] test/crypto: add transport mode cases

2021-12-06 Thread Anoob Joseph
Add transport mode tests with test cases for IPv4 packets. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 39 ++ app/test/test_cryptodev_security_ipsec.c | 71 +--- app/test/test_cryptodev_security_ipsec.h | 1 + doc

[PATCH v2 08/13] test/crypto: add security stats cases

2021-12-06 Thread Anoob Joseph
From: Ankur Dwivedi Adds security stats test cases in IPSEC protocol testsuite. Signed-off-by: Ankur Dwivedi --- app/test/test_cryptodev.c| 21 + app/test/test_cryptodev_security_ipsec.c | 29 + app/test/test_cryptodev_security_ip

[PATCH v2 09/13] test/crypto: add lookaside IPsec AES-CTR known vectors

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add known vectors for AES-CTR in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_security_ipsec.h | 15 +++ doc/guides/rel_notes/release_22_03.rst | 1 + 2 files changed, 16 insertions(+) diff --git a/app/test/test_cryptode

[PATCH v2 10/13] test/crypto: add fragmented packet case

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Add fragmented plain packet test case in combined mode. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 7 +++ 2 files changed, 23 insertions(+) diff --git a/app/test/test_

[PATCH v2 11/13] test/crypto: skip null auth in ICV corrupt case

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Skipping NULL auth in ICV corruption test case. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 9a8cced..0ab4ca7 100644 --- a/app/test/test_cr

[PATCH v2 12/13] test/crypto: add aes xcbc known vectors

2021-12-06 Thread Anoob Joseph
Add known vector test cases for NULL cipher + AES-XCBC. Also add both algos to the combined mode list of algos. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 38 +++-- app/test/test_cryptodev_security_ipsec.c | 2 + app/test

[PATCH v2 13/13] test/crypto: add copy and set DF cases

2021-12-06 Thread Anoob Joseph
Add test cases to verify copy DF and set DF options with lookaside IPsec offload. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 75 app/test/test_cryptodev_security_ipsec.c | 71 -- app/test

[PATCH 01/25] common/cnxk: define minor opcodes for MISC opcode

2021-12-06 Thread Anoob Joseph
MISC CPT instruction behaves differently based on minor opcode. Define the missing minor opcodes for MISC major opcode. Signed-off-by: Aakash Sasidharan Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 02/25] common/cnxk: add aes-xcbc key derive

2021-12-06 Thread Anoob Joseph
Add support for AES-XCBC key derivation. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_aes.c | 208 drivers/common/cnxk/roc_aes.h | 14 +++ drivers/common/cnxk/roc_api.h | 3 + drivers/common

[PATCH 07/25] crypto/cnxk: add lookaside IPsec AES-CBC-HMAC-SHA256 support

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CBC-HMAC-SHA256 support to lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 39 +++ doc/guides/rel_notes/release_22_03.rst| 4 +++ drivers/common/cnxk/cnxk_security.c

[PATCH 08/25] crypto/cnxk: clear session data before populating

2021-12-06 Thread Anoob Joseph
Clear session data before populating fields to not have garbage data. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c index 93eab1b..1bd127e 100644

[PATCH 09/25] crypto/cnxk: update max sec crypto caps

2021-12-06 Thread Anoob Joseph
Update the macro to include newly added ciphers. Updated the functions populating caps to throw error when max is exceeded. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 8 ++-- 2 files changed

[PATCH 10/25] crypto/cnxk: write CPT CTX through microcode op

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding support to write CPT CTX through microcode op(SET_CTX) for cn10k lookaside PMD. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 121 -- 1 file changed, 89 insertions(+), 32 deletions(-) diff --git a/driver

[PATCH 11/25] crypto/cnxk: support cnxk lookaside IPsec HMAC-SHA384/512

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding HMAC-SHA384/512 support to cnxk lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 4 ++ doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 36 +

[PATCH 12/25] crypto/cnxk: account for CPT CTX updates and flush delays

2021-12-06 Thread Anoob Joseph
to differentiate s/w immutable and s/w mutable portions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +-- drivers/crypto/cnxk/cn10k_ipsec.c | 60 --- drivers/crypto/cnxk/cn10k_ipsec.h | 25 - drivers/crypto

[PATCH 13/25] crypto/cnxk: use struct sizes for ctx writes

2021-12-06 Thread Anoob Joseph
CTX writes only require the lengths are 8B aligned. Use the struct size directly. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk

[PATCH 14/25] crypto/cnxk: add security session stats get

2021-12-06 Thread Anoob Joseph
From: Ankur Dwivedi Adds the security session stats get op for cn10k. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cn10k_ipsec.c | 55 +++ drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + drivers/crypto/cnxk/cnxk_cryptodev_sec.c |

[PATCH 15/25] crypto/cnxk: add skip for unsupported cases

2021-12-06 Thread Anoob Joseph
Add skip for transport mode tests that are not supported. Also, updated the transport mode path to configure IP version as v4. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 53 +++- 1 file changed, 47 insertions(+), 6 deletions(-) diff

[PATCH 00/25] New features and improvements in cnxk crypto PMD

2021-12-06 Thread Anoob Joseph
New features and fixes to cnxk crypto PMDs - Support for more algorithms in lookaside crypto & protocol - Support for copy & set DF bit - Support for CPT CTX update - Support for security session stats in cn10k Ankur Dwivedi (1): crypto/cnxk: add security session stats get Anoob Jo

[PATCH 03/25] common/cnxk: add bit fields for params

2021-12-06 Thread Anoob Joseph
From: Archana Muniganti Added new structure with bit fields for params. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 30 +- drivers/crypto/cnxk/cn9k_ipsec.c | 16 +--- 2 files changed, 42 insertions(+), 4 deletions(-) diff --

[PATCH 04/25] common/cnxk: fix reset of fields

2021-12-06 Thread Anoob Joseph
Copy DF/DSCP fields would get set based on ipsec_xform in the code preceding this. Setting it again would cause the options to be reset. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_secu

[PATCH 05/25] common/cnxk: verify input args

2021-12-06 Thread Anoob Joseph
Add input arg verification. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/common/cnxk/roc_cpt.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h index 919f842..ccc7af4 100644 --- a

[PATCH 06/25] crypto/cnxk: only enable queues that are allocated

2021-12-06 Thread Anoob Joseph
From: Shijith Thotton Only enable/disable queue pairs that are allocated during cryptodev start/stop. Fixes: 6a95dbc1a291 ("crypto/cnxk: add dev start and dev stop") Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 13 +++-- 1 file changed, 11 insertions(+

[PATCH 16/25] crypto/cnxk: add context reload for IV

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding context reload in datapath for IV in debug mode. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 10 -- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH 17/25] crypto/cnxk: handle null chained ops

2021-12-06 Thread Anoob Joseph
Verification doesn't cover cases when NULL auth/cipher is provided as a chain. Removed the separate function for verification and added a replacement function which calls the appropriate downstream functions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c

[PATCH 18/25] crypto/cnxk: fix inflight cnt calculation

2021-12-06 Thread Anoob Joseph
Inflight count calculation is updated to cover wrap around cases where head can become smaller than tail. Reported-by: Kiran Kumar K Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH 19/25] crypto/cnxk: use atomics to access cpt res

2021-12-06 Thread Anoob Joseph
The memory would be updated by hardware. Use atomics to read the same.. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 24 drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 28

[PATCH 21/25] crypto/cnxk: support lookaside IPsec AES-CTR

2021-12-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CTR support to cnxk CPT in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 2 ++ doc/guides/rel_notes/release_22_03.rst| 1 + drivers/common/cnxk/cnxk_security.c | 6 +

[PATCH 20/25] crypto/cnxk: add more info on command timeout

2021-12-06 Thread Anoob Joseph
Print more info when command timeout happens. Print software and hardware queue information. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/hw/cpt.h | 11 drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 1 + drivers/crypto/cnxk

[PATCH 22/25] crypto/cnxk: fix extend tail calculation

2021-12-06 Thread Anoob Joseph
arvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h index 2dc8913..2b0261e 100644 --- a/drivers/c

[PATCH 23/25] crypto/cnxk: add aes xcbc and null cipher

2021-12-06 Thread Anoob Joseph
Add support for AES XCBC and NULL cipher. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 4 + doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 48 drivers/common/cnxk/roc_ie_on.h

[PATCH 24/25] crypto/cnxk: add copy and set DF

2021-12-06 Thread Anoob Joseph
Add support for copy and set DF bit. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 7 ++- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers

[PATCH 25/25] crypto/cnxk: add aes cmac

2021-12-06 Thread Anoob Joseph
Add support for AES CMAC auth algorithm. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 37 +++--- doc/guides/cryptodevs/features/cn9k.ini | 37 +++--- doc/guides/rel_notes

RE: [EXT] [PATCH] crypto: use single buffer for asymmetric session

2021-12-13 Thread Anoob Joseph
Hi Ciara, +1 to the overall approach. Few comments inline. Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Monday, December 13, 2021 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Ciara > Power ; Declan Doherty > ; Ankur Dwi

[PATCH v2 00/29] New features and improvements in cnxk crypto PMD

2021-12-16 Thread Anoob Joseph
t IV in cn9k - Support for cn10k v1.19 microcode Ankur Dwivedi (1): crypto/cnxk: add security session stats get Anoob Joseph (20): common/cnxk: define minor opcodes for MISC opcode common/cnxk: add aes-xcbc key derive common/cnxk: fix reset of fields common/cnxk: verify input args common/

[PATCH v2 01/29] common/cnxk: define minor opcodes for MISC opcode

2021-12-16 Thread Anoob Joseph
MISC CPT instruction behaves differently based on minor opcode. Define the missing minor opcodes for MISC major opcode. Signed-off-by: Aakash Sasidharan Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 02/29] common/cnxk: add aes-xcbc key derive

2021-12-16 Thread Anoob Joseph
Add support for AES-XCBC key derivation. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_aes.c | 208 drivers/common/cnxk/roc_aes.h | 14 +++ drivers/common/cnxk/roc_api.h | 3 + drivers/common

[PATCH v2 03/29] common/cnxk: add bit fields for params

2021-12-16 Thread Anoob Joseph
From: Archana Muniganti Added new structure with bit fields for params. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 30 +- drivers/crypto/cnxk/cn9k_ipsec.c | 16 +--- 2 files changed, 42 insertions(+), 4 deletions(-) diff --g

[PATCH v2 04/29] common/cnxk: fix reset of fields

2021-12-16 Thread Anoob Joseph
Copy DF/DSCP fields would get set based on ipsec_xform in the code preceding this. Setting it again would cause the options to be reset. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_secu

[PATCH v2 05/29] common/cnxk: verify input args

2021-12-16 Thread Anoob Joseph
Add input arg verification. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/common/cnxk/roc_cpt.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h index 919f842..ccc7af4 100644 --- a

[PATCH v2 06/29] common/cnxk: update completion code

2021-12-16 Thread Anoob Joseph
Update completion code to match v1.19 microcode release. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ie_ot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h index 5b61902..923656f 100644 --- a

<    1   2   3   4   5   6   7   8   9   10   >