Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-26 Thread Anoob Joseph
Hi Radu, On 01/26/2018 04:52 PM, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, January 25, 2018 5:13 PM To: Akhil Goyal ; Nicolau, Radu Cc: Doherty, Declan ; Gonzalez Monroy, Sergio ; anoob.jos

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-29 Thread Anoob Joseph
Hi Akhil, Radu, On 01/29/2018 01:02 PM, Akhil Goyal wrote: On 1/26/2018 8:38 PM, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Friday, January 26, 2018 2:38 PM To: Nicolau, Radu ; Akhil Goyal Cc: anoob.jos

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-29 Thread Anoob Joseph
Hi Akhil, On 01/29/2018 02:38 PM, Akhil Goyal wrote: On 1/29/2018 1:33 PM, Anoob Joseph wrote: Hi Akhil, Radu, On 01/29/2018 01:02 PM, Akhil Goyal wrote: On 1/26/2018 8:38 PM, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-29 Thread Anoob Joseph
Hi Radu, On 01/29/2018 03:31 PM, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Monday, January 29, 2018 8:04 AM To: Akhil Goyal ; Nicolau, Radu Cc: anoob.jos...@caviumnetworks.com; Doherty, Declan ; Gonzalez Monroy, Sergio

[dpdk-dev] [PATCH] examples/ipsec-secgw: add support for AES 256

2018-02-07 Thread Anoob Joseph
Adding support for AES 256 algorithm in ipsec-secgw application Signed-off-by: Anoob Joseph --- doc/guides/sample_app_ug/ipsec_secgw.rst | 1 + examples/ipsec-secgw/sa.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: print correct crypto name

2018-02-11 Thread Anoob Joseph
On 09/02/18 16:10, Radu Nicolau wrote: When AES-256 was used aes-128 was printed in the console Fixes: fa9088849e12 ("examples/ipsec-secgw: support AES 256") Signed-off-by: Radu Nicolau Acked-by: Anoob Joseph --- examples/ipsec-secgw/sa.c | 3 ++- 1 file changed, 2 insert

[dpdk-dev] [PATCH 0/5] handle seq no overflow in IPsec offload

2018-02-20 Thread Anoob Joseph
be used by the application to identify the SA on which the sequence number overflow is about to happen. Anoob Joseph (5): lib/ethdev: support for inline IPsec events lib/security: add ESN soft limit in conf lib/security: extend userdata for IPsec events examples/ipsec-secgw: handle ESN soft l

[dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-20 Thread Anoob Joseph
Joseph --- lib/librte_ether/rte_ethdev.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 0361533..4e4e18d 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2438,6 +2438,27

[dpdk-dev] [PATCH 2/5] lib/security: add ESN soft limit in conf

2018-02-20 Thread Anoob Joseph
Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(inline protocol), rte_eth_event framework would raise an IPsec event. Signed-off-by: Anoob Joseph

[dpdk-dev] [PATCH 5/5] app/testpmd: support for IPsec event

2018-02-20 Thread Anoob Joseph
Adding support for IPsec event Signed-off-by: Anoob Joseph --- app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 97d22b8..7ea882f 100644 --- a/app/test-pmd/parameters.c

[dpdk-dev] [PATCH 3/5] lib/security: extend userdata for IPsec events

2018-02-20 Thread Anoob Joseph
r problem for inline processed inbound traffic. Updating the documentation to extend the usage of 'userdata'. Signed-off-by: Anoob Joseph --- lib/librte_security/rte_security.h| 14 -- lib/librte_security/rte_security_driver.h | 6 +++--- 2 files changed, 11 insertions(+)

[dpdk-dev] [PATCH 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-02-20 Thread Anoob Joseph
soft limit set by the application. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 56 ++ examples/ipsec-secgw/ipsec.c | 10 +-- examples/ipsec-secgw/ipsec.h | 2 ++ 3 files changed, 65 insertions(+), 3 deletions(-) diff

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-26 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob On 26/02/18 15:05, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Wednesday, February 21, 2018 5:37 AM To: Akhil Goyal ; Doherty, Declan ; Nicolau, Radu Cc: Anoob Joseph ; Jerin

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-27 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob On 27/02/18 15:49, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Tuesday, February 27, 2018 6:57 AM To: Nicolau, Radu ; Akhil Goyal ; Doherty, Declan Cc: Jerin Jacob ; Narayana

[dpdk-dev] [PATCH v2 1/5] lib/ethdev: support for inline IPsec events

2018-03-01 Thread Anoob Joseph
Joseph --- v2: * Added time expiry & byte expiry IPsec events in the enum lib/librte_ether/rte_ethdev.h | 28 1 file changed, 28 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 0361533..96b2aa0 100644 --- a/lib/librte_e

[dpdk-dev] [PATCH v2 5/5] app/testpmd: support for IPsec event

2018-03-01 Thread Anoob Joseph
Adding support for IPsec event Signed-off-by: Anoob Joseph --- v2: * No change app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 97d22b8..7ea882f 100644 --- a/app/test

[dpdk-dev] [PATCH v2 0/5] handle seq no overflow in IPsec offload

2018-03-01 Thread Anoob Joseph
be used by the application to identify the SA on which the sequence number overflow is about to happen. Anoob Joseph (5): lib/ethdev: support for inline IPsec events lib/security: add ESN soft limit in conf lib/security: extend userdata for IPsec events examples/ipsec-secgw: handle ESN soft l

[dpdk-dev] [PATCH v2 2/5] lib/security: add ESN soft limit in conf

2018-03-01 Thread Anoob Joseph
Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(inline protocol), rte_eth_event framework would raise an IPsec event. Signed-off-by: Anoob Joseph --- v2

[dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-03-01 Thread Anoob Joseph
soft limit set by the application. Signed-off-by: Anoob Joseph --- v2: * No change examples/ipsec-secgw/ipsec-secgw.c | 56 ++ examples/ipsec-secgw/ipsec.c | 10 +-- examples/ipsec-secgw/ipsec.h | 2 ++ 3 files changed, 65 insertions(+), 3

[dpdk-dev] [PATCH v2 3/5] lib/security: extend userdata for IPsec events

2018-03-01 Thread Anoob Joseph
r problem for inline processed inbound traffic. Updating the documentation to extend the usage of 'userdata'. Signed-off-by: Anoob Joseph --- v2: * No change lib/librte_security/rte_security.h| 14 -- lib/librte_security/rte_security_driver.h | 6 +++--- 2 files changed,

Re: [dpdk-dev] [PATCH v2 0/5] handle seq no overflow in IPsec offload

2018-03-07 Thread Anoob Joseph
Hi Akhil, Radu, Can you review the patch set and share your comments? Thanks, Anoob On 01/03/18 14:51, Anoob Joseph wrote: This series enables application to set the sequence number soft limit for IPsec offload. In inline IPsec offload, as the sequence number (maintained by PMD/device

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-08 Thread Anoob Joseph
HI Nelio, On 08-12-2017 20:10, Nelio Laranjeiro wrote: On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: Hi Nelio, [...] + goto flow_create; + /* Try Queue. */ + for (i = 0; +

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
Hi, On 12/11/2017 03:56 PM, Radu Nicolau wrote: Hi, On 12/6/2017 11:08 AM, Anoob wrote: Hi Akhil, On 12/04/2017 01:19 PM, Akhil Goyal wrote: Hi Anoob, On 11/29/2017 9:51 AM, Anoob Joseph wrote: Hi Akhil, On 24-11-2017 16:19, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 3:28 PM, Anoob

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
per packet LPM lookup would be avoided for IPsec packets, in inline mode. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph --- v4 * Made get_hop_for_offload_pkt() be aware of the packet type (ipv4/ipv6) and return success/er

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being sent out. This would have performance improve

Re: [dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix missing ingress flow attribute

2017-12-11 Thread Anoob Joseph
d-by: Radu Nicolau Acked-by: Anoob Joseph --- examples/ipsec-secgw/ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index ec8bf95e1..17bd7620d 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c

[dpdk-dev] [PATCH v5] examples/ipsec-secgw: fix usage of incorrect port

2017-12-12 Thread Anoob Joseph
per packet LPM lookup would be avoided for IPsec packets, in inline mode. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- v5 * Updated comments as suggested by Akhil v4 * Made get_hop_for_offload_pkt() be aw

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v3: * removed PASSTHRU test for ingress. * removed check on configured queues for the queue ac

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-12 Thread Anoob Joseph
PM, Radu Nicolau wrote: Hi, Comment inline On 11/24/2017 8:50 AM, Akhil Goyal wrote: Hi Anoob, Radu, On 11/23/2017 4:49 PM, Anoob Joseph wrote: In case of inline protocol processed ingress traffic, the packet may not have enough information to determine the security parameters with which the

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/12/2017 08:08 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 07:34:31PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/11/2017

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-13 Thread Anoob Joseph
Hi Nelio, On 12/13/2017 03:32 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 12:11:18PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017 08:08 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 07:34:31PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-13 Thread Anoob Joseph
Hi Nelio, On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/13/2017 03:32 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 12:11:18PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017

[dpdk-dev] [PATCH v4 1/2] lib/security: add support for get userdata

2017-12-15 Thread Anoob Joseph
pected to return the application registered "userdata" as is, without any modifications. Signed-off-by: Anoob Joseph --- v4: * Documented the usage of rte_mbuf.udata64 field by security library * Removed (rte_security_get_pkt_metadata() API as the udata64 field itself will have device-s

[dpdk-dev] [PATCH v4 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-15 Thread Anoob Joseph
the security session which processed the packet. In egress side, the plain packet would be submitted to the driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- v4: * Directly using

[dpdk-dev] [PATCH v4 0/2] add inline protocol support

2017-12-15 Thread Anoob Joseph
the packet was processed. Application can register what it needs to identify the required parameter. The userdata will be set while creating the security session. Second patch adds support for inline protocol in ipsec-secgw application Anoob Joseph (2): lib/security: add support for get metadata

[dpdk-dev] [PATCH v5 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-15 Thread Anoob Joseph
the security session which processed the packet. In egress side, the plain packet would be submitted to the driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- v5: * Fixed checkpatch

[dpdk-dev] [PATCH v5 1/2] lib/security: add support for get userdata

2017-12-15 Thread Anoob Joseph
pected to return the application registered "userdata" as is, without any modifications. Signed-off-by: Anoob Joseph --- v5: * No change v4: * Documented the usage of rte_mbuf.udata64 field by security library * Removed (rte_security_get_pkt_metadata() API as the udata64 field itself will

[dpdk-dev] [PATCH v5 0/2] add inline protocol support

2017-12-15 Thread Anoob Joseph
the packet was processed. Application can register what it needs to identify the required parameter. The userdata will be set while creating the security session. Second patch adds support for inline protocol in ipsec-secgw application Anoob Joseph (2): lib/security: add support for get metadata

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Hi Nelio, On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: Add Egress flow create for devices supporting RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. Signed-off-by: Nelio Laranjeiro --- examples/ipsec-secgw/ipsec.c | 8 1 file changed, 8 insertions(+) diff --git a/examples/ipsec-secgw/ipse

Re: [dpdk-dev] [PATCH v5 1/2] lib/security: add support for get userdata

2017-12-15 Thread Anoob Joseph
Hi Akhil, On 12/15/2017 03:31 PM, Akhil Goyal wrote: Hi Anoob, On 12/15/2017 2:13 PM, Anoob Joseph wrote: diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_security/rte_security_version.map index e12c04b..87f35d7 100644 --- a/lib/librte_security

Re: [dpdk-dev] [PATCH v5 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-15 Thread Anoob Joseph
Hi Nelio, On 12/15/2017 03:09 PM, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Dec 15, 2017 at 08:43:16AM +, Anoob Joseph wrote: Adding support for inline protocol processing In ingress side, application will receive regular IP packets, without any IPsec related info. Application will do a

Re: [dpdk-dev] [PATCH v5 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-15 Thread Anoob Joseph
Hi Akhil, On 12/15/2017 03:34 PM, Akhil Goyal wrote: On 12/15/2017 2:13 PM, Anoob Joseph wrote: Adding support for inline protocol processing In ingress side, application will receive regular IP packets, without any IPsec related info. Application will do a selector check (SP-SA check) by

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Hi Nelio, On 15-12-2017 19:23, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Dec 15, 2017 at 02:35:12PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: Add Egress flow create for devices supporting RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. Signed-off-by: Nelio

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Laranjeiro wrote: Hi Anoob, Seems you want to address a lot of stuff where is should be done in a different series, please see below, On Fri, Dec 15, 2017 at 09:09:00PM +0530, Anoob Joseph wrote: Hi Nelio, On 15-12-2017 19:23, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Dec 15, 2017 at 02:35

[dpdk-dev] [PATCH v6 0/2] add inline protocol support

2017-12-17 Thread Anoob Joseph
the packet was processed. Application can register what it needs to identify the required parameter. The userdata will be set while creating the security session. Second patch adds support for inline protocol in ipsec-secgw application Anoob Joseph (2): lib/security: add support for get userdata

[dpdk-dev] [PATCH v6 1/2] lib/security: add support for get userdata

2017-12-17 Thread Anoob Joseph
pected to return the application registered "userdata" as is, without any modifications. Signed-off-by: Anoob Joseph --- v6: * The file *_version.map needs APIs to be in alphabetical order. Fixed this for the new API added. v5: * No change v4: * Documented the usage of rte_mbuf.uda

[dpdk-dev] [PATCH v6 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-17 Thread Anoob Joseph
the security session which processed the packet. In egress side, the plain packet would be submitted to the driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- v6: * No change v5

Re: [dpdk-dev] [PATCH v4 2/3] examples/ipsec-secgw: add target queues in flow actions

2017-12-18 Thread Anoob Joseph
Hi Nelio, On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v4: * remove Egress code. Changes in v3: * removed PASSTHRU test for ingress. * removed ch

Re: [dpdk-dev] [PATCH v5 2/3] examples/ipsec-secgw: add target queues in flow actions

2017-12-18 Thread Anoob Joseph
On 12/18/2017 03:54 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro Acked-by: Anoob Joseph --- Changes in v5: * Add back default second action. Changes in v4: * remove Egress code

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-21 Thread Anoob Joseph
HI Boris, On 12/20/2017 09:49 PM, Boris Pismenny wrote: Hi, On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: Hi, On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 05:08

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-04 Thread Anoob Joseph
Hi Boris, On 12/21/2017 03:42 PM, Boris Pismenny wrote: Hi Anoob, On 12/21/2017 10:06 AM, Anoob Joseph wrote: HI Boris, On 12/20/2017 09:49 PM, Boris Pismenny wrote: Hi, On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: Hi, On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-04 Thread Anoob Joseph
Hi Adrien, On 12/21/2017 07:52 PM, Adrien Mazarguil wrote: On Thu, Dec 21, 2017 at 12:12:29PM +0200, Boris Pismenny wrote: On 12/21/2017 10:06 AM, Anoob Joseph wrote: I can see the benefits of using rte_flow in both rx & tx, but this unnecessarily introduces hardware requirements

[dpdk-dev] soft lockup calling receive burst

2015-03-20 Thread Joseph Vossen
hello, I am working on a dpdk-based app using version 1.6 under RH7.3. Under varying traffic loads, I will intermittently notice a kernel soft lockup and the RIP provided by the kernel always points to the same MOV instruction in rte_ethdev.h (line #1982). The stack trace looks like:

[dpdk-dev] soft lockup calling receive burst

2015-03-20 Thread Joseph Vossen
[snip] > I haven't seen that, but there's a soft-lockup in KNI in DPDK 1.6. Here's > what I posted about that one a few weeks ago: > > Found the problem. No patch to submit since it's already fixed in later > versions of DPDK, but thought I'd follow up with the details since I'm sure > we aren

Re: [dpdk-dev] [PATCH 1/3] common/cpt: improve structures used in datapath

2019-03-18 Thread Anoob Joseph
Hi Akhil, Can you review this series and share your thoughts? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Saturday, March 2, 2019 12:12 AM > To: Akhil Goyal ; Pablo de Lara > > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Ra

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-18 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Monday, March 11, 2019 4:11 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Ankur

Re: [dpdk-dev] [PATCH v3] doc: add cryptodev xform deprecation notice

2019-04-03 Thread Anoob Joseph
auth_xform``, > +and > + ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > -- > 2.14.5 Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-11 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Wednesday, December 11, 2019 4:36 PM > To: Anoob Joseph ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin >

Re: [dpdk-dev] [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support

2019-12-11 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, December 11, 2019 5:04 PM > To: Anoob Joseph ; Radu Nicolau > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi

Re: [dpdk-dev] [EXT] Re: [PATCH 10/15] crypto/octeontx2: add lookup mem changes to hold sa indices

2019-12-12 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob > Sent: Monday, December 9, 2019 1:32 PM > To: Anoob Joseph > Cc: Akhil Goyal ; Declan Doherty > ; Thomas Monjalon ; > Archana Muniganti ; Jerin Jacob Kollanukkaran > ; Nara

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] add OCTEONTX2 inline IPsec support

2019-12-12 Thread Anoob Joseph
Hi Thomas, Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, December 11, 2019 4:25 AM > To: Jerin Jacob ; Anoob Joseph > > Cc: Akhil Goyal ; Declan Doherty > ; Jerin Jacob Kollanukkaran > ; Narayana Prasa

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-14 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, December 13, 2019 5:25 PM > To: Anoob Joseph ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin > Jacob > Kollanu

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-16 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, December 16, 2019 6:24 PM > To: Anoob Joseph ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin > Jacob > Kollanu

Re: [dpdk-dev] [PATCH 01/14] examples/ipsec-secgw: add default rte_flow for inline Rx

2019-12-16 Thread Anoob Joseph
Hi Konstantin, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, December 16, 2019 7:51 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Ankur Dwivedi ; Jeri

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-16 Thread Anoob Joseph
Hi Vladimir, Please see inline. Thanks, Anoob > -Original Message- > From: Medvedkin, Vladimir > Sent: Monday, December 16, 2019 9:29 PM > To: Anoob Joseph ; Ananyev, Konstantin > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin &g

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-17 Thread Anoob Joseph
Hi Vladimir, Please see inline. Thanks, Anoob > -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, December 17, 2019 4:51 PM > To: Anoob Joseph ; Ananyev, Konstantin > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin &g

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-17 Thread Anoob Joseph
Hi Vladimir, Please see inline. Thanks, Anoob > -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, December 17, 2019 11:14 PM > To: Anoob Joseph ; Ananyev, Konstantin > ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-18 Thread Anoob Joseph
Hi Vladimir, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Medvedkin, Vladimir > Sent: Wednesday, December 18, 2019 7:22 PM > To: Anoob Joseph ; Ananyev, Konstantin > ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, F

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

2020-01-01 Thread Anoob Joseph
Hi Arek, Please see inline. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, December 20, 2019 9:36 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Ayuj Verma ; Trahe, Fiona > ; J

Re: [dpdk-dev] [PATCH 14/14] examples/ipsec-secgw: add cmd line option for bufs

2020-01-02 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, December 23, 2019 9:47 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jeri

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-03 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, December 23, 2019 10:13 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jeri

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-03 Thread Anoob Joseph
Hi Konstantin Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, December 24, 2019 6:18 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran >

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-04 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, December 23, 2019 10:58 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran >

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, January 6, 2020 11:16 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Ankur Dwivedi ; Jeri

Re: [dpdk-dev] [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, December 24, 2019 12:18 AM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad R

Re: [dpdk-dev] [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, December 25, 2019 8:49 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkara

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, January 6, 2020 10:21 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran >

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-01-06 Thread Anoob Joseph
> -Original Message- > From: Archana Muniganti > Sent: Monday, January 6, 2020 3:03 PM > To: marko.kovace...@intel.com; roy.fan.zh...@intel.com; > akhil.go...@nxp.com > Cc: Sucharitha Sarananaga ; Anoob Joseph > ; Abed Mohammad Kamaluddin > ; Jerin Jacob Kollan

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-08 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, January 6, 2020 9:15 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jeri

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-09 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, January 7, 2020 8:01 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Ankur Dwivedi ; Jeri

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: fix missing operation status check

2020-01-10 Thread Anoob Joseph
_cryptodev.c | 96 +-- > 1 file changed, 52 insertions(+), 44 deletions(-) > Tested-by: Ankur Dwivedi Reviewed-by: Anoob Joseph

[dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-10 Thread Anoob Joseph
Currently only one qp will be used for one core. The number of qps can be increased to match the number of lcore params. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 39 +++--- examples/ipsec-secgw/ipsec.h | 4 +++- 2 files changed

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

2020-01-13 Thread Anoob Joseph
Hi Akhil, Do you suggest any change for the title here? As in, should I make it, cryptodev: support ECDSA @Arek, please see inline for responses. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, January 9, 2020 6:34 PM > To: Anoob Joseph ;

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for EC Point Multiplication

2020-01-13 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, January 13, 2020 6:14 PM > To: Anoob Joseph ; Declan Doherty > ; Pablo de Lara > > Cc: Balakrishna Bhamidipati ; Fiona Trahe > ; Arek Kusztal ; > Jerin Jac

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-14 Thread Anoob Joseph
Hi Ori, Please see inline. Thanks, Anoob > -Original Message- > From: Ori Kam > Sent: Thursday, January 9, 2020 1:06 PM > To: Medvedkin, Vladimir ; Ananyev, > Konstantin ; Anoob Joseph > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan > ; Yigit

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-01-14 Thread Anoob Joseph
thm > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > Signed-off-by: Arek Kusztal > Acked-by: Fiona Trahe Acked-by: Anoob Joseph > --- > v2: > - moved release notes to 20.02 > v3: > - added algorithm strings > > doc/guides/cryp

[dpdk-dev] [PATCH v2 2/4] crypto/octeontx: add ECDSA support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Adding support for ECDSA operations in crypto_octeontx PMD. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx.ini|8 +- drivers/common/cpt/Makefile|1

[dpdk-dev] [PATCH v2 3/4] crypto/octeontx2: add ECDSA support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Adding support for ECDSA operations in crypto_octeontx2 PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx2.ini | 8 +++-- .../crypto/octeontx2/otx2_cryptodev_capabilities.c

[dpdk-dev] [PATCH v2 0/4] add ECDSA support

2020-01-15 Thread Anoob Joseph
This series adds support for ECDSA asymmetric operations. Library changes and PMD changes for crypto_octeontx & crypto_octoentx2 is added. The final patch adds the required test vectors and verification routines. v2: * Changed all NIST references to use SECP. * Minor updates to documentation/comme

[dpdk-dev] [PATCH v2 1/4] cryptodev: support ECDSA

2020-01-15 Thread Anoob Joseph
From: Ayuj Verma Asymmetric crypto library is extended to add ECDSA. Elliptic curve xform and ECDSA op params are introduced. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/default.ini | 11 ++-- doc/guides/rel_notes

[dpdk-dev] [PATCH v2 4/4] app/test: add ECDSA sign/verify tests

2020-01-15 Thread Anoob Joseph
From: Ayuj Verma This patch adds ECDSA sign and verify test routine and test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 219 +++- app/test/test_cryptodev_asym_util.h | 11

[dpdk-dev] [PATCH v2 0/4] add ECPM support

2020-01-15 Thread Anoob Joseph
This series adds support for ECPM (Elliptic Curve Point Multiplication) asymmetric operations. Library changes and PMD changes for crypto_octeontx & crypto_octeontx2 is added. The final patch adds the required test vectors and verification routines. v2: * Made all references to point multiplicatio

[dpdk-dev] [PATCH v2 2/4] crypto/octeontx: add ECPM support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add support for asymmetric opertion EC Point Multiplication, in crypto_octeontx PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx.ini| 1 + drivers/common/cpt

[dpdk-dev] [PATCH v2 1/4] cryptodev: support ECPM

2020-01-15 Thread Anoob Joseph
From: Balakrishna Bhamidipati Asymmetric crypto library is extended to add ECPM (Elliptic Curve Point Multiplication). The required xform type and op parameters are introduced. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides

[dpdk-dev] [PATCH v2 3/4] crypto/octeontx2: add ECPM support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add support asymmetric operation EC Point MUltiplication, in crypto_octeontx2 PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx2.ini | 1 + .../crypto/octeontx2

[dpdk-dev] [PATCH v2 4/4] app/test: add ECPM tests

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add test vectors and verify routines for asymmetric operation, EC Point Multiplication. Signed-off-by: Anoob Joseph Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 176 ++ app/test/test_cryptodev_asym_util.h | 11 + app/test

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-16 Thread Anoob Joseph
Hi Ori, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, January 16, 2020 5:06 PM > To: Anoob Joseph ; Medvedkin, Vladimir > ; Ananyev, Konstantin > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan >

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-18 Thread Anoob Joseph
Hi Ori, Please see inline. Thanks, Anoob > -Original Message- > From: Ori Kam > Sent: Thursday, January 16, 2020 7:08 PM > To: Anoob Joseph ; Medvedkin, Vladimir > ; Ananyev, Konstantin > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan > ; Yigit,

[dpdk-dev] [PATCH v2 02/15] common/octeontx2: add routine to check if sec capable otx2

2020-01-18 Thread Anoob Joseph
From: Vamsi Attunuru This routine returns true if given rte_eth_dev is security offload capable and belongs to octeontx2. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/common/octeontx2/otx2_common.c | 20

<    9   10   11   12   13   14   15   16   17   18   >