On 11/29/2014 12:42 AM, Thomas Monjalon wrote:
> 2014-11-28 16:13, Jincheng Miao:
>> On 11/28/2014 01:01 AM, Thomas Monjalon wrote:
>>> 2014-10-31 15:37, Jincheng Miao:
>>>> Function pci_num_vf() is introduced from upstream linux-2.6.34. So
>>>> this
Here is my patch for it, and it also resolves issue of pci_num_vf()
definition.
And I will send V3 for a while.
On 12/10/2014 10:38 AM, Helin Zhang wrote:
> strict_strtoul() was just a redefinition of kstrtoul() for a long
> time. From kernel version of 3.18, strict_strtoul() will not be
> defi
-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h |8
lib/librte_eal/linuxapp/igb_uio/igb_uio.c |4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h
b/lib/librte_eal/linuxapp/igb_uio/compat.h
index a36f
>From upstream kernel commit 3db2e9cd, strict_strto* serial functions
are removed. So that we should directly used kstrtoul instead.
And add kni/compat.h for be compatible with older kernel.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/kni/compat.h| 16
>From upstream kernel commit 3db2e9cd, strict_strto* serial functions
are removed. So that we should directly used kstrtoul instead.
And add xen_dom0/compat.h for be compatible with older kernel.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/xen_dom0/compat.h |
commit 11ba0426.
For other distro like RHEL behaved to pci_num_vf(), we could simply
append following condition macro:
(!(defined(OTHER_RELEASE_CODE) && \
OTHER_RELEASE_CODE >= OTHER_RELEASE_VERSION(X, Y)))
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h |
_dom0. Add compat.h in kni and xen_dom0 for compatible with
older kernels.
v2:
Merge these two patch in one patchset.
Compatible with old kernel for kstrtoul.
Compatible with RHEL6 for pci_num_vf.
Jincheng Miao (4):
igb_uio: compatible with upstream longterm kernel and RHEL
igb_ui
Forget to add 'v3' in header.
@helin, thanks for your review.
On 12/10/2014 11:32 AM, Jincheng Miao wrote:
> The related kernel function is:
> - pci_num_vf, it is introduced from upstream linux-2.6.34. For RHEL-based
> kernel, it is defined from RHEL5.9.
>
> - kstrtoul
- Original Message -
> Hi Jincheng,
>
> 2014-12-10 11:33, Jincheng Miao:
> > From upstream kernel commit 3db2e9cd, strict_strto* serial functions
> > are removed. So that we should directly used kstrtoul instead.
> >
> > And add kni/compat.h fo
- Original Message -
> 2014-12-10 03:48, Jincheng Miao:
> > > It seems you forgot to include the new compat.h.
> > >
> > > Did you do some tests with different Fedora/RHEL versions?
> >
> > Yes, missing compat.h in kni_vhost.c.
> >
>
ot;replace strict_strtoul with kstrtoul" into 3 patches for igb_uio,
kni, and xen_dom0. Add compat.h in kni and xen_dom0 for compatible with
older kernels.
v2:
Merge these two patch in one patchset.
Compatible with old kernel for kstrtoul.
Compatible with RHEL6 for pci_num_vf.
-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h | 8
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h
b/lib/librte_eal/linuxapp/igb_uio/compat.h
index a36f034..455e
Add kni/compat.h for be compatible with older kernel.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/kni/compat.h| 16
lib/librte_eal/linuxapp/kni/kni_vhost.c | 3 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
create mode 100644 lib/librte_eal/linuxapp
And add xen_dom0/compat.h for be compatible with older kernel.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/xen_dom0/compat.h | 16
lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 2 +-
2 files changed, 17 insertions(+), 1 deletion(-)
create mode 100644
commit 11ba0426.
For other distro like RHEL behaved to pci_num_vf(), we could simply
append following condition macro:
(!(defined(OTHER_RELEASE_CODE) && \
OTHER_RELEASE_CODE >= OTHER_RELEASE_VERSION(X, Y)))
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h | 3
- Original Message -
> 2014-12-10 19:04, Jincheng Miao:
> > And add xen_dom0/compat.h for be compatible with older kernel.
> >
> > Signed-off-by: Jincheng Miao
> [...]
> > new file mode 100644
> > index 000..89dab27
> > --- /dev/null
And add xen_dom0/compat.h for be compatible with older kernel.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/xen_dom0/compat.h | 16
lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 3 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
create mode 100644
t;
>> v3:
>> Adjust pci_num_vf() introduced RHEL version number.
>>Seperate "replace strict_strtoul with kstrtoul" into 3 patches for
>> igb_uio,
>> kni, and xen_dom0. Add compat.h in kni and xen_dom0 for compatible with
>> older kernels.
>
IZE=1024
CONFIG_RTE_KNI_VHOST_VNET_HDR_EN=y
CONFIG_RTE_KNI_VHOST_DEBUG_RX=y
CONFIG_RTE_KNI_VHOST_DEBUG_TX=y
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/kni/compat.h|6 ++
lib/librte_eal/linuxapp/kni/kni_vhost.c | 17 +
2 files changed, 23 insertions(+)
ACK, kernel-3.18.0 drops _PAGE_IOMAP.
On 12/12/2014 03:33 AM, Shu Shen wrote:
> This patch fixes build failing with undefined symbol _PAGE_IOMAP with
> kernel 3.18.
>
> The Xen-specific _PAGE_IOMAP PTE flag was removed in kernel 3.18 and
> could be used for other purpose in future. This patch ensu
On 12/16/2014 11:21 PM, Thomas Monjalon wrote:
> 2014-12-11 13:27, Jincheng Miao:
>> RHEL6.5 kernel is based on 2.6.32. But there are two changing
>> from 2.6.35:
>> 1. socket struct is changed
>> It wrappered previous wait_queue_head_t of socket to
>> struct s
) )
-#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
+#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6,6)))
#if (!(UBUNTU_KERNEL_CODE >= UBUNTU_KERNEL_VERSION(3,13,0,30,54) \
&& (UBUNTU_RELEASE_CODE == UBUNTU_RELEASE_VE
f.h:620: note: previous definition of ?skb_set_hash? was here
make[8]: ***
[/root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/e1000_82575.o] Error
1
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h |2 +-
1 files changed, 1 insertions(+), 1 deleti
On 11/28/2014 01:01 AM, Thomas Monjalon wrote:
> 2014-10-31 15:37, Jincheng Miao:
>> Function pci_num_vf() is introduced from upstream linux-2.6.34. So
>> this patch make compatible with longterm kernel linux-2.6.32.63.
>>
>> For RHEL6's kernel, although it
>From upstream kernel commit 3db2e9cd, strict_strto* serial functions
are removed. So that we should directly used kstrtoul instead.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++--
lib/librte_eal/linuxapp/kni/kni_vhost.c | 2 +-
lib/librte_
Signed-off-by: Jincheng Miao
---
doc/guides/linux_gsg/sys_reqs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/linux_gsg/sys_reqs.rst
b/doc/guides/linux_gsg/sys_reqs.rst
index 6a03f54..c14411e 100755
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides
On 10/30/2014 08:04 AM, Thomas Monjalon wrote:
> Hi Jincheng,
>
> 2014-10-24 15:07, Jincheng Miao:
>> From upstream kernel commit 3db2e9cd, strict_strto* serial functions
>> are removed. So that we should directly used kstrtoul instead.
> kstrtoul appeared in
/lib/librte_eal/linuxapp/igb_uio/igb_uio.c: In
function ?show_max_vfs?:
/root/dpdk-source/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:75:
error: implicit declaration of function ?pci_num_vf?
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h |2 +-
1 files
other distros, if they have some
problem, we should
hack it in the same way.
Thanks and regards,
Jincheng Miao
On 10/30/2014 04:18 PM, Jincheng Miao wrote:
> There is a logical error in igb_uio/compat.h when define pci_num_vf().
> Only CONFIG_PCI_IOV enabled, this function could be defined.
from RHEL6.4.
This patchset do some compatiblity work for these two functions, and
replace strict_strtoul which is depleted from linux-3.18.
v2:
Merge these two patch in one patchset.
Compatible with old kernel for kstrtoul.
Compatible with RHEL6 for pci_num_vf.
Jincheng Miao (2):
igb_uio: compa
RHEL6. So we should check the macro
RHEL_RELEASE_CODE to consider this situation.
Signed-off-by: Jincheng Miao
---
lib/librte_eal/linuxapp/igb_uio/compat.h |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h
b/lib/librte_eal/lin
>From upstream kernel commit 3db2e9cd, strict_strto* serial functions
are removed. So that we should directly used kstrtoul instead.
For compatible with old kernel and RHEL6, add some logic to
igb_uio/compat.h, same as what we do for pci_num_vf().
Signed-off-by: Jincheng Miao
---
32 matches
Mail list logo
