[dpdk-dev] [PATCH v7 00/10] app/testpmd: enable testpmd on Windows

2021-04-22 Thread Jie Zhou
APIs - Use OS independant rte_rand - Add device event stubs for Windows - Disable unsupported Apps --- V2 changes: - Fix commit message log long line issue - Fix coding style issues of pointer location - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF

[dpdk-dev] [PATCH v7 04/10] app/testpmd: resolve name collisions

2021-04-22 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v7 08/10] app/testpmd: fix headers inclusion

2021-04-22 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6

[dpdk-dev] [PATCH v7 06/10] app/testpmd: fix parse_fec_mode return type

2021-04-22 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b

[dpdk-dev] [PATCH v7 05/10] app/testpmd: add clock_gettime on Windows

2021-04-22 Thread Jie Zhou
Add clock_gettime for testpmd on Windows in config.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 10 ++- app/test-pmd/config.h | 66 +++ 2 files changed, 68 insertions(+), 8 deletions(-) create mode 100644 app/test

[dpdk-dev] [PATCH v7 07/10] app/testpmd: replace POSIX specific code

2021-04-22 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code on Windows for now Signed-off-by: Jie Zhou Signed-off-by: Jie

[dpdk-dev] [PATCH v7 09/10] app/testpmd: fix unused function warnings

2021-04-22 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +---

[dpdk-dev] [PATCH v7 10/10] app/testpmd: enable building testpmd on Windows

2021-04-22 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test

[dpdk-dev] [PATCH v8 01/10] lib: build libraries that testpmd depends on

2021-04-27 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.build

[dpdk-dev] [PATCH v8 00/10] app/testpmd: enable testpmd on Windows

2021-04-27 Thread Jie Zhou
on - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device event stubs app/testpmd: resolve name collisions app/testpmd: add clock_ge

[dpdk-dev] [PATCH v8 02/10] eal/windows: add necessary macros

2021-04-27 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h index

[dpdk-dev] [PATCH v8 03/10] eal/windows: add device event stubs

2021-04-27 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/windows/eal_dev.c diff

[dpdk-dev] [PATCH v8 04/10] app/testpmd: resolve name collisions

2021-04-27 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v8 08/10] app/testpmd: fix headers inclusion

2021-04-27 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6

[dpdk-dev] [PATCH v8 06/10] app/testpmd: fix parse_fec_mode return type

2021-04-27 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b

[dpdk-dev] [PATCH v8 07/10] app/testpmd: replace POSIX specific code

2021-04-27 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v8 05/10] app/testpmd: add clock_gettime on Windows

2021-04-27 Thread Jie Zhou
Add clock_gettime for testpmd on Windows in config.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 10 ++- app/test-pmd/config.h | 66 +++ 2 files changed, 68 insertions(+), 8 deletions(-) create mode 100644 app/test

[dpdk-dev] [PATCH v8 09/10] app/testpmd: fix unused function warnings

2021-04-27 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-Off-By: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +---

[dpdk-dev] [PATCH v8 10/10] app/testpmd: enable building testpmd on Windows

2021-04-27 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-29 Thread Jie Zhou
On Wed, Apr 28, 2021 at 11:45:40AM +0300, Dmitry Kozlyuk wrote: > 2021-04-19 21:41 (UTC+0200), Thomas Monjalon: > > 19/04/2021 20:34, Tyler Retzlaff: > > > > > Originally and internally, the function was added into eal. But then > > > > > restricted the functionality just inside testpmd to avoid cu

[dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on

2021-04-30 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.build

[dpdk-dev] [PATCH v9 02/10] eal/windows: add necessary macros

2021-04-30 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h index

[dpdk-dev] [PATCH v9 00/10] app/testpmd: enable testpmd on Windows

2021-04-30 Thread Jie Zhou
it message log long line issue - Fix coding style issues of pointer location - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device

[dpdk-dev] [PATCH v9 03/10] eal/windows: add device event stubs

2021-04-30 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/windows/eal_dev.c diff

[dpdk-dev] [PATCH v9 04/10] eal/Windows: add clock_gettime on Windows

2021-04-30 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 1 + lib/eal/windows/include/rte_os_shim.h | 38 +++ 2 files changed, 39 insertions(+) diff --git a/app/test-pmd/config.c b/app

[dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-04-30 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b

[dpdk-dev] [PATCH v9 10/10] app/testpmd: enable building testpmd on Windows

2021-04-30 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test

[dpdk-dev] [PATCH v9 07/10] app/testpmd: replace POSIX specific code

2021-04-30 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v9 05/10] app/testpmd: resolve name collisions

2021-04-30 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v9 08/10] app/testpmd: fix headers inclusion

2021-04-30 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6

[dpdk-dev] [PATCH v9 09/10] app/testpmd: fix unused function warnings

2021-04-30 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +---

Re: [dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on

2021-05-03 Thread Jie Zhou
ends on > > > > You should mention the change is for Windows only. Will explicitly mention the change is for Windows only in V10. > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > --- > > lib/meson.build | 7 +++ > > 1 file chang

Re: [dpdk-dev] [PATCH v9 07/10] app/testpmd: replace POSIX specific code

2021-05-03 Thread Jie Zhou
t > > - Replace htons with RTE_BE16 > > - Replace POSIX specific inet_aton with OS independent inet_pton > > - Replace sleep with rte_delay_us_sleep > > - Repalce random with rte_rand > > - #ifndef mman related code for now > > > > Signed-off-by: Jie Z

Re: [dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-05-03 Thread Jie Zhou
o we need a fixes/CC stable tags here? Will add CC stable, but not sure how to find the original patch which introduced this. > > > External email: Use caution opening links or attachments > > > > > > Fix parse_fec_mode to return fec_capa instead of mode > > >

Re: [dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-05-03 Thread Jie Zhou
On Mon, May 03, 2021 at 02:43:32PM -0700, Jie Zhou wrote: > On Mon, May 03, 2021 at 05:38:21PM +, Tal Shnaiderman wrote: > > > Subject: [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type > > > > > > > I think you should name this patch

[dpdk-dev] [PATCH v10 01/10] lib: build libraries that testpmd depends on

2021-05-03 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib

[dpdk-dev] [PATCH v10 02/10] eal/windows: add necessary macros

2021-05-03 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h index

[dpdk-dev] [PATCH v10 03/10] eal/windows: add device event stubs

2021-05-03 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/windows/eal_dev.c diff

[dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-03 Thread Jie Zhou
on - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device event stubs eal/Windows: add clock_gettime on Windows app/testpmd: resolve name

[dpdk-dev] [PATCH v10 04/10] eal/Windows: add clock_gettime on Windows

2021-05-03 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include

[dpdk-dev] [PATCH v10 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-03 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/tes

[dpdk-dev] [PATCH v10 08/10] app/testpmd: fix headers inclusion

2021-05-03 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6

[dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-03 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v10 09/10] app/testpmd: fix unused function warnings

2021-05-03 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +---

[dpdk-dev] [PATCH v10 10/10] app/testpmd: enable building testpmd on Windows

2021-05-03 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test

[dpdk-dev] [PATCH v10 05/10] app/testpmd: resolve name collisions

2021-05-03 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c

Re: [dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
On Tue, May 04, 2021 at 09:31:08AM +0200, Thomas Monjalon wrote: > When you receive an ack in previous versions, > you should add it manually in your patch > so we keep track of it. > Will send out V11 with adding back the acked-by from V9. Thanks.

Re: [dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
of ifndefs by using the functions > rte_mem_map, rte_mem_lock? I used rte_mem_xxx APIs in V3. DmitryK pointed out that Apps except unit tests should not use these internal APIs, and also rte_mem_map does not support hugepage with different sized. Given that, decided to work on the mman rel

Re: [dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
On Wed, May 05, 2021 at 09:09:20AM -0700, Jie Zhou wrote: > On Wed, May 05, 2021 at 08:34:34AM +, Tal Shnaiderman wrote: > > > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code > > > > > > External email: Use caution opening links or attachmen

[dpdk-dev] [PATCH v11 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib

[dpdk-dev] [PATCH v11 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows

[dpdk-dev] [PATCH v11 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
Add device event stubs for Windows - Disable unsupported Apps --- V2 changes: - Fix commit message log long line issue - Fix coding style issues of pointer location - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libr

[dpdk-dev] [PATCH v11 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal

[dpdk-dev] [PATCH v11 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include

[dpdk-dev] [PATCH v11 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/tes

[dpdk-dev] [PATCH v11 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files

[dpdk-dev] [PATCH v11 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v11 09/10] app/testpmd: fix unused function warnings

2021-05-05 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/con

[dpdk-dev] [PATCH v11 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app

[dpdk-dev] [PATCH v11 10/10] app/testpmd: enable building testpmd on Windows

2021-05-05 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build

[dpdk-dev] [PATCH v12 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows

[dpdk-dev] [PATCH v12 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib

[dpdk-dev] [PATCH v12 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal

[dpdk-dev] [PATCH v12 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
ssues of pointer location - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device event stubs eal/Windows: add clock_gettime on Windows a

[dpdk-dev] [PATCH v12 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/tes

[dpdk-dev] [PATCH v12 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files

[dpdk-dev] [PATCH v12 10/10] app/testpmd: enable building testpmd on Windows

2021-05-05 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build

[dpdk-dev] [PATCH v12 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include

[dpdk-dev] [PATCH v12 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v12 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app

[dpdk-dev] [PATCH v12 09/10] app/testpmd: fix unused function warnings

2021-05-05 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/con

[dpdk-dev] [PATCH v13 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 64a59abab..3fd1ffa0b 100644 --- a/lib/meson.build +++ b/lib

[dpdk-dev] [PATCH v13 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal

[dpdk-dev] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include

[dpdk-dev] [PATCH v13 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
e - Fix FreeBSD2101 compilation issue of AF_INET undeclared --- Jie Zhou (10): lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device event stubs eal/Windows: add clock_gettime on Windows app/testpmd: resolve name collisions app/test

[dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows

[dpdk-dev] [PATCH v13 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files

[dpdk-dev] [PATCH v13 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/tes

[dpdk-dev] [PATCH v13 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app

[dpdk-dev] [PATCH v13 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v13 10/10] app/testpmd: enable building testpmd on Windows

2021-05-05 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build

[dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-05-05 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/con

Re: [dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:28:27AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Add required macros by testpmd on Windows in rte_os_shim.h > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal Shnaiderman >

Re: [dpdk-dev] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:36AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Add clock_gettime on Windows in rte_os_shim.h > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > --- > > lib

Re: [dpdk-dev] [PATCH v13 08/10] app/testpmd: fix headers inclusion

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:48AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > - Include rte_os_shim.h in testpmd.h > > - Remove redundant headers > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal S

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Function print_fdir_mask and print_fdir_flex_payload is only called > > when either i40e or ixgbe presents. Add #if defined to remove > > "unused fun

[dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-23 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 4a64756a68..1673ca4323 100644 --- a/lib/meson.build +++ b/lib

[dpdk-dev] [PATCH v14 2/9] eal/windows: add necessary macros

2021-06-23 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows

[dpdk-dev] [PATCH v14 0/9] app/testpmd: enable testpmd on Windows

2021-06-23 Thread Jie Zhou
independant rte_rand - Add device event stubs for Windows - Disable unsupported Apps --- V2 changes: - Fix commit message log long line issue - Fix coding style issues of pointer location - Fix indentation issue - Fix FreeBSD2101 compilation issue of AF_INET undeclared ---

[dpdk-dev] [PATCH v14 4/9] eal/Windows: add clock_gettime on Windows

2021-06-23 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 33 +++ 1 file changed, 33 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include

[dpdk-dev] [PATCH v14 3/9] eal/windows: add device event stubs

2021-06-23 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions

[dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name

2021-06-23 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/tes

[dpdk-dev] [PATCH v14 7/9] app/testpmd: replace POSIX specific code

2021-06-23 Thread Jie Zhou
redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 6 +- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/csumonly.c | 2 +- app/test-pmd/icmpecho.c | 4 ++-- app/test-pmd/ieee1588fwd.c | 8 app

[dpdk-dev] [PATCH v14 8/9] app/testpmd: fix unused function warnings

2021-06-23 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/con

[dpdk-dev] [PATCH v14 9/9] app/testpmd: enable building testpmd on Windows

2021-06-23 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- app/meson.build| 4 app/pdump/meson.build | 6

[dpdk-dev] [PATCH v14 5/9] app/testpmd: resolve name collisions

2021-06-23 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-06-23 Thread Jie Zhou
From: Jie Zhou lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel on Windows do not check parameters to fail fast for invalid parameters, which captured by DPDK UT alarm_autotest. Enforce Windows lib/eal alarm APIs parameters check and log invalid parameter info. Signed-off-by: Jie

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-24 Thread Jie Zhou
On Thu, Jun 24, 2021 at 09:44:04PM +0300, Dmitry Kozlyuk wrote: > 2021-06-24 08:45 (UTC-0700), Tyler Retzlaff: > > On Wed, Jun 23, 2021 at 02:26:32PM -0700, Jie Zhou wrote: > > > On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > > > > - > > &

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-29 Thread Jie Zhou
On Mon, Jun 28, 2021 at 07:10:01AM -0700, Tyler Retzlaff wrote: > On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote: > > On 6/28/21 1:01 PM, Andrew Rybchenko wrote: > > >On 6/24/21 1:34 AM, Jie Zhou wrote: > > >>Enable building libraries that

Re: [dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name

2021-06-29 Thread Jie Zhou
On Mon, Jun 28, 2021 at 07:29:11AM -0700, Tyler Retzlaff wrote: > On Mon, Jun 28, 2021 at 01:55:02PM +0300, Andrew Rybchenko wrote: > > On 6/24/21 1:34 AM, Jie Zhou wrote: > > >Replace parse_fec_mode misleading return type name mode with fec_capa > > > > > >Fi

<    1   2   3   4   5   6   7   8   9   10   >