[dpdk-dev] [PATCH v3 08/11] app/test: convert current pci_test into a single test case

2016-05-17 Thread Jan Viktorin
The current test_pci is just a single test case that tests the blacklisting of devices. Rename it to test_pci_blacklist and call it from the test_pci. The setup and cleanup are moved out of the test_pci_blacklist entirely to cover all other tests. Signed-off-by: Jan Viktorin --- v3: * improved

[dpdk-dev] [PATCH v3 10/11] app/test: scan PCI bus using a fake sysfs

2016-05-17 Thread Jan Viktorin
Scan the PCI bus by providing a fake sysfs with a PCI device. The fake sysfs is a packed file hierarchy linked into the test. Signed-off-by: Jan Viktorin --- app/test/Makefile | 1 + app/test/test_pci.c| 58

[dpdk-dev] [PATCH v3 09/11] eal/pci: allow to override sysfs

2016-05-17 Thread Jan Viktorin
now possible to create a fake sysfs hierarchy for testing. Signed-off-by: Jan Viktorin --- v3: * changed subject * test_pci_sysfs has been slightly modified to be more understandable * fixed whitespace in *version.map files --- app/test/test_pci.c | 28

[dpdk-dev] [PATCH v3 11/11] app/test: do not dump PCI devices in blacklist test

2016-05-17 Thread Jan Viktorin
Dumping of devices in a unittest is useless. Instead, test whether the test has been set up well - i.e. there are no devices. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c

[dpdk-dev] [PATCH v3 01/11] app/test: introduce resources for tests

2016-05-19 Thread Jan Viktorin
es checked will do for v4. Jan On Tue, 17 May 2016 20:34:51 +0200 Jan Viktorin wrote: > Certain internal mechanisms of DPDK access different file system structures > (e.g. /sys/bus/pci/devices). It is difficult to test those cases automatically > by a unit test when such path is not hard-co

[dpdk-dev] [PATCH v3 09/11] eal/pci: allow to override sysfs

2016-05-19 Thread Jan Viktorin
On Tue, 17 May 2016 20:34:59 +0200 Jan Viktorin wrote: > The SYSFS_PCI_DEVICES is a constant that makes the PCI testing difficult as > it points to an absolute path. We remove using this constant and introducing > a function pci_get_sysfs_path that gives the same value. However, the

[dpdk-dev] [dpdk-dev, PATCHv2, 2/4] drivers: Update driver registration macro usage

2016-05-19 Thread Jan Viktorin
devinitfn_ ##d(void)\ > {\ > - rte_eal_driver_register(&d);\ > -} > +rte_eal_driver_register(&d);\ > +}\ > +DRIVER_EXPORT_NAME(n, __COUNTER__) > + > +#define DRIVER_REGISTER_PCI_TABLE(n, t) \ > +static const char n##_pci_tbl_export[] __attribute__((used))

[dpdk-dev] [PATCH] mbuf: make rearm_data address naturally aligned

2016-05-19 Thread Jan Viktorin
elong at the end of the first > > 64 byte > > cache line as currently "port" is defined as uint8_t, IMO, that is less. > > We may need to increase that uint16_t. The reason why I think that > > because, Currently in ThunderX HW, we do have 128VFs per socket for > > built-in NIC, So, the two node configuration and one external PCIe NW card > > configuration can easily go beyond 256 ports. > > > Ok, good point. If you think it's needed, and if we are changing the mbuf > structure, it might be a good time to extend that field while you are at it, > save > a second ABI break later on. > > /Bruce > > > > > > > Regards, > > > /Bruce > > > > > > Ref: http://dpdk.org/ml/archives/dev/2014-December/009432.html > > > -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-23 Thread Jan Viktorin
Hello David, please, see my comments inline. I didn't see the previous versions of the mempool (well, only very roughly) so I am probably missing some points... My point of view is as a user of the handler API. I need to understand the API to implement a custom handler for my purposes. On Thu,

[dpdk-dev] [dpdk-dev, v5, 3/3] mbuf: get default mempool handler from configuration

2016-05-23 Thread Jan Viktorin
. > + rte_pktmbuf_pool_init(mp, &mbp_priv); > + > + if (rte_mempool_populate_default(mp) < 0) { > + rte_mempool_free(mp); > + return NULL; > + } > + > + rte_mempool_obj_iter(mp, rte_pktmbuf_init, NULL); > + > + return

[dpdk-dev] [dpdk-dev, v5, 2/3] app/test: test external mempool handler

2016-05-23 Thread Jan Viktorin
On Thu, 19 May 2016 14:45:00 +0100 David Hunt wrote: > Use a minimal custom mempool external handler and check that it also > passes basic mempool autotests. > > Signed-off-by: Olivier Matz > Signed-off-by: David Hunt > > --- > app/test/test_mempool.c | 113 +++

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-31 Thread Jan Viktorin
. > > > > How can I pass an opaque pointer here? The only way I see is through the > > rte_mempool.pool. > > I think have addressed this in a later patch, in the discussions with > Jerin on the list. But > rather than passing data at register time, I pa

[dpdk-dev] [dpdk-dev, v5, 2/3] app/test: test external mempool handler

2016-05-31 Thread Jan Viktorin
On Tue, 31 May 2016 10:17:41 +0100 "Hunt, David" wrote: > Hi Jan, > > On 5/23/2016 1:45 PM, Jan Viktorin wrote: > > On Thu, 19 May 2016 14:45:00 +0100 > > David Hunt wrote: > > --snip-- > [...] > >> + > > The test becomes quite co

[dpdk-dev] [PATCH v2 2/2] arch/ppc: fix file descriptor leakage when getting CPU features

2016-11-04 Thread Jan Viktorin
On Fri, 4 Nov 2016 15:16:43 +0530 Jianbo Liu wrote: > close the file descriptor after finish using it. s/close/Close/ Please include my ack (below). Jan > > Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power) > > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin

[dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor leakage when getting CPU features

2016-11-04 Thread Jan Viktorin
On Fri, 4 Nov 2016 15:16:42 +0530 Jianbo Liu wrote: > close the file descriptor after finish using it. s/close/Close/ > > Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7) > Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8) > > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-11 Thread Jan Viktorin
gt; > > > > /projects/dpdk_latest/lib/librte_vhost/vhost_user/virtio- > > > > > net-user.c:250:23: > > > > > > error: array subscript is above array bounds [-Werror=array-bounds] > > > > > >rvq = dev->virtqueue[i * VIRTIO_QNUM +

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-23 Thread Jan Viktorin
Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ethdev: introduce sample action for rte flow Jan > > Thanks. > B.R. > > Jonny > > > -Original Message- > > From: Jan Viktorin > > Se

[dpdk-dev] Duplicating traffic with RTE Flow

2020-09-18 Thread Jan Viktorin
was no support on mlx5 for passthru... flow isolate 0 true flow create 0 ingress pattern end actions passthru / rss end / end Is there any other possibility or PMD+NIC that is known to solve such issue? Thanks Jan Viktorin [1] https://doc.dpdk.org/guides/prog_guide/rte_flow.html#table-rte

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-21 Thread Jan Viktorin
failed: drivers/net/mlx5/mlx5_flow_dv.c:80 error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply error: patch failed: drivers/net/mlx5/mlx5_flow_dv.c:9007 error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply Jan > > Regards, > Asaf Penso > > >-Original Message----- >

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Jan Viktorin
is based on Jan Viktorin's original patch but also checks the > > > > type of the passed pointer against the type of the member. > > > > > > > > Signed-off-by: Jan Viktorin > > > > Signed-off-by: Shreyansh Jain > > > > [jblu

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-03 Thread Jan Viktorin
; Probably you are talking about (Patch 3/4 and 4/4). > Is my understanding correct? > > So, movement to just Linux area is not enough? > I am not well versed with BSD way of doing something similar so if > someone can point it out, I can integrate that. (I will investigate it > at

[dpdk-dev] [PATCH] doc: arm64: document DPDK application profiling methods

2016-10-04 Thread Jan Viktorin
> > +This method can not be used in production systems as this may alter PMU > > +state used by standard Linux user space tool like perf. > > More details please? > -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH v4 11/17] eal/soc: add default scan for Soc devices

2016-10-16 Thread Jan Viktorin
On Sat, 15 Oct 2016 19:15:02 +0530 Shreyansh Jain wrote: > From: Jan Viktorin > > Default implementation which scans the sysfs platform devices hierarchy. > For each device, extract the ueven and convert into rte_soc_device. > > The information populated can then be used

Re: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-17 Thread Jan Viktorin
Hello Vipin and others, please, will there be any progress or update on this series? I successfully tested those changes on our Intel and AMD machines and would like to use it in production soon. The API is a little bit unintuitive, at least for me, but I successfully integrated into our softwar

<    2   3   4   5   6   7