[dpdk-dev] [PATCH 3/9] drivers: no more pdev drivers

On Wed, 10 Feb 2016 10:27:14 +0100 David Marchand wrote: > On Wed, Feb 10, 2016 at 9:51 AM, David Marchand > wrote: > > On Tue, Feb 9, 2016 at 6:05 PM, Jan Viktorin > > wrote: > >> What about introducing a macro for this? > >> > >> RTE_RE

[dpdk-dev] [PATCH 6/9] eal: initialize vdevs right next to pci devices

On Fri, 29 Jan 2016 15:08:33 +0100 David Marchand wrote: > This way, the resources probing happens in a common place. > > Signed-off-by: David Marchand > --- > lib/librte_eal/bsdapp/eal/eal.c | 7 +++ > lib/librte_eal/common/include/rte_dev.h | 2 +- > lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH 7/9] pci: add a helper for device name

dev) > if (pci_dev == NULL) > return -EINVAL; > > - /* Create unique Ethernet device name using PCI address */ > - rte_eth_dev_create_unique_device_name(ethdev_name, > - sizeof(ethdev_name), pci_dev); > + eal_pci_device_name(&pci_dev->addr, ethdev_name, sizeof(ethdev_name)); > > eth_dev = rte_eth_dev_allocated(ethdev_name); > if (eth_dev == NULL) -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH 8/9] pci: add a helper to refresh a device

inuxapp/eal/eal_pci.c > @@ -393,6 +393,19 @@ pci_scan_one(const char *dirname, uint16_t domain, > uint8_t bus, > return 0; > } > > +int > +pci_refresh_device(const struct rte_pci_addr *addr) > +{ > + char filename[PATH_MAX]; > + > + snprintf(filename, sizeof(filename

[dpdk-dev] [PATCH 8/9] pci: add a helper to refresh a device

On Wed, 10 Feb 2016 13:00:50 +0100 David Marchand wrote: > On Wed, Feb 10, 2016 at 12:23 PM, Jan Viktorin > wrote: > > On Fri, 29 Jan 2016 15:08:35 +0100 > > David Marchand wrote: > > > >> It will be used mainly for hotplug code. > >> > >>

[dpdk-dev] [PATCH 3/9] drivers: no more pdev drivers

On Wed, 10 Feb 2016 12:38:20 +0100 David Marchand wrote: > On Wed, Feb 10, 2016 at 11:20 AM, Jan Viktorin > wrote: > > On Wed, 10 Feb 2016 10:27:14 +0100 > > David Marchand wrote: > >> #define RTE_EAL_PCI_REGISTER(name, d)\ > >> void pciinitfn_ ##

[dpdk-dev] [PATCH 1/2] eal: introduce rte_prefetch_non_temporal

> unlike the rte_prefetch0() function which imply that > prefetched data to use repeatedly. > > Signed-off-by: Jerin Jacob Acked-by: Jan Viktorin

[dpdk-dev] vm_power_manager uses non-public API, broken build on top of installed SDK

it's possible to move the contents of channel_commands.h into the rte_power.h. And, there is no maintainer listed for the librte_power and related stuff... By the way, is there a command that installs the examples on the target? I didn't find any yet... Regards Jan --

[dpdk-dev] [PATCH] arm: fix name armv7-a used for dpdk purposes

The CONFIG_RTE_MACHINE must not contain hyphens to work correctly. This was initially done only for the file name defconfig_arm-armv7a-linuxapp-gcc. This patch fixes install-sdk goal. Otherwise, it creates a wrong directory for this platform. Signed-off-by: Jan Viktorin --- config/defconfig_arm

[dpdk-dev] [dpdk-dev, 1/6] mempool: add external mempool manager support

.name = "ring_sp_sc", > + .alloc = rte_mempool_common_ring_alloc, > + .put = common_ring_sp_put, > + .get = common_ring_sc_get, > + .get_count = common_ring_get_count, > + .free = NULL > +}; > +static struct rte_mempool_handler handler_

[dpdk-dev] Fw: dpdk-armv7 - Build # 281 - Failure!

Hello, I've noticed a build regression for vhost library. See the log. I'll send a fix for this very soon. Regards Jan

[dpdk-dev] [PATCH] vhost: fix missing dependency on librte_net

dd Tx offload capabilities") Signed-off-by: Jan Viktorin --- lib/librte_vhost/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 035b569..ef9bbae 100644 --- a/lib/librte_vhost/Makefile +++ b/lib/librte_vhost/Makefile @@ -

[dpdk-dev] [PATCH v1 04/10] app/test: support resources archived by tar

introduces functions resource_untar and resource_rm_by_tar to perform those tasks. An example of using those functions is included as a test. Signed-off-by: Jan Viktorin --- app/test/Makefile| 4 ++ app/test/resource.c | 180 +++ app

[dpdk-dev] [PATCH v1 03/10] app/test: add functions to create files from resources

A resource can be written into the target filesystem by calling resource_fwrite or resource_fwrite_file. Such file can be created before a test is started and removed after the test finishes. Signed-off-by: Jan Viktorin --- app/test/resource.c | 35 +++ app

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

tests of simple resources is included. Signed-off-by: Jan Viktorin --- app/test/Makefile| 2 ++ app/test/resource.c | 61 ++ app/test/resource.h | 77 app/test/test_resource.c | 75

[dpdk-dev] [PATCH v1 02/10] app/test: support resources externally linked

resource creation is a subject of change. Any comments of how to integrate those are welcome. Signed-off-by: Jan Viktorin --- app/test/Makefile| 32 app/test/resource.h | 5 + app/test/test_resource.c | 18 ++ 3 files changed, 55

[dpdk-dev] [PATCH v1 00/10] Include resources in tests

... Regards Jan --- v1 * fix non-existing RTE_INIT, using raw __attribute__ approach instead * included PCI test changes to demonstrate resource API Jan Viktorin (10): app/test: introduce resources for tests app/test: support resources externally linked app/test: add functions to create f

[dpdk-dev] [PATCH v1 05/10] app/test: use linked list to store PCI drivers

The test unregisters all real drivers before starting into an array. This inflexiable as we can use a linked list for this purpose. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/app/test/test_pci.c b

[dpdk-dev] [PATCH v1 06/10] app/test: extract test_pci_setup and test_pci_cleanup

Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cf82373..9d53ba5 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c

[dpdk-dev] [PATCH v1 10/10] app/test: do not dump PCI devices in blacklist test

Dumping of devices in a unittest is useless. Instead, test whether the test has been set up well - i.e. there are no devices. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c

[dpdk-dev] [PATCH v1 08/10] eal/pci: replace SYSFS_PCI_DEVICES with pci_get_sysfs_path()

now possible to create a fake sysfs hierarchy for testing. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 28 + drivers/net/szedata2/rte_eth_szedata2.c | 2 +- drivers/net/virtio/virtio_pci.c | 2 +- lib

[dpdk-dev] [PATCH v1 09/10] app/test: scan PCI bus using a fake sysfs

Scan the PCI bus by providing a fake sysfs with a PCI device. The fake sysfs is a packed file hierarchy linked into the test. Signed-off-by: Jan Viktorin --- app/test/Makefile | 4 ++ app/test/test_pci.c| 58

[dpdk-dev] [PATCH v1 07/10] app/test: convert current pci_test into a single test case

The current test_pci is just a single test case that tests the blacklisting of devices. Rename it to test_pci_blacklist and call it from the test_pci. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 85 + 1 file changed, 47 insertions

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

Hello, On Fri, 6 May 2016 10:26:45 +0100 Declan Doherty wrote: > On 20/04/16 13:41, Jan Viktorin wrote: > > On Wed, 20 Apr 2016 13:05:24 +0100 > > Bruce Richardson wrote: > > > >> On Wed, Apr 20, 2016 at 01:44:00PM +0200, David Marchand wrote: > >>&

[dpdk-dev] [PATCH v1 00/28] Support non-PCI devices

The patch set is designed to be merged partially, if needed (due to its size) and at this stage it should help to solve the rte_driver / rte_device task. Regards Jan Jan Viktorin (28): eal: make enum rte_kernel_driver non-PCI specific eal: extract function eal_parse_sysfs_valuef eal/

[dpdk-dev] [PATCH v1 01/28] eal: make enum rte_kernel_driver non-PCI specific

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/include/rte_dev.h | 8 lib/librte_eal/common/include/rte_pci.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

The eal_parse_sysfs_value function accepts a filename however, such interface introduces race-conditions to the code. Introduce the variant of this function that accepts an already opened file instead of a filename. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_filesystem.h | 5

[dpdk-dev] [PATCH v1 03/28] eal/linux: extract function rte_eal_unbind_kernel_driver

Generalize the PCI-specific pci_unbind_kernel_driver. It is now divided into two parts. First, determination of the path and string identification of the device to be unbound. Second, the actual unbind operation which is generic. Signed-off-by: Jan Viktorin --- lib/librte_eal/common

[dpdk-dev] [PATCH v1 04/28] eal/linux: extract function rte_eal_get_kernel_driver_by_path

Generalize the PCI-specific pci_get_kernel_driver_by_path. The function is general enough, we have just moved it to eal.c, changed the prefix to rte_eal and provided it privately to other parts of EAL. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_private.h | 14

[dpdk-dev] [PATCH v1 05/28] eal: remove pci_ prefix from pci_(un)map_resource

The functions pci_map_resource, pci_unmap_resource are generic so the pci_ prefix can be omitted. The functions are moved to the eal_common_dev.c so they can be reused by other infrastructure. Signed-off-by: Jan Viktorin --- lib/librte_eal/bsdapp/eal/eal_pci.c| 2 +- lib/librte_eal

[dpdk-dev] [PATCH v1 06/28] eal/soc: introduce very essential SoC infra definitions

Define initial structures and functions for the SoC infrastructure. We support only a very minimal functions now. More features will be added in the following commits. It is to be refactored when a generic rte_device/driver pair is added to DPDK. Signed-off-by: Jan Viktorin --- app/test

[dpdk-dev] [PATCH v1 07/28] eal/soc: add rte_eal_soc_register/unregister logic

Signed-off-by: Jan Viktorin --- app/test/test_soc.c | 106 lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 + lib/librte_eal/common/eal_common_soc.c | 55

[dpdk-dev] [PATCH v1 08/28] eal/soc: implement SoC device discovery

Signed-off-by: Jan Viktorin --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_soc.c | 40 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 + lib/librte_eal/common/eal_common_soc.c | 45 lib/librte_eal/common/include

[dpdk-dev] [PATCH v1 09/28] eal: introduce --no-soc option

This option has the same meaning for the SoC infra as the --no-pci for the PCI infra. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_options.c | 5 + lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h| 2 ++ 3 files changed, 8

[dpdk-dev] [PATCH v1 10/28] eal/soc: init SoC infra from EAL

Signed-off-by: Jan Viktorin --- lib/librte_eal/bsdapp/eal/eal.c | 4 lib/librte_eal/common/eal_private.h | 10 ++ lib/librte_eal/linuxapp/eal/eal.c | 3 +++ lib/librte_eal/linuxapp/eal/eal_soc.c | 17 + 4 files changed, 34 insertions(+) diff --git a

[dpdk-dev] [PATCH v1 11/28] eal/soc: implement probing of drivers

Signed-off-by: Jan Viktorin --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 + lib/librte_eal/common/eal_common_soc.c | 200 lib/librte_eal/common/include/rte_soc.h | 25 +++ lib/librte_eal/linuxapp/eal/eal.c | 4 + lib

[dpdk-dev] [PATCH v1 12/28] eal/soc: extend and utilize devargs

This code is not tested. We assume to white/blacklist SoC devices by giving the prefix "soc:" on the command line. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_dev.c | 31 ++- lib/librte_eal/common/eal_common_devargs.c | 7 ++ lib/

[dpdk-dev] [PATCH v1 13/28] eal/soc: update device on probe when already exists

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_soc.c | 5 + lib/librte_eal/common/eal_private.h| 13 + lib/librte_eal/linuxapp/eal/eal_soc.c | 11 +++ 3 files changed, 29 insertions(+) diff --git a/lib/librte_eal/common/eal_common_soc.c b/lib

[dpdk-dev] [PATCH v1 14/28] eal/soc: detect assigned kernel driver

. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/include/rte_soc.h | 2 ++ lib/librte_eal/linuxapp/eal/eal_soc.c | 28 2 files changed, 30 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/librte_eal/common/include/rte_soc.h index

[dpdk-dev] [PATCH v1 15/28] eal/soc: map/unmap resources

Signed-off-by: Jan Viktorin --- lib/librte_eal/bsdapp/eal/eal_soc.c | 12 ++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_soc.c | 13 +++ lib/librte_eal/common/include/rte_soc.h | 50 + lib

[dpdk-dev] [PATCH v1 16/28] eal/soc: add intr_handle

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/include/rte_soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/librte_eal/common/include/rte_soc.h index 3192121..4b4789b 100644 --- a/lib/librte_eal/common/include/rte_soc.h +++ b/lib

[dpdk-dev] [PATCH v1 17/28] eal/soc: hack (const char *) compatible setting

The strict GCC rules do not allow to set the rte_soc_addr.compatible as it is marked 'const'. However, we need it to be const because drivers will set it statically by const strings. So this hack enables both. Is there a better way to go? Signed-off-by: Jan Viktorin --- lib/librte_

[dpdk-dev] [PATCH v1 18/28] eal/soc: detect numa_node of the rte_soc_device

No idea whether this is useful. Who creates the numa_node in the sysfs? This can be probably dropped later. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_soc.c | 8 lib/librte_eal/common/include/rte_soc.h | 1 + lib/librte_eal/linuxapp/eal/eal_soc.c | 26

[dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags

The flags are copied from the PCI ones. They should be refactorized into a general set of flags in the future. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/include/rte_soc.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib

[dpdk-dev] [PATCH v1 20/28] eal/soc: map resources conditionally

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_soc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/eal_common_soc.c b/lib/librte_eal/common/eal_common_soc.c index af4daa5..d178c48 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v1 21/28] eal/soc: unbind kernel driver on probe

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_soc.c | 6 ++ lib/librte_eal/common/eal_private.h| 10 ++ lib/librte_eal/linuxapp/eal/eal_soc.c | 11 +++ 3 files changed, 27 insertions(+) diff --git a/lib/librte_eal/common/eal_common_soc.c b/lib

[dpdk-dev] [PATCH v1 22/28] eal/soc: detect DMA non-coherent devices

hould be used here. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_soc.c | 8 lib/librte_eal/common/include/rte_soc.h | 3 +++ lib/librte_eal/linuxapp/eal/eal_soc.c | 24 3 files changed, 35 insertions(+) diff --git a/lib/librte_eal/c

[dpdk-dev] [PATCH v1 23/28] eal: define macro container_of

Signed-off-by: Jan Viktorin --- lib/librte_eal/common/include/rte_common.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 332f2a4..a9b6792 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v1 24/28] ether: utilize container_of for pci_drv

It is not necessary to place the rte_pci_driver at the beginning of the rte_eth_dev struct anymore as we use the container_of macro to get the parent pointer. Signed-off-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 2 +- 2 files changed, 3

[dpdk-dev] [PATCH v1 25/28] ether: verify we copy info from a PCI device

Signed-off-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 5474523..0b0dcbc 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -3077,6

[dpdk-dev] [PATCH v1 26/28] ether: extract function eth_dev_get_intr_handle

We abstract access to the intr_handle here as we want to get it either from the pci_dev or soc_dev. Signed-off-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether

[dpdk-dev] [PATCH v1 27/28] ether: extract function eth_dev_get_driver_name

Signed-off-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 9378a4a..4af2e5f 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

Signed-off-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 127 +- lib/librte_ether/rte_ethdev.h | 31 +++ 2 files changed, 157 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

On Fri, 06 May 2016 16:01:08 +0200 Thomas Monjalon wrote: > 2016-05-06 12:48, Jan Viktorin: > > --- /dev/null > > +++ b/app/test/resource.h > > @@ -0,0 +1,61 @@ > > +/*- > > + * BSD LICENSE > [...] > > + */ > > Please include a multi-line

[dpdk-dev] [PATCH v1 02/10] app/test: support resources externally linked

or comments. I will fix those and come back with something better. > > 2016-05-06 12:48, Jan Viktorin: > > --- a/app/test/Makefile > > +++ b/app/test/Makefile > > @@ -33,6 +33,37 @@ include $(RTE_SDK)/mk/rte.vars.mk > > > > ifeq ($(CONFIG_RTE_APP_TEST),y)

[dpdk-dev] [PATCH v1 02/10] app/test: support resources externally linked

urce framework"? Regards Jan -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

On Fri, 06 May 2016 16:01:08 +0200 Thomas Monjalon wrote: > 2016-05-06 12:48, Jan Viktorin: > > --- /dev/null > > +++ b/app/test/resource.h > > @@ -0,0 +1,61 @@ > > +/*- > > + * BSD LICENSE > [...] > > + */ > > Please include a multi-line

[dpdk-dev] [PATCH] armv7a: disable qede pmd

:39: error: variable ?pbl_size? set but not used [-Werror=unused-but-set-variable] u32 page_cnt = p_chain->page_cnt, i, pbl_size; Fixes: 3eae93a9bfd5 ("qede: enable PMD build") Signed-off-by: Jan Viktorin --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 + 1 file chan

[dpdk-dev] [PATCH 00/15] Make VFIO support independent on PCI

Hello Santosh, On Tue, 10 May 2016 17:48:23 +0530 Santosh Shukla wrote: > On Fri, Apr 29, 2016 at 7:14 PM, Jan Viktorin > wrote: > > > > Hello, > > > > here follows several patchs extracting the general VFIO code out of the > > PCI + VFIO code base. U

[dpdk-dev] [PATCH 15/15] vfio: change VFIO init to be extendable

Hello Anatoly, On Tue, 10 May 2016 11:50:23 + "Burakov, Anatoly" wrote: > Hi Jan, > > > We can now just OR the vfio_enabled sequentially and so adding new VFIO > > subsystems (vfio_platform) is possible. > > > > Signed-off-by: Jan Viktorin > &

[dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c

e > > +value in > > + * case the given device cannot be managed this way. > > + */ > > I think it would've been good to fix the typo in the comment ("indentified") > :) Ok. Regards Jan > > Thanks, > Anatoly -- Jan ViktorinE-mail: Viktorin at RehiveTech.com System ArchitectWeb:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

ng things around. I can't find any > viability checks in eal_vfio.c Thanks for this catch, I'll check. I've rebased the patch set once because there were some changes to the original VFIO code. Hope for no more such rebasing. Regards Jan > > Thanks, > Anatoly -- Jan ViktorinE-mail: Viktorin at RehiveTech.com System ArchitectWeb:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

On Tue, 10 May 2016 14:58:26 +0200 Jan Viktorin wrote: > On Tue, 10 May 2016 11:53:21 + > "Burakov, Anatoly" wrote: > > > Hi Jan, > > > > > > > /* > > > - * at this point, we know at least one port on this device is bound to

[dpdk-dev] [PATCH v2 00/11] Include resources in tests

ppc) * few random bits (usually suggested by T. Monjalon) * included a note about the new dependency libarchive in the particular commit Jan Viktorin (11): app/test: introduce resources for tests mk: define objcopy-specific target and arch app/test: support resources externally linked app

[dpdk-dev] [PATCH v2 01/11] app/test: introduce resources for tests

tests of simple resources is included. Signed-off-by: Jan Viktorin --- v2: * added comments * resource_size is not inline anymore * REGISTER_RESOURCE is a single macro now * fixed double constructor declaration * __resource_register renamed to resource_register * less number of underscores

[dpdk-dev] [PATCH v2 02/11] mk: define objcopy-specific target and arch

The program objcopy uses non-standard conventions to name the target and arch. Define the values for supported architectures. FIXME: tile and ppc_64 are not present. Signed-off-by: Jan Viktorin --- mk/arch/arm/rte.vars.mk | 5 + mk/arch/arm64/rte.vars.mk | 5 + mk/arch/i686

[dpdk-dev] [PATCH v2 03/11] app/test: support resources externally linked

end_; (extern const char siz_;) A unit test that packs the resource.c source file is included. Signed-off-by: Jan Viktorin --- v2: * macro resource renamed to linked_resource and documented * the linking principle is better explained now --- app/test/Makefile| 19 +++ app

[dpdk-dev] [PATCH v2 04/11] app/test: add functions to create files from resources

A resource can be written into the target filesystem by calling resource_fwrite or resource_fwrite_file. Such file can be created before a test is started and removed after the test finishes. Signed-off-by: Jan Viktorin --- app/test/resource.c | 35 +++ app

[dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers

The test unregisters all real drivers before starting into an array. This inflexiable as we can use a linked list for this purpose. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/app/test/test_pci.c b

[dpdk-dev] [PATCH v2 05/11] app/test: support resources archived by tar

patch introduces functions resource_untar and resource_rm_by_tar to perform those tasks. An example of using those functions is included as a test. A new dependency is required to build the app/test: libarchive. Signed-off-by: Jan Viktorin --- v2: * mentioned the libarchive dependency in commit log

[dpdk-dev] [PATCH v2 07/11] app/test: extract test_pci_setup and test_pci_cleanup

Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cf82373..9d53ba5 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c

[dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case

The current test_pci is just a single test case that tests the blacklisting of devices. Rename it to test_pci_blacklist and call it from the test_pci. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 85 + 1 file changed, 47 insertions

[dpdk-dev] [PATCH v2 09/11] eal/pci: replace SYSFS_PCI_DEVICES with pci_get_sysfs_path()

now possible to create a fake sysfs hierarchy for testing. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 28 + drivers/net/szedata2/rte_eth_szedata2.c | 2 +- drivers/net/virtio/virtio_pci.c | 2 +- lib

[dpdk-dev] [PATCH v2 11/11] app/test: do not dump PCI devices in blacklist test

Dumping of devices in a unittest is useless. Instead, test whether the test has been set up well - i.e. there are no devices. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c

[dpdk-dev] [PATCH v2 10/11] app/test: scan PCI bus using a fake sysfs

Scan the PCI bus by providing a fake sysfs with a PCI device. The fake sysfs is a packed file hierarchy linked into the test. Signed-off-by: Jan Viktorin --- app/test/Makefile | 1 + app/test/test_pci.c| 58

[dpdk-dev] [dpdk-dev, 2/3] eth_dev: add support for device dma mask

/**< NUMA node connection */ > const char *drv_name; /**< Driver name */ > + uint64_t dma_mask; /** device supported address space range */ > }; > > /** Device supports hotplug detach */ -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

On Thu, 12 May 2016 16:58:31 +0200 Thomas Monjalon wrote: > 2016-05-06 18:20, Jan Viktorin: > > On Fri, 06 May 2016 16:01:08 +0200 > > Thomas Monjalon wrote: > > > 2016-05-06 12:48, Jan Viktorin: > > > > +static struct resource linkres_ ##_n = {

[dpdk-dev] [dpdk-dev,3/3] nfp: set device dma mask

counters values */ > nfp_net_stats_reset(eth_dev); > > + /* Setting dma_mask */ > + eth_dev->data->dma_mask = DMA_BIT_MASK(40); Can we read this from /sys/bus/pci/devices/*/dma_mask_bits? I am not sure whether is this generic enough but I can see dma_mask

[dpdk-dev] [dpdk-dev, 1/3] eal/linux: add function for checking hugepages within device supported address range

" > + " mask 0x%"PRIx64"\n", physaddr, dma_mask); > + if (physaddr & ~dma_mask) { > + RTE_LOG(ERR, EAL, "Allocated hugepages are out of > device address" > +

[dpdk-dev] [dpdk-dev,3/3] nfp: set device dma mask

On Thu, 12 May 2016 16:13:55 +0100 Alejandro Lucero wrote: > On Thu, May 12, 2016 at 4:03 PM, Jan Viktorin > wrote: > > > On Thu, 12 May 2016 15:34:00 +0100 > > "Alejandro.Lucero" wrote: > > > > > - Just hugepages within the supported range wi

[dpdk-dev] [PATCH v2 01/11] app/test: introduce resources for tests

On Thu, 12 May 2016 17:19:21 +0200 Thomas Monjalon wrote: > 2016-05-10 20:13, Jan Viktorin: > > +REGISTER_TEST_COMMAND(resource_cmd); > > Should you add this test in group 1 of autotest_data.py? Will do for v3. This way: ...

[dpdk-dev] [dpdk-dev, 2/3] eth_dev: add support for device dma mask

Hi, Just a note, please, when replying inline, do not prepend ">" before your new text. I could not find your replies. See below... On Thu, 12 May 2016 16:03:14 +0100 Alejandro Lucero wrote: > Hi Jan > > On Thu, May 12, 2016 at 3:52 PM, Jan Viktorin > wrot

[dpdk-dev] [PATCH v2 09/11] eal/pci: replace SYSFS_PCI_DEVICES with pci_get_sysfs_path()

On Thu, 12 May 2016 17:41:22 +0200 Thomas Monjalon wrote: > 2016-05-10 20:13, Jan Viktorin: > > The SYSFS_PCI_DEVICES is a constant that makes the PCI testing difficult as > > it points to an absolute path. We remove using this constant and introducing > > a function pc

[dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers

On Thu, 12 May 2016 17:31:28 +0200 Thomas Monjalon wrote: > 2016-05-10 20:13, Jan Viktorin: > > The test unregisters all real drivers before starting into an array. This > > inflexiable as we can use a linked list for this purpose. > > I don't understand this. Ma

[dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers

On Thu, 12 May 2016 18:08:16 +0200 Thomas Monjalon wrote: > 2016-05-12 17:53, Jan Viktorin: > > On Thu, 12 May 2016 17:31:28 +0200 > > Thomas Monjalon wrote: > > > > > 2016-05-10 20:13, Jan Viktorin: > > > > The test unregisters all real drivers be

[dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case

On Thu, 12 May 2016 17:34:13 +0200 Thomas Monjalon wrote: > 2016-05-10 20:13, Jan Viktorin: > > The current test_pci is just a single test case that tests the blacklisting > > of devices. Rename it to test_pci_blacklist and call it from the test_pci. > > The functions

[dpdk-dev] [PATCH v2 09/11] eal/pci: replace SYSFS_PCI_DEVICES with pci_get_sysfs_path()

On Thu, 12 May 2016 18:10:07 +0200 Thomas Monjalon wrote: > 2016-05-12 17:46, Jan Viktorin: > > On Thu, 12 May 2016 17:41:22 +0200 > > Thomas Monjalon wrote: > > > 2016-05-10 20:13, Jan Viktorin: > > > > + orig = pci_get_sysfs_path(); > > &

[dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c

Self review: * missing #ifdef VFIO_PRESENT ... #endif in eal_vfio.c leads to fail when VFIO build is disabled Jan On Fri, 29 Apr 2016 15:44:12 +0200 Jan Viktorin wrote: > The vfio_cfg is a module-global variable and so together with this > variable, it is necessary to move fun

[dpdk-dev] What is the status of mempool manager?

May/038486.html Any idea how to start with this? Regards Jan -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] What is the status of mempool manager?

Hello Olivier... On Tue, 17 May 2016 15:56:32 +0200 Olivier MATZ wrote: > Hi Jan, > > On 05/17/2016 02:34 PM, Jan Viktorin wrote: > > Hello, > > > > I was trying to find out the status of the mempool rework and found > > this 36-pieces long patch set: > &

[dpdk-dev] [PATCH v1 09/28] eal: introduce --no-soc option

On Fri, 13 May 2016 11:28:18 +0800 Jianbo Liu wrote: > On 6 May 2016 at 21:47, Jan Viktorin wrote: > > This option has the same meaning for the SoC infra as the --no-pci > > for the PCI infra. > > > > Signed-off-by: Jan Viktorin > > --- > > lib/lib

[dpdk-dev] [PATCH v1 03/28] eal/linux: extract function rte_eal_unbind_kernel_driver

On Fri, 13 May 2016 09:22:23 +0800 Jianbo Liu wrote: > On 6 May 2016 at 21:47, Jan Viktorin wrote: > > Generalize the PCI-specific pci_unbind_kernel_driver. It is now divided into > > two parts. First, determination of the path and string identification of the > > device

[dpdk-dev] [PATCH v3 00/11] Include resources in tests

(usually suggested by T. Monjalon) * included a note about the new dependency libarchive in the particular commit v3: * resource_autotest added to autotest_data.py * improved test of affecting pci_get_sysfs_path() by setenv * few other bits... --- Jan Viktorin (11): app/test: introduce resources for

[dpdk-dev] [PATCH v3 01/11] app/test: introduce resources for tests

tests of simple resources is included and added into the group_1. Signed-off-by: Jan Viktorin --- v3: * fixed doc comments --- app/test/Makefile | 2 + app/test/autotest_data.py | 6 +++ app/test/resource.c | 66 +++ app/test/resource.h | 98

[dpdk-dev] [PATCH v3 02/11] mk: define objcopy-specific target and arch

The program objcopy uses non-standard conventions to name the target and arch. Define the values for supported architectures. FIXME: tile and ppc_64 are not present. Signed-off-by: Jan Viktorin --- mk/arch/arm/rte.vars.mk | 5 + mk/arch/arm64/rte.vars.mk | 5 + mk/arch/i686

[dpdk-dev] [PATCH v3 03/11] app/test: support resources externally linked

end_; (extern const char siz_;) A unit test that packs the resource.c source file is included. Signed-off-by: Jan Viktorin --- app/test/Makefile| 19 +++ app/test/resource.h | 10 ++ app/test/test_resource.c | 18 ++ 3 files changed, 47

[dpdk-dev] [PATCH v3 04/11] app/test: add functions to create files from resources

A resource can be written into the target filesystem by calling resource_fwrite or resource_fwrite_file. Such file can be created before a test is started and removed after the test finishes. Signed-off-by: Jan Viktorin --- app/test/resource.c | 35 +++ app

[dpdk-dev] [PATCH v3 05/11] app/test: support resources archived by tar

patch introduces functions resource_untar and resource_rm_by_tar to perform those tasks. An example of using those functions is included as a test. A new dependency is required to build the app/test: libarchive. Signed-off-by: Jan Viktorin --- app/test/Makefile| 9 +++ app/test/resource.c

[dpdk-dev] [PATCH v3 06/11] app/test: use linked list to store PCI drivers

The test unregisters all drivers before start. The drivers were stored into a fixed-sized array. This is inflexible. This patch change this to utilize a linked list for the same purpose. Signed-off-by: Jan Viktorin --- v3: * fixed commit message * used "backup" to de

[dpdk-dev] [PATCH v3 07/11] app/test: extract test_pci_setup and test_pci_cleanup

Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index 8b7c8bb..50078a0 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c

<    1   2   3   4   5   6   7   >