[dpdk-dev] vhost: Problem RESET_OWNER processing

2015-08-07 Thread Jan Kiszka
Hi, I was wondering if I'm alone with this: the vhost-switch example crashes on client disconnects if the client send a RESET_OWNER message. That's at least the case for QEMU and vhost-user mode (I suppose vhost-cuse is legacy now). And it really ruins the party when playing with this because ever

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-08-07 Thread Jan Kiszka
On VHOST_*_RESET_OWNER, we reinitialize the device but without telling the application. That will cause crashes when it continues to invoke vhost services on the device. Fix it by calling the destruction hook if the device is still in use. Signed-off-by: Jan Kiszka --- This is the surprisingly

[dpdk-dev] vhost-switch example: huge memory need and CRC off-loading issue

2015-08-07 Thread Jan Kiszka
Hi again, two findings in the vhost-switch example code that can cause grey hair for starters: - MAX_QUEUES of 512 causes pretty high memory need for the application (something between 1 and 2G) - is that really needed? I'm now running with 32, and I'm able to get away with 256M. Can we tune

[dpdk-dev] vhost: Problem RESET_OWNER processing

2015-08-08 Thread Jan Kiszka
On 2015-08-08 02:04, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Kiszka >> Sent: Friday, August 7, 2015 10:04 PM >> To: dev at dpdk.org; Xie, Huawei >> Subject: [dpdk-dev] vhost: Pro

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-08-08 Thread Jan Kiszka
On 2015-08-08 02:25, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Kiszka >> Sent: Saturday, August 8, 2015 1:21 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] vchost: No

[dpdk-dev] vhost-switch example: huge memory need and CRC off-loading issue

2015-08-08 Thread Jan Kiszka
On 2015-08-08 02:39, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Kiszka >> Sent: Saturday, August 8, 2015 1:31 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] vhost-switch e

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-08-10 Thread Jan Kiszka
On 2015-08-10 03:20, Ouyang, Changchun wrote: >> -Original Message- >> From: Jan Kiszka [mailto:jan.kiszka at siemens.com] >> Sent: Saturday, August 8, 2015 2:43 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] vchost: N

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-08-12 Thread Jan Kiszka
On 2015-08-12 05:34, Xie, Huawei wrote: > On 8/8/2015 1:21 AM, Jan Kiszka wrote: >> On VHOST_*_RESET_OWNER, we reinitialize the device but without telling >> the application. That will cause crashes when it continues to invoke >> vhost services on the device. Fix it by calling

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2016-03-17 Thread Jan Kiszka
On 2016-03-17 15:42, Thomas Monjalon wrote: > 2015-08-07 19:20, Jan Kiszka: >> On VHOST_*_RESET_OWNER, we reinitialize the device but without telling >> the application. That will cause crashes when it continues to invoke >> vhost services on the device. Fix it by calling th