[dpdk-dev] [PATCH v4 14/15] test/crypto: add raw API test for dpaax

2021-10-13 Thread Hemant Agrawal
This patch add support for raw API tests for dpaa_sec and dpaa2_sec platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 116 +++--- 1 file changed, 109 insertions(+), 7 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v4 04/15] crypto: fix raw process for multi-seg case

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh If no next segment available the “for” loop will fail and it still returns i+1 i.e. 2, which is wrong as it has filled only 1 buffer. Fixes: 7adf992fb9bf ("cryptodev: introduce CPU crypto API") Cc: marcinx.smoczyn...@intel.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep S

[dpdk-dev] [PATCH v4 10/15] crypto/dpaa2_sec: enhance error checks with raw buffer APIs

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves error conditions and support of Wireless algos with raw buffers. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 - 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dp

[dpdk-dev] [PATCH v4 09/15] crypto/dpaa2_sec: support OOP with raw buffer API

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh add support for out of order processing with raw vector APIs. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 156 +++- 2 files changed, 116 insertions(+), 41 deletions(-

[dpdk-dev] [PATCH v4 07/15] crypto/dpaa2_sec: support AUTHENC with raw buffer APIs

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh This patch supports AUTHENC with raw buufer APIs Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 128 ++-- 1 file changed, 121 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drive

[dpdk-dev] [PATCH v4 06/15] crypto/dpaa2_sec: support AUTH only with raw buffer APIs

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh Auth only with raw buffer APIs has been supported in this patch. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 21 drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 114 ++-- 2 files changed, 108 insertions(+), 27 delet

[dpdk-dev] [PATCH v4 13/15] crypto/dpaa_sec: support AEAD and proto with raw APIs

2021-10-13 Thread Hemant Agrawal
From: Gagandeep Singh This add support for AEAD and proto offload with raw APIs for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 293 ++ 1 file changed, 293 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_raw_d

Re: [dpdk-dev] [PATCH v4 02/15] crypto: add total raw buffer length

2021-10-17 Thread Hemant Agrawal
Hi Fan On 10/14/2021 6:09 PM, Zhang, Roy Fan wrote: Hi Hemant, I still think it is enough to use rte_crypto_vec as well as rte_crypto_sym_ofs is enough to describe the data including both the data and aad. Imagine 2 10 bytes segments case, encryption/hash size of 12 and aad of 8. We will have

Re: [dpdk-dev] [PATCH v4 05/14] drivers/event: invoke probing finish function

2021-10-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 01/14] eventdev: make driver interface as internal

2021-10-17 Thread Hemant Agrawal
For dpaax Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v5 00/15] crypto: add raw vector support in DPAAx

2021-10-17 Thread Hemant Agrawal
rypto/dpaa_sec: support AEAD and proto with raw APIs Hemant Agrawal (4): crypto: change sgl to src_sgl in vector crypto: add dest_sgl in raw vector APIs test/crypto: add raw API test for dpaax test/crypto: add raw API support in 5G algos app/test/test_cryptodev.c | 179 +++-

[dpdk-dev] [PATCH v5 01/15] crypto: change sgl to src_sgl in vector

2021-10-17 Thread Hemant Agrawal
This patch renames the sgl to src_sgl to help differentiating between source and destination sgl. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 6 ++--- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12

[dpdk-dev] [PATCH v5 02/15] crypto: add total raw buffer length

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh The current crypto raw data vectors is extended to support rte_security usecases, where we need total data length to know how much additional memory space is available in buffer other than data length so that driver/HW can write expanded size data after encryption. Signed-o

[dpdk-dev] [PATCH v5 03/15] crypto: add dest_sgl in raw vector APIs

2021-10-17 Thread Hemant Agrawal
The structure rte_crypto_sym_vec is updated to add dest_sgl to support out of place processing. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_21_11.rst | 5 - lib

[dpdk-dev] [PATCH v5 04/15] crypto: fix raw process for multi-seg case

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh If no next segment available the “for” loop will fail and it still returns i+1 i.e. 2, which is wrong as it has filled only 1 buffer. Fixes: 7adf992fb9bf ("cryptodev: introduce CPU crypto API") Cc: marcinx.smoczyn...@intel.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep S

[dpdk-dev] [PATCH v5 05/15] crypto/dpaa2_sec: support raw datapath APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This path add framework for raw API support. The initial patch only test cipher only part. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 13 +- drivers

[dpdk-dev] [PATCH v5 06/15] crypto/dpaa2_sec: support AUTH only with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh Auth only with raw buffer APIs has been supported in this patch. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 21 drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 114 ++-- 2 files changed, 108 insertions(+), 27 delet

[dpdk-dev] [PATCH v5 07/15] crypto/dpaa2_sec: support AUTHENC with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch supports AUTHENC with raw buufer APIs Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 128 ++-- 1 file changed, 121 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drive

[dpdk-dev] [PATCH v5 08/15] crypto/dpaa2_sec: support AEAD with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh add raw vector API support for AEAD algos. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 249 +--- 1 file changed, 214 insertions(+), 35 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drivers/cr

[dpdk-dev] [PATCH v5 09/15] crypto/dpaa2_sec: support OOP with raw buffer API

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh add support for out of order processing with raw vector APIs. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 156 +++- 2 files changed, 116 insertions(+), 41 deletions(-

[dpdk-dev] [PATCH v5 10/15] crypto/dpaa2_sec: enhance error checks with raw buffer APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves error conditions and support of Wireless algos with raw buffers. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 - 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dp

[dpdk-dev] [PATCH v5 11/15] crypto/dpaa_sec: support raw datapath APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch add raw vector API framework for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/dpaa_sec/dpaa_sec.c| 23 +- drivers/crypto/dpaa_sec/dpaa_sec.h| 39 +- drivers/crypto/dpaa_s

[dpdk-dev] [PATCH v5 12/15] crypto/dpaa_sec: support authonly and chain with raw APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves the raw vector support in dpaa_sec driver for authonly and chain usecase. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.h| 3 +- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 296 +- 2 files changed, 28

[dpdk-dev] [PATCH v5 13/15] crypto/dpaa_sec: support AEAD and proto with raw APIs

2021-10-17 Thread Hemant Agrawal
From: Gagandeep Singh This add support for AEAD and proto offload with raw APIs for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 293 ++ 1 file changed, 293 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_raw_d

[dpdk-dev] [PATCH v5 14/15] test/crypto: add raw API test for dpaax

2021-10-17 Thread Hemant Agrawal
This patch add support for raw API tests for dpaa_sec and dpaa2_sec platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 116 +++--- 1 file changed, 109 insertions(+), 7 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v5 15/15] test/crypto: add raw API support in 5G algos

2021-10-17 Thread Hemant Agrawal
This patch add support for RAW API testing with ZUC and SNOW test cases. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 57 ++- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/app/test

RE: [PATCH 1/4] net/dpaa2: update mc to 10.32

2022-05-10 Thread Hemant Agrawal
Hi Ferruh, I am ok for it. You can add: Acked-by: Hemant Agrawal > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, May 10, 2022 6:22 PM > To: Gagandeep Singh ; dev@dpdk.org; Hemant Agrawal > ; Sachin Saxena (OSS) > > Cc: Rohit Raj > Subj

Re: [PATCH v3 0/6] move DPAA2 QDMA driver freom raw to dma

2022-05-25 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 5/5/2022 2:35 PM, nipun.gu...@nxp.com wrote: From: Nipun Gupta This change removes the DPAA2 QDMA raw driver and adds the QDMA driver in dma set of drivers. The underlying I/O framework remains intact, whereas the configuration part is done as per the DMA API

Re: [PATCH v1] bbdev: add new operation for FFT processing

2022-05-25 Thread Hemant Agrawal
the la12xx PMD but would be good to get review/feedback. This can be used for vanilla FFT and/or chained FFT/iFFT + point-wise multiplication making it applicable for SRS processing. Thanks, Nic Acked-by:  Hemant Agrawal HI Nicolas,     Yes, I had a look into it.  I see no issue in it. This is

Re: [PATCH] maintainers: update for nxp devices

2022-06-02 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 6/3/2022 11:20 AM, nipun.gu...@nxp.com wrote: From: Nipun Gupta Update and add maintainers for NXP devices and RAW device API Signed-off-by: Nipun Gupta --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [PATCH v2 0/4] clean up zero-length arrays

2022-06-02 Thread Hemant Agrawal
Series- Acked-by:  Hemant Agrawal On 6/2/2022 9:43 PM, Bruce Richardson wrote: This patchset adds a coccinelle script to clean-up zero-length arrays in structures. The final patches are the result of running that script on the DPDK repository. V2: rebased to fix apply conflict Bruce

Re: [dpdk-dev] [PATCH v2] test/crypto-perf: support lookaside IPsec

2021-10-20 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 10/9/2021 1:45 AM, Akhil Goyal wrote: Added support for lookaside IPsec protocol offload. Supported cases: -AEAD -Cipher+auth Command used for testing: ./dpdk-test-crypto-perf -c 0xf -- --devtype crypto_octeontx2 --ptest throughput --optype ipsec --cipher-algo aes

Re: [dpdk-dev] [PATCH v3 0/8] crypto/security session framework rework

2021-10-20 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Tuesday, October 19, 2021 3:05 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Hemant Agrawal > ; ano...@marvell.com; > pablo.de.

Re: [dpdk-dev] [PATCH v6 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-20 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal > -Original Message- > From: Apeksha Gupta > Sent: Thursday, October 21, 2021 10:17 AM > To: david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Ag

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-08 Thread Hemant Agrawal
t;>> + */ > >>> + > >> > >> Only sfc has that blank line between SPDX tag and Copyright, is it > >> intentional? > > > > As far as I remember it is not intentional. Just coincident and may be > > definitely fixed in vdpa/sfc. > >

[dpdk-dev] Minutes of Technical Board Meeting, 2021-08-25

2021-09-10 Thread Hemant Agrawal
Minutes of Technical Board Meeting, 2021-08-25 Members Attending: 11/12 - Aaron Conole - Bruce Richardson - Ferruh Yigit - Hemant Agrawal (Chair) - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Thomas Monjalon NOTE

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-13 Thread Hemant Agrawal
HI Maxime, > > On 9/1/21 4:54 PM, Chautru, Nicolas wrote: > > > > > >> -Original Message- > >> From: Kinsella, Ray > >> Sent: Wednesday, September 1, 2021 4:15 AM > >> To: Hemant Agrawal ; David Marchand > >> ; Chautru,

Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation

2021-09-16 Thread Hemant Agrawal
th_dev)) + return -ENOMEM; +#endif Hi Hemant, I see 'RTE_LIB_SECURITY' is still used in some PMDs, as this new PMD also uses it? Previously I assume this macro was to mark that security library is enabled, is this macro still valid? Who should set this macro now? Also can you pleas

Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation

2021-09-16 Thread Hemant Agrawal
On 9/8/2021 2:07 PM, Jiawen Wu wrote: Initialize securiry context, and support to get security capabilities. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/meson.build | 3 +- drivers/net/ngbe/ngbe_ethdev.c| 10 ++ drivers/net/ngbe/ng

Re: [dpdk-dev] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument

2021-09-16 Thread Hemant Agrawal
VAL */ } static inline void core_stats_update_drop(int n) { -#if (STATS_INTERVAL > 0) int lcore_id = rte_lcore_id(); core_statistics[lcore_id].dropped += n; -#else - RTE_SET_USED(n); -#endif /* STATS_INTERVAL */ } /* helper routine to free bulk of packets */ Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 02/15] crypto: add total raw buffer length

2021-09-21 Thread Hemant Agrawal
Hi Konstantin On 9/21/2021 12:58 AM, Akhil Goyal wrote: From: Gagandeep Singh The current crypto raw data vectors is extended to support rte_security usecases, where we need total data length to know how much additional memory space is available in buffer other than data length so that driver/

Re: [dpdk-dev] [PATCH v4 2/5] test/crypto: add combined mode tests

2021-09-24 Thread Hemant Agrawal
HI Anoob, On 9/17/2021 6:45 PM, Anoob Joseph wrote: Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-24 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-24 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 01/10] security: add support for TSO on IPsec session

2021-09-24 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

2021-09-24 Thread Hemant Agrawal
On 9/6/2021 4:39 PM, Nicolau, Radu wrote: On 9/5/2021 3:19 PM, Akhil Goyal wrote: Hi Radu, Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckle

Re: [dpdk-dev] [PATCH v2 02/15] crypto: add total raw buffer length

2021-09-28 Thread Hemant Agrawal
gt; > protocol > > > > support. > > > > > Yes, total length is representing the total buffer length > > > > > available. The security protocol shall take care of the headroom and > offsets. > > > > > > > > Hmm, and how it will now how many bytes are in head-room, and how > > > > many are in tail-room? > > > > We either need to provide values for both, or assume that only > > > > tail-room > > is > > > > available for the driver. > > > I believe it should be starting point where output can be written > > > till the end > > of buffer. > > > > Right, that's: > > base = rte_pktmbuf_mtod_offset(mb, void *, ofs); > > > > > There should not be any headroom and tailroom for raw buffers. > > > > I am not talking about raw buffers, what I am saying that some space > > in the mbuf might be already occupied, that's why we have data_off > > inside rte_mbuf, etc. > > > > > It should be mbuf->buf_len - ofs. > > > > No, it should be: > > len = mb->buf_len - rte_pktmbuf_headroom(m) - ofs; Otherwise PMD can > > overwrite memory beyond its buf_len. > > > @Hemant: Do you agree. Please send next version. [Hemant] [Hemant] Yes, I will send the new version

[dpdk-dev] [PATCH 0/7] NXP DPAAx fixes and improvements

2021-07-19 Thread Hemant Agrawal
This series add few minor fixes and enhancements for the NXP DPAAx drivers. Hemant Agrawal (3): bus/dpaa: fix to use right type of memory free bus/dpaa: reduce syscall usages doc: remove SDK info form individual dev guides Nipun Gupta (2): net/dpaa: fix headroom in VSP case net/dpaa2

[dpdk-dev] [PATCH 1/7] bus/dpaa: fix to use right type of memory free

2021-07-19 Thread Hemant Agrawal
if was allocated with rte_malloc, free shall be equivalent. Fixes: 4762b3d419c3 ("bus/dpaa: delay fman device list to bus probe") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 2/7] net/dpaa: fix headroom in VSP case

2021-07-19 Thread Hemant Agrawal
From: Nipun Gupta This patch fixes providing the correct headroom size when VSP is enabled. Fixes: e4abd4ff183c ("net/dpaa: support virtual storage profile") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(

[dpdk-dev] [PATCH 3/7] bus/dpaa: reduce syscall usages

2021-07-19 Thread Hemant Agrawal
Reuse dpdk rte_gettid instead of syscall. It will help to reduce the dpaa portal allocation time. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 3 +-- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 9 - 2 files changed, 5 insertions(+), 7 deletions(-) diff

[dpdk-dev] [PATCH 4/7] net/dpaa: add check for parsing default Rx queue

2021-07-19 Thread Hemant Agrawal
From: Rohit Raj Add check for the PCD queue from the kernel interface for default and error queues. Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 16 +++- drivers/bus/dpaa/include/fman.h | 7 +-- drivers/net/dpaa/dpaa_fmc.c

[dpdk-dev] [PATCH 5/7] net/dpaa2: add per thread init PMD API

2021-07-19 Thread Hemant Agrawal
From: Nipun Gupta DPAA2 hardware require a hardware portal context. If a thread doing DPAA2 i/o do not have portal, it will allocate it on run-time. This may cause a delay in the datapath at run-time. To avoid it, it is better to allocate a hw context portal at the start of thread expected to do

[dpdk-dev] [PATCH 6/7] net/dpaa2: add input validation

2021-07-19 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds validation of the port id for rte_pmd_dpaa2_set_custom_hash API to check if the port is a valid DPAA2 port. Also handles some edge cases in the rte_pmd_dpaa2_mux_flow_create API. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/net

[dpdk-dev] [PATCH 7/7] doc: remove SDK info form individual dev guides

2021-07-19 Thread Hemant Agrawal
The prerequisite info is already present in the platform guide. No need to repeat it in individual dev guides. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 6 -- doc/guides/eventdevs/dpaa2.rst | 6 -- doc/guides/nics/dpaa2.rst | 6 -- doc

[dpdk-dev] [PATCH 1/5] crypto/dpaa2_sec: fix to check next null for auth only case

2021-07-21 Thread Hemant Agrawal
This patch fixes the issue to check for next pointer as null in the integrity only case in pdcp-security context. Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dps

[dpdk-dev] [PATCH 2/5] crypto/dpaa_sec: support DES-CBC

2021-07-21 Thread Hemant Agrawal
From: Gagandeep Singh add DES-CBC support and enable available cipher-only test cases. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/features/dpaa_sec.ini | 1 + drivers/crypto/dpaa_sec/dpaa_sec.c | 13 + drivers/crypto/dpaa_sec/dpaa_sec.h | 20 +++

[dpdk-dev] [PATCH 3/5] crypto/dpaa_sec: support non-HMAC auth algos

2021-07-21 Thread Hemant Agrawal
From: Gagandeep Singh This patch add support for non-HMAC, md5, shax algos. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/features/dpaa_sec.ini | 8 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 55 +++-- drivers/crypto/dpaa_sec/dpaa_sec.h | 126 ++

[dpdk-dev] [PATCH 4/5] crypto/dpaa_sec: support AES-XCBC-MAC

2021-07-21 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support for AES-XCBC-MAC algo. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/features/dpaa_sec.ini | 1 + drivers/crypto/dpaa_sec/dpaa_sec.c | 21 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/doc

[dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: add support for AES CMAC integrity check

2021-07-21 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support for AES_CMAC integrity in non-security mode. This patch modifies the camm flib to handles the AES CMAC without conflicting the proto ALG operations. i.e. by creating another ALG operation routine. Signed-off-by: Gagandeep Singh --- doc/guides/crypt

Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec

2021-07-30 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-02 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: announce cryptodev-PMD interface as internal

2021-08-04 Thread Hemant Agrawal
yal > > Acked-by: Ajit Khaparde > Acked-by: Matan Azrad Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH] doc: announce change in crypto raw data vector

2021-08-05 Thread Hemant Agrawal
memory space is available in buffer other than data length so that driver/HW can write expanded size data after encryption. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/deprecation.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

2021-08-05 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector

2021-08-05 Thread Hemant Agrawal
> > -Original Message- > > From: Hemant Agrawal > > Sent: Thursday, August 5, 2021 9:06 AM > > To: dev@dpdk.org; gak...@marvell.com > > Cc: ano...@marvell.com; Nicolau, Radu ; > > Doherty, Declan ; ma...@nvidia.com; > Ananyev, > > Konstanti

[dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector

2021-08-05 Thread Hemant Agrawal
memory space is available in buffer other than data length so that driver/HW can write expanded size data after encryption. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/deprecation.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc

Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector

2021-08-05 Thread Hemant Agrawal
ping for review. On 8/5/2021 7:25 PM, Hemant Agrawal wrote: The current crypto raw data vectors need to be extended to support out of place processing. It is proposed to add additional desl_sgl to provide details for destination sgl. The same is also extended to support rte_security usecases

Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector

2021-08-06 Thread Hemant Agrawal
Hi Konstantin On 8/6/2021 3:34 PM, Ananyev, Konstantin wrote: Hi Hemant, The current crypto raw data vectors need to be extended to support out of place processing. It is proposed to add additional desl_sgl to provide details for destination sgl. The same is also extended to support

[dpdk-dev] [RFC 00/16] crypto: add raw vector support in DPAAx

2021-08-12 Thread Hemant Agrawal
: enhance error checks with raw buffer APIs crypto/dpaa_sec: support raw datapath APIs crypto/dpaa_sec: support authonly and chain with raw APIs crypto/dpaa_sec: support AEAD and proto with raw APIs Hemant Agrawal (4): crypto: change sgl to src_sgl in vector crypto: add dest_sgl in raw vector

[dpdk-dev] [RFC 01/16] crypto: change sgl to src_sgl in vector

2021-08-12 Thread Hemant Agrawal
This patch renames the sgl to src_sgl to help differentiating between source and destination sgl. Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 6 +++--- drivers/crypto/qat/qat_sym_hw_dp.c | 27 --- lib/cryptodev/rte_crypto_sym.h | 2

[dpdk-dev] [RFC 02/16] crypto: add total raw buffer length

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh The current crypto raw data vectors is extended to support rte_security usecases, where we need total data length to know how much additional memory space is available in buffer other than data length so that driver/HW can write expanded size data after encryption. Signed-o

[dpdk-dev] [RFC 03/16] crypto: add dest_sgl in raw vector APIs

2021-08-12 Thread Hemant Agrawal
The structure rte_crypto_sym_vec is updated to add dest_sgl to support out of place processing. Signed-off-by: Hemant Agrawal --- lib/cryptodev/rte_crypto_sym.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h index e5cef1fb72

[dpdk-dev] [RFC 04/16] crypto: enhance raw process for protocol offload

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves the raw vector processing for security protocol with OOP processing. Signed-off-by: Gagandeep Singh --- lib/cryptodev/rte_crypto_sym.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/

[dpdk-dev] [RFC 05/16] crypto/dpaa2_sec: support raw datapath APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This path add framework for raw API support. The initial patch only test cipher only part. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 13 +- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 60

[dpdk-dev] [RFC 06/16] crypto/dpaa2_sec: support AUTH only with raw buffer APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh Auth only with raw buffer APIs has been supported in this patch. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 21 drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 114 ++-- 2 files changed, 108 insertions(+), 27 delet

[dpdk-dev] [RFC 07/16] crypto/dpaa2_sec: support AUTHENC with raw buffer APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This patch supports AUTHENC with raw buufer APIs Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 128 ++-- 1 file changed, 121 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drive

[dpdk-dev] [RFC 08/16] crypto/dpaa2_sec: support AEAD with raw buffer APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh add raw vector API support for AEAD algos. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 249 +--- 1 file changed, 214 insertions(+), 35 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drivers/cr

[dpdk-dev] [RFC 09/16] crypto/dpaa2_sec: support OOP with raw buffer API

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh add support for out of order processing with raw vector APIs. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 1 + drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 156 +++- 2 files changed, 116 insertions(+), 41 deletions(-

[dpdk-dev] [RFC 10/16] crypto/dpaa2_sec: fix ctx memset size

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh Driver is doing memset on memory more than its allocation. This patch fixes the size of memset. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dp

[dpdk-dev] [RFC 11/16] crypto/dpaa2_sec: enhance error checks with raw buffer APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves error conditions and support of Wireless algos with raw buffers. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 - 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dp

[dpdk-dev] [RFC 12/16] crypto/dpaa_sec: support raw datapath APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This patch add raw vector API framework for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.c| 23 +- drivers/crypto/dpaa_sec/dpaa_sec.h| 39 +- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 485 ++

[dpdk-dev] [RFC 13/16] crypto/dpaa_sec: support authonly and chain with raw APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This patch improves the raw vector support in dpaa_sec driver for authonly and chain usecase. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.h| 3 +- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 296 +- 2 files changed, 28

[dpdk-dev] [RFC 14/16] crypto/dpaa_sec: support AEAD and proto with raw APIs

2021-08-12 Thread Hemant Agrawal
From: Gagandeep Singh This add support for AEAD and proto offload with raw APIs for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 293 ++ 1 file changed, 293 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_raw_d

[dpdk-dev] [RFC 15/16] test/crypto: add raw API test for dpaax

2021-08-12 Thread Hemant Agrawal
This patch add support for raw API tests for dpaa_sec and dpaa2_sec platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 116 +++--- 1 file changed, 109 insertions(+), 7 deletions(-) diff --git a/app/test

[dpdk-dev] [RFC 16/16] test/crypto: enabling raw API support in 5G algos

2021-08-12 Thread Hemant Agrawal
This patch add support for RAW API testing with ZUC and SNOW test cases. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 57 ++- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH 0/7] NXP DPAAx ethernet PMD changes

2021-01-20 Thread Hemant Agrawal
/dpaa2: add traffic management driver Hemant Agrawal (3): net/dpaa2: allocate SGT table from first segment net/dpaa: support external buffers in Tx net/dpaa2: add support to configure dpdmux max Rx frame len Nipun Gupta (1): net/dpaa2: support external buffers in Tx Rohit Raj (1): net

[dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len

2021-01-20 Thread Hemant Agrawal
This patch introduce a new pmd api, which can help the applications to configure the max framelen for a given dpdmux interface Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_mux.c | 28 +++- drivers/net/dpaa2/rte_pmd_dpaa2.h | 18

Re: [dpdk-dev] meson: wrong dependency in cross compilation on ARM

2021-01-22 Thread Hemant Agrawal
Mon, Dec 21, 2020 at 12:19:17PM +, Hemant Agrawal wrote: Hi,   I am trying to cross compile DPDK for arm64 on a ubuntu machine, which has a zlib pre-installed for native env. I am encountering following build error in net_bnx2x as it has dependency on zlib.  It is trying to

Re: [dpdk-dev] [PATCH] build: force pkg-config for dependency detection

2021-01-22 Thread Hemant Agrawal
Tested-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-27 Thread Hemant Agrawal
iSgHBg- > >BTo&s=DFG7a9oFDFczCcODfR0wVGjkLQXwMU19q_ogaFVw90I&e= > >[3] > >https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld > e > >fense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > &data=04%7C01%7Chemant. > >agrawal%40nxp.com%7Cf05a2623ec9347bd254708d8c2d4896c%7C686ea1d > 3bc2b4c6f > >a92cd99c5c301635%7C0%7C0%7C637473565383043785%7CUnknown%7CT > WFpbGZsb3d8e > >yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > D%7C100 > >0&sdata=o7%2BXNileFgI2By08IHvEYPWrDjRikXlfFtal1MCdyCM%3D&a > mp;reserv > >ed=0 > >3A__developer.arm.com_documentation_ka001301_1- > >2D0&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=1cjuAHrGh745jHNm > >j2fD85sUMIJ2IPIDsIJzo6FN6Z0&m=A7kOn5DYMe_WZiykt8BVATgv7- > >qTVhfo4iSgHBg- > >BTo&s=GQsJJuft9k1iooO8VNNIM8ZUUgGjCEPB6eRxN3qm62U&e= > > > >> If the ID mappings are not public then the plaform owners would need > >to > >> add the support, right? > >I agree here. There are firmware changes required and we do not know > >the IDs as well. It will be good for Marvell/NXP/NVIDIA to do this. > >Pavan, is this ok for you? > > Yeah, I believe we need fallback to the current mechanisms if SOC_ID > support is not present or platform owners have not updated them. [Hemant] +1

Re: [dpdk-dev] [PATCH] license: remove exception for old pmdinfogen

2021-02-04 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len

2021-02-04 Thread Hemant Agrawal
HI Ferruh, On 2/2/2021 5:08 PM, Ferruh Yigit wrote: On 1/20/2021 2:27 PM, Hemant Agrawal wrote: This patch introduce a new pmd api, which can help the applications to configure the max framelen for a given dpdmux interface Signed-off-by: Hemant Agrawal <...> +/** + * @warning

Re: [dpdk-dev] [PATCH 6/7] net/dpaa2: add traffic management driver

2021-02-04 Thread Hemant Agrawal
On 2/2/2021 5:11 PM, Ferruh Yigit wrote: On 1/20/2021 2:27 PM, Hemant Agrawal wrote: From: Gagandeep Singh Add basic support for scheduling and shaping on dpaa2 platform. HW supports 2 level of scheduling and shaping. However the current patch only support single level. Signed-off-by

Re: [dpdk-dev] [PATCH 1/7] bus/fslmc: fix to use ci value for qbman 5.0

2021-02-04 Thread Hemant Agrawal
On 2/2/2021 5:06 PM, Ferruh Yigit wrote: On 1/20/2021 2:27 PM, Hemant Agrawal wrote: From: Youri Querry since for qbman 5.0 generally, pi == ci, no need for extra checks. They are causing issue. It would be nice to document the issues, in case users encounter them, they will know this

[dpdk-dev] [PATCH] doc: add tested platforms with NXP SoCs

2021-02-11 Thread Hemant Agrawal
Add tested platforms with NXP SoCs to the 21.02 release notes. Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_21_02.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index

[dpdk-dev] [PATCH] doc: add tested platforms with NXP SoCs

2021-02-11 Thread Hemant Agrawal
Add tested platforms with NXP SoCs to the 21.02 release notes. Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_21_02.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index

[dpdk-dev] [PATCH v2 00/20] NXP DPAAx ethernet PMD changes

2021-02-11 Thread Hemant Agrawal
add TM documentation Akhil Goyal (1): net/dpaa2: add support for raw pattern in dpdmux Apeksha Gupta (1): net/dpaa2: dpdmux skip reset Gagandeep Singh (1): net/dpaa2: add traffic management driver Hemant Agrawal (8): net/dpaa2: allocate SGT table from first segment net/dpaa: support

[dpdk-dev] [PATCH v2 01/20] bus/fslmc: fix to use ci value for qbman 5.0

2021-02-11 Thread Hemant Agrawal
ename portal pi index to consumer index") Cc: sta...@dpdk.org Signed-off-by: Youri Querry Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers

<    1   2   3   4   5   6   7   8   9   10   >