From: Heinrich Kuhn
During rx/tx queue setup, memory is reserved for the hardware rings.
This memory zone should subsequently be freed in the queue release
logic. This commit also adds a call to the release logic in the
dev_close() callback so that the ring memzone may be freed during port
close
other PMD's. Apart form adopting the common PMD layout
this change should also aid in future feature development to the NFP
PMD. The previous layout where most of the logic resided in a single
file (nfp_net.c) would have become tedious to support going forward.
Heinrich Kuhn (7):
net/nfp:
This change splits out the rx/tx specific structs and defines from the
main nfp_net_pmd header file and into their own header file.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/nfp_net.c | 1 +
drivers/net/nfp/nfp_net_pmd.h | 248 --
drivers/net/nfp
Create a new rxtx file and move the Rx/Tx functions to this file. This
commit will also move the needed shared functions to the nfp_net_pmd.h
file as needed.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_net.c | 1090
This commit moves the CPP bridge logic to a separate file. A new
corresponding header file is also created.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_cpp_bridge.c | 392 +++
drivers/net/nfp/nfp_cpp_bridge.h | 36
The majority of "ethdev" type functions are used for both PF devices and
VF devices. Prototype these functions in the nfp_net_pmd header file in
preparation of splitting PF and VF specific functions.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/nfp_net.
Move any ethdev functionality specific to VF devices into a new file
called nfp_ethdev_vf.c.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_ethdev_vf.c | 504
drivers/net/nfp/nfp_net.c | 42 +--
3 files
Similar to the last commit, this changeset moves all the PF specific
functions to a new file called nfp_ethdev.c.
Signed-off-by: Heinrich Kuhn
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_ethdev.c | 1099 ++
drivers/net/nfp/nfp_net.c| 1088
Rename the nfp_net.c file to nfp_common as it now contains functions
common to VF and PF functionality. Rename the header file too to be
consistent. Also remove the "net" naming from the _ctrl and _logs files
for consistency across the PMD.
Signed-off-by: Heinrich Kuhn
---
drive
other PMD's. Apart form adopting the common PMD layout
this change should also aid in future feature development to the NFP
PMD. The previous layout where most of the logic resided in a single
file (nfp_net.c) would have become tedious to support going forward.
v2:
* Added missing sign-off&#
This change splits out the rx/tx specific structs and defines from the
main nfp_net_pmd header file and into their own header file.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 1 +
drivers/net/nfp/nfp_net_pmd.h | 248
Create a new rxtx file and move the Rx/Tx functions to this file. This
commit will also move the needed shared functions to the nfp_net_pmd.h
file as needed.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_net.c
This commit moves the CPP bridge logic to a separate file. A new
corresponding header file is also created.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_cpp_bridge.c | 392 +++
drivers/net
The majority of "ethdev" type functions are used for both PF devices and
VF devices. Prototype these functions in the nfp_net_pmd header file in
preparation of splitting PF and VF specific functions.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp
Move any ethdev functionality specific to VF devices into a new file
called nfp_ethdev_vf.c.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_ethdev_vf.c | 504
drivers/net/nfp/nfp_net.c
Similar to the last commit, this changeset moves all the PF specific
functions to a new file called nfp_ethdev.c.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_ethdev.c | 1099 ++
drivers
Rename the nfp_net.c file to nfp_common as it now contains functions
common to VF and PF functionality. Rename the header file too to be
consistent. Also remove the "net" naming from the _ctrl and _logs files
for consistency across the PMD.
Signed-off-by: Heinrich Kuhn
Signed-off
>>> -#else
>>> #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>> -#endif
>>>
>>> extern int nfp_logtype_driver;
>>> #define PMD_DRV_LOG(level, fmt, args...) \
>
>
>
Hi Andrew,
Apologies for the delay, looks good thanks
Reviewed-by: Heinrich Kuhn
w firmware loader helper added in:
https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781
* Add dependency to patch-93299
v2:
* Added missing sign-off's
---
Depends-on: patch-93299 ("net/nfp: remove compile time log")
Heinrich Kuhn (7):
net/nfp: split rxtx headers into separate
This change splits out the rx/tx specific structs and defines from the
main nfp_net_pmd header file and into their own header file.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 1 +
drivers/net/nfp/nfp_net_pmd.h | 248
Create a new rxtx file and move the Rx/Tx functions to this file. This
commit will also move the needed shared functions to the nfp_net_pmd.h
file as needed.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_net.c
This commit moves the CPP bridge logic to a separate file. A new
corresponding header file is also created.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_cpp_bridge.c | 392 +++
drivers/net
The majority of "ethdev" type functions are used for both PF devices and
VF devices. Prototype these functions in the nfp_net_pmd header file in
preparation of splitting PF and VF specific functions.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp
Move any ethdev functionality specific to VF devices into a new file
called nfp_ethdev_vf.c.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build | 1 +
drivers/net/nfp/nfp_ethdev_vf.c | 504
drivers/net/nfp/nfp_net.c
Similar to the last commit, this changeset moves all the PF specific
functions to a new file called nfp_ethdev.c.
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfp_ethdev.c | 1067 ++
drivers
Rename the nfp_net.c file to nfp_common as it now contains functions
common to VF and PF functionality. Rename the header file too to be
consistent. Also remove the "net" naming from the _ctrl and _logs files
for consistency across the PMD.
Signed-off-by: Heinrich Kuhn
Signed-off
On 2021/07/23 11:18, Thomas Monjalon wrote:
> 16/07/2021 10:35, Heinrich Kuhn:
>> This patch set restructures the NFP PMD, aligning it more with the
>> common layout adopted by most other PMD's. Although the changes look
>> fairly large, functionally nothing is added
purposes, follow the
hardware team convention of subtracting 0x10 from the PluDevice register
to obtain the chip model/revision number.
Fixes: c7e9729da ("net/nfp: support CPP")
Cc: sta...@dpdk.org
Signed-off-by: Heinrich Kuhn
Reviewed-by: Louis Peens
Signed-off-by: Simon Horman
---
drive
Release-on-close has been implemented for the NFP PMD. Remove the
UNMAINTAINED flag.
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 77a2273c1..68c5ce6e5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
From: "Chaoyong.He"
1. Fixup the suffix of the PCI ID to be consistent with the code.
2. Add specification of using MAC address to identify port.
Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong.He
Signed-off-by: Hei
From: Heinrich Kuhn
The link state change interrupt handler of the NFP PMD will delay the
actual LSC work for a short period to ensure the link is stable. If the
link of the port changes state and the port is closed immediately after
the link event then a segmentation fault will occur. This
On 2021/07/29 15:47, Heinrich Kuhn wrote:
> This patch set restructures the NFP PMD, aligning it more with the
> common layout adopted by most other PMD's. Although the changes look
> fairly large, functionally nothing is added or removed from the driver
> and the existing co
From: Heinrich Kuhn
The NFP4000/6000 supports a minimum of 256 Tx/Rx descriptors and not 64.
Before this patch when a DPDK application configured < 256 Tx
descriptors the hardware read/write pointers would be unmasked and not
wrapped at the expected size of the ring. The PMD logic to determ
From: Heinrich Kuhn
Some of Netronome's activities and people have moved over to Corigine,
including NFP PMD maintenance and myself.
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8013b
From: Heinrich Kuhn
Niklas has been appointed the new maintainer for the NFP PMD. Update the
MAINTAINERS file to reflect this
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fdea1c623f..2ae2f8ffb4
te Rx RSS hash offload capabilities")
Cc: sta...@dpdk.org
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_n
From: "Chaoyong.He"
Set the Rx multi-queue mode to NONE when configuring a port that is
associated with hardware that only supports a single Rx queue.
Signed-off-by: Chaoyong He
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
examples/l3fwd/main.c | 4
1 file
port number is now correctly used for configuration
changes.
Fixes: 5e15e799d ("net/nfp: create separate entity for PF device")
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 38 +++
drivers/net/nfp/nfp_net_
s for each physical port during PF initialization,
giving them more consistent names.
Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 31 ---
have the primary register the service if it is also
needed in a secondary process. This implies that both the primary and
secondary will have their own copy of the bridge service.
Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
Signed-off-by: Heinrich Kuhn
Signe
s for each physical port during PF initialization,
giving them more consistent names.
Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 31 ---
have the primary register the service if it is also
needed in a secondary process. This implies that both the primary and
secondary will have their own copy of the bridge service.
Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
Signed-off-by: Heinrich Kuhn
Signe
; PCI_PRI_FMT,
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function);
> }
>
> /* Interrupt configuration and handling */
>
Acked-by: Heinrich Kuhn
: 934e4c60fbff ("nfp: add RSS")
Cc: sta...@dpdk.org
Signed-off-by: Heinrich Kuhn
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 88e3f01d6..f47200cc4 100644
---
PP bridge as service")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferruh Yigit
> ---
Acked-by: Heinrich Kuhn
quot;)
> CC: sta...@dpdk.org
>
> Signed-off-by: Yunjian Wang
Thanks Yunjian
Acked-by: Heinrich Kuhn
Jan is no longer with Netronome. Remove him as maintainer for the
Netronome PMD
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bc98b9167..3d5e8d110 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -784,7 +784,6 @@ F
As Alejandro is no longer with Netronome we appointed two new
maintainers for the Netronome PMD
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4a0c9a47e..6bac90c25 100644
--- a/MAINTAINERS
+++ b
On 2019/11/25 20:52, thomas at monjalon.net (Thomas Monjalon) wrote:
> 13/11/2019 14:05, Alejandro Lucero:
>> On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit
>> wrote:
>>> On 11/13/2019 12:47 PM, Alejandro Lucero wrote:
[...]
>>> Can it be possible to nominate someone?
>>> It would be good to have a
On 2019/09/27 10:33, hemant.agrawal at nxp.com (Hemant Agrawal) wrote:
> Signed-off-by: Hemant Agrawal
Acked-by: Heinrich Kuhn
cond patch in the series makes the changes in nfp_net_close to
free the private data of a given port. PF resources are only freed once
all other ports under the PF has also been cleaned up.
Heinrich Kuhn (2):
net/nfp: create a separate entity for a NFP PF device
net/nfp: free port private d
uring this phase because memory has already been allocated
and an eth_dev already exits for the 0th port.
Signed-off-by: Heinrich Kuhn
Reviewed-by: Louis Peens
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c | 545 +-
drivers/net/nfp/nfp_net_pmd.h | 6
x27;t explicitly supported for NFP6000/4000 devices but
all the private data of all the ports under the PF in question will be
freed upon device removal.
Signed-off-by: Heinrich Kuhn
Reviewed-by: Louis Peens
Signed-off-by: Simon Horman
---
drivers/net/nfp/nfp_net.c
Report Rx and Tx descriptor related limitations in the nfp dev_info_get
callback function. This commit also adds NFP_ALIGN_RING_DESC to replace
a static integer value used during rx/tx queue setups to validate
descriptor alignment.
Cc: sta...@dpdk.org
Signed-off-by: Heinrich Kuhn
Signed-off-by
The Agilio CX family of smartNIC's generally have a 1:many mapping of PF
to physical ports. Elaborate on this mapping in the PF multiport section
of the NFP PMD documentation.
Fixes: d625beafc8be ("doc: update NFP with PF support information")
Cc: sta...@dpdk.org
Signed-off-by
55 matches
Mail list logo
