Fix json output buffer size for a single largest value.
Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
v2:
- split from series 18768 ("cnxk: enable telemetry endpoints").
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/telemetry/telemetry_j
Add telemetry endpoints to cryptodev.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-19052 ("cnxk: enable telemetry endpoints for mempool and
ethdev")
Depends-on: patch-19054 ("telemetry: fix json output buffer size")
v2:
- split from series 18768 (&qu
ot it. Yeah, "len" is actual available space. I ll send next version based on
this.
Also, I propose if we can have platform defined upper limits (esp MAX_CMD_LEN,
MAX_SINGLE_STRING_LEN etc) so that, we need not revisit lib/telemetry for
platform needs (and I don't think one size fits all platform, may be excess
too).
Thoughts ?
Thanks,
Gowrishankar
>
> Thanks,
> Ciara
Fix json output buffer size for a single largest value.
Also fix compile assertion for the size of output buffer.
Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- use "len" param as buffer size.
Fix json output buffer size for a single largest value.
Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
Signed-off-by: Gowrishankar Muthukrishnan
---
v4:
- corrected typo in commit message.
v3:
- use "len" param as buffer size.
---
lib/teleme
This patch series enables telemetry in NPA LF of cnxk.
Gowrishankar Muthukrishnan (3):
telemetry: enable storing pointer value
test/telemetry: add unit tests for pointer value
common/cnxk: add telemetry endpoints to npa
app/test/test_telemetry_data.c | 124 +
app
At present, value of pointer variable or address can only be
stored in u64 type which is slightly not human readable, hence
this patch is. It adds telemetry support to store pointer value,
which is stringified.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/telemetry/rte_telemetry.h | 37
Adding tests to evaluate pointer value in array and dict.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_telemetry_data.c | 124 +
app/test/test_telemetry_json.c | 28 ++--
2 files changed, 145 insertions(+), 7 deletions(-)
diff --git a/app
Add telemetry endpoints to npa.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/cnxk_telemetry.h | 23 +++
drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++
drivers/common/cnxk/meson.build | 4 +
drivers/common/cnxk/roc_platform.h
though it is up to user to choose.
3. Also while debugging telemetry date using script like
usertools/dpdk-telemetry.py,
perceiving address as hex is quicker than same as u64.
Answering on returned data, user needs to convert stringified hex to pointer
value.
Regards,
Gowrishankar
This patch series enables telemetry in NPA LF of cnxk.
v2:
* using uintptr_t to encode pointer value in json.
*** BLURB HERE ***
Gowrishankar Muthukrishnan (3):
telemetry: enable storing pointer value
test/telemetry: add unit tests for pointer value
common/cnxk: add telemetry endpoints
available
at JSON clients, hex value of address can be encoded instead
of uintptr_t.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/telemetry/rte_telemetry.h | 37 ++-
lib/telemetry/telemetry.c | 21 --
lib/telemetry/telemetry_data.c | 40
Adding tests to evaluate pointer value in array and dict.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_telemetry_data.c | 124 +
app/test/test_telemetry_json.c | 28 ++--
2 files changed, 145 insertions(+), 7 deletions(-)
diff --git a/app
Add telemetry endpoints to npa.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/cnxk_telemetry.h | 26 +++
drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++
drivers/common/cnxk/meson.build | 4 +
drivers/common/cnxk/roc_platform.h
> -Original Message-
> From: Gowrishankar Muthukrishnan
> Sent: Friday, July 30, 2021 5:38 PM
> To: Bruce Richardson
> Cc: dev@dpdk.org; ciara.po...@intel.com; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda ;
> Nithin Kumar Dabilpuram ; Sunil Kumar Kori
&g
This patch series enables telemetry in NPA LF of cnxk.
v3:
- fixed format specifier for uintptr_t
Gowrishankar Muthukrishnan (3):
telemetry: enable storing pointer value
test/telemetry: add unit tests for pointer value
common/cnxk: add telemetry endpoints to npa
app/test
available
at JSON clients, hex value of address can be encoded instead
of uintptr_t.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/telemetry/rte_telemetry.h | 37 ++-
lib/telemetry/telemetry.c | 21 --
lib/telemetry/telemetry_data.c | 40
Adding tests to evaluate pointer value in array and dict.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_telemetry_data.c | 125 +
app/test/test_telemetry_json.c | 29 ++--
2 files changed, 147 insertions(+), 7 deletions(-)
diff --git a/app
Add telemetry endpoints to npa.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/cnxk_telemetry.h | 26 +++
drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++
drivers/common/cnxk/meson.build | 4 +
drivers/common/cnxk/roc_platform.h
Hi Ciara,
> -Original Message-
> From: Power, Ciara
> Sent: Wednesday, August 11, 2021 9:30 PM
> To: Gowrishankar Muthukrishnan ; dev@dpdk.org
> Cc: Richardson, Bruce ; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda ;
> Nithin Kumar Dabilpuram ; Sunil
This patch series adds support for SHA3, SHAKE, AES-CCM
JSON test vectors and fixes existing algorithms to
support NIST test vectors.
v2:
- fixed type punning SHAKE test function.
Gowrishankar Muthukrishnan (10):
examples/fips_validation: fix MCT output for SHA
examples/fips_validation: add
MCT test for SHA need not print message string along
with digest value.
Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_sha.c | 8 ++--
examples/fips_validat
Add support in fips_validation to parse SHA3 algorithms.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 5 +-
examples/fips_validation/fips_validation.h| 1 +
.../fips_validation/fips_validation_hmac.c| 8 ++
.../fips_validation
Parsing integer value in test case vector does not store
it because only string was expected. This patch adds handling
for integer value as well.
Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_
Add support in fips_validation to parse SHAKE algorithms.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- fixed type punning reported in CI.
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.h| 4 +-
.../fips_validation
Add support in fips_validation to parse CCM JSON vectors.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h| 3 +
.../fips_validation
Add support to validate ECDSA keygen mode tests.
Signed-off-by: Gowrishankar Muthukrishnan
---
.../fips_validation/fips_validation_ecdsa.c | 52 +++
examples/fips_validation/main.c | 13 +
2 files changed, 65 insertions(+)
diff --git a/examples
Add SHA3 algorithms in ECDSA as supported.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_ecdsa.c | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/fips_validation_ecdsa.c
b/examples/fips_validation/fips_validation_ecdsa.c
AES GCM validation tests fail in FIPS validation due to incorrect
fields populated in response file. This patch fixes them.
Fixes: 5b540bebac8e ("examples/fips_validation: fix GMAC decryption output")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_valida
Fix AES XTS test to read sequence number correctly.
Fixes: f8e431ed8f6 ("examples/fips_validation: add parsing for AES-XTS")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_xts.c | 13 +
1 file changed, 9 insertions(+), 4 deletion
JSON buffer size")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/fips_validation/fips_validation.h
b/examples/fips_validation/fips_validation.h
index c4988053c1..abc1d64
I have fixed it in v2 and CI passed.
http://mails.dpdk.org/archives/test-report/2023-February/360464.html
Thanks,
Gowrishankar
> -Original Message-
> From: Akhil Goyal
> Sent: Tuesday, February 28, 2023 1:09 PM
> To: Akhil Goyal ; Dooley, Brian
> ; Gowrishankar Muthuk
This patch series adds SM2 crypto algorithm support, along with tests
verified using Openssl.
Gowrishankar Muthukrishnan (3):
cryptodev: add SM2 asymmetric crypto algorithm
test/test_cryptodev_asym: add SM2 tests
crypto/openssl: add SM2 asymmetric crypto support
app/test
ShangMi 2 (SM2) is a encryption and digital signatture algorithm
used in the Chinese National Standard.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/default.ini | 1 +
doc/guides/rel_notes/release_23_07.rst | 3 +
lib/cryptodev/rte_crypto_asym.h
Add SM2 tests.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 506 +
app/test/test_cryptodev_sm2_test_vectors.h | 120 +
2 files changed, 626 insertions(+)
create mode 100644 app/test/test_cryptodev_sm2_test_vectors.h
diff
Add SM2 asymmetric algorithm support in openssl PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/openssl.ini | 1 +
doc/guides/cryptodevs/openssl.rst| 1 +
doc/guides/rel_notes/release_23_07.rst | 4 +
drivers/crypto/openssl
++ Kai Ji
Thanks,
Gowrishankar
Memory allocated through OPENSSL_malloc should be freed only
through OPENSSL_free.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers
Depending on RSA op, the output buffer size could be set
minimal expected memory, rather than 0 as today. This will allow
PMD to do any validation on the size, in case an application
did not create enough memory or even in case of any memory
fault.
Signed-off-by: Gowrishankar Muthukrishnan
creation. Hence, moving this info from
crypto op into xform structure.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 6 +--
app/test/test_cryptodev_rsa_test_vectors.h | 2 +
drivers/common/cpt/cpt_ucode_asym.h | 4 +-
drivers/crypto/cnxk
c/html/draft-shen-sm2-ecdsa-02
> >
> > Signed-off-by: Gowrishankar Muthukrishnan
> > ---
> > app/test/test_cryptodev_asym.c | 506 +
> > app/test/test_cryptodev_sm2_test_vectors.h | 120 +
> > 2 files changed, 62
This patch series adds SM2 crypto algorithm support, along with tests
verified using Openssl.
v2:
- addressed suggestions in v1.
Gowrishankar Muthukrishnan (3):
cryptodev: add SM2 asymmetric crypto algorithm
test/crypto: add asymmetric SM2 test cases
crypto/openssl: add SM2 asymmetric
ShangMi 2 (SM2) is a encryption and digital signature algorithm
used in the Chinese National Standard.
Added support for asymmetric SM2 in cryptodev along with prime
field curve, as referenced in RFC:
https://datatracker.ietf.org/doc/html/draft-shen-sm2-ecdsa-02
Signed-off-by: Gowrishankar
Added test cases and test vectors for asymmetric SM2 crypto verification.
Cases are added for sign/verify/encrypt/decrypt.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 504 +
app/test/test_cryptodev_sm2_test_vectors.h | 120
Add SM2 asymmetric algorithm support in openssl PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/openssl.ini | 1 +
doc/guides/cryptodevs/openssl.rst| 1 +
doc/guides/rel_notes/release_23_07.rst | 4 +
drivers/crypto/openssl
is N bytes)
> > +* input : for signature verification
> > +*/
> > + rte_crypto_uint s;
> > + /**< s component of elliptic curve signature
> > +* output : for signature generation (of at least N bytes
> > +* where prime field length is N bytes)
> > +* input : for signature verification
> > +*/
> > +};
> > +
> > /**
> > * Asymmetric Cryptographic Operation.
> > *
> > @@ -665,6 +741,7 @@ struct rte_crypto_asym_op {
> > struct rte_crypto_dsa_op_param dsa;
> > struct rte_crypto_ecdsa_op_param ecdsa;
> > struct rte_crypto_ecpm_op_param ecpm;
> > + struct rte_crypto_sm2_op_param sm2;
> > };
> > uint16_t flags;
> > /**<
> > diff --git a/lib/cryptodev/rte_cryptodev.c
> > b/lib/cryptodev/rte_cryptodev.c index a96114b2da..21cabc3ffd 100644
> > --- a/lib/cryptodev/rte_cryptodev.c
> > +++ b/lib/cryptodev/rte_cryptodev.c
> > @@ -299,6 +299,7 @@ crypto_asym_xform_strings[] = {
> > [RTE_CRYPTO_ASYM_XFORM_DSA] = "dsa",
> > [RTE_CRYPTO_ASYM_XFORM_ECDSA] = "ecdsa",
> > [RTE_CRYPTO_ASYM_XFORM_ECPM]= "ecpm",
> > + [RTE_CRYPTO_ASYM_XFORM_SM2] = "sm2",
> > };
> >
> > /**
> > --
> > 2.25.1
Thanks for the review,
Gowrishankar
This patch series adds SM2 crypto algorithm support, along with tests
verified using Openssl.
v3:
- sm2 xform contains hash param and key pair info moved into op.
Gowrishankar Muthukrishnan (3):
cryptodev: add SM2 asymmetric crypto algorithm
test/crypto: add asymmetric SM2 test cases
ShangMi 2 (SM2) is set of public-key cryptography algorithms
based on elliptic curves.
Added support for asymmetric SM2 in cryptodev along with prime
field curve, as referenced in RFC:
https://datatracker.ietf.org/doc/html/draft-shen-sm2-ecdsa-02
Signed-off-by: Gowrishankar Muthukrishnan
Added test cases for asymmetric SM2 crypto validation.
Test cases are added for sign/verify/encrypt/decrypt.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 581 +
app/test/test_cryptodev_sm2_test_vectors.h | 129 +
2 files
Add SM2 asymmetric algorithm support in openssl PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/openssl.ini | 1 +
doc/guides/cryptodevs/openssl.rst| 1 +
doc/guides/rel_notes/release_23_07.rst | 4 +
drivers/crypto/openssl
, but v3 is good to go for openSSL pmd.
Thanks,
Gowrishankar
Hi,
Could this series be merged as the patches are acked.
Thanks,
Gowrishankar
Hi,
Could this series be merged as the patches are acked.
Thanks,
Gowrishankar
I have named variables dma_src_sge and dma_dst_sge to fit context.
Please check
https://patches.dpdk.org/project/dpdk/patch/20240227160031.3931694-5-amitpraka...@marvell.com/
.
Thanks,
Gowrishankar
ransfer_dir ==
RTE_DMA_DIR_MEM_TO_MEM). Would you still need it in this patch only ?.
Thanks,
Gowrishankar
> So pls restrict it only mem2mem, or drop this commit.
>
> Thanks
Hi Fengcheng,
> -Original Message-
> From: fengchengwen
> Sent: Wednesday, February 28, 2024 3:02 PM
> To: Amit Prakash Shukla ; Cheng Jiang
>
> Cc: dev@dpdk.org; Jerin Jacob ; Anoob Joseph
> ; Kevin Laatz ; Bruce
> Richardson ; Pavan Nikhilesh Bhagavatula
> ;
Improve dma-perf application to support PCI dev and SG copy,
along with additional supports as below:
- validate copied memory
- skip tests if not opted.
v11:
- Review suggestions.
Gowrishankar Muthukrishnan (4):
app/dma-perf: add skip support
app/dma-perf: add PCI device support
app/dma
Add support to test performance for "device to memory" and
"memory to device" data transfer.
Signed-off-by: Amit Prakash Shukla
Acked-by: Anoob Joseph
Acked-by: Chengwen Feng
---
v11:
- config file formatting.
app/test-dma-perf/benchmark.c | 119 ++
app/test-d
Add support to skip running a dma-perf test-case.
Signed-off-by: Amit Prakash Shukla
Acked-by: Anoob Joseph
Acked-by: Chengwen Feng
---
v11:
- config file formatting
app/test-dma-perf/config.ini | 2 ++
app/test-dma-perf/main.c | 48 ++--
app/test-dma-per
Validate copied memory to ensure DMA copy did not fail.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
Acked-by: Chengwen Feng
---
app/test-dma-perf/benchmark.c | 23 ++-
app/test-dma-perf/main.c | 16 +++-
app/test-dma-perf/main.h
Add SG copy support.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
Acked-by: Chengwen Feng
---
v11:
- using struct for SGE config.
app/test-dma-perf/benchmark.c | 283 ++
app/test-dma-perf/config.ini | 25 ++-
app/test-dma-perf/main.c
rte_mbuf_data_iova(dsts[i]), buf_size, 0);
> if (unlikely(ret < 0)) {
> if (ret == -ENOSPC) {
> do_dma_submit_and_poll(dev_id,
> &async_cnt, worker_info);
> goto dma_copy;
> } else
> error_exit(dev_id);
> }
> async_cnt++;
>
> if ((async_cnt % kick_batch) == 0)
> do_dma_submit_and_poll(dev_id,
> &async_cnt, worker_info);
> }
>
> if (unlikely(work_info->verify)) {
> ret = verify();
> if (ret != 0) {
> // error trace,
> break;
> }
> }
>
> if (worker_info->stop_flag) // if don't stop, it will do many
> round copies.
> break;
> }
>
> and make this verify as a config entry
I believe there is a difference in understanding of what this is intended to
do. Intention here is not to validate every operation done by DMA, and that is
already taken care by UT.
Is it possible that we are we misreporting numbers if the application is buggy
or PMD is misbehaving for the scenario under test and the copies are not
actually performed? Yes. Think about a scenario where PMD is buggy when trying
bursts of more than 1.
Checking last set of buffers is more like testing a sample from the perf test
to make sure perf test was indeed performing what it is claiming to do. If you
think it is unnecessary to do so, we can drop this from upstream. But adding
complete verification in performance app would be repeating what a unit test is
expected to do. I would suggest not to do that.
Thanks,
Gowrishankar
t sounds better for an op. Also, this op capability check could be done
once for the session.
If you are also aligned, I can send an RFC for capab check.
> + /* Similar applies to the key exchange in the HW. The second phase of
> KE, most likely,
> + * will go as far as to obtain xU,yU(xV,
Fix NULL dereference, out-of-bound, bad bit shift issues
reported by coverity scan.
Coverity issue: 384440, 384435, 384433, 384429
Fixes: 36128a67c27 ("examples/fips_validation: add asymmetric validation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
vate and public keys in EC session")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/roc_ae.h | 16 +---
drivers/crypto/cnxk/cnxk_ae.h | 24 +++-
2 files changed, 28 insertions(+), 12 deletions(-)
diff --git a/drivers/co
Fix dequeue operation for ECDH pubkey verify.
Fixes: baae0994fa96 ("crypto/cnxk: support ECDH")
Fixes: 5c9025583167 ("crypto/cnxk: fix CN9K ECDH public key verification")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cn10k_
This patch series adds below asymmetric tests in crypto-perf tool:
* MODEX group tests (RFC 3526)
* SM2 tests
* ECDSA P256R1 tests
Akhil Goyal (1):
app/crypto-perf: support SM2
Gowrishankar Muthukrishnan (5):
app/crypto-perf: add modex groups test
app/crypto-perf: remove redundant
Add perf tests for modex groups 5, 14, 15, 16, 17 and 18
based on RFC 3526.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_test_vectors.c | 570 +-
app/test-crypto-perf/cperf_test_vectors.h | 4 +-
2 files changed, 571 insertions(+), 3 deletions
Remove redundant local variable used for asym session.
Fixes: a29bb248988 ("cryptodev: hide asymmetric session structure")
Fixes: 2973dbf93b4 ("security: hide session structure")
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_ops.c | 9 +++-
For asymmetric op, private test data should be stored after
rte_crypto_asym_op struct.
Fixes: a538d1d2d01e ("test/crypto-perf: extend asymmetric crypto throughput
test")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_test_comm
Replace checking input option for every asymmetric test case by
a function.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_test_common.c | 12 +++-
app/test-crypto-perf/cperf_test_common.h | 2 ++
app/test-crypto-perf/cperf_test_latency.c| 7
From: Akhil Goyal
Added support for SM2 asymmetric crypto performance.
A new command line option is added to specify
asymmetric operation type `--asym-op Type`.
Type can be sign/verify/encrypt/decrypt.
Example command:
./dpdk-test-crypto-perf --vdev crypto_openssl -c 0x30 -- \
--devtype crypto_
Added support for ECDSA SECP256R1 curve SIGN and VERIFY operations.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_ops.c | 57 ++
app/test-crypto-perf/cperf_options.h | 2 +
app/test-crypto-perf/cperf_options_parsing.c | 10 ++-
app
This patch series enhances modex tests to:
* use common test function in existing test vectors
* add test for zero padded operands
Gowrishankar Muthukrishnan (4):
test/crypto: validate modex result from first nonzero value
test/crypto: remove unused variable in modex test data
test/crypto
: 1ffefe00f1 ("test/crypto: add modexp and modinv functions")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c
Remove unused result_len from modex test data.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_mod_test_vectors.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/app/test/test_cryptodev_mod_test_vectors.h
b/app/test/test_cryptodev_mod_test_vectors.h
index
Use common test function for modex and modinv tests.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 238 ++---
app/test/test_cryptodev_asym_util.h| 18 --
app/test/test_cryptodev_mod_test_vectors.h | 206 ++
3
Add modex tests for zero padded operands, as in ASN encoding.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 16 +
app/test/test_cryptodev_mod_test_vectors.h | 71 ++
2 files changed, 87 insertions(+)
diff --git a/app/test
This patch series enhances modex tests to:
* use common test function in existing test vectors
* add test for zero padded operands
v2:
- Retain old modex test functions to avoid doc updates.
Gowrishankar Muthukrishnan (4):
test/crypto: validate modex result from first nonzero value
test
: 1ffefe00f1 ("test/crypto: add modexp and modinv functions")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c
Remove unused result_len from modex test data.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_mod_test_vectors.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/app/test/test_cryptodev_mod_test_vectors.h
b/app/test/test_cryptodev_mod_test_vectors.h
index
Use common test function for modex and modinv tests.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- Old functions not removed.
---
app/test/test_cryptodev_asym.c | 21 +++-
app/test/test_cryptodev_mod_test_vectors.h | 124 +
2 files changed, 140 insertions
Add modex tests for zero padded operands, as in ASN encoding.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 16 +
app/test/test_cryptodev_mod_test_vectors.h | 71 ++
2 files changed, 87 insertions(+)
diff --git a/app/test
This patch series adds below asymmetric tests in crypto-perf tool:
* MODEX group tests (RFC 3526)
* SM2 tests
* ECDSA P256R1 tests
Akhil Goyal (1):
app/crypto-perf: support SM2
Gowrishankar Muthukrishnan (5):
app/crypto-perf: add modex groups test
app/crypto-perf: remove redundant
Add perf tests for modex groups 5, 14, 15, 16, 17 and 18
based on RFC 3526.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_test_vectors.c | 570 +-
app/test-crypto-perf/cperf_test_vectors.h | 4 +-
2 files changed, 571 insertions(+), 3 deletions
Remove redundant local variable used for asym session.
Fixes: a29bb248988 ("cryptodev: hide asymmetric session structure")
Fixes: 2973dbf93b4 ("security: hide session structure")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_op
For asymmetric op, private test data should be stored after
rte_crypto_asym_op struct.
Fixes: a538d1d2d01e ("test/crypto-perf: extend asymmetric crypto throughput
test")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_test_comm
Replace checking input option for every asymmetric test case by
a function.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- cperf_is_asym_test is fixed to check only modex in this patch.
---
app/test-crypto-perf/cperf_test_common.c | 11 ++-
app/test-crypto-perf
From: Akhil Goyal
Added support for SM2 asymmetric crypto performance.
A new command line option is added to specify
asymmetric operation type `--asym-op Type`.
Type can be sign/verify/encrypt/decrypt.
Example command:
./dpdk-test-crypto-perf --vdev crypto_openssl -c 0x30 -- \
--devtype crypto_
Added support for ECDSA SECP256R1 curve SIGN and VERIFY operations.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-crypto-perf/cperf_ops.c | 57 ++
app/test-crypto-perf/cperf_options.h | 2 +
app/test-crypto-perf/cperf_options_parsing.c | 10 ++-
app
This patch series add modex test for zero padded operands
v3:
- removed patch to use common test function which will be addressed
seperately due to document conflict.
Gowrishankar Muthukrishnan (3):
test/crypto: validate modex result from first nonzero value
test/crypto: remove unused
: 1ffefe00f1 ("test/crypto: add modexp and modinv functions")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c
Remove unused result_len from modex test data.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_mod_test_vectors.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/app/test/test_cryptodev_mod_test_vectors.h
b/app/test/test_cryptodev_mod_test_vectors.h
index
Add modex tests for zero padded operands, as in ASN encoding.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 16 +
app/test/test_cryptodev_mod_test_vectors.h | 75 ++
2 files changed, 91 insertions(+)
diff --git a/app/test
Fix modex to nomalize input only when MSW is zero.
Fixes: 5a3513caeb45 ("crypto/cnxk: add asymmetric session")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cnxk_ae.h | 30 +-
1 file changed, 21 insertions(+), 9
Fix NULL dereference, out-of-bound, bad bit shift issues
reported by coverity scan.
Coverity issue: 384440, 384435, 384433, 384429
Fixes: 36128a67c27 ("examples/fips_validation: add asymmetric validation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Br
This patch series fixes SM2 algorithm implementation to
support digest message as input along with plain message
as today.
Gowrishankar Muthukrishnan (6):
crypto/openssl: include SM2 in asymmetric capabilities
cryptodev: add RNG capability in EC based xform
cryptodev: add hash support in
Elliptic curve based asymmetric operations use cryptographically
secure random number in its computation. If PMD supports RNG
for such ops, the application could skip computing on its own.
This patch adds new field in asymmetric capability to declare
this capability.
Signed-off-by: Gowrishankar
Include SM2 algorithm in the asymmetric capabilities supported
by OpenSSL PMD.
Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 14 ++
1 file changed, 14 insertion
Most of the asymmetric operations start with hash of the input.
Add a new field in asymmetric capability to declare support
for hash operations that PMD can support for the asymmetric
operations. Application can skip computing hash if PMD already
supports it.
Signed-off-by: Gowrishankar
301 - 400 of 895 matches
Mail list logo
