Re: [PATCH v2] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-24 Thread Georg Sauthoff
Hello, Stephen Hemminger wrote (Sun, 16 Jan 2022 08:32:20 -0800): > I would propose that DPDK have same kind of define as the kernel > for SAFE_UNALIGNED_ACCESS. The C standard has to apply to all architectures > but DPDK will make the choice to be fast rather than standards conformant. perhaps

Re: [dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation

2021-10-16 Thread Georg Sauthoff
Hello, On Fri, Oct 15, 2021 at 04:39:02PM +0200, Olivier Matz wrote: > On Sat, Sep 18, 2021 at 01:49:30PM +0200, Georg Sauthoff wrote: > > That means a superfluous cast is removed and aliasing through a uint8_t > > pointer is eliminated. Note that uint8_t doesn't have the same

Re: [dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation

2021-10-16 Thread Georg Sauthoff
Hello, On Sat, Oct 16, 2021 at 10:21:03AM +0200, Morten Brørup wrote: > I have given this some more thoughts. > > Most bytes transferred in real life are transferred in large packets, > so faster processing of large packets is a great improvement! > > Furthermore, a quick analysis of a recent pa

[dpdk-dev] [PATCH v2 0/1] net: fix aliasing issue in checksum computation

2021-10-17 Thread Georg Sauthoff
rsion is half as big as the existing one. Signed-off-by: Georg Sauthoff --- v2: * Reword commit message (detail aliasing implications of uint8_t) * Add unlikely() Georg Sauthoff (1): net: fix aliasing issue in checksum computation lib/net/rte_ip.h | 27 --- 1 fi

[dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-17 Thread Georg Sauthoff
r can speed up (i.e. auto-vectorize) it in a similar way. For example, GCC auto-vectorizes it for Haswell using AVX registers while halving the number of instructions in the generated code. Signed-off-by: Georg Sauthoff --- lib/net/rte_ip.h | 27 --- 1 file changed, 8 inser

[dpdk-dev] [PATCH 0/1] net: fix aliasing issue in checksum computation

2021-09-18 Thread Georg Sauthoff
rsion is half as big as the existing one. Georg Sauthoff (1): net: fix aliasing issue in checksum computation lib/net/rte_ip.h | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) -- 2.31.1

[dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation

2021-09-18 Thread Georg Sauthoff
. For example, GCC auto-vectorizes it for Haswell using AVX registers while halving the number of instructions in the generated code. Signed-off-by: Georg Sauthoff --- lib/net/rte_ip.h | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/lib/net/rte_ip.h b/li