Re: [dpdk-dev] [PATCH v2 2/2] vhost: introduce async enqueue for split ring

2020-07-02 Thread Fu, Patrick
Thanks Marvin, my comments inline: > -Original Message- > From: Liu, Yong > Sent: Wednesday, July 1, 2020 4:51 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com; Xia, Chenbo ; Wang, > Zhihong > Cc: Fu, Patrick ; Wang, Yinan > ; Jiang, Cheng1 ; Lia

Re: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API

2020-07-06 Thread Fu, Patrick
Hi, > -Original Message- > From: Liu, Yong > Sent: Monday, July 6, 2020 11:06 AM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com; Xia, Chenbo ; Wang, > Zhihong > Cc: Fu, Patrick ; Wang, Yinan > ; Jiang, Cheng1 ; Liang, > Cunming > Subject

[dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-17 Thread Fu, Patrick
Background DPDK vhost library implements a user-space VirtIO net backend allowing host applications to directly communicate with VirtIO front-end in VMs and containers. However, every vhost enqueue/dequeue operation requires to copy packet buffers between gue

Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-17 Thread Fu, Patrick
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, April 17, 2020 4:02 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Maxime Coquelin ; Ye, > Xiaolong ; Hu, Jiayu ; Wang, > Zhihong ; Liang, Cunming > > Subject: Re: [dpdk-dev] [RFC] Accelerating D

Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-17 Thread Fu, Patrick
> -Original Message- > From: Maxime Coquelin > Sent: Friday, April 17, 2020 4:40 PM > To: Fu, Patrick ; Jerin Jacob > Cc: dev@dpdk.org; Ye, Xiaolong ; Hu, Jiayu > ; Wang, Zhihong ; Liang, > Cunming > Subject: Re: [dpdk-dev] [RFC] Accelerating Data Movement f

Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-20 Thread Fu, Patrick
Hi Jerin > -Original Message- > From: Jerin Jacob > Sent: Monday, April 20, 2020 8:15 PM > To: Maxime Coquelin > Cc: Liang, Cunming ; Fu, Patrick > ; dev@dpdk.org; Ye, Xiaolong > ; Hu, Jiayu ; Wang, Zhihong > > Subject: Re: [dpdk-dev] [RFC] Accelerating D

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-18 Thread Fu, Patrick
> -Original Message- > From: Liu, Yong > Sent: Thursday, June 18, 2020 1:51 PM > To: Fu, Patrick > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang, Cunming ; > dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Subject

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-18 Thread Fu, Patrick
Hi, > -Original Message- > From: Liu, Yong > Sent: Thursday, June 18, 2020 2:57 PM > To: Fu, Patrick > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang, Cunming ; > dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Subject

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 26, 2020 10:29 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Jiang, Cheng1 ; Liang, Cunming > > Subject: Re: [PATCH v1 1/2] vhost

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 26, 2020 10:46 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Jiang, Cheng1 ; Liang, Cunming > > Subject: Re: [PATCH v1 2/2] vhost: introd

Re: [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 9:27 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong > Cc: Wang, Yinan ; Jiang, Cheng1 > ; Liang, Cunming > Subject: Re: [PATCH v6 0/2] introduce asynchro

Re: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 21, 2020 12:40 AM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: support cross page buf in async data path > > The title could be improved, it is

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Fu, Patrick
V2 patch sent with revised title > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 11:52 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Yinan > Subject: Re: [PATCH v1] vhost: set zmbufs to NULL when freed > > Do

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Fu, Patrick
V2 patch sent with revised title > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 11:58 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: add vq status check in async enqueue poll > > What about this co

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 10:58 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Yinan > Subject: Re: [PATCH v2] vhost: support async copy free segmentations > > Hi Patrick, >

Re: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-21 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 21, 2020 4:35 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: support cross page buf in async data path > > Hi Patrick, > > On 7/21/20 4:57

Re: [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs

2020-07-22 Thread Fu, Patrick
Thanks for comments. v2 patch sent with all the changes suggested. Thanks, Patrick > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, July 22, 2020 7:21 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v1 1/2] doc:

Re: [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs

2020-07-22 Thread Fu, Patrick
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, July 22, 2020 7:25 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v1 2/2] doc: update release notes for vhost async APIs > > Hi Patrick, > > > --

Re: [dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async transfer

2020-07-22 Thread Fu, Patrick
Hi, Sorry but I'd like to withdraw this patch as the issue could be addressed by applications to register a pre_msg_handler. Thanks, Patrick > -Original Message- > From: Fu, Patrick > Sent: Thursday, July 23, 2020 1:38 PM > To: dev@dpdk.org; maxime.coque...@redhat

Re: [dpdk-dev] [PATCH v3] vhost: fix async copy fail on multi-page buffers

2020-07-27 Thread Fu, Patrick
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Monday, July 27, 2020 9:14 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v3] vhost: fix async copy fail on multi-page buffers > > Hi Patrick, > > > -O

Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type define

2020-07-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 28, 2020 5:10 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: fix async callback return type define > > > > On 7/23/20 7:39 AM, patric

Re: [dpdk-dev] [PATCH v4] vhost: fix async copy fail on multi-page buffers

2020-07-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 28, 2020 9:55 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v4] vhost: fix async copy fail on multi-page buffers > > > > On 7/28/20 5:28 AM, patric

Re: [dpdk-dev] [PATCH v4] vhost: fix async copy fail on multi-page buffers

2020-07-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 29, 2020 9:40 AM > To: 'Maxime Coquelin' ; dev@dpdk.org; Xia, > Chenbo > Subject: RE: [PATCH v4] vhost: fix async copy fail on multi-page buffers > > Hi Maxime, > > >

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-30 Thread Fu, Patrick
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 30, 2020 2:33 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coque...@redhat.com; Richardson, Bruce > ; Wang, Zhihong ; > Wang, Liang-min ; Ananyev, Konstan

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-31 Thread Fu, Patrick
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, July 31, 2020 5:32 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coque...@redhat.com; Richardson, Bruce > ; Wang, Zhihong ; > Wang, Liang-min ; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend

2020-09-23 Thread Fu, Patrick
> -Original Message- > From: Xia, Chenbo > Sent: Thursday, September 24, 2020 1:26 PM > To: Maxime Coquelin ; dev@dpdk.org; Fu, > Patrick ; amore...@redhat.com > Subject: RE: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA > backend > > Hi Maxime, >

Re: [dpdk-dev] [PATCH v1 3/4] vhost: fix async vec buf overrun

2020-09-28 Thread Fu, Patrick
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 23, 2020 5:22 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Zhihong ; Jiang, Cheng1 > > Subject: Re: [PATCH v1 3/4] vhost: fix async vec buf overrun > > s/buf/b

Re: [dpdk-dev] [PATCH v1 2/4] vhost: dynamically alloc async memory

2020-09-28 Thread Fu, Patrick
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 23, 2020 5:15 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Zhihong ; Jiang, Cheng1 > > Subject: Re: [PATCH v1 2/4] vhost: dynamically alloc async memory > >

Re: [dpdk-dev] [PATCH v3 4/4] vhost: fix async register/unregister deadlock

2020-10-09 Thread Fu, Patrick
> -Original Message- > From: Maxime Coquelin > Sent: Monday, October 5, 2020 10:26 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Zhihong ; Jiang, Cheng1 > > Subject: Re: [PATCH v3 4/4] vhost: fix async register/unregister deadlock >

Re: [dpdk-dev] [PATCH v3 1/4] vhost: simplify async copy completion

2020-10-09 Thread Fu, Patrick
> > On 9/29/20 11:29 AM, Patrick Fu wrote: > > Current async ops allows check_completed_copies() callback to return > > arbitrary number of async iov segments finished from backend async > > devices. This design creates complexity for vhost to handle breaking > > transfer of a single packet (i.e. t

Re: [dpdk-dev] [PATCH v1 1/3] lib/mirror: introduce traffic mirror API

2020-09-08 Thread Fu, Patrick
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, September 9, 2020 9:10 AM > To: Fu, Patrick ; dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > maxime.coque...@redhat.com; Richardson, Bruce > ; mm6...@att.com; Wang, Zhihong > ; Wang, Liang-min