[dpdk-dev] [PATCH] MAINTAINERS: update entry for compressdev

2021-10-06 Thread Fiona Trahe
Replacing myself with Fan as compressdev API maintainer. Signed-off-by: Fiona Trahe --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 278e5b3..2586468 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -438,7 +438,7 @@ F: doc

[dpdk-dev] [PATCH] cryptodev: enable BPI for Cablelabs DOCSIS security spec

2017-01-18 Thread Fiona Trahe
-by: Fiona Trahe --- This patch is targeted at dpdk 17.05 release - pushing API early to give people a chance to comment. PMD patches implementing this are expected later in the 17.05 release cycle. lib/librte_cryptodev/rte_crypto_sym.h | 10 +- 1 file changed, 9 insertions(+), 1

[dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite in OOP case

2016-12-09 Thread Fiona Trahe
In out-of-place operation, data is DMAed from source mbuf to destination mbuf. To avoid header data in dest mbuf being overwritten, the minimal data-set should be DMAed. Fixes: 39e0bee48e81 ("crypto/qat: rework request builder for performance") Signed-off-by: Fiona Trahe CC: sta..

[dpdk-dev] [PATCH] crypto test: add integrity check for mbuf data

2016-12-22 Thread Fiona Trahe
In block cipher test cases, add checks that the source and destination mbufs are not modified except where expected. Signed-off-by: Fiona Trahe --- app/test/test_cryptodev_blockcipher.c | 139 -- 1 file changed, 134 insertions(+), 5 deletions(-) diff --git a/app

[dpdk-dev] [PATCH] crypto/qat: fix possible out-of-bounds error

2017-07-03 Thread Fiona Trahe
Out-of-bounds access possible if ctx.qat_cipher_alg has invalid value. This should never happen at this point on data path, but fix for safety. Coverity issue: 143458 Coverity issue: 143465 Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode") Signed-off-by: Fiona Trahe --

[dpdk-dev] [PATCH] doc: fix typo in qat ini file

2017-03-23 Thread Fiona Trahe
Fix typo in qat.ini file. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/features/qat.ini | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/features/qat.ini b/doc/guides/cryptodevs/features/qat.ini index 0c9c3b6..a3a46eb 100644 --- a/doc

[dpdk-dev] [PATCH] cryptodev: add API note

2017-03-23 Thread Fiona Trahe
Add note to cryptodev API that chained mbufs are not supported in DOCSISBPI mode. Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib

[dpdk-dev] [PATCH v3 0/3] crypto/qat: add support for Intel QAT device D15xx

2017-04-03 Thread Fiona Trahe
Add support for Intel QuickAssist Technology device D15xx v3 changes: - fix poor formatting in documentation v2 changes: - update documentation Fiona Trahe (3): crypto/qat: add support for Intel QAT device D15xx doc: restructure QAT PMD guide doc: add support for Intel QAT device

[dpdk-dev] [PATCH v3 1/3] crypto/qat: add support for Intel QAT device D15xx

2017-04-03 Thread Fiona Trahe
Add support for Intel QuickAssist Technology device D15xx Signed-off-by: Fiona Trahe --- drivers/crypto/qat/rte_qat_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 5b34f5e..386a449 100644

[dpdk-dev] [PATCH v3 2/3] doc: restructure QAT PMD guide

2017-04-03 Thread Fiona Trahe
Restructure QAT PMD instructions and add a device table to minimise duplication for each device and make it easier to add devices. Fix some device name typos and poor formatting. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 416 ++ 1

[dpdk-dev] [PATCH v3 3/3] doc: add support for Intel QAT device D15xx

2017-04-03 Thread Fiona Trahe
Add instructions for D15xx device to the QAT PMD guide. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index d6f1773..cf4ad9e 100644 --- a/doc

[dpdk-dev] [PATCH v2] cryptodev: add API note

2017-04-03 Thread Fiona Trahe
Add note to cryptodev API that chained mbufs are not supported in DOCSISBPI mode. Signed-off-by: Fiona Trahe --- v2 changes: - moved the comment from the rte_crypto_sym_op to the algorithm enum lib/librte_cryptodev/rte_crypto_sym.h | 4 1 file changed, 4 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH] crypto/qat: add support for Intel QAT device D15xx

2017-02-21 Thread Fiona Trahe
Add support for Intel QuickAssist Technology device D15xx Signed-off-by: Fiona Trahe --- drivers/crypto/qat/rte_qat_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 5b34f5e..386a449 100644

[dpdk-dev] [PATCH 0/4] crypto/qat: add DOCSISBPI mode support

2017-03-02 Thread Fiona Trahe
://dpdk.org/dev/patchwork/patch/20899) Fiona Trahe (4): crypto/qat: adding docsisbpi mode support test: add AES DOCSIS tests for QAT PMD test: add DES DOCSIS tests for QAT PMD test: added crypto OOP tests doc/guides/cryptodevs/overview.rst | 2 + doc/guides/cryptodevs

[dpdk-dev] [PATCH 2/4] test: add AES DOCSIS tests for QAT PMD

2017-03-02 Thread Fiona Trahe
Extend test suite to run AES DOCSIS tests on Intel QuickAssist PMD. Signed-off-by: Fiona Trahe --- app/test/test_cryptodev.c | 18 ++ app/test/test_cryptodev_aes_test_vectors.h | 18 -- 2 files changed, 30 insertions(+), 6 deletions(-) diff

[dpdk-dev] [PATCH 1/4] crypto/qat: adding docsisbpi mode support

2017-03-02 Thread Fiona Trahe
DOCSISPBI mode is handled in the QAT PMD by sending full blocks to the hardware device for encryption and using openssl libcrypto for pre- or post-processing of any partial blocks. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/overview.rst | 2 + doc/guides/cryptodevs

[dpdk-dev] [PATCH 4/4] test: added crypto OOP tests

2017-03-02 Thread Fiona Trahe
Added out-of-place (OOP) tests for AES-CBC, AES-DOCSIS and DES-DOCSIS to tests suites for QuickAssist and openssl PMDs. Signed-off-by: Fiona Trahe --- app/test/test_cryptodev_aes_test_vectors.h | 58 ++ app/test/test_cryptodev_des_test_vectors.h | 49

[dpdk-dev] [PATCH 3/4] test: add DES DOCSIS tests for QAT PMD

2017-03-02 Thread Fiona Trahe
Extend test suite to run DES DOCSIS tests on Intel QuickAssist PMD. Signed-off-by: Fiona Trahe --- app/test/test_cryptodev.c | 18 ++ app/test/test_cryptodev_des_test_vectors.h | 18 -- 2 files changed, 30 insertions(+), 6 deletions

[dpdk-dev] [PATCH] doc: fix crypto overview matrix for missing QAT items

2017-03-03 Thread Fiona Trahe
bdbe12fbfc1 ("crypto/qat: add aes-sha224-hmac capability") Fixes: d905ee32d0dc ("crypto/qat: add aes-sha384-hmac capability") Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Fixes: d4f2745300e0 ("crypto/qat: add KASUMI") Fixes: 2fa64f840d65 (&q

[dpdk-dev] [PATCH v2 0/3] crypto/qat: add support for Intel QAT device D15xx

2017-03-09 Thread Fiona Trahe
Add support for Intel QuickAssist Technology device D15xx v2 changes: - update documentation Fiona Trahe (3): crypto/qat: add support for Intel QAT device D15xx doc: restructure QAT PMD guide doc: add support for Intel QAT device D15xx doc/guides/cryptodevs/qat.rst | 374

[dpdk-dev] [PATCH v2 1/3] crypto/qat: add support for Intel QAT device D15xx

2017-03-09 Thread Fiona Trahe
Add support for Intel QuickAssist Technology device D15xx Signed-off-by: Fiona Trahe --- drivers/crypto/qat/rte_qat_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 5b34f5e..386a449 100644

[dpdk-dev] [PATCH v2 3/3] doc: add support for Intel QAT device D15xx

2017-03-09 Thread Fiona Trahe
Add instructions for D15xx device to the QAT PMD guide. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 4927a00..897919e 100644 --- a/doc

[dpdk-dev] [PATCH v2 2/3] doc: restructure QAT PMD guide

2017-03-09 Thread Fiona Trahe
Restructure QAT PMD instructions and add a device table to minimise duplication for each device and make it easier to add devices. Fix some device name typos. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 370 +- 1 file changed, 148

[dpdk-dev] [PATCH 1/2] crypto/qat: rework request builder for performance

2016-10-24 Thread Fiona Trahe
re-factored to do this efficiently. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_adf/icp_qat_hw.h | 5 + drivers/crypto/qat/qat_adf/qat_algs.h| 1 + drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 + drivers/crypto/qat/qat_crypto.c | 239

[dpdk-dev] [PATCH 0/2] crypto/qat: performance optimisation

2016-10-24 Thread Fiona Trahe
re-factored to do this efficiently. Also performance test not taking IV prepend offsets into account were corrected. Fiona Trahe (2): crypto/qat: rework request builder for performance app/test: use correct offsets in AES perf test app/test/test_cryptodev_perf.c | 15

[dpdk-dev] [PATCH 2/2] app/test: use correct offsets in AES perf test

2016-10-24 Thread Fiona Trahe
offsets for digest and data need to be adjusted to take prepended IV into account Signed-off-by: Fiona Trahe --- app/test/test_cryptodev_perf.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c

[dpdk-dev] [PATCH] doc/guides: add more info re VT-d/iommu settings for QAT

2016-10-26 Thread Fiona Trahe
add more info re VT-d/iommu settings for QAT remove limitation re performance tuning Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index

[dpdk-dev] [PATCH v2] doc/guides: add more info about VT-d/iommu settings

2016-10-26 Thread Fiona Trahe
Add more information about VT-d/iommu settings for QAT PMD. Remove limitation indicating QAT driver is not performance tuned. Signed-off-by: Fiona Trahe --- v2: clarified commit message doc/guides/cryptodevs/qat.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH v3 0/2] Add 3DES support to Quickassist PMD

2016-09-16 Thread Fiona Trahe
rypto patch, which will be sent separately. Changes since v1: * rebased qat.rst against Kasumi patch changes http://dpdk.org/dev/patchwork/patch/15320/ http://dpdk.org/dev/patchwork/patch/15322/ Changes since v2: * added 3DES to QAT PMD capabilities * added 3DES to 16.11 release notes. Fiona Tra

[dpdk-dev] [PATCH v3 1/2] crypto/qat: code cleanup

2016-09-16 Thread Fiona Trahe
Cleanup of unused code. Rename and simplify a badly named struct element, was aes, but used for all types of ciphers Print correct error msg (Unsupported rather than Undefined) for all ciphers not supported by qat PMD. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_adf/icp_qat_hw.h

[dpdk-dev] [PATCH v3 2/2] crypto/qat: adding support for 3DES cipher algorithm

2016-09-16 Thread Fiona Trahe
3DES support added to QuickAssist PMD With CTR and CBC mode. Both cipher-only and chained with HMAC_SHAx This patch depends on following patch : crypto/qat: enable support of Kasumi F8 in QAT cryptodev http://dpdk.org/dev/patchwork/patch/15813/ Signed-off-by: Fiona Trahe --- doc/guides

[dpdk-dev] [PATCH] app/test: improve error message in crypto test code

2016-09-16 Thread Fiona Trahe
Resending patch as first send got to mailing list but didn't get to pachwork Improve error message if crypto PMD build is not enabled in config file Signed-off-by: Fiona Trahe --- app/test/test_cryptodev.c | 37 + app/test/test_cryptodev_perf.c

[dpdk-dev] [PATCH v2] app/test: improve error message in crypto test code

2016-09-26 Thread Fiona Trahe
Improve error message if crypto PMD build is not enabled in config file Signed-off-by: Fiona Trahe --- app/test/test_cryptodev.c | 33 + app/test/test_cryptodev_perf.c | 18 ++ 2 files changed, 51 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto num qps

2016-09-29 Thread Fiona Trahe
and setting up queue-pair of a different size fails. Signed-off-by: Akhil Goyal Signed-off-by: Fiona Trahe --- v2: Fix for broken QAT PMD unit tests exposed by v1 i.e. In test_device_configure_invalid_queue_pair_ids() after running tests for invalid values restore original nb_queue_pairs. A

[dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-25 Thread Fiona Trahe
Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 11 ++- 1 file changed, 6 insert

[dpdk-dev] [PATCH] app/crypto-perf: add minimise-offload-cost flag

2017-05-09 Thread Fiona Trahe
which can be acheived. Signed-off-by: Fiona Trahe --- app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 12 + app/test-crypto-perf/cperf_test_throughput.c | 76 ++-- 3 files changed, 75 insertions(+), 15 deletions(-) diff

[dpdk-dev] [PATCH] test/crypto: fix misleading trace message

2018-12-20 Thread Fiona Trahe
Test was reporting digest verification failed for all operation errors. Fixed so it only reports this if the PMD actually reports an auth failure. Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test") CC: sta...@dpdk.org Signed-off-by: Fiona Trahe ---

[dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD

2018-12-20 Thread Fiona Trahe
Remove AESNI_MB flag from SGL test cases which it doesn't support. Signed-off-by: Fiona Trahe --- test/test/test_cryptodev_aes_test_vectors.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test/test_cryptodev_aes_test_vectors.h b/test

[dpdk-dev] [PATCH] crypto/aesni_mb: enable out of place processing

2018-12-20 Thread Fiona Trahe
Add out-of-place processing, i.e. different source and destination m_bufs, plus related capability update, tests and documentation. Document limitation to cipher-only as lib doesn't support digest generation in encrypt & generate direction for out-of-place yet. Signed-off-by: Fiona Trah

[dpdk-dev] [PATCH] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
.@dpdk.org Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 6 -- drivers/crypto/qat/qat_sym_pmd.c| 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 63af23a..6510

[dpdk-dev] [PATCH v2] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
tions") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v2 changes: - clarified documentation doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 6 -- drivers/crypto/qat/qat_sym_pmd.c| 6 -- 3 files changed, 11 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH] common/qat: add support for GEN3 devices

2018-10-01 Thread Fiona Trahe
This adds pci detection, queue-pair configuration and documentation for Intel GEN3 QuickAssist devices. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 3 +++ doc/guides/rel_notes/release_18_11.rst | 4 drivers/common/qat/qat_common.h| 3 ++- drivers

[dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding

2018-10-05 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 changes: - allocate 2 buffers per intermediate buffer sgl - Compile out trace for debugging intermediate buffers Depends on: https://patches.dpdk.org/patch/45794/ config

[dpdk-dev] [PATCH v3] compress/qat: enable dynamic huffman encoding

2018-10-11 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v3 changes: - reverted to 1 buffer per intermediate buffer sgl v2 changes: - allocate 2 buffers per intermediate buffer sgl - Compile out trace for debugging intermediate

[dpdk-dev] [PATCH v3] drivers/qat: fix failure to create PMD

2018-10-11 Thread Fiona Trahe
rg Signed-off-by: Fiona Trahe --- v3 changes: - moved checks up a layer to the probe fn as more appropriate place. v2 changes: - clarified documentation drivers/common/qat/qat_device.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v4] compress/qat: enable dynamic huffman encoding

2018-10-15 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v4 changes: - use #define for IM buffer logs, disable all by default and use param for clearer hexdump length. v3 changes: - reverted to 1 buffer per intermediate buffer sgl

[dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-17 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v5 changes: - update release note v4 changes: - use #define for IM buffer logs, disable all by default and use param for clearer hexdump length. v3

[dpdk-dev] [PATCH] common/qat: replace snprintf

2018-07-02 Thread Fiona Trahe
Replaced snprintf with strlcpy for safer string copy Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/common/qat/qat_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c index

[dpdk-dev] [PATCH v2 00/16] compress/qat: add compression PMD

2018-07-05 Thread Fiona Trahe
device Fiona Trahe (16): common/qat: updated firmware headers compress/qat: add makefiles for PMD compress/qat: add meson build compress/qat: add xform processing compress/qat: create fw request and process response compress/qat: check that correct firmware is in use compress/qat: add

[dpdk-dev] [PATCH v2 01/16] common/qat: updated firmware headers

2018-07-05 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Change-Id: Ia8890f78361852664d555db1a26ecc03ef2c39d2 Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat

[dpdk-dev] [PATCH v2 03/16] compress/qat: add meson build

2018-07-05 Thread Fiona Trahe
Add meson build files. Change-Id: Ia759f56fcc230f90252afcc5e1745c6fb78cefa3 Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18

[dpdk-dev] [PATCH v2 02/16] compress/qat: add makefiles for PMD

2018-07-05 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Change-Id: I71c4c6abd1982443cd6f7ff25e03bb161fb3fb16 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak

[dpdk-dev] [PATCH v2 05/16] compress/qat: create fw request and process response

2018-07-05 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Change-Id: Ie03a6ba3de3741f237e2247d543f2e7101c7435d Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101

[dpdk-dev] [PATCH v2 04/16] compress/qat: add xform processing

2018-07-05 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Change-Id: I8e785d3a6ab3fe196d581413d938244f8143d7bb Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239

[dpdk-dev] [PATCH v2 06/16] compress/qat: check that correct firmware is in use

2018-07-05 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Change-Id: I0d1a6ba3a27380226e60491e66aef3284e49de67 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers

[dpdk-dev] [PATCH v2 07/16] compress/qat: add stats functions

2018-07-05 Thread Fiona Trahe
Add fns to get and clear compression queue-pair stats. Change-Id: I22cbf2425c96850472410da11a18be64727f5d17 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7

[dpdk-dev] [PATCH v2 09/16] compress/qat: add fns to configure and clear device

2018-07-05 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Change-Id: I24d75b20141ae9bda3917dda0c9c2accf874cf88 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c

[dpdk-dev] [PATCH v2 08/16] compress/qat: setup queue-pairs for compression service

2018-07-05 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Change-Id: Id9e517eb7bfcbbd3a79cae8f6757c91cc46d4de6 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 62

[dpdk-dev] [PATCH v2 10/16] compress/qat: add fn to return device info

2018-07-05 Thread Fiona Trahe
Add capabilities ptr to internal qat comp device and function to return this and other info. Change-Id: Ic0bf5375e0fbf6338d90fb10e7b9ae1454c93792 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 18 ++ drivers/compress/qat

[dpdk-dev] [PATCH v2 11/16] compress/qat: add enqueue/dequeue functions

2018-07-05 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Change-Id: Ie2fd918f17b29fd97f52ce9773966d231f4c7a33 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h

[dpdk-dev] [PATCH v2 12/16] compress/qat: add device start and stop fns

2018-07-05 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Change-Id: I09288ffee58614ee68acf54f031b0eadb991b266 Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat

[dpdk-dev] [PATCH v2 13/16] compress/qat: create and populate the ops structure

2018-07-05 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific finctions. Change-Id: I4fec917df598b983b889e4e07e5aa110774e446d Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat

[dpdk-dev] [PATCH v2 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-05 Thread Fiona Trahe
Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/common/qat/qat_device.h | 4 ++ drivers/common/qat/qat_qp.c | 11 - drivers/common/qat/qat_qp.h | 5 ++ drivers/compress/qat/qat_comp_pmd.c | 95 +++-- drivers/compress/qat

[dpdk-dev] [PATCH v2 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-05 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Change-Id: Ie196fbaa0ab09ecdf5dfb8e4c3059b3d437a53a6 Signed-off-by

[dpdk-dev] [PATCH v2 16/16] docs/qat: refactor docs adding compression guide

2018-07-05 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common informationi, particularly about kernel driver. Update release note. Update compression feature ist for qat. Change-Id: I7d9bde8b71d23e5e160170243ae4705aaa4cff3d Signed-off-by: Fiona Trahe --- config/common_base

[dpdk-dev] [PATCH v3 00/16] compress/qat: add compression PMD

2018-07-05 Thread Fiona Trahe
huffman encoding and related IM buffer config flag - Removed support for DH895xcc device Fiona Trahe (16): common/qat: updated firmware headers compress/qat: add makefiles for PMD compress/qat: add meson build compress/qat: add xform processing compress/qat: create fw request and process

[dpdk-dev] [PATCH v3 01/16] common/qat: updated firmware headers

2018-07-05 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482

[dpdk-dev] [PATCH v3 02/16] compress/qat: add makefiles for PMD

2018-07-05 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- MAINTAINERS | 4

[dpdk-dev] [PATCH v3 03/16] compress/qat: add meson build

2018-07-05 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat

[dpdk-dev] [PATCH v3 08/16] compress/qat: setup queue-pairs for compression service

2018-07-05 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 62 + drivers/compress/qat

[dpdk-dev] [PATCH v3 07/16] compress/qat: add stats functions

2018-07-05 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v3 06/16] compress/qat: check that correct firmware is in use

2018-07-05 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compress/qat/qat_comp.h | 2 ++ 2 files changed, 17

[dpdk-dev] [PATCH v3 05/16] compress/qat: create fw request and process response

2018-07-05 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101 drivers/compress/qat/qat_comp.h | 8

[dpdk-dev] [PATCH v3 09/16] compress/qat: add fns to configure and clear device

2018-07-05 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 96 + drivers

[dpdk-dev] [PATCH v3 04/16] compress/qat: add xform processing

2018-07-05 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 drivers/compress/qat

[dpdk-dev] [PATCH v3 10/16] compress/qat: add fn to return device info

2018-07-05 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 18 ++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 24

[dpdk-dev] [PATCH v3 11/16] compress/qat: add enqueue/dequeue functions

2018-07-05 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h | 8 2 files changed, 22 insertions(+) diff

[dpdk-dev] [PATCH v3 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-05 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_

[dpdk-dev] [PATCH v3 13/16] compress/qat: create and populate the ops structure

2018-07-05 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific functions. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_comp_pmd.h | 30 - 2 files

[dpdk-dev] [PATCH v3 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-05 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz

[dpdk-dev] [PATCH v3 12/16] compress/qat: add device start and stop fns

2018-07-05 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 17 insertions

[dpdk-dev] [PATCH v3 16/16] docs/qat: refactor docs adding compression guide

2018-07-05 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common information, particularly about kernel driver dependency. Update release note. Update compression feature list for qat. Signed-off-by: Fiona Trahe --- config/common_base | 2 +- doc/guides/compressdevs/features

[dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-06 Thread Fiona Trahe
() rte_cryptodev_sym_session_get_user_data() Refers to changes introduced here: https://patches.dpdk.org/patch/38172/ Signed-off-by: Fiona Trahe --- doc/guides/prog_guide/cryptodev_lib.rst| 14 +++--- doc/guides/prog_guide/event_crypto_adapter.rst | 6 +++--- doc/guides/rel_notes/release_18_08.rst

[dpdk-dev] [PATCH] common/qat: fix for invalid response from firmware

2018-10-23 Thread Fiona Trahe
Check that the firmware response has a bit set indicating it's valid before dereferencing the rest of the response contents. Fixes: 0bdd36e12245 ("crypto/qat: make dequeue function generic") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 8 +

[dpdk-dev] [PATCH v6] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v6 changes: - replace %lx with PRIx64 to fix compiler issue - reorder entry in release notes so

[dpdk-dev] [PATCH v7] compress/qat: enable dynamic huffman encoding

2018-10-26 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v7 changes: - replace %ld with %zu for printing size_t to fix compiler issue - replace phys addr with rte_iova_t v6 changes

[dpdk-dev] [PATCH] lib/compressdev: clarify usage of op structure

2018-10-26 Thread Fiona Trahe
Add note on usage of op structure and when it can be accessed and freed. Fixes: 63f4bfd5328b ("compressdev: add enqueue/dequeue functions") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_compressdev.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH] lib/compressdev: Fix logic error on op allocation

2018-10-26 Thread Fiona Trahe
("compressdev: add operation management") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c index c663be

[dpdk-dev] [PATCH v2] lib/compressdev: Fix logic error on op allocation

2018-10-26 Thread Fiona Trahe
;) Cc: sta...@dpdk.org Reported-by: Sabyasachi Sengupta Signed-off-by: Fiona Trahe --- v2 change: - added Reported-by tag lib/librte_compressdev/rte_comp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/

[dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

2018-10-30 Thread Fiona Trahe
ned-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 38 - 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 01dd736..ea93077 100644 --- a/drivers/co

[dpdk-dev] [PATCH] test/compress: improve trace

2018-10-30 Thread Fiona Trahe
Make clear which engine is compressing and which is decompressing in debug output. Also add newline and print ratio = 0 if test fails. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/test

[dpdk-dev] [PATCH] compress/qat: display error in case IM buffer too small

2018-10-30 Thread Fiona Trahe
Display trace if error returned from firmware is likely due to intermediate buffers being too small for the compressed output. Update documentation to explain this error case and to clarify intermediate buffer memory usage. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 22

[dpdk-dev] [PATCH v2] compress/qat: display error in case IM buffer too small

2018-10-31 Thread Fiona Trahe
Display trace if error returned from firmware is likely due to intermediate buffers being too small for the compressed output. Update documentation to explain this error case and to clarify intermediate buffer memory usage. Signed-off-by: Fiona Trahe --- v2 changes: - improved some text in

[dpdk-dev] [PATCH 0/2] compressdev: add bulk op free API

2018-11-19 Thread Fiona Trahe
Add API to bulk free operations and use it in the unit test suite. Fiona Trahe (2): compressdev: add api to bulk free ops test/compress: use bulk free operations api lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h

[dpdk-dev] [PATCH 1/2] compressdev: add api to bulk free ops

2018-11-19 Thread Fiona Trahe
There's an API to bulk allocate operations, this adds a corresponding bulk free API. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h | 14 ++ lib/librte_compre

[dpdk-dev] [PATCH 2/2] test/compress: use bulk free operations api

2018-11-19 Thread Fiona Trahe
Use the new rte_comp_op_bulk_free API. Add trace to catch any mempool elements not freed at test end. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test

[dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-11-19 Thread Fiona Trahe
enqueue (default). An application may find this useful for tuning. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_compressdev.c | 2 ++ lib/librte_compressdev/rte_compressdev.h | 8 2 files changed, 10 insertions(+) diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib

[dpdk-dev] [PATCH v4 01/16] common/qat: updated firmware headers

2018-07-09 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482

[dpdk-dev] [PATCH v4 00/16] compress/qat: add compression PMD

2018-07-09 Thread Fiona Trahe
device Fiona Trahe (16): common/qat: updated firmware headers compress/qat: add makefiles for PMD compress/qat: add meson build compress/qat: add xform processing compress/qat: create fw request and process response compress/qat: check that correct firmware is in use compress/qat: add

[dpdk-dev] [PATCH v4 03/16] compress/qat: add meson build

2018-07-09 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat

  1   2   3   4   >