Re: [PATCH v2 15/21] net/virtio-user: get max number of queue pairs from device

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > When supported by the backend (only vDPA for now), this > patch gets the maximum number of queue pairs supported by > the device by querying it in its config space. > > This is required for adding backend control queue support, > as is inde

Re: [PATCH v2 16/21] net/virtio-user: allocate shadow control queue

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > If the backends supports control virtqueue, allocate a > shadow control virtqueue, and implement the notify callback > that writes into the kickfd. > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia Even with the nitpick below,

Re: [PATCH v2 17/21] net/virtio-user: send shadow virtqueue info to the backend

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > This patch adds sending the shadow control queue info > to the backend. > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez > --- > .../net/virtio/virtio_user/virtio_user_dev.c | 28 --

Re: [PATCH v2 18/21] net/virtio-user: add new callback to enable control queue

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > This patch introduces a new callback that is to be called > when the backend supports control virtqueue. > > Implementation for Vhost-vDPA backend is added in this patch. > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia Small

Re: [PATCH v2 20/21] net/virtio-user: advertize control VQ support with vDPA

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > This patch advertizes control virtqueue support by the vDPA > backend if it supports VIRTIO_NET_F_CTRL_VQ. > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez > --- > drivers/net/virtio/virtio_user/vho

Re: [PATCH v2 19/21] net/virtio-user: forward control messages to shadow queue

2023-02-07 Thread Eugenio Perez Martin
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > This patch implements control messages forwarding from the > regular control queue to the shadow control queue. > > Signed-off-by: Maxime Coquelin Acked-by: Eugenio Pérez > --- > .../net/virtio/virtio_user/virtio_user_dev.c | 35 +

Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop

2021-08-30 Thread Eugenio Perez Martin
On Mon, Aug 30, 2021 at 1:58 PM Xia, Chenbo wrote: > > Hi Eugenio, > Hi Chenbo, > > -Original Message- > > From: Eugenio Pérez > > Sent: Saturday, August 28, 2021 12:13 AM > > To: Maxime Coquelin ; Xia, Chenbo > > > > Cc: dev@dpdk.org; Pei Zhang ; Jason Wang > > > > Subject: [PATCH] v

Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop

2021-08-31 Thread Eugenio Perez Martin
On Tue, Aug 31, 2021 at 4:02 AM Xia, Chenbo wrote: > > Hi Eugenio, > > > -Original Message- > > From: Eugenio Perez Martin > > Sent: Tuesday, August 31, 2021 2:10 AM > > To: Xia, Chenbo > > Cc: Maxime Coquelin ; dev@dpdk.org; Pei Zhang > >

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Eugenio Perez Martin
Hi Kevin! Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize packed ring dequeue"), what was not present on 18.11 version (I've checked that v19.08 does not contain the failure). Do I need to send another patch version with corrected commit message? Thanks! On Fri, Jan 3

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Eugenio Perez Martin
n 04/02/2020 09:23, Eugenio Perez Martin wrote: > > Hi Kevin! > > > > Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: > optimize > > packed ring dequeue"), what was not present on 18.11 version (I've > checked > > that v19.08 does not c

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Eugenio Perez Martin
Thanks! On Wed, Feb 5, 2020 at 10:48 AM Maxime Coquelin wrote: > > > On 2/4/20 3:47 PM, Eugenio Pérez wrote: > > The current implementation of vhost_net in packed vring tries to fill > > the shadow vector before send any actual changes to the guest. While > > this can be beneficial for the throu

Re: [dpdk-dev] [PATCH 0/1] vhost: fix iotlb mempool single-consumer flag

2020-08-18 Thread Eugenio Perez Martin
On Mon, Aug 10, 2020 at 4:11 PM Eugenio Pérez wrote: > > Bugzilla bug: 523 > > Using testpmd as a vhost-user with iommu: > > /home/dpdk/build/app/dpdk-testpmd -l 1,3 \ > --vdev net_vhost0,iface=/tmp/vhost-user1,queues=1,iommu-support=1 \ > -- --auto-start --stats-period 5 --forward

Re: [dpdk-dev] [PATCH 1/1] vhost: fix iotlb mempool single-consumer flag

2020-08-26 Thread Eugenio Perez Martin
Hi Chenbo. On Wed, Aug 26, 2020 at 8:29 AM Xia, Chenbo wrote: > > Hi Eugenio, > > > -Original Message- > > From: Eugenio Pérez > > Sent: Monday, August 10, 2020 10:11 PM > > To: dev@dpdk.org > > Cc: Adrian Moreno Zapata ; Maxime Coquelin > > ; sta...@dpdk.org; Wang, Zhihong > > ; Xia, Ch

Re: [PATCH 0/2] Search the split vq desc and avail in RO areas

2025-06-05 Thread Eugenio Perez Martin
On Thu, Jun 5, 2025 at 1:50 PM David Marchand wrote: > > On Thu, Jun 5, 2025 at 1:36 PM Eugenio Pérez wrote: > > > > QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If > > we don't change it, vhost_iova_to_vva do not consider them as valid and > > returns that they're not foun

Re: [PATCH 1/2] vhost: search the split vq desc and avail in RO areas

2025-06-12 Thread Eugenio Perez Martin
On Thu, Jun 12, 2025 at 3:56 PM Maxime Coquelin wrote: > > > > On 6/5/25 1:35 PM, Eugenio Pérez wrote: > > QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If > > we don't change it, vhost_iova_to_vva do not consider them as valid and > > returns that they're not found. > > > >