[dpdk-dev] Tcpdump

2016-10-27 Thread Dror Birkman
Hi, I have a DPDK application that binds to an interface and processes packets. For debugging purposes I want to run tcpdump on this interface. IYO, what is my best option with hurting the performance of the application too much? TIA, Dror

[dpdk-dev] pcap: memory leak in eth_pcap_rx_jumbo

2016-09-18 Thread Dror Birkman
Hi, It seems there is a memory leak in eth_pcap_rx_jumbo() in case rte_pktmbuf_alloc() fails on any segment that is not the initial segment. If someone can confirm it, I'll patch it. TIA, Dror

[dpdk-dev] [PATCH] pcap: fix memory leak in jumbo frames

2016-09-20 Thread Dror Birkman
If rte_pktmbuf_alloc() fails on any segment that is not the initial segment, previously allocated mbufs are not freed. Signed-off-by: Dror Birkman --- drivers/net/pcap/rte_eth_pcap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers

[dpdk-dev] [PATCH] pcap: fix memory leak in jumbo frames

2016-09-20 Thread Dror Birkman
Cool! Adding fixline: If rte_pktmbuf_alloc() fails on any segment that is not the initial segment, previously allocated mbufs are not freed. Fixes: 6db141c91e1f ("pcap: support jumbo frames") Signed-off-by: Dror Birkman --- drivers/net/pcap/rte_eth_pcap.c | 4 +++- 1 file

[dpdk-dev] [PATCH v2] pcap: fix memory leak in jumbo frames

2016-09-20 Thread Dror Birkman
If rte_pktmbuf_alloc() fails on any segment that is not the initial segment, previously allocated mbufs are not freed. Fixes: 6db141c91e1f ("pcap: support jumbo frames") Cc: Signed-off-by: Dror Birkman --- drivers/net/pcap/rte_eth_pcap.c | 4 +++- 1 file changed, 3 insertions(+),

[dpdk-dev] [PATCH] pcap: fix captured frame length

2016-01-28 Thread Dror Birkman
The actual captured length is header.caplen, whereas header.len is the original length on the wire. Signed-off-by: Dror Birkman --- Without this fix, if the captured length is smaller than the original length on the wire, mbuf will contain incorrect data. drivers/net/pcap/rte_eth_pcap.c

[dpdk-dev] [PATCH] pcap: fix captured frame length

2016-01-30 Thread Dror Birkman
ur setup unusual though? > This might sound like a silly question but I don't remember seeing that > issue and I should have since your fix is correct. > > Nico. > > On 28/01/16 08:09, Dror Birkman wrote: > > The actual captured length is header.caplen, whereas header.len

[dpdk-dev] PCAP memory leak in freeing jumbo frames

2016-11-03 Thread Dror Birkman
Hi, I have a huge memory leak when I release mbufs allocated by eth_pcap_rx_jumbo(). I use rte_mempool_put_bulk() to release the mbufs. To my horror I found out it puts back to the mempool only the head mbuf and not its segments! I know rte_pktmbuf_free() frees the mbuf and all it segments, but