I made a mistake, The subtile shoud be [PATCH v4].
Others is ok.
Thanks,
Dongdong
On 2022/9/24 16:13, Dongdong Liu wrote:
This patchset is to add some extended features for dpdk-proc-info.
Thanks to Reshma and Stephen help to review the patchset and give many
useful comments.
v3->v4:
-
Hi Reshma
Many thanks for your view.
On 2022/9/23 20:18, Pattan, Reshma wrote:
-Original Message-
From: Dongdong Liu
Subject: [PATCH v4 3/3] app/procinfo: support descriptor dump
From: "Min Hu (Connor)"
This patch support HW Rx/Tx descriptor dump
The command is like:
Hi Andrew
Kindly ping. Could you have a look at these patches?
Thanks,
Dongdong
On 2022/9/5 16:59, Dongdong Liu wrote:
This patchset consists of two parts that have been sent out before.
1. [PATCH 0/5] some bugfixes and clean code for hns3
https://lore.kernel.org/all/20220713115002.8959-2
ist can be used to restore. The modification of RSS function may
introduce new problem. So this patch fix it.
Fixes: eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/h
Feng (5):
net/hns3: fix header file self contained
net/hns3: remove unused structure definition
net/hns3: do not use reserved identifier macro
net/hns3: revert fix mailbox communication with HW
net/hns3: fix VF mark wrong message processed
Dongdong Liu (1):
net/hns3: fix gcov compile
ix flushing RSS rule")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_flow.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
index b84f2
27 ("net/hns3: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_flow.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
index
inked
list to restore RSS flow rule.
Fixes: 920be799dbc3 ("net/hns3: fix RSS indirection table configuration")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.c| 11 ++-
drivers/net/hns3/hns3_ethdev_vf.c | 11 +
off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 330a913cb8..bbc086f21d 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2808,6 +280
From: Jie Hai
Removing magic numbers with macros.
Signed-off-by: Jie Hai
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index bbc086f21d
ssing outer L4 UDP flag for VXLAN")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index fc304e1efd..
e_eth_devices[]'. So this patch fix the input of this function.
Fixes: 920be799dbc3 ("net/hns3: fix RSS indirection table configuration")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.c| 3 +--
drivers/net/hns3/hns
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.c | 4
drivers/net/hns3/hns3_fdir.c | 3 +++
drivers/net/hns3/hns3_flow.c | 7 +++
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/hns3/hns3_et
From: Chengwen Feng
This patch removes unused structure definition.
Signed-off-by: Chengwen Feng
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_cmd.h | 19 ---
drivers/net/hns3/hns3_rss.h | 4
2 files changed, 23 deletions(-)
diff --git a/drivers/net/hns3
From: Chengwen Feng
Header files should be self contained and should not be cyclically
dependent. This patch fixed it.
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_cmd.h| 3 +++
drivers/net/hns3/hns3_common.c | 2 +-
drivers
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_cmd.h | 6 +++---
drivers/net/hns3/hns3_common.h| 6 +++---
drivers/net/hns3/hns3_dcb.h | 6 +++---
drivers/net/hns3/hns3_dump.h | 6 +++---
drivers/net/hns3/hns3_ethdev.h| 6 +++---
drivers/net
os.
Fixes: 806f1d5ab0e3 ("net/hns3: set RSS hash type input configuration")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_rss.c | 14 ++
drivers/net/hns3/hns3_rss.h | 2 ++
2 files changed, 16 insertions(+)
diff --gi
From: Huisong Li
This patch fixes spelling errors about IPV6-SCTP macro.
Fixes: 1bc633c34008 ("net/hns3: enable RSS for IPv6-SCTP dst/src port fields")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_rss.c | 12 ++--
1 fi
From: Huisong Li
When user set 'L3_SRC/DST_ONLY' or 'L4_SRC/DST_ONLY' to 'rss_hf' and
do not specify the packet type, these types will be set to hardware.
So this patch adds a check for them.
Fixes: 806f1d5ab0e3 ("net/hns3: set RSS hash type input configuration")
Cc: sta...@dpdk.org
Signed-off-
or 'ipv4' flow. So this patch fixes
this problem.
Fixes: 806f1d5ab0e3 ("net/hns3: set RSS hash type input configuration")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_rss.c | 266
1 fi
ommunication with HW")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_mbx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index 02028dcd9c..910a16c999
.
Fixes: 395b5e08ef8d ("net/hns3: add Tx short frame padding compatibility")
Cc: sta...@dpdk.org
Signed-off-by: Jie Hai
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_cmd.h | 6 ++
drivers/net/hns3/hns3_ethdev.c| 4 +++-
drivers/net/hns3/hns3_ethdev.h| 3 +--
driver
ndary process")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_mbx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index 910a16c999..8e0a58aa02 100644
---
Hi Ferruh
Many thanks for your review.
On 2022/10/4 6:40, Ferruh Yigit wrote:
On 9/23/2022 8:43 AM, Dongdong Liu wrote:
From: "Min Hu (Connor)"
Added the ethdev Rx/Tx desc dump API which provides functions for query
descriptor from device. HW descriptor info differs in different
entation and procinfo part
Dongdong Liu (3):
ethdev: introduce ethdev desc dump API
net/hns3: support Rx/Tx bd dump
app/procinfo: support descriptor dump
app/proc-info/main.c | 80 +++
doc/guides/rel_notes/release_22_11.rst | 6 ++
drivers/net/hns3/
-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
doc/guides/rel_notes/release_22_11.rst | 6 +++
lib/ethdev/ethdev_driver.h | 53 +
lib/ethdev/rte_ethdev.c| 52
lib/ethdev/rte_ethdev.h| 55
This patch support query HW descriptor from hns3 device. HW descriptor
is also called BD(buffer description) which is shared memory between
software and hardware.
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_dump.c | 88
.
offset: The offset of the descriptor starting from tail.
num: The number of the descriptors to dump.
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
app/proc-info/main.c | 80
1 file changed, 80 insertions(+)
diff --git a/app/proc-info
ome comments from Reshma.
Dongdong Liu (4):
app/procinfo: add firmware version dump
app/procinfo: fix some wrong doxygen syntax
app/procinfo: support descriptor dump
doc: add some extended features in procinfo guide
Jie Hai (1):
app/procinfo: add dump of Rx/Tx burst mode
Min Hu (Connor
From: "Min Hu (Connor)"
Add support for dump dpdk version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 19 ++-
1 fi
From: "Min Hu (Connor)"
This patch add support for module eeprom info dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-module-eeprom
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
From: "Min Hu (Connor)"
This patch add support for RSS reta dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rss-reta
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
Add support for dump ethdev firmware version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --firmware-version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 35 +++
1
: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 90e7e41e38..67217ab68b 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -845,6 +845,7 @@ show_port(void
This code is to do cleanup for the wrong doxygen syntax comments
The DPDK API is documented using doxygen comment annotations in the
header files. The procinfo code seems no need to use doxygen comment.
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 40
.
offset: The offset of the descriptor starting from tail.
num: The number of the descriptors to dump.
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
app/proc-info/main.c | 81
1 file changed, 81 insertions(+)
diff --git a/app/proc-info
Add the below extended features in procinfo guide.
--show-port-private
--version
--firmware-version
--show-rss-reta
--show-module-eeprom
--show-rx-descriptor
--show-tx-descriptor
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
doc/guides/tools/proc_info.rst | 36
Hi Reshma
Many thanks for your review.
I have sent out the below patchset. this patchset have fixed the comments.
[v8,7/8] app/procinfo: support descriptor dump
https://patches.dpdk.org/project/dpdk/list/?series=25047
Thanks,
Dongdong.
On 2022/10/7 22:43, Pattan, Reshma wrote:
-Original
Delete some unnecessary code.
v1->v2: Fix some comments from Reshma.
Dongdong Liu (4):
app/procinfo: add firmware version dump
app/procinfo: fix some wrong doxygen syntax
app/procinfo: support descriptor dump
doc: add some extended features in procinfo guide
Jie Hai (1):
app/procinfo:
From: "Min Hu (Connor)"
Add support for dump dpdk version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 19 ++-
1 fi
Add support for dump ethdev firmware version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --firmware-version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 35 +++
1
From: "Min Hu (Connor)"
This patch add support for RSS reta dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rss-reta
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
From: "Min Hu (Connor)"
This patch add support for module eeprom info dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-module-eeprom
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
This code is to do cleanup for the wrong doxygen syntax comments
The DPDK API is documented using doxygen comment annotations in the
header files. The procinfo code seems no need to use doxygen comment.
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 40
: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 90e7e41e38..67217ab68b 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -845,6 +845,7 @@ show_port(void
.
offset: The offset of the descriptor starting from tail.
num: The number of the descriptors to dump.
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
app/proc-info/main.c | 80
1 file changed, 80 insertions(+)
diff --git a/app/proc-info
Add the below extended features in procinfo guide.
--show-port-private
--version
--firmware-version
--show-rss-reta
--show-module-eeprom
--show-rx-descriptor
--show-tx-descriptor
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
doc/guides/tools/proc_info.rst | 36
On 2022/10/7 0:42, Ferruh Yigit wrote:
On 10/6/2022 1:05 PM, Dongdong Liu wrote:
Support ethdev Rx/Tx descriptor dump by using procinfo tool.
Thanks to Ferruh, Andrew and Reshma help to review the patchset.
NOTE:
October 1st to October 7th is China's National Day holiday.
I don
On 2022/10/9 17:10, Chengwen Feng wrote:
This patch supports proactive error handling mode.
Signed-off-by: Chengwen Feng
Acked-by: Dongdong Liu
---
drivers/net/hns3/hns3_common.c | 2 ++
drivers/net/hns3/hns3_intr.c | 24
2 files changed, 26 insertions
Hi Reshma
Many thanks for your review.
On 2022/10/10 17:08, Pattan, Reshma wrote:
-Original Message-
From: Dongdong Liu
+static void
+nic_descriptor_display(uint16_t port_id, struct desc_param *desc,
+ desc_dump_t desc_dump)
+{
+ static const char
From: "Min Hu (Connor)"
Add support for dump dpdk version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 19 ++-
1 fi
option to show firmware.
- Use errors on stderr, not stdout.
- Delete some unnecessary code.
v1->v2: Fix some comments from Reshma.
Dongdong Liu (4):
app/procinfo: add firmware version dump
app/procinfo: fix some wrong doxygen syntax
app/procinfo: support descriptor dump
doc: add some ex
Add support for dump ethdev firmware version.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --firmware-version
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 35 +++
1
From: "Min Hu (Connor)"
This patch add support for module eeprom info dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-module-eeprom
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
From: "Min Hu (Connor)"
This patch add support for RSS reta dump.
The command is like:
dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rss-reta
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/m
: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 90e7e41e38..67217ab68b 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -845,6 +845,7 @@ show_port(void
This code is to do cleanup for the wrong doxygen syntax comments
The DPDK API is documented using doxygen comment annotations in the
header files. The procinfo code seems no need to use doxygen comment.
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
app/proc-info/main.c | 40
.
offset: The offset of the descriptor starting from tail.
num: The number of the descriptors to dump.
Signed-off-by: Min Hu (Connor)
Signed-off-by: Dongdong Liu
---
app/proc-info/main.c | 104 +++
1 file changed, 104 insertions(+)
diff --git a/app/proc-info
Add the below extended features in procinfo guide.
--show-port-private
--version
--firmware-version
--show-rss-reta
--show-module-eeprom
--show-rx-descriptor
--show-tx-descriptor
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
---
doc/guides/tools/proc_info.rst | 36
Hi Thomas
Kindly ping.
Can this patchset be applied?
Thanks,
Dongdong
On 2022/10/11 19:18, Dongdong Liu wrote:
This patchset is to add some extended features for dpdk-proc-info.
Thanks to Reshma and Stephen help to review the patchset.
v9->v10:
- Fix some comments for Rx/Tx descriptor d
On 2022/11/15 17:52, David Marchand wrote:
On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu wrote:
This patchset is to add some extended features for dpdk-proc-info.
Thanks to Reshma and Stephen help to review the patchset.
v9->v10:
- Fix some comments for Rx/Tx descriptor dump.
v8-
Acked-by: Dongdong Liu
Thanks,
Dongdong
On 2022/12/15 9:41, Chengwen Feng wrote:
The driver supports create flow rules when device is stopped, and
re-setup flow rules when restarting, so declare support
RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP.
The driver also supports to create indirect actions
On 2022/12/13 17:13, Chengwen Feng wrote:
This patch supports rte_memarea_alloc()/rte_memarea_free()/
rte_memarea_refcnt_update() API.
Signed-off-by: Chengwen Feng
---
doc/guides/prog_guide/memarea_lib.rst | 10 ++
lib/memarea/memarea_private.h | 3 +
lib/memarea/rte_memarea.c
Hi Chengwen
Except for a minor comments, this patchset looks good to me.
Reviewed-by: Dongdong Liu
Thanks,
Dongdong
On 2022/12/13 17:13, Chengwen Feng wrote:
The memarea library is an allocator of variable-size object which based
on a memory region. The main features are as follows:
- The
201 - 264 of 264 matches
Mail list logo
