Integrate RCU QSBR process.
(Refer to RCU documentation to understand various aspects of
integrating RCU library into other libraries.)
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
---
lib/librte_hash/Makefile | 2 +-
lib/librte_hash/meson.build
> On Sep 5, 2019, at 10:26 AM, Stephen Hemminger
> wrote:
>
> On Sun, 1 Sep 2019 06:58:08 +0000
> Dharmik Thakkar wrote:
>
>> Compilation issue arises due to multiple definitions of 'bool'
>> in 'ixgbe_ethdev.h'.
>> (Please note that
> On Nov 2, 2020, at 11:32 PM, Honnappa Nagarahalli
> wrote:
>
>
>
>>>>
>>>> Avoid code duplication by combining single and multi threaded tests
>>>>
>>>> Signed-off-by: Dharmik Thakkar
>>>&
Remove redundant error checking for reader threads
since they never return error.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa N
gle writer
Dharmik Thakkar (4):
test/lpm: fix cycle calculation in rcu qsbr perf
test/lpm: return error on failure in rcu qsbr perf
test/lpm: remove error checking in rcu qsbr perf
test/lpm: avoid code duplication in rcu qsbr perf
app/test/test_lpm_perf.c | 383 ++--
Return error if Add/Delete fail in multiwriter perf test
Return error if single or multi writer test fails
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
R
Avoid code duplication by combining single and multi threaded tests
Also, enable support for more than 2 writers
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 359 +--
1 file changed, 84 insertions(+), 275 deletions
ance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test/test_lpm_perf.c | 45 ++--
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/
> On Nov 4, 2020, at 9:46 AM, Medvedkin, Vladimir
> wrote:
>
> Hi Thakkar,
>
> On 03/11/2020 22:23, Dharmik Thakkar wrote:
>> Avoid code duplication by combining single and multi threaded tests
>> Also, enable support for more than 2 writers
>> Signed-off
re details about the fix to the commit message
- Replace hard coded values with an enum
- Remove lock acquire/release for single writer
Dharmik Thakkar (4):
test/lpm: fix cycle calculation in rcu qsbr perf
test/lpm: return error on failure in rcu qsbr perf
test/lpm: remove error checking in rcu
Avoid code duplication by combining single and multi threaded tests
Also, enable support for more than 2 writers
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test/test_lpm_perf.c | 356 +--
1 file
Remove redundant error checking for reader threads
since they never return error.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa N
Return error if Add/Delete fail in multiwriter perf test
Return error if single or multi writer test fails
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
R
ance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test/test_lpm_perf.c | 45 ++--
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/
Remove build steps about using meson option armv8_crypto_dir.
Add build steps about using pkg-config.
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
doc/guides/cryptodevs/armv8.rst | 10 --
1 file changed, 8 insertions(+), 2 deletions
armv8.html
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
drivers/crypto/armv8/meson.build | 19 ---
meson_options.txt| 2 --
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/crypto/armv8/meson.build
rite the values for any (native, SoC or cross) build
>
Tested ok on N1SDP and ThunderX2. No regression seen with testpmd and l3fwd.
Tested using native build, default build and using arm_soc option.
Series Tested-by: Dharmik Thakkar
Hi David,
> On Oct 16, 2020, at 8:53 AM, David Marchand wrote:
>
> Hello Dharmik,
>
> On Wed, Sep 2, 2020 at 12:01 AM Dharmik Thakkar
> wrote:
>>> [Wang, Yipeng]
>>> Hi, Dharmik,
>>> Thanks for the patch. It generally looks good to me.
>
s of 'bool')
from the series as it is already accepted
Dharmik Thakkar (3):
lib/hash: integrate RCU QSBR
test/hash: replace rte atomic with C11 atomic APIs
test/hash: add tests for integrated RCU QSBR
app/test/test_hash.c | 390 +++
Add functional and performance tests for the integrated RCU QSBR.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash.c | 390 -
app/test/test_hash_readwrite_lf_perf.c | 171 ++-
2
Replace rte_atomic APIs with C11 atomic APIs in
test_hash_readwrite_lf_perf.c
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash_readwrite_lf_perf.c | 89 +++---
1 file changed, 36 insertions(+), 53 deletions(-)
diff --git a/app/test
libraries.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
doc/guides/prog_guide/hash_lib.rst | 11 +-
lib/librte_hash/meson.build | 1 +
lib/librte_hash/rte_cuckoo_hash.c| 300 +--
lib/librte_hash
libraries.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Acked-by: Ray Kinsella
---
doc/guides/prog_guide/hash_lib.rst | 11 +-
lib/librte_hash/meson.build | 1 +
lib/librte_hash/rte_cuckoo_hash.c| 302
Replace rte_atomic APIs with C11 atomic APIs in
test_hash_readwrite_lf_perf.c
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash_readwrite_lf_perf.c | 89 +++---
1 file changed, 36 insertions(+), 53 deletions(-)
diff --git a/app/test
Add functional and performance tests for the integrated RCU QSBR.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash.c | 390 -
app/test/test_hash_readwrite_lf_perf.c | 171 ++-
2
(net/ixgbe: avoid multpile definitions of 'bool')
from the series as it is already accepted
Dharmik Thakkar (3):
lib/hash: integrate RCU QSBR
test/hash: replace rte atomic with C11 atomic APIs
test/hash: add tests for integrated RCU QSBR
app/test/test_hash.c
Build the lib for Windows.
Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9
Signed-off-by: Dharmik Thakkar
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/meson.build b/lib/meson.build
index dd55b5cb53e4..1bb019720c6a 100644
--- a/lib/meson.build
+++ b/lib
> On Oct 19, 2020, at 4:05 PM, David Marchand wrote:
>
> On Mon, Oct 19, 2020 at 6:37 PM Dharmik Thakkar
> wrote:
>>
>> Integrate RCU QSBR to make it easier for the applications to use lock
>> free algorithm.
>>
>> Resource reclamation implementa
> On Oct 20, 2020, at 3:13 AM, David Marchand wrote:
>
> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar
> wrote:
>>
>> Build the lib for Windows.
>>
>> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9
>> Signed-off-by: Dharmik Thakkar
> On Oct 20, 2020, at 3:34 AM, Dmitry Kozlyuk wrote:
>
> On Tue, 20 Oct 2020 10:13:11 +0200, David Marchand wrote:
>> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar
>> wrote:
>>>
>>> Build the lib for Windows.
>>>
>>> Change-Id: Ib
Build the lib for Windows.
Signed-off-by: Dharmik Thakkar
Tested-by: Dmitry Kozlyuk
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/meson.build b/lib/meson.build
index dd55b5cb53e4..1bb019720c6a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -41,6 +41,7 @@ if
libraries.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Acked-by: Ray Kinsella
---
doc/guides/prog_guide/hash_lib.rst | 11 +-
lib/librte_hash/meson.build| 1 +
lib/librte_hash/rte_cuckoo_hash.c | 302 ++---
lib
Replace rte_atomic APIs with C11 atomic APIs in
test_hash_readwrite_lf_perf.c
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash_readwrite_lf_perf.c | 89 +++---
1 file changed, 36 insertions(+), 53 deletions(-)
diff --git a/app/test
Add functional and performance tests for the integrated RCU QSBR.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash.c | 390 -
app/test/test_hash_readwrite_lf_perf.c | 170 ++-
2
the RCU QSBR library instead
- Remove patch (net/ixgbe: avoid multpile definitions of 'bool')
from the series as it is already accepted
Dharmik Thakkar (4):
rcu: build on Windows
lib/hash: integrate RCU QSBR
test/hash: replace rte atomic with C11 atomic APIs
test/hash: add tests
> On Oct 20, 2020, at 10:52 AM, Dmitry Kozlyuk wrote:
>
> On Tue, 20 Oct 2020 12:51:14 +, Dharmik Thakkar wrote:
>> I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain,
>> but I am seeing some compilation error:
>>
>> ../lib/librt
> On Oct 20, 2020, at 9:42 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-----
>> From: Dharmik Thakkar
>> Sent: Tuesday, October 20, 2020 9:13 AM
>> To: Wang, Yipeng1 ; Gobriel, Sameh
>> ; Richardson, Bruce
>> ; Ray Kinsella ; Neil Horman
>
> On Oct 20, 2020, at 10:54 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-----
>> From: Dharmik Thakkar
>> Sent: Tuesday, October 20, 2020 9:13 AM
>> To: Wang, Yipeng1 ; Gobriel, Sameh
>> ; Richardson, Bruce
>> Cc: dev@dpdk.org; n...@arm.com;
Build the lib for Windows.
Signed-off-by: Dharmik Thakkar
Tested-by: Dmitry Kozlyuk
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/meson.build b/lib/meson.build
index dd55b5cb53e4..1bb019720c6a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -41,6 +41,7 @@ if
Replace rte_atomic APIs with C11 atomic APIs in
test_hash_readwrite_lf_perf.c
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Acked-by: Yipeng Wang
---
app/test/test_hash_readwrite_lf_perf.c | 89 +++---
1 file changed, 36 insertions(+), 53 deletions(-)
diff
ed functions and use resource reclamation
APIs from the RCU QSBR library instead
- Remove patch (net/ixgbe: avoid multpile definitions of 'bool')
from the series as it is already accepted
Dharmik Thakkar (4):
rcu: build on Windows
lib/hash: integrate RCU QSBR
test/hash: repl
libraries.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Acked-by: Ray Kinsella
---
doc/guides/prog_guide/hash_lib.rst | 12 +-
lib/librte_hash/meson.build| 1 +
lib/librte_hash/rte_cuckoo_hash.c | 303 ++---
lib
Add functional and performance tests for the integrated RCU QSBR.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_hash.c | 390 -
app/test/test_hash_readwrite_lf_perf.c | 170 ++-
2
these as runtime config alongside other
available runtime options within testpmd.
Dharmik Thakkar (5):
app/testpmd: add record-core-cycles runtime config
doc: add record-core-cycles to testpmd funcs doc
app/testpmd: add record-burst-stats runtime config
doc: add record-burst-stats to
Update documentation to include description of
'record-core-cycles' runtime configuration.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
doc/guides/testpmd_app_ug/run_app.rst | 6 ++
doc/guides/test
Update documentation to include description of
'record-burst-stats' runtime configuration.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
doc/guides/testpmd_app_ug/run_app.rst | 2 ++
doc/guides/test
Convert CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS to a
runtime configuration.
Signed-off-by: Dharmik Thakkar
Tested-by: Phil Yang
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test-pmd/5tswap.c | 8 ++-
app/test-pmd/cmdline.c| 46
Enable empty polls in burst stats within 5tswap.c
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
---
app/test-pmd/5tswap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test-pmd/5tswap.c b/app/test-pmd/5tswap.c
index d9026ce86556..3cf1692eaba8
Convert CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES to a
runtime configuration.
Signed-off-by: Dharmik Thakkar
Tested-by: Phil Yang
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test-pmd/5tswap.c | 16 +++---
app/test-pmd/cmdline.c| 46
From: Phil Yang
Add burst stats for noisy vnf mode.
Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode")
Cc: sta...@dpdk.org
Cc: jfreim...@redhat.com
Signed-off-by: Dharmik Thakkar
Signed-off-by: Phil Yang
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Ru
n the other patch [1]? Do you plan on including that as
well in your series?
[1] [1/2] config/arm: avoid variable reuse
https://patches.dpdk.org/patch/75946/
>
>> -Original Message-
>> From: Thomas Monjalon
>> Sent: Tuesday, October 13, 2020 4:32 PM
>> To
> On Oct 14, 2020, at 1:53 AM, Juraj Linkeš wrote:
>
> Hi Dharmik,
>
>> -Original Message-
>> From: Dharmik Thakkar
>> Sent: Tuesday, October 13, 2020 5:15 PM
>> To: Juraj Linkeš
>> Cc: tho...@monjalon.net; dev@dpdk.org; Stephen Hemminge
ggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
v2:
- Remove defer queue related functions and use resource reclamation
APIs from the RCU QSBR library instead
- Remove patch (net/ixgbe: avoid multpile definitions of 'bool')
from
CI has reported some compilation issues for this patch. I will resolve these
issues once the RFC patch is approved.
Thank you!
> On Aug 18, 2020, at 11:05 PM, Dharmik Thakkar wrote:
>
> Integrate RCU QSBR to make it easier for the applications to use lock
> free algorithm.
&
when using native build to
correctly set RTE_MAX_LCORE.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
config/get_max_lcores.py | 13 +
config/meson.build | 13 -
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100755 config
Rename 'machine' to 'machine_properties' in config/arm/meson.build since
'machine' is previously being used in config/meson.build
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
config/arm/meson.build | 18 +-
1 file changed, 9 inser
> On Aug 25, 2020, at 11:47 PM, Jerin Jacob wrote:
>
> On Wed, Aug 26, 2020 at 2:44 AM Dharmik Thakkar
> wrote:
>>
>> For Arm, RTE_MAX_LCORE is hard-coded into the config. It leads to incorrect
>> RTE_MAX_LCORE when machines have same Implemener and part num
> On Aug 26, 2020, at 11:41 AM, Bruce Richardson
> wrote:
>
> On Wed, Aug 26, 2020 at 05:33:20PM +0100, Ferruh Yigit wrote:
>> On 7/14/2020 10:51 PM, Dharmik Thakkar wrote:
>>> Meson build system lacks support for
>>> CONFIG
Hi Yipeng,
Thank you for the comments!
> On Aug 31, 2020, at 3:47 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-----
>> From: Dharmik Thakkar
>> Sent: Tuesday, August 18, 2020 9:06 PM
>> To: Wang, Yipeng1 ; Gobriel, Sameh
>> ; Richardson, Bruce ;
>&
> On Sep 3, 2020, at 1:20 AM, Juraj Linkeš wrote:
>
>
>
>> -Original Message-
>> From: dev On Behalf Of Dharmik Thakkar
>> Sent: Wednesday, August 26, 2020 6:56 AM
>> To: Jerin Jacob
>> Cc: tho...@monjalon.net; dpdk-dev ; nd
>> Sub
> On Sep 3, 2020, at 5:52 PM, Stephen Hemminger
> wrote:
>
> On Thu, 3 Sep 2020 06:20:17 +
> Juraj Linkeš wrote:
>
>>> -Original Message-
>>> From: dev On Behalf Of Dharmik Thakkar
>>> Sent: Wednesday, August 26, 2020 6:56 AM
>
> On Sep 17, 2020, at 4:33 AM, Juraj Linkeš wrote:
>
>
>
>> -Original Message-
>> From: dev On Behalf Of Dharmik Thakkar
>> Sent: Tuesday, August 25, 2020 11:13 PM
>> To: Thomas Monjalon
>> Cc: dev@dpdk.org; n...@arm.com; Dharmik Tha
> On Sep 17, 2020, at 4:56 AM, Juraj Linkeš wrote:
>
>
>
>> -Original Message-
>> From: Dharmik Thakkar
>> Sent: Friday, September 4, 2020 7:44 AM
>> To: Stephen Hemminger
>> Cc: Juraj Linkeš ; Jerin Jacob
>> ; tho...@monjalon.
201 - 263 of 263 matches
Mail list logo
