Re: [dpdk-dev] [PATCH v5] sched: make RED scaling configurable

Hi Cristian, Responses inline below. Regards Alan > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Thursday, January 11, 2018 1:11 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar ; Kantecki, Tomasz > ; Singh, Jasvinder

Re: [dpdk-dev] [PATCH v5] sched: make RED scaling configurable

Hi Cristian, > > + > > + rte_red_scaling -= count - RTE_RED_SCALING; > > Why not simply: rte_red_scaling = count? The RED code stores the moving average in a uint32_t as a pseudo floating point number with a fixed sized fractional part of 10 bits. This allows a maximum queue length of 1024.

Re: [dpdk-dev] [PATCH v5] sched: make RED scaling configurable

> > > > > diff --git a/lib/librte_sched/rte_red.c > > > > > b/lib/librte_sched/rte_red.c > > > > > +int > > > > > +rte_red_set_scaling(uint16_t max_red_queue_length) { > > > > > + int8_t count; > > > > > + > > > > > + if (rte_red_init_done) > > > > > + /** > > > > > +

Re: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable

Hi Cristian, No problem, it doesn't sounds like it will be too difficult. Unfortunately I'm in the middle of another piece of work, so it will probably be a couple of weeks before I get around to it. Regards Alan -Original Message- From: Dumitrescu, Cristian [mailto:cristian.dumitre.

Re: [dpdk-dev] [PATCH] vhost: support non multiqueue guests

Hi Maxime, Many thanks for the heads up. I'll try out your suggested fix later today and let you know if it resolves my issue. Regards Alan -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, February 05, 2018 8:42 AM To: alangordonde...@gmail.co

Re: [dpdk-dev] [PATCH v2] sched: fix overflow errors in WRR weighting code

Hi Cristian, Responses in-line below... > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Tuesday, January 02, 2018 4:14 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v2] sched: fix overflow errors

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Tuesday, January 02, 2018 4:44 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > Hi Alan, > > T

Re: [dpdk-dev] [PATCH v2] test: new sched WRR unit-test

Hi Cristian, In response to your comment at the very end, "Please keep the unit test in the same patch set with the code", any revised change will include the new unit-tests. Regards Alan > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent:

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

> > > > +int > > > > +rte_red_set_scaling(uint16_t max_red_queue_length); > > > > + > > > > +/** > > > > + * @brief Reset the RED scaling factor - only for use by RED > > > > +unit-tests > > > > + * > > > > + * @return Operation status > > > > + */ > > > > +void > > > > +rte_red_reset_scaling(void

Re: [dpdk-dev] [PATCH] sched: fix port time rounding error

> -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 20, 2020 12:23 PM > To: Dumitrescu, Cristian ; > alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH] sched: fix port time rounding error > > > > > -Original Message- > > From: Dumi