[dpdk-dev] [PATCH v5 2/6] Support for unique interface naming of pmds

2014-06-18 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c| 32

[dpdk-dev] [PATCH v5 1/6] Link Bonding Library (lib/librte_pmd_bond)

2014-06-18 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linux

[dpdk-dev] [PATCH v5 6/6] Link Bonding Library doxygen additions

2014-06-18 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 7b26e98..ee3ad4f 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md

[dpdk-dev] [PATCH v5 4/6] Link bonding Unit Tests

2014-06-18 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app

[dpdk-dev] [PATCH v5 0/6] Link Bonding Library

2014-06-18 Thread Declan Doherty
to support unique naming of pmds 0003 - librte_eal changes to support bonding device intialization 0005 - link bonding unti test suite 0005 - testpmd link bonding support changes 0006 - doxygen additions Declan Doherty (6): Link Bonding Library (lib/librte_pmd_bond) Support for unique

[dpdk-dev] [PATCH v5 3/6] EAL support for link bonding device initialization

2014-06-18 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c | 10 - lib/librte_eal

[dpdk-dev] [PATCH v5 5/6] testpmd link bonding additions

2014-06-18 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v6 0/6] Link Bonding Library

2014-06-24 Thread Declan Doherty
intialization 0005 - link bonding unti test suite 0005 - testpmd link bonding support changes 0006 - doxygen additions Declan Doherty (6): Link Bonding Library (lib/librte_pmd_bond) Support for unique interface naming of pmds EAL support for link bonding device initialization Link

[dpdk-dev] [PATCH v6 2/6] Support for unique interface naming of pmds

2014-06-24 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c| 32

[dpdk-dev] [PATCH v6 3/6] EAL support for link bonding device initialization

2014-06-24 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c | 10 - lib/librte_eal

[dpdk-dev] [PATCH v6 5/6] testpmd link bonding additions

2014-06-24 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v6 1/6] Link Bonding Library (lib/librte_pmd_bond)

2014-06-24 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linux

[dpdk-dev] [PATCH v6 6/6] Link Bonding Library doxygen additions

2014-06-24 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 7b26e98..ee3ad4f 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md

[dpdk-dev] [PATCH v6 4/6] Link bonding Unit Tests

2014-06-24 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app

[dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device initialization

2014-06-24 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c | 10 - lib/librte_eal

[dpdk-dev] [PATCH v7 0/6] Link Bonding Library

2014-06-24 Thread Declan Doherty
0006 - doxygen additions Declan Doherty (6): Link Bonding Library (lib/librte_pmd_bond) Support for unique interface naming of pmds EAL support for link bonding device initialization Link bonding Unit Tests testpmd link bonding additions Link Bonding Library doxygen additions app

[dpdk-dev] [PATCH v7 5/6] testpmd link bonding additions

2014-06-24 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v7 4/6] Link bonding Unit Tests

2014-06-24 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app

[dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions

2014-06-24 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 7b26e98..ee3ad4f 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md

[dpdk-dev] [PATCH v7 1/6] Link Bonding Library (lib/librte_pmd_bond)

2014-06-24 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linux

[dpdk-dev] [PATCH v7 2/6] Support for unique interface naming of pmds

2014-06-24 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c| 33

[dpdk-dev] [PATCH v8 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c | 10 - lib/librte_eal

[dpdk-dev] [PATCH v8 6/6] Link Bonding Library doxygen additions

2014-06-25 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 7b26e98..ee3ad4f 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md

[dpdk-dev] [PATCH v8 1/6] Link Bonding Library (lib/librte_pmd_bond)

2014-06-25 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linux

[dpdk-dev] [PATCH v8 2/6] Support for unique interface naming of pmds

2014-06-25 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c| 32

[dpdk-dev] [PATCH v8 4/6] Link bonding Unit Tests

2014-06-25 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app

[dpdk-dev] [PATCH v8 0/6] Link Bonding Library

2014-06-25 Thread Declan Doherty
intialization 0005 - link bonding unti test suite 0005 - testpmd link bonding support changes 0006 - doxygen additions Declan Doherty (6): Link Bonding Library (lib/librte_pmd_bond) Support for unique interface naming of pmds EAL support for link bonding device initialization Link bonding Unit

[dpdk-dev] [PATCH v8 5/6] testpmd link bonding additions

2014-06-25 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v10 0/5] link bonding

2014-06-27 Thread Declan Doherty
Fixed copyright in link bonding library Makefile Declan Doherty (5): bond: new link bonding library ethdev: add unique name to devices eal: support link bonding device initialization bond: unit tests bond: testpmd support app/test-pmd/cmdline.c | 579 app

[dpdk-dev] [PATCH v10 3/5] eal: support link bonding device initialization

2014-06-27 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_eal/bsdapp/eal/eal.c

[dpdk-dev] [PATCH v10 2/5] ethdev: add unique name to devices

2014-06-27 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_ether

[dpdk-dev] [PATCH v10 5/5] bond: testpmd support

2014-06-27 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v10 1/5] bond: new link bonding library

2014-06-27 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- config/common_bsdapp |

[dpdk-dev] [PATCH v10 4/5] bond: unit tests

2014-06-27 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test/Makefile |4 +- app/test/commands.c

[dpdk-dev] [PATCH v11 0/5] link bonding library

2014-06-29 Thread Declan Doherty
aries APIs into a seperate library, as they are directly coupled to with the bonding library implmentation Declan Doherty (5): bond: new link bonding library ethdev: add unique name to devices eal: support link bonding device initialization bond: unit tests bond: testpmd support app/tes

[dpdk-dev] [PATCH v11 2/5] ethdev: add unique name to devices

2014-06-29 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_ether

[dpdk-dev] [PATCH v11 3/5] eal: support link bonding device initialization

2014-06-29 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_eal/bsdapp/eal/eal.c

[dpdk-dev] [PATCH v11 5/5] bond: testpmd support

2014-06-29 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v11 1/5] bond: new link bonding library

2014-06-29 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linux

[dpdk-dev] [PATCH v11 4/5] bond: unit tests

2014-06-29 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test/Makefile |6 +- app/test/commands.c

[dpdk-dev] [PATCH v6 2/8] bond: removing switch statement from rx burst method

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 65 +++--- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index de0cd56..f2fe930 100644 --- a

[dpdk-dev] [PATCH v6 1/8] bond: link status interrupt support

2014-11-07 Thread Declan Doherty
Adding support for lsc interrupt from bonded device to link bonding library with supporting unit tests in the test application. Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 213 +++-- lib/librte_pmd_bond/rte_eth_bond_api.c | 4 + lib

[dpdk-dev] [PATCH v6 0/8] link bonding

2014-11-07 Thread Declan Doherty
tatus interrupt in the link bonding pmd. It also contains some patches to tidy up the code structure and to of the link bonding code and to fix bugs relating to transmission failures in the under lying slave pmd which could lead to leaked mbufs. Declan Doherty (8): bond: link status interrupt su

[dpdk-dev] [PATCH v6 3/8] bond: fix naming inconsistency in tx_burst_round_robin

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index f2fe930..6e770af 100644 --- a/lib/librte_pmd_bond

[dpdk-dev] [PATCH v6 6/8] testpmd: adding parameter to reconfig method to set socket_id when adding new port to portlist

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/testpmd.c | 3 ++- app/test-pmd/testpmd.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4c3fc76..be12c13 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v6 5/8] test app: adding support for generating variable sized packet

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 25 - app/test/packet_burst_generator.h | 6 +- app/test/test_link_bonding.c | 14 +- 3 files changed, 22 insertions(+), 23 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v6 4/8] bond: free mbufs if transmission fails in bonding tx_burst functions

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 393 - app/test/virtual_pmd.c | 79 +-- app/test/virtual_pmd.h | 7 + lib/librte_pmd_bond/rte_eth_bond_pmd.c | 83 +-- 4 files changed, 524

[dpdk-dev] [PATCH v6 8/8] bond: unit test test macro refactor

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 2574 +- 1 file changed, 1036 insertions(+), 1538 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 4aa57a7..aa6a52f 100644 --- a/app/test

[dpdk-dev] [PATCH v6 7/8] bond: lsc polling support

2014-11-07 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c | 63 + app/test/test.h | 7 +- app/test/test_link_bonding.c| 265 --- app/test/virtual_pmd.c | 17 +- app/test/virtual_pmd.h

[dpdk-dev] [PATCH 0/2] enablement of avx512 instruction support in aesni_mb_pmd

2016-12-02 Thread Declan Doherty
ded in the new version of the library to the aesni_mb_pmd. The second patch add a new initialisation option which allows the user to explicitly select which set of SIMD functions to use from the base library. Declan Doherty (2): crypto/aesni_mb: enablement of avx512 support in IPsec_mb librar

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: enablement of avx512 support in IPsec_mb library

2016-12-02 Thread Declan Doherty
of the Multi-Buffer Crypto for IPsec library. Signed-off-by: Declan Doherty --- drivers/crypto/aesni_mb/aesni_mb_ops.h | 28 +++- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 7 ++- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 3 files changed, 35 insertions

[dpdk-dev] [PATCH 2/2] crypto/aesni_mb: add new option to select SIMD mode

2016-12-02 Thread Declan Doherty
Add new initialisation option to the aesni_mb_pmd to allow the user to specify which set of SIMD functions to load from the AESNI Multi-Buffer Crypto for IPsec library. Signed-off-by: Declan Doherty --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 141 ++--- drivers

Re: [dpdk-dev] [PATCH 2/2] crypto/aesni_mb: add new option to select SIMD mode

2016-12-02 Thread Declan Doherty
On 02/12/16 10:37, Thomas Monjalon wrote: 2016-12-02 09:46, Declan Doherty: Add new initialisation option to the aesni_mb_pmd to allow the user to specify which set of SIMD functions to load from the AESNI Multi-Buffer Crypto for IPsec library. Why let user choose? Isn't the most recen

Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-02 Thread Declan Doherty
On 02/12/16 14:57, Bruce Richardson wrote: On Fri, Dec 02, 2016 at 03:31:24PM +0100, Thomas Monjalon wrote: 2016-12-02 14:15, Fan Zhang: This patch provides the initial implementation of the scheduler poll mode driver using DPDK cryptodev framework. Scheduler PMD is used to schedule and enqueu

[dpdk-dev] [PATCH 0/6] link bonding

2014-08-19 Thread Declan Doherty
This patch set adds support for link status interrupt in the link bonding pmd. It also contains some patches to tidy up the code structure and to of the link bonding code and to fix bugs relating to transmission failures in the under lying slave pmd which could lead to leaked mbufs. Declan

[dpdk-dev] [PATCH 1/6] bond: link status interrupt support

2014-08-19 Thread Declan Doherty
Adding support for lsc interrupt from bonded device to link bonding library with supporting unit tests in the test application. Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 216 +++- lib/librte_pmd_bond/rte_eth_bond_api.c |4 + lib

[dpdk-dev] [PATCH 2/6] bond: removing switch statement from rx burst method

2014-08-19 Thread Declan Doherty
Splitting rx burst function into seperate functions to avoid the need for a switch statement and also to match the structure of the tx burst functions. Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 62 ++-- 1 files changed, 35

[dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in tx_burst_round_robin

2014-08-19 Thread Declan Doherty
Renaming struct bond_dev_pritvate *dev_private to internals to match convention used in other pmds Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c

[dpdk-dev] [PATCH 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions

2014-08-19 Thread Declan Doherty
Fixing a number of corner cases that if transmission failed on slave devices then this could lead to leaked mbufs Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c |4 +- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 46 +--- 2 files

[dpdk-dev] [PATCH 5/6] test app: adding support for generating variable sized packets

2014-08-19 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 22 +++--- app/test/packet_burst_generator.h |6 +- app/test/test_link_bonding.c | 14 +- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH 6/6] testpmd: adding parameter to reconfig method to set socket_id when adding new port to portlist

2014-08-19 Thread Declan Doherty
Fix for "show port info" command which displays the incorrect "connected to socket" when port is a link bonding port. Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c |2 +- app/test-pmd/testpmd.c |3 ++- app/test-pmd/testpmd.h |2 +- 3 files changed

[dpdk-dev] [PATCH] doc: link bonding related updates to programmers guide

2014-12-01 Thread Declan Doherty
Adding details for link status interrupts and link status polling. Adding details for mode 4 / mode 5 Tidying up rst document to conform to 80 character line limit Adding diagrams to explain bonding modes Signed-off-by: Declan Doherty --- doc/guides/prog_guide/img/bond-mode-0.svg | 638

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-05 Thread Declan Doherty
. Adding unit test to cover failing assignment scenarios Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 192 - app/test/virtual_pmd.c | 1 - lib/librte_pmd_bond/rte_eth_bond_pmd.c | 14 ++- 3 files changed, 199

[dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device

2014-12-08 Thread Declan Doherty
move data within the same array, as this was corrupting the slave array. Adding unit test to cover failing assignment scenarios Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 192 - app/test/virtual_pmd.c | 1 -

[dpdk-dev] [PATCH] doc: add license header to link bonding diagrams

2014-12-08 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/guides/prog_guide/img/bond-mode-0.svg | 34 + doc/guides/prog_guide/img/bond-mode-1.svg | 34 + doc/guides/prog_guide/img/bond-mode-2.svg | 34 + doc/guides/prog_guide

[dpdk-dev] [PATCH] bond: static analysis issues fix

2014-12-12 Thread Declan Doherty
Fixes for link bonding library identified by static analysis tool - Overflow check for active_slaves array in activate_slave function - Allocation check of pci_id_table in rte_eth_bond_create - Use of eth_dev pointer in mac_address_get/set before NULL check Signed-off-by: Declan Doherty

[dpdk-dev] [PATCH v2] bond: static analysis issues fix

2014-12-15 Thread Declan Doherty
eate - Use of eth_dev pointer in mac_address_get/set before NULL check Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 7 ++- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 8 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Declan Doherty
generator. Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 2 +- lib/librte_net/rte_ip.h| 2 + lib/librte_pmd_bond/rte_eth_bond_api.c | 8 ++ lib/librte_pmd_bond/rte_eth_bond_pmd.c | 161 - lib

[dpdk-dev] [PATCH v2] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Declan Doherty
test application packet generator. Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 2 +- lib/librte_net/rte_ip.h| 8 ++ lib/librte_pmd_bond/rte_eth_bond_api.c | 8 ++ lib/librte_pmd_bond/rte_eth_bond_pmd.c | 162

[dpdk-dev] [PATCH v3 0/3] bond: static analysis issues fix

2014-12-17 Thread Declan Doherty
d_table in rte_eth_bond_create - Use of eth_dev pointer in mac_address_get/set before NULL check Declan Doherty (3): bond: add bounds check before assigning active slave count value bond: fix pci_id_table allocation check in rte_eth_bond_create bond: eth_dev parameter used before NULL check mac_a

[dpdk-dev] [PATCH v3 2/3] bond: fix pci_id_table allocation check in rte_eth_bond_create

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c index b124784..c2a99a3 100644 --- a/lib/librte_pmd_bond

[dpdk-dev] [PATCH v3 1/3] bond: add bounds check before assigning active slave count value

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c index ef5ddf4..b124784 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_api.c +++ b/lib

[dpdk-dev] [PATCH v3 3/3] bond: eth_dev parameter used before NULL check in mac_address_get/set

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 3db473b..bb4a537 100644 --- a/lib/librte_pmd_bond

[dpdk-dev] [PATCH 0/2] link bonding unit test fix

2014-07-21 Thread Declan Doherty
fix for link bonding unit tests which are failing due to change introduced in rte_eth_dev_configure which now explicitly checks in pmd supports link status chnage interrupts. Also adds some common test macros to the test application for unit testing Declan Doherty (2): test app: bond

[dpdk-dev] [PATCH 1/2] test app:

2014-07-21 Thread Declan Doherty
- Adding common test assertion macros for unit testing - Structs for encapsulating unit tests / test suites data. - test suite runner method Signed-off-by: Declan Doherty --- app/test/test.c | 53 +++ app/test/test.h | 82

[dpdk-dev] [PATCH 2/2] bond: unit test suite fix

2014-07-21 Thread Declan Doherty
: Declan Doherty --- app/test/test_link_bonding.c | 491 app/test/virtual_pmd.c |1 + lib/librte_pmd_bond/rte_eth_bond_pmd.c | 92 +++--- 3 files changed, 221 insertions(+), 363 deletions(-) diff --git a/app/test/test_link_bonding.c b/app

[dpdk-dev] [PATCH v3 0/5] Link Bonding PMD Library

2014-06-13 Thread Declan Doherty
This patch contains the initial release of the Link Bonding PMD Library Supporting bonding modes: 0 - Round Robin 1 - Active Backup 2 - Balance (Supporting 3 transmission polices) layer 2, layer 2+3, layer 3+4 3 - Broadcast Version 3 of this patch set add the following functionality

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ???vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/common/eal_common_dev.c | 66

[dpdk-dev] [PATCH v3 5/5] Link Bonding PMD Library (Doxygen Additions)

2014-06-13 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md | 1 + doc/doxy-api.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 6e75a6e..a4d2e57 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md @@ -36,6 +36,7 @@ API

[dpdk-dev] [PATCH v3 1/5] Link Bonding PMD Library

2014-06-13 Thread Declan Doherty
Link Bonding Library (lib/librte_pmd_bond) initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsd

[dpdk-dev] [PATCH v3 3/5] Link Bonding PMD Library (Unit Test Suite)

2014-06-13 Thread Declan Doherty
Link bonding unit tests, including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c

[dpdk-dev] [PATCH v3 4/5] Link Bonding PMD Library (testpmd link bonding API support)

2014-06-13 Thread Declan Doherty
Adding link bonding support to testpmd. - Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd

[dpdk-dev] [PATCH v4 0/6] Link Bonding Library

2014-06-16 Thread Declan Doherty
intialization 0005 - link bonding unti test suite 0005 - testpmd link bonding support changes 0006 - doxygen additions Declan Doherty (6): Link Bonding Library (lib/librte_pmd_bond) initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Support

[dpdk-dev] [PATCH v4 3/6] EAL support for link bonding device initialization

2014-06-16 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/common/eal_common_dev.c | 66

[dpdk-dev] [PATCH v4 2/6] Support for unique interface naming of pmds

2014-06-16 Thread Declan Doherty
allocating a ethdev, which also verifies that the name is unique and hasn?t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd?s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c| 33

[dpdk-dev] [PATCH v4 1/6] Link Bonding Library (lib/librte_pmd_bond) initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer

2014-06-16 Thread Declan Doherty
Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linuxapp |5 + lib/Makefile |1 + lib/librte_pmd_bond/Makefile | 32 + lib/librte_pmd_bond/rte_eth_bond.c | 2149

[dpdk-dev] [PATCH v4 6/6] Link Bonding Library doxygen additions

2014-06-16 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 83303a1..8338a9b 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md

[dpdk-dev] [PATCH v4 5/6] testpmd link bonding additions

2014-06-16 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 571

[dpdk-dev] [PATCH v4 4/6] Link bonding Unit Tests

2014-06-16 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app

[dpdk-dev] bond: mode 4 promiscuous mode

2015-05-20 Thread Declan Doherty
On 15/05/15 14:36, Andriy Berestovskyy wrote: > Hey guys, > Can we in function bond_mode_8023ad_activate_slave() try to add to the > slave bond and LACP multicast MACs first? And then we would fall back > into promiscuous mode if the adding has failed. > > In other words: > > if (rte_eth_dev_mac_ad

[dpdk-dev] [PATCH v3 3/5] testpmd: adding parameter to reconfig method to set socket_id when adding new port to portlist

2014-09-23 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c |2 +- app/test-pmd/testpmd.c |3 ++- app/test-pmd/testpmd.h |2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 67321f7..ed76eea 100644 --- a/app/test

[dpdk-dev] [PATCH v3 1/5] bond: free mbufs if transmission fails in bonding tx_burst functions

2014-09-23 Thread Declan Doherty
Fixing a number of corner cases that if transmission failed on slave devices then this could lead to leaked mbufs Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 393 +++- app/test/virtual_pmd.c | 80 +-- app/test

[dpdk-dev] [PATCH v3 4/5] bond: lsc polling support

2014-09-23 Thread Declan Doherty
Adds link status polling functionality to bonding device as well as API to set polling interval and link up / down propagation delay. Also contains unit tests for testing polling functionailty. Signed-off-by: Declan Doherty --- app/test/test.h|7 +- app/test

[dpdk-dev] [PATCH v3 5/5] bond: unit test test macro refactor

2014-09-23 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 2574 +- 1 files changed, 1036 insertions(+), 1538 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index c32b685..c4fcaf7 100644 --- a/app/test

[dpdk-dev] [PATCH v3 0/5] link bonding

2014-09-23 Thread Declan Doherty
nding unit test so that all tests use the new test macros. Declan Doherty (5): bond: free mbufs if transmission fails in bonding tx_burst functions test app: adding support for generating variable sized packet testpmd: adding parameter to reconfig method to set socket_id when adding new po

[dpdk-dev] [PATCH v3 2/5] test app: adding support for generating variable sized packet

2014-09-23 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 25 - app/test/packet_burst_generator.h |6 +- app/test/test_link_bonding.c | 14 +- 3 files changed, 22 insertions(+), 23 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v4 2/8] bond: removing switch statement from rx burst method

2014-09-30 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 62 +++--- 1 file changed, 35 insertions(+), 27 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index aca2dcf..348e28f 100644 --- a

[dpdk-dev] [PATCH v4 1/8] bond: link status interrupt support

2014-09-30 Thread Declan Doherty
Adding support for lsc interrupt from bonded device to link bonding library with supporting unit tests in the test application. Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 213 +++-- lib/librte_pmd_bond/rte_eth_bond_api.c | 4 + lib

[dpdk-dev] [PATCH v4 6/8] testpmd: adding parameter to reconfig method to set socket_id when adding new port to portlist

2014-09-30 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/testpmd.c | 3 ++- app/test-pmd/testpmd.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 225f669..15ca493 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v4 4/8] bond: free mbufs if transmission fails in bonding tx_burst functions

2014-09-30 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 393 - app/test/virtual_pmd.c | 80 +-- app/test/virtual_pmd.h | 7 + lib/librte_pmd_bond/rte_eth_bond_pmd.c | 83 +-- 4 files changed, 525

  1   2   3   4   5   6   >