Re: [PATCH 01/13] net/ionic: add stat for completion queue entries processed

2024-02-05 Thread Boyer, Andrew
> On Feb 2, 2024, at 11:24 PM, Stephen Hemminger > wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Fri, 2 Feb 2024 11:32:26 -0800 > Andrew Boyer wrote: > >> When completion coalesc

Re: [PATCH 13/13] net/ionic: optimize device start operation

2024-02-05 Thread Boyer, Andrew
> On Feb 2, 2024, at 11:28 PM, Stephen Hemminger > wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Fri, 2 Feb 2024 11:32:38 -0800 > Andrew Boyer wrote: > >> + memset(ctx, 0, si

Re: [PATCH 04/13] net/ionic: fix missing volatile type for cqe pointers

2024-02-05 Thread Boyer, Andrew
> On Feb 2, 2024, at 11:26 PM, Stephen Hemminger > wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Fri, 2 Feb 2024 11:32:29 -0800 > Andrew Boyer wrote: > >> From: Neel Patel >> >

Adding helper function for ARM "dsb st"

2024-02-05 Thread Boyer, Andrew
I see that cnxk has added inline assembly for the ARM "dsb st" barrier. We, too, would like to add a use of this instruction. Can a helper function be added to the atomics headers? > drivers/ml/cnxk/cn10k_ml_dev.h:#define dsb_st ({ asm volatile("dsb st" : : : > "memory"); }) What would the hel

Re: [PATCH 00/13] net/ionic: miscellaneous fixes and improvements

2024-02-05 Thread Boyer, Andrew
On Feb 5, 2024, at 1:44 PM, Patrick Robb wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Recheck-request: iol-intel-Functional I saw this failed in CI testing for the DTS MTU_Update test but suspect

Re: [EXT] [PATCH] cryptodev: add a simple mapping cache to speed up ops pool create

2024-02-06 Thread Boyer, Andrew
On Feb 6, 2024, at 9:24 PM, Morten Brørup wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Akhil Goyal [mailto:gak...@marvell.com] Sent: Tuesday, 6 February 2024 15.25 Cache the most recent VA

Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications

2024-02-19 Thread Boyer, Andrew
On Feb 19, 2024, at 10:24 AM, Yigit, Ferruh wrote: On 2/16/2024 5:07 PM, Andrew Boyer wrote: Add support for running DPDK applications directly on AMD Pensando embedded HW. The platform exposes the device BARs through UIO. The UIO code in the common/ionic library walks the sysfs filesystem to i

Re: [PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-20 Thread Boyer, Andrew
On Feb 19, 2024, at 9:02 PM, Wathsala Wathawana Vithanage wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. -Original Message- From: Wathsala Wathawana Vithanage mailto:wathsala.vithan...@arm

Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications

2024-02-20 Thread Boyer, Andrew
On Feb 19, 2024, at 9:02 PM, Honnappa Nagarahalli wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Feb 16, 2024, at 11:07 AM, Andrew Boyer wrote: Add support for running DPDK applications direct

Re: [RFC 0/5] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-03-01 Thread Boyer, Andrew
> On Feb 22, 2024, at 1:40 PM, Boyer, Andrew wrote: > > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks.

Re: Testing scatter support for PMDs using testpmd

2024-01-26 Thread Boyer, Andrew
On Jan 24, 2024, at 12:16 PM, Jeremy Spewock wrote: Hello maintainers, In porting over the first ethdev suite to the new DTS framework, there was an inconsistency that we found and we were wondering if anyone would be able to shed some light on this. In general the inconsistency pertains to

Re: [PATCH 2/6] crypto/ionic: add device and admin command handlers

2024-04-22 Thread Boyer, Andrew
On Apr 19, 2024, at 3:53 PM, Boyer, Andrew wrote: diff --git a/drivers/crypto/ionic/ionic_crypto_main.c b/drivers/crypto/ionic/ionic_crypto_main.c new file mode 100644 index 00..7b26080bd1 --- /dev/null +++ b/drivers/crypto/ionic/ionic_crypto_main.c @@ -0,0 +1,42 @@ +/* SPDX-License

Re: [PATCH v2 0/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-06-04 Thread Boyer, Andrew
> On Apr 30, 2024, at 4:21 PM, Boyer, Andrew wrote: > > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks. >

Re: [PATCH v2 0/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-06-04 Thread Boyer, Andrew
> On Jun 4, 2024, at 9:28 AM, Boyer, Andrew wrote: > > >> On Apr 30, 2024, at 4:21 PM, Boyer, Andrew wrote: >> >> This patchset introduces a new crypto PMD for AMD Pensando hardware >> accelerators. It allows applications running directly on the AMD Pensand

Re: [EXTERNAL] [PATCH v2 3/9] crypto/ionic: add device commands

2024-06-04 Thread Boyer, Andrew
> On Jun 1, 2024, at 9:57 AM, Akhil Goyal wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > >> Subject: [EXTERNAL] [PATCH v2 3/9] crypto/ionic: add device commands >> >> This defines the dev

Re: [EXTERNAL] [PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-06-04 Thread Boyer, Andrew
On May 30, 2024, at 8:02 AM, Akhil Goyal wrote: diff --git a/drivers/common/ionic/ionic_common_uio.c b/drivers/common/ionic/ionic_common_uio.c index e5c73faf96..c647b22eaf 100644 --- a/drivers/common/ionic/ionic_common_uio.c +++ b/drivers/common/ionic/ionic_common_uio.c @@ -23,10 +23,12 @@ #de

Re: [EXTERNAL] [PATCH v3 1/9] crypto/ionic: introduce AMD Pensando driver

2024-06-13 Thread Boyer, Andrew
> On Jun 13, 2024, at 6:07 AM, Akhil Goyal wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > >> diff --git a/drivers/crypto/ionic/meson.build >> b/drivers/crypto/ionic/meson.build >> new fil

rte_bitmap_free() Re: DPDK Coverity issue 426433

2024-06-20 Thread Boyer, Andrew
Hello John, While Coverity is correct that this is a useless call, that's an internal implementation detail of rte_bitmap_free() - not really something the caller should know about. Can we annotate rte_bitmap_free() in some way to eliminate these? This is not the first PMD that's had this issue

Re: [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer

2025-03-19 Thread Boyer, Andrew
> On Mar 11, 2025, at 11:51 AM, Stephen Hemminger > wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > The expression *dev->intf->setup_bars and dev->intf->setup_bars > are equivalent. > >