2018-03-09 0:15 GMT+01:00 Stephen Hemminger :
> On Thu, 8 Mar 2018 21:52:48 +0800
> Qi Zhang wrote:
>
>> +struct bpf_insn prog[] = {
>> + {
>> + .code = 0x85, //call imm
>> + .dst_reg = 0,
>> + .src_reg = 0,
>> + .off = 0,
>> + .imm
On Linux PF hosts, the VF has no means of changing the HW CRC strip
setting for a RX queue. It's implicitly enabled.
This patch ignores, and warns, if HW CRC stripping was disabled.
Signed-off-by: Bj?rn T?pel
---
drivers/net/i40e/i40e_ethdev_vf.c | 15 +++
1 file changed, 15 inserti
On Linux PF hosts, the VF has no means of changing the HW CRC strip
setting for a RX queue. It's implicitly enabled.
This patch checks if the host is running a Linux PF kernel driver, and
returns an error, if HW CRC stripping was disabled.
Signed-off-by: Bj?rn T?pel
---
drivers/net/i40e/i40e_et
On hosts running a non-DPDK PF driver, the VF has no means of changing
the HW CRC strip setting for a RX queue. It's implicitly enabled.
This patch checks if the host is running a non-DPDK PF kernel driver,
and returns an error, if HW CRC stripping was disabled.
Signed-off-by: Bj?rn T?pel
---
d
Firstly, sorry about the late reply.
> From my view, crc-strip is not a "MUST" check for the port start. We can
> configure the value after
> the port start.
> Any thoughts?
>From my perspective, a non-supported configuration should return an
error code to the API user.
> Do you know is there a
Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC
stripping config") broke l3fwd, since it was forcing that CRC was
kept. Now, if i40evf is running, CRC stripping will be enabled.
Signed-off-by: Bj?rn T?pel
---
examples/l3fwd/main.c | 9 -
1 file changed, 8 insertions(+), 1
> Thanks for raising the issue. It is completely defeating the generic
> ethdev API. We must not have different behaviours depending of the
> driver. Why it cannot be fixed in the driver?
I should probably refer to the thread, where the concern was raised:
http://dpdk.org/ml/archives/dev/2016-July
Adding Helin to the conversation.
> That's a common problem across Intel VF devices. Bothe igb and ixgbe
> overcomes that problem just by forcing ' rxmode.hw_strip_crc = 1;' at
> PMD itself:
[...]
> Wonder, can't i40e VF do the same?
Right, however, and this (silent failure) approach was reject
>> Correct, so the broader question would be "what is the correct
>> behavior for an example application, when a port configuration
>> isn't supported by the hardware?".
>>
>> My stand, FWIW, is that igb and ixgbe should have the same
>> semantics as i40e currently has, i.e. return an error to the
Bj?rn/Konstantin wrote:
>> Finally, why doesn't l3fwd have the CRC stripped?
>
> I don?t know any good reason for that for l3fwd or any other sample
> app. I think it is just a 'historical' reason.
Ok! Then I'd suggest changing the l3fwd default to actually *strip* CRC
instead of not doing it. Lei
Lei wrote:
> I'm testing some DPDK sample under VMware. During the testing work, I
> find l3fwd+ ixgbe vf can work ,but L3fwd + i40evf can't work. So I
> reported this issue to Bjorn. From my perspective, if can add new
> parameter in l3fwd sample like what have already don?t in testpmd
> "c
Thomas wrote:
> Just to make it sure, you mean returning an error in the driver when
> a configuration cannot be applied, right?
Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC
stripping config"), where -EINVAL is returned.
Bj?rn
12 matches
Mail list logo
