Re: [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir

2023-01-16 Thread Ashish Sadanandan
On Wed, Jan 11, 2023 at 5:11 AM John Levon wrote: > On Sun, Jan 08, 2023 at 06:52:39PM -0700, Ashish Sadanandan wrote: > > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Ashish Sadanandan
On Fri, Feb 2, 2024 at 2:41 AM Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > 02/02/2024 06:13, Ashish Sadanandan: > > > The header was missing the extern "C" directive which causes name > > > mangling of f

[PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-01 Thread Ashish Sadanandan
Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- .mailmap | 2 +- lib/eal/include/generic/rte_vect.h | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index aa569ff456..3938ace307 100644 --- a/.mailmap +++ b/.mail

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
com] > > >> Sent: Monday, 5 February 2024 18.37 > > >> > > >> On Fri, Feb 02, 2024 at 09:40:59AM +, Bruce Richardson wrote: > > >>> On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > >>>> 02/02/2

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
On Wed, Mar 13, 2024 at 2:45 PM Thomas Monjalon wrote: > 13/03/2024 21:26, Ashish Sadanandan: > > On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup > > wrote: > > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > > Sent: Monday, 12 Februar

[PATCH v2 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-17 Thread Ashish Sadanandan
n stating `extern "C"` block should be added to public headers. Fixes: 86c743cf9140 ("eal: define generic vector types") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- .mailmap | 2 +- doc/g

[PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-17 Thread Ashish Sadanandan
n stating `extern "C"` block should be added to public headers. Fixes: 86c743cf9140 ("eal: define generic vector types") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- .mailmap | 2 +- doc/g

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Ashish Sadanandan
Hi everyone, I've made the updates as suggested. Could someone please review the latest patchset? Not sure if I followed the new patchset instructions correctly, I've always had trouble with that part. Thanks, Ashish. On Sun, Mar 17, 2024 at 8:44 PM Ashish Sadanandan < a

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-06 Thread Ashish Sadanandan
On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > 02/04/2024 18:03, Ashish Sadanandan: > > Hi everyone, > > I've made the updates as suggested. Could someone please review the > latest > > patchset? Not sure if I followed the new patchset instructions correctly

[PATCH 1/1] eal/linux: reject mountpt shorter than --huge-dir

2023-01-03 Thread Ashish Sadanandan
The code added for allowing --huge-dir to specify hugetlbfs sub-directories has a bug where it incorrectly matches mounts that contain a prefix of the specified --huge-dir. Consider --huge-dir=/dev/hugepages1G is passed to rte_eal_init. Given the following hugetlbfs mounts $ mount | grep hugetlbf

Re: [PATCH 1/1] eal/linux: reject mountpt shorter than --huge-dir

2023-01-03 Thread Ashish Sadanandan
3, 2023 at 11:57 AM Ashish Sadanandan < ashish.sadanan...@gmail.com> wrote: > The code added for allowing --huge-dir to specify hugetlbfs > sub-directories has a bug where it incorrectly matches mounts that > contain a prefix of the specified --huge-dir. > > Consider --huge-di

[PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-03 Thread Ashish Sadanandan
s") Cc: john.le...@nutanix.com Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- lib/eal/linux/eal_hugepage_info.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6cb31f

[PATCH v3 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
s") Cc: john.le...@nutanix.com Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- lib/eal/linux/eal_hugepage_info.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6cb31f

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
On Wed, Jan 4, 2023 at 4:24 AM Dmitry Kozlyuk wrote: > 2023-01-03 17:00 (UTC-0700), Ashish Sadanandan: > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a prefix of the

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
On Wed, Jan 4, 2023 at 9:22 AM John Levon wrote: > On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote: > > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a

[PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir

2023-01-08 Thread Ashish Sadanandan
s") Cc: john.le...@nutanix.com Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- lib/eal/linux/eal_hugepage_info.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6cb31f

[dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Signed-off-by: Ashish Sadanandan --- lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Ashish Sadanandan
10 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 29 Dec 2020 12:41:44 -0700 > Ashish Sadanandan wrote: > > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker erro

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
Cc: sta...@dpdk.org Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48 Signed-off-by: Ashish Sadanandan --- v2: * No functional change * Add fixes tag with reference to commit that introduced the header * CC sta...@dpdk.org lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 inser

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- v2: * No functional change * Add fixes tag with reference to commit that introduced the header * CC sta...@dpdk.org lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_dyn

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-06 Thread Ashish Sadanandan
g a patch to DPDK, so forgive me if this > > is covered in the contributing doc, but I couldn't find anything that > > applied to this situation > > > > On Tue, Dec 29, 2020 at 1:10 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > > &

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- v2: * No functional change * Add fixes tag with reference to commit that introduced the header * CC sta...@dpdk.org lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_dyn

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-07 Thread Ashish Sadanandan
Cc: sta...@dpdk.org Signed-off-by: Ashish Sadanandan --- v2: * No functional change * Add fixes tag with reference to commit that introduced the header * CC sta...@dpdk.org lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_dyn

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-07 Thread Ashish Sadanandan
Hi David, On Thu, Jan 7, 2021 at 1:02 AM David Marchand wrote: > On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan > wrote: > > > > Hi Olivier, > > > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz > wrote: > > > > > > Hi Ashish, > > >