* invalid escape sequences now generate SyntaxWarning
* therefore changed syntax to raw string noration.
Link: https://docs.python.org/3/library/re.html#module-re
Signed-off-by: Ariel Otilibili
---
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Hello,
This is my first patch to the list; your feedback is much appreciated.
My aim is to understand the internals of DPDK.
While compiling from scratch, I came across these Python warnings.
Thank you,
Ariel Otilibili (1):
buildtools: clear out regex syntax warnings
buildtools/get-test
Hello Maryam,
On Wed, Jan 29, 2025 at 6:58 PM Maryam Tahhan wrote:
> > +static struct rte_mbuf *
> > +maybe_kick_tx(struct pkt_tx_queue *txq, uint32_t *idx_tx, struct
> rte_mbuf *mbuf)
> > +{
> > + struct rte_mbuf *ret = mbuf;
> > +
> > + if (!xsk_ring_prod__reserve(&txq->tx, 1, idx_tx))
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
/)
Ariel Otilibili (2):
net/af_xdp: Fix use after free in af_xdp_tx_zc
net/af_xdp: Refactor af_xdp_tx_zc
.mailmap| 2 +-
drivers/net/af_xdp/rte_eth_af_xdp.c | 64 -
2 files changed, 36 insertions(+), 30 deletions(-)
--
2.30.2
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 62
On Fri, Jan 31, 2025 at 12:55 AM Stephen Hemminger <
step...@networkplumber.org> wrote:
> Need space after xdp_desc to follow style used elsewhere in DPDK.
>
There you are, Stephen:
https://inbox.dpdk.org/dev/20250131183439.909831-3-ariel.otilib...@6wind.com/
n
v2
(https://inbox.dpdk.org/dev/20250116225151.188214-1-ariel.otilib...@6wind.com/)
* reworded commit messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
net/af_xdp: Fix use after free in af_xdp_
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp
Hi Maryam,
On Thu, Feb 6, 2025 at 2:09 AM Maryam Tahhan wrote:
>
>
> On Sat 1 Feb 2025, 10:03 Ariel Otilibili,
> wrote:
>
>> Both legs of the loop share the same logic: the common parts are about
>> reserving and filling both address and length into the descriptio
Hi Maryam,
On Thu, Feb 6, 2025 at 3:09 AM Maryam Tahhan wrote:
>
>
> On Sat 1 Feb 2025, 10:03 Ariel Otilibili,
> wrote:
>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index 092bcb73aa0a..840a12dbf508 1
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
Hi Maryam, hi Stephen;
On Fri, Feb 7, 2025 at 10:14 AM Maryam Tahhan wrote:
> Sorry if my remarks were confusing, it was just missing from the previous
> patch and it needs to be:
> desc->len = mbuf->pkt_len;
>
> We need to keep this the same as the original code. This is a scenario
> where we n
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
net/af_xdp: Fix use after free in af_xdp_tx_zc
net/af_xdp: Refactor af_xdp_tx_zc
.mailmap| 2 +-
drivers/net/af_xdp/rte_eth_af_xdp.c | 75
On Fri, Feb 7, 2025 at 12:13 PM Maryam Tahhan wrote:
>
> On 07/02/2025 10:45, Ariel Otilibili wrote:
>
> Both legs of the loop share the same logic: the common parts are about
> reserving and filling both address and length into the description.
>
> This is moved
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
ssage of patch-1
* addressed feedback of Maryam Tahhan
v2
(https://inbox.dpdk.org/dev/20250116225151.188214-1-ariel.otilib...@6wind.com/)
* reworded commit messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
net/af_xdp: Fix use after free in af_xdp_tx_zc
net/af_xdp: Refactor af_xdp_tx_zc
.mailmap| 2 +-
drivers/net
Hello Stephen,
On Thu, Jan 30, 2025 at 7:24 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> Acked-by: Stephen Hemminger
>
Thanks for having looked into the patch; I have ACKed the fourth version by
your name,
https://inbox.dpdk.org/dev/20250130221853.789366-2-ariel.otilib...@6wind.co
Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.
This is moved into reserve_and_fill().
Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp
messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
net/af_xdp: Fix use after free in af_xdp_tx_zc
net/af_xdp: Refactor af_xdp_tx_zc
.mailmap| 2 +-
drivers/net
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
Acked-by: Stephen Hemminger
---
Coverity issue: 385414, 374016
Fixes: c836a7ba33e ("net/octeon_ep: support mailbox between VF and PF")
Fixes: bb5b5bf1e5c ("net/enetfec: support queue configuration")
Signed-off-by: Ariel Otilibili
--
Cc: sta...@dpdk.org
Cc: Vamsi Attunuru
Cc: Apeksha Gupta
Cc: Sachin Saxe
Hello,
This patch clears out the Coverity issues 385414 & 374016.
Thank you,
Ariel Otilibili (1):
net/{octeon_ep,enetfec}: remove unused value
drivers/net/enetfec/enet_ethdev.c | 1 -
drivers/net/octeon_ep/otx_ep_mbox.c | 3 ---
2 files changed, 4 deletions(-)
--
2.47.1
sertools/dpdk-telemetry-exporter.py|383|fullname = re.sub(r"\W", ".",
f"dpdk.{e.__name__}.{name}")
```
Link: https://inbox.dpdk.org/dev/d6amqxrsg8e7.33baorrhrh...@redhat.com/
Link:
https://inbox.dpdk.org/dev/cajfav8yeawsx2kdianwukx7zsvtenrvov
Robin Jarry
Signed-off-by: Ariel Otilibili
---
dts/framework/testbed_model/traffic_generator/scapy.py | 2 +-
dts/tests/TestSuite_smoke_tests.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dts/framework/testbed_model/traffic_generator/scapy
/
Link: https://docs.python.org/3/whatsnew/3.12.html#other-language-changes
Fixes: 9d4efc5cc6f ("buildtools: fix NUMA nodes count")
Fixes: f88b0b89220 ("devtools: forbid indent with tabs in Meson")
Cc: Bruce Richardson
Cc: sta...@dpdk.org
Suggested-by: Robin Jarry
Signed-off
return -1;
}
return 0;
}
```
Coverity issue: 357712
Coverity issue: 357737
Signed-off-by: Ariel Otilibili
---
app/test/test_bitmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
index bab11812c7..a21210a215 100644
--- a/app/test/
*** BLURB HERE ***
Ariel Otilibili (1):
app/test: remove useless calls to rte_bitmap_free
app/test/test_bitmap.c | 2 --
1 file changed, 2 deletions(-)
--
v2:
* fix style issues.
2.47.1
Hello,
This patch fixes the Coverity IDs 357712 & 357737.
Afterwards the application compiles without warnings.
Thank you,
Ariel Otilibili (1):
app/test: remove useless calls to rte_bitmap_free
app/test/test_bitmap.c | 2 --
1 file changed, 2 deletions(-)
--
2.47.1
return -1;
}
return 0;
}
```
Reported-by: Coverity, IDs 357712 & 357737
Signed-off-by: Ariel Otilibili
---
app/test/test_bitmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
index bab11812c7..a21210a215 100644
--- a/app/t
Hello,
This series clears out the Coverity issues 38 & 451221.
Being one-liners, as advised by David Marchand, it is backported onto stable.
Thank you,
Link:
https://inbox.dpdk.org/dev/cajfav8yeawsx2kdianwukx7zsvtenrvovjnzaoq_ocdzm8z...@mail.gmail.com/
Ariel Otilibili (2):
exam
Coverity issue: 38
Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
Cc: Andrew Rybchenko
Cc: sta...@dpdk.org
Signed-off-by: Ariel Otilibili
---
drivers/net/sfc/sfc_repr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_repr.c b/drive
Coverity issue: 451221
Fixes: 16158f3490 ("examples/flow_filtering: introduce use cases snippets")
Cc: Ori Kam
Cc: sta...@dpdk.org
Signed-off-by: Ariel Otilibili
---
examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/flow
orphaned tests")
Cc: sta...@dpdk.org
Signed-off-by: Ariel Otilibili
---
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
index c61f6a273f..fd22d25f36 100644
--- a/buildtools/get-
Hello,
This is my first patch to the list; your feedback is much appreciated.
My aim is to understand the internals of DPDK.
While compiling from scratch, I came across these Python warnings.
Thank you,
Ariel Otilibili (1):
buildtools: clear out regex syntax warnings
buildtools/get-test
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 171875d067 ("net/bonding: release port upon close")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Chas Williams
Cc: "Min Hu (Connor)"
---
drivers/net/bonding/rt
v2:
* fix style issues.
Ariel Otilibili (10):
devtools/cocci,lib/eal: remove unused rte_bitmap_free()
app/test: remove unsued rte_bitmap_free()
net/sfc: remove unused rte_bitmap_free()
crypto/ionic: remove unused rte_bitmap_free()
net/cxgbe: remove unused rte_bitmap_free()
net/mlx4: remov
https://lore.kernel.org/all/6a08397f-8d6e-4631-b63e-4cae319f1...@amd.com/T/#m35464e4e6dccfa904ab7e5f0a0b246e63e0ed74e
Link: https://inbox.dpdk.org/dev/20241213085928.0f2f2de1@hermes.local/
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Stephen Hemminger step...@networkplumber.org
Cc: Andrew Boyer
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: e00c3a0c1b ("net/sfc: rename SW stats structures")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Andrew Rybchenko
---
drivers/net/sfc/sfc_sw_stats.c | 1 -
1 file changed,
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Coverity issue: 357712, 357737
Fixes: 24d376bfee ("test/bitmap: fix memory leak")
Signed-off-by: Ariel Otilibili
--
Cc: sta...@dpdk.org
Cc: Cristian Dumitrescu
Cc: Stephen Hemminger
---
ap
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Matan Azrad
Cc: Viacheslav Ovsiienko
---
drivers/net/mlx4/mlx4_mr.c | 1
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Dariusz Sosnowski
Cc: Viacheslav Ovsiienko
Cc: Bing Zhao
Cc: Ori Kam
Cc: Sua
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Potnuri Bharat Teja
---
drivers/net/cxgbe/cxgbe_main.c | 1 -
1 file changed,
The default switch case ends with a goto; meaning these instructions are
never reached.
Coverity issue: 121742
Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base")
Signed-off-by: Ariel Otilibili
--
Cc: sta...@dpdk.org
Cc: Andrew Rybchenko
---
drivers/common/sfc_efx/base/efx_mon.c
Hello,
This patch clears out Coverity ID 121742.
Thank you,
Ariel Otilibili (1):
common/sfc_efx/base: remove unreachable code
drivers/common/sfc_efx/base/efx_mon.c | 3 ---
1 file changed, 3 deletions(-)
--
2.47.1
t outbound soft expiry notification")
Fixes: 05d727e8b1 ("common/cnxk: support NIX traffic management")
Fixes: 124ff1a4cb ("common/cnxk: support NPA device")
Fixes: 357f5ebc8a ("common/cnxk: support flow aging")
Fixes: 7eabd6c637 ("net/cnxk: support inline securi
k/cnxk_ethdev.c:314:
plt_bitmap_free(dev->outb.sa_bmap);
```
Fixes: fa8f86a14e ("common/cnxk: add build infrastructre and HW definition")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Nithin Dabilpuram
Cc: Kiran Kumar K
Cc: Sunil Kumar Kori
Cc: Satha Rao
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 171875d067 ("net/bonding: release port upon close")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Chas Williams
Cc: "Min Hu (Connor)"
---
drivers/net/bonding/rt
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Long Li
Cc: Wei Hu
---
drivers/net/netvsc/hn_rxtx.c | 1
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 6bc7f2cf66 ("crypto/ionic: support sessions")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Andrew Boyer
---
drivers/crypto/ionic/ionic_crypto_main.c | 1 -
1 file
https://lore.kernel.org/all/6a08397f-8d6e-4631-b63e-4cae319f1...@amd.com/T/#m35464e4e6dccfa904ab7e5f0a0b246e63e0ed74e
Link: https://inbox.dpdk.org/dev/20241213085928.0f2f2de1@hermes.local/
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Stephen Hemminger
Cc: Andrew Boyer
---
devtools/cocci/nullfre
h/20241222013328.1362225-3-otili...@eurecom.fr/
* fix build failures, https://github.com/ovsrobot/dpdk/actions/runs/12450201352
v3:
* addressed feedback from Stephen Hemminger
* removed rte_bitmap_free() wherever it was used
v2:
* fix style issues.
Ariel Otilibili (11):
devtools/cocc
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: e00c3a0c1b ("net/sfc: rename SW stats structures")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Andrew Rybchenko
---
drivers/net/sfc/sfc_sw_stats.c | 1 -
1 file changed,
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Potnuri Bharat Teja
---
drivers/net/cxgbe/cxgbe_main.c | 1 -
1 file changed,
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Dariusz Sosnowski
Cc: Viacheslav Ovsiienko
Cc: Bing Zhao
Cc: Ori Kam
Cc: Sua
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Coverity issue: 357712, 357737
Fixes: 24d376bfee ("test/bitmap: fix memory leak")
Signed-off-by: Ariel Otilibili
--
Cc: sta...@dpdk.org
Cc: Cristian Dumitrescu
Cc: Stephen Hemminger
---
ap
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused
rte_bitmap_free()").
Fixes: 06c047b680 ("remove unnecessary null checks")
Signed-off-by: Ariel Otilibili
---
Cc: sta...@dpdk.org
Cc: Matan Azrad
Cc: Viacheslav Ovsiienko
---
drivers/net/mlx4/mlx4_mr.c | 1
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/raw/ifpga/base/opae_intel_m
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/bnxt/bnxt_ethdev.c
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
lib/vhost/socket.c | 14 ++
ux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Ariel Otilibili (6):
raw/ifpga: remove check around pthread_mutex_init()
net/bnxt: remove check around pthread_mutex_init()
common/cnxk: remove check around pthread_mutex_init()
net/failsafe: remove check around pthread_mute
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/hinic/base/hinic_compat
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/common/cnxk/roc_bphy_cgx.c | 5 +-
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/failsafe/failsafe.c | 6 +--
function.
Bugzilla ID: 1559
Signed-off-by: Ariel Otilibili
---
lib/mempool/rte_mempool_ops.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/mempool/rte_mempool_ops.c b/lib/mempool/rte_mempool_ops.c
index 1b33380259b3..b5c68ac61b67 100644
--- a/lib/mempool
Hello,
This series is for BugZilla ID 1559.
rte_mempool_set_ops_byname() did not set rte_errno for error exit. As well,
other functions did not consistently set the variable.
For avoiding that, they are turned into single-exit functions.
Thank you,
Ariel Otilibili (2):
mempool: add
Some functions did not set rte_errno; for avoiding that, they are turned
into single-exit ones.
Bugzilla ID: 1559
Signed-off-by: Ariel Otilibili
---
lib/mempool/rte_mempool_ops.c | 38 ++-
1 file changed, 28 insertions(+), 10 deletions(-)
diff --git a/lib
Hi Maryam,
On Mon, Jan 20, 2025 at 4:28 PM Maryam Tahhan wrote:
>
> On 16/01/2025 17:51, Ariel Otilibili wrote:
>
This ends up duplicating the if condition `if (mbuf->pool ==
> umem->mb_pool) {` twice in `af_xdp_tx_zc`. Which is messy to read tbh...
>
> I think it woul
Hi Maryam,
On Mon, Jan 20, 2025 at 3:54 PM Maryam Tahhan wrote:
> I think that you could've just set tx_bytes to the desc->len as this is
> being set in all scenarios...
>
> tx_bytes += desc->len;
>
Thanks for your feedback. I'll change that.
For properly setting rte_errno, and exiting rte_mempool_create_empty()
from a single place.
Bugzilla ID: 1559
Signed-off-by: Ariel Otilibili
---
lib/mempool/rte_mempool.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/lib/mempool/rte_mempool.c
From: Ariel Otilibili https://inbox.dpdk.org/dev/20250119174643.2162110-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
mempool: fix rte_errno in rte_mempool_create_empty
mempool: make rte_mempool_create_empty a single-exit
lib/mempool/rte_mempool.c | 31
ol_8h.html#a82e301ee33ed7a263ceb4582655dc3ea
Signed-off-by: Ariel Otilibili
---
lib/mempool/rte_mempool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
index d8e39e5c2072..1e4f24783c0b 100644
--- a/lib/mempool/rte_mempool.c
+++ b/l
Hi Konstantin,
On Mon, Jan 20, 2025 at 12:44 AM Konstantin Ananyev <
konstantin.anan...@huawei.com> wrote:
>
>
> > Some functions did not set rte_errno; for avoiding that, they are turned
> > into single-exit ones.
> >
> > Bugzilla ID: 1559
> > Signe
Both legs of the loop share the same logic: either to go out of the
function, or to fall through to the next instructions.
For that, maybe_cpy_pkt() is introduced.
Bugzilla ID: 1440
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 131 ++--
1
/)
* reworded commit messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili (2):
net/af_xdp: fix use after free in af_xdp_tx_zc()
net/af_xdp: Refactor af_xdp_tx_zc()
drivers/net/af_xdp/rte_eth_af_xdp.c | 131
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_et
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/raw/ifpga/base/opae_intel_m
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/bnxt/bnxt_ethdev.c
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/hinic/base/hinic_compat
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
lib/vhost/socket.c | 14 ++
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/common/cnxk/roc_bphy_cgx.c | 5 +-
ux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
---
v2
* fix build issues
v1 (https://inbox.dpdk.org/dev/20250112185842.9752-1-otili...@eurecom.fr/#t)
Ariel Otilibili (6):
raw/ifpga: remove check around pthread_mutex_init()
net/bnxt: remove check around pthread_mutex_init()
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/failsafe/failsafe.c | 6 +--
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/hinic/base/hinic_compat
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
lib/vhost/socket.c | 14 ++
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/bnxt/bnxt_ethdev.c
ux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
---
v3
* fix style issues
v2 (https://inbox.dpdk.org/dev/20250112193043.67372-1-otili...@eurecom.fr/)
* fix build issues
v1 (https://inbox.dpdk.org/dev/20250112185842.9752-1-otili...@eurecom.fr/#t)
Ariel Otilibili (6):
raw/ifpga:
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/common/cnxk/roc_bphy_cgx.c | 5 +-
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/raw/ifpga/base/opae_intel_max10.c
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili
---
drivers/net/failsafe/failsafe.c | 6 +--
Hello,
This patch clears out a static analysis warning.
Your feedback is much appreciated,
Ariel Otilibili (1):
eal/linux: Remove unused values
lib/eal/linux/eal_dev.c | 3 ---
1 file changed, 3 deletions(-)
--
2.30.2
rse and process")
Signed-off-by: Ariel Otilibili
---
lib/eal/linux/eal_dev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index e63f24d108c7..be97f56424de 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_de
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Cc: Ziyang Xuan
Cc: Xiaoyun Wang
Signed-off-by: Ariel Otilibili
Acked-by: S
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Cc: Maxime Coquelin
Cc: Chenbo Xia
Signed-off-by: Ariel Otilibili
Acked-by: S
1 - 100 of 152 matches
Mail list logo
