Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

ncern here. Perhaps there are cases where it's compiled without optimization, like debugging, but then I believe it's a non-issue. Hope my explanations shed some more light on this patch. :-) On Fri, Jan 12, 2018 at 6:35 PM, Thomas Monjalon wrote: > 21/11/2017 08:05, Aleksey

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

Please see my comments inline. On Sun, Jan 14, 2018 at 1:24 AM, Thomas Monjalon wrote: > Hi, > > I moved your top-post below and did some comments inline. > More opinions are welcome. > > 13/01/2018 23:05, Aleksey Baulin: > > On Fri, Jan 12, 2018 at 6:35 PM, Thomas Monja

[dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

A warning is issued when using an argument to likely() or unlikely() builtins which is evaluated to a pointer value, as __builtin_expect() expects a 'long int' type for its first argument. With this fix a pointer value is converted to an integer with the value of 0 or 1. Signed-off-b

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

Sorry for late response. Jim had given the correct answer already. You won't get an extra instruction with compiler optimization turned on. Aleksey. On Mon, Nov 20, 2017 at 4:36 PM, Wiles, Keith wrote: > > > > On Nov 19, 2017, at 4:16 PM, Aleksey Baulin > wrote: > &g

Re: [dpdk-dev] [PATCH] config: sort PMD config options

_LIBRTE_ARK_DEBUG_TX=n > -CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS=n > -CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=n > +CONFIG_RTE_LIBRTE_PMD_NULL=y > > # > -# Compile WRS accelerated virtual port (AVP) guest PMD driver > +# Compile software PMD backed by PCAP files > # > -CONFIG_RTE_LIBRTE_AVP_PMD=n > -CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=n > -CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=n > -CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y > -CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n > +CONFIG_RTE_LIBRTE_PMD_PCAP=n > > # > -# Compile the TAP PMD > -# It is enabled by default for Linux only. > +# Compile example software rings based PMD > # > -CONFIG_RTE_LIBRTE_PMD_TAP=n > +CONFIG_RTE_LIBRTE_PMD_RING=y > +CONFIG_RTE_PMD_RING_MAX_RX_RINGS=16 > +CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16 > > # > -# Compile null PMD > +# Compile SOFTNIC PMD > # > -CONFIG_RTE_LIBRTE_PMD_NULL=y > +CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y > > # > -# Compile fail-safe PMD > +# Compile the TAP PMD > +# It is enabled by default for Linux only. > # > -CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y > +CONFIG_RTE_LIBRTE_PMD_TAP=n > > # > # Do prefetch of packet data within PMD driver receive function > -- > 2.13.6 > > -- Aleksey Baulin