[PATCH] pci: define more standard register offsets

2025-04-15 Thread David Marchand
The PCI standard defines registers for: - subsystem id, - revision id, - status of the device, - vital product data, Add them to rte_pci.h and use in existing drivers. Signed-off-by: David Marchand --- drivers/dma/hisilicon/hisi_dmadev.c | 3 +-- drivers/dma/hisilicon/hisi_dmadev.h | 1 - dri

Flow API Test Suite Inquiry

2025-04-15 Thread Dean Marx
Hello Ori, I work at the UNH-IOL DPDK Community Lab, and I am writing an rte_flow test suite to add to the DPDK Test Suite. The flow API allows for an extremely broad set of rules to be created. My understanding from my first pass at writing the test suite is that there is a small subset of tho

[PATCH 1/2] dts: add remote create dir function

2025-04-15 Thread Thomas Wilks
Add a function that creates a directory on the remote. Signed-off-by: Thomas Wilks Reviewed-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/testbed_model/os_session.py| 4 dts/framework/testbed_model/posix_session.py | 4 2 files changed, 8 insertions(+) diff --

Re: [PATCH v2 2/4] buildtools: use macro to embed information in binaries

2025-04-15 Thread Andre Muezerie
On Tue, Apr 15, 2025 at 10:44:51AM +0300, Dmitry Kozlyuk wrote: > On 15.04.2025 04:21, Andre Muezerie wrote: > >-_, tmp_root, ar, archive, output, *pmdinfogen = sys.argv > >+_, tmp_root, archiver, archive, output, *pmdinfogen = sys.argv > > with tempfile.TemporaryDirectory(dir=tmp_root) as temp: >

Re: [RFC 01/13] app/testpmd: revert auto attach/detach

2025-04-15 Thread lihuisong (C)
Hi Stephen, The main cause of cpfl driver attach failure is the added alarm in new event callback to setup port automatically. It's a question of when to set up the new port. Please see the discussion[1]. I have a stupid method, but I'm not very willing to do that. For the Bugzilla id1695, I'l

Re: [PATCH v2 2/4] buildtools: use macro to embed information in binaries

2025-04-15 Thread Dmitry Kozlyuk
On 15.04.2025 04:21, Andre Muezerie wrote: -_, tmp_root, ar, archive, output, *pmdinfogen = sys.argv +_, tmp_root, archiver, archive, output, *pmdinfogen = sys.argv with tempfile.TemporaryDirectory(dir=tmp_root) as temp: paths = [] -for name in subprocess.run([ar, "t", archive], stdou

[PATCH] net/intel: fix igb tx queue offloads capability

2025-04-15 Thread Kaiwen Deng
The igb driver assigns the tx port offload capability to the tx queue offload capability. This commit will fix this issue. Fixes: daa3b0833f08 ("net/e1000: fix Tx offload capability typos") Cc: sta...@dpdk.org Signed-off-by: Kaiwen Deng --- drivers/net/intel/e1000/igb_rxtx.c | 6 ++ 1 file

[PATCH v1 03/12] node: add IP4 FIB route add

2025-04-15 Thread Ankur Dwivedi
Adds a public function to add IP4 route to FIB. The applications should call this function to add IP4 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 36 lib/node/rte_node_ip4_api.h | 19 +++ 2 files changed, 55 i

[PATCH v1 10/12] node: add process callback for IP6 FIB

2025-04-15 Thread Ankur Dwivedi
Adds the process callback function for ip6_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 158 ++ 1 file changed, 158 insertions(+) diff --git a/lib/node/ip6_lookup_fib.c b/lib/node/ip6_lookup_fib.c index caf3e9d1fa..6ad975dddb

[PATCH] net/e1000: fix eeprom dump failure

2025-04-15 Thread Yuan Wang
There is a incorrect comparison in get_eeprom that cause epprom dump fail. This patch fixes this issue. Fixes: 83c314da4c38 (igb: add access to specific device info) Cc: sta...@dpdk.org Signed-off-by: Yuan Wang --- drivers/net/intel/e1000/igb_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH] dts: add ICMP to packet filter config

2025-04-15 Thread Luca Vizzarro
NICs like the Intel E810-C often produce ICMP packets. These packets are stray and can interfere with testing. Therefore, add an ICMP filtering option in the packet filter. Moreover, use Scapy constants for the header values. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- Hi ther

Re: [RFC PATCH 1/4] ethdev: add support to provide link type

2025-04-15 Thread Nithin Dabilpuram
On Fri, Apr 4, 2025 at 6:16 AM Stephen Hemminger wrote: > > On Thu, 3 Apr 2025 12:38:34 +0530 > Nithin Dabilpuram wrote: > > > /** > > * A structure used to retrieve link-level information of an Ethernet port. > > */ > > @@ -341,6 +354,7 @@ struct rte_eth_link { > > uin

[PATCH v1] net/zxdh: add support E31X series device ID

2025-04-15 Thread Junlong Wang
add support e312s、e316、e310_rdma、e312_rdma device id. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 23 --- drivers/net/zxdh/zxdh_ethdev.h | 13 +++-- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/d

Re: [PATCH v2 3/4] usertools: parse strings from PE images

2025-04-15 Thread Robin Jarry
Hi Andre, Thanks for the respin. Could you format the code using ruff/black before sending a v3? Andre Muezerie, Apr 15, 2025 at 03:21: > Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse > symbols from sections in PE images. > > Signed-off-by: Andre Muezerie > --- > userto

[PATCH] net/gve: support for gVNIC PCI revision 1 and later

2025-04-15 Thread Joshua Washington
gVNIC PCI revisions greater than 0 have support for setting the admin queue by its full address instead of using the PFN, which can be problematic if the system page size is not actually 4K as the device assumes. Beyond that, a new device/driver reset mechanism is introduced. Originally, a device r

[PATCH] maintainers: update GVE maintainers

2025-04-15 Thread Joshua Washington
Signed-off-by: Joshua Washington --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 167cc74a15..96e1d4e7a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -754,7 +754,6 @@ F: doc/guides/nics/features/enic.ini Google Virtual Ethernet M: Jeroen de B

[PATCH v1 06/12] app/graph: add IP4 lookup mode command

2025-04-15 Thread Ankur Dwivedi
Adds a command to setup lookup mode for IP4 packets. By default the LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP4 lookup fib node. Signed-off-by: Ankur Dwiv

[PATCH 0/2] dts: use tmp dir and DPDK tree dir

2025-04-15 Thread Thomas Wilks
Hi, Sending this update to extend the use of the tmp and DPDK tree dir. Best regards, Thomas Thomas Wilks (2): dts: add remote create dir function dts: use tmp dir and DPDK tree dir dts/framework/remote_session/dpdk.py | 74 ++-- dts/framework/testbed_model/os_sess

[PATCH v1 01/12] fib: move macro to header file

2025-04-15 Thread Ankur Dwivedi
Moves RTE_FIB_NAMESIZE to header file, in order to use it outside the fib library. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib.c | 3 --- lib/fib/rte_fib.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c index 2c05d46500..184210f

[PATCH v3 4/4] drivers: use macro to embed information in binaries

2025-04-15 Thread Andre Muezerie
DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

[PATCH v3 2/4] buildtools: use macro to embed information in binaries

2025-04-15 Thread Andre Muezerie
The archiver tool from the MSVC toolset is lib.exe. It has different parameters then it's GNU counterpart "ar". buildtools\meson.build was updated to use lib.exe when MSVC compiler is used. This is to allow the code to be built without requiring GNU "ar" to be installed in that scenario. Script g

[PATCH v3 3/4] usertools: parse strings from PE images

2025-04-15 Thread Andre Muezerie
Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse symbols from sections in PE images. Signed-off-by: Andre Muezerie --- usertools/dpdk-pmdinfo.py | 53 +++ 1 file changed, 43 insertions(+), 10 deletions(-) diff --git a/usertools/dpdk-pmdi

[PATCH v3 0/4] allow pmdinfo to be inserted and parsed using MSVC

2025-04-15 Thread Andre Muezerie
DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

[PATCH v3 1/4] eal: add macro to embed information in binaries

2025-04-15 Thread Andre Muezerie
DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

Re: [RFC 01/13] app/testpmd: revert auto attach/detach

2025-04-15 Thread Stephen Hemminger
On Tue, 15 Apr 2025 21:28:07 +0800 "lihuisong (C)" wrote: > Hi Stephen, > > The main cause of cpfl driver attach failure is the added alarm in new > event callback to setup port automatically. > It's a question of when to set up the new port. Please see the > discussion[1]. I have a stupid met

Re: [PATCH 3/3] net/nfp: standard the data endian of NFDk Tx descritor

2025-04-15 Thread Stephen Hemminger
On Tue, 15 Apr 2025 10:54:53 +0800 Chaoyong He wrote: > The data endian of NFDk Tx descriptor should be little, and the related > logic also should modify. > > Fixes: d7f6d9b21ffa ("net/nfp: adjust coding style for NFDk") > Cc: sta...@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Long

Re: [PATCH v2 4/4] drivers: use macro to embed information in binaries

2025-04-15 Thread Stephen Hemminger
On Mon, 14 Apr 2025 18:21:36 -0700 Andre Muezerie wrote: > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c > b/drivers/baseband/acc/rte_acc100_pmd.c > index b7f02f56e1..a4cbe6f42f 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4082,9 +

[PATCH v1 02/12] node: add IP4 lookup FIB node

2025-04-15 Thread Ankur Dwivedi
Adds a lookup FIB node for IP4. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 127 ++ lib/node/meson.build | 3 +- 2 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 lib/node/ip4_lookup_fib.c diff --git a/lib/node/ip4_

[PATCH v1 04/12] node: add process callback for IP4 FIB

2025-04-15 Thread Ankur Dwivedi
Adds the process callback function for ip4_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 164 ++ 1 file changed, 164 insertions(+) diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c index e87864e672..c535b191f8

[PATCH v1 00/12] add lookup fib nodes in graph library

2025-04-15 Thread Ankur Dwivedi
This patch series adds two inbuilt nodes ip4_lookup_fib and ip6_lookup_fib in graph library. These nodes uses the existing Forwarding Information Base (FIB) library to create FIB, to do route addition and route lookup. Two new commands (for ipv4 and ipv6) for providing the lookup mode is added in

[PATCH v1 05/12] node: add next node in packet classification

2025-04-15 Thread Ankur Dwivedi
The ip4_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/pkt_cls_priv.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 9d21b7f307..3bd0ec0bbc 100644 --- a/lib/n

[PATCH v1 12/12] app/graph: add IP6 lookup mode command

2025-04-15 Thread Ankur Dwivedi
Adds a command to setup lookup mode for IP6 packets. By default LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP6 lookup fib node. Signed-off-by: Ankur Dwivedi

[PATCH v1 11/12] node: add next node in packet classification

2025-04-15 Thread Ankur Dwivedi
The ip6_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/pkt_cls_priv.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 3bd0ec0bbc..56bd5176b2 100644 --- a/lib/n

[PATCH v1 09/12] node: add IP6 FIB route add

2025-04-15 Thread Ankur Dwivedi
Adds a public function to add IP6 route to FIB. The applications should call this function to add IP6 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 34 ++ lib/node/rte_node_ip6_api.h | 19 +++ 2 files changed, 53 ins

[PATCH v1 07/12] fib: move macro to header file

2025-04-15 Thread Ankur Dwivedi
Moves the macro FIB6_NAMESIZE to header file and rename it to RTE_FIB6_NAMESIZE. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib6.c | 11 --- lib/fib/rte_fib6.h | 3 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/fib/rte_fib6.c b/lib/fib/rte_fib6.c index 00647bd

[PATCH v2 1/4] eal: add macro to embed information in binaries

2025-04-15 Thread Andre Muezerie
DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

[PATCH 2/2] dts: use tmp dir and DPDK tree dir

2025-04-15 Thread Thomas Wilks
File operations were not consistently using the same dedicated directory for the test run. Moreover the DPDK tree temporary directory was inconsistent and relying on the name chosen by the user. Update all the file operations to use the dedicated temporary directory, and make sure that the DPDK tr

[PATCH v1 08/12] node: add IP6 lookup FIB node

2025-04-15 Thread Ankur Dwivedi
Adds a lookup FIB node for IP6. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 124 ++ lib/node/meson.build | 1 + 2 files changed, 125 insertions(+) create mode 100644 lib/node/ip6_lookup_fib.c diff --git a/lib/node/ip6_lookup_fib.c b/l