RE: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

> Hi Stephen, > > Thanks for commenting. See response inline. > > Regards, > Nitin > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > wrote: > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > Nitin Saxena wrote: > > > > > +int rte_node_mbuf_dynfield_register(void) > > > +{ > > > + struct no

[PATCH v3 2/2] node: use node mbuf dynfield in ip4 nodes

- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c |

[PATCH v3 1/2] node: add global node mbuf dynfield

This patch defines rte_node specific dynamic field structure (rte_node_mbuf_dynfield_t) rte_node_mbuf_dynfield_t structure holds two types of fields - Persistent data fields which are preserved across graph walk. Currently size of persistent data fields is zero. - Overloadable data fields which

[PATCH v3 0/2] node: add mbuf dynamic field for nodes

Currently each rte_node registers separate mbuf dynamic fields for their own purpose. This leads to wastage of mbuf space as once mbuf get passed a particular node, the registered dynamic field(by that node) is no longer used. This patch series adds a global/common mbuf dynamic field which is reus

Re: [PATCH v7 5/8] build: mark exported symbols

On 4/4/25 08:48, Hemant Agrawal wrote: for DPAA/FSLMC changes Acked-by: Hemant Agrawal For common/sfc_efx: Acked-by: Andrew Rybchenko

Re: [PATCH v12 10/10] drivers: remove use of term sanity check

On 4/3/25 02:23, Stephen Hemminger wrote: Don't use term "sanity" because it is considered derogatory. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal For sfc: Acked-by: Andrew Rybchenko

Re: [PATCH v7 5/8] build: mark exported symbols

On 4/3/25 19:58, David Marchand wrote: Annotate symbols with newly introduced export macros. For code not compiled via drivers/meson.build (think base drivers code), the exported symbols are added in some new XX_base_symbols.c file added to the sources variable so they get caught by drivers/meso

Re: [PATCH 1/2] node: add global node mbuf dynfield

Hi Stephen, Thanks for commenting. See response inline. Regards, Nitin On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger wrote: > > On Tue, 1 Apr 2025 09:50:46 +0530 > Nitin Saxena wrote: > > > +int rte_node_mbuf_dynfield_register(void) > > +{ > > + struct node_mbuf_dynfield_mz *f = NULL; >

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

21/03/2025 10:20, Mcnamara, John: > > Subject: [PATCH V1] doc: add tested Intel platforms with Intel NICs > > > > Add tested Intel platforms with Intel NICs to v25.03 release note. > > Acked-by: John McNamara Applied, thanks.

[PATCH v2 1/2] eal: fix uncheck worker ID

The worker_id may come from user input. So it is necessary to verify it. Fixes: a95d70547c57 ("eal: factorize lcore main loop") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- lib/eal/common/eal_common_launch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_commo

[PATCH v3 1/4] net/intel: use common Tx queue structure

Merge in additional fields used by the idpf driver and then convert it over to using the common Tx queue structure. Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 18 ++ drivers/net/intel/cpfl/cpfl_ethdev.c | 2 +- drivers/net/intel/cpfl/cpfl_ethdev.h

[PATCH v4 02/11] net/intel: use common AVX build code

Remove driver-specific build instructions for the AVX2 and AVX-512 code, and rely instead on the generic driver build file. Signed-off-by: Bruce Richardson --- drivers/net/intel/i40e/meson.build | 26 ++ drivers/net/intel/iavf/meson.build | 25 ++--- d

[DPDK/other Bug 183] Problem using cloned rte_mbuf buffers with KNI interface

https://bugs.dpdk.org/show_bug.cgi?id=183 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Status|CONFIRMED |RESOLVED

Re: DPDK for rust

27/03/2025 17:17, Bruce Richardson: > On Thu, Mar 27, 2025 at 11:00:40AM +0200, Etelson, Gregory wrote: > > Hello Morten, > > > > Thank you for raising these questions ! > > > > > > > > Do we want the DPDK project itself to support rust? > > > Or should parts of this be a DPDK hosted project, li

Re: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

On Fri, 4 Apr 2025 08:11:07 + Pavan Nikhilesh Bhagavatula wrote: > > Hi Stephen, > > > > Thanks for commenting. See response inline. > > > > Regards, > > Nitin > > > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > > wrote: > > > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > > Nitin S

[PATCH 09/10] net/txgbe: use common base code build handling

Use the base code build handling logic in the drivers/meson.build file, rather than re-implementing it in the driver itself. Signed-off-by: Bruce Richardson --- drivers/net/txgbe/base/meson.build | 18 ++ drivers/net/txgbe/meson.build | 3 --- 2 files changed, 2 insertions(

Re: [PATCH v12 07/10] dts: replace use of sanity check in comment

Unfortunately I do find myself saying sanity check often... something to cut out from my vocabulary. From a quick google it looks like many are using coherence check in its place, or just explicitly writing out what the check is as you did. It would also probably be fine to just remove the comment

Re: 24.11.2 patches review and test

I tested below 18 scenarios on RHEL 9.2 hosts and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput testin

[PATCH] net/nfp: fix the hash key length logic problem

There does not exist an API for driver to get/set the hash key length from/to the firmware. --- #define NFP_NET_CFG_RSS_KEY_SZ 0x28 #define NFP_NET_CFG_MACADDR 0x0024 --- The original logic try to use the 'NFP_NET_CFG_RSS_KEY_SZ' as the inexistent API, read fr

Migrate DPDK 18.05.1 -> DPDK 24.11.1 LTS

Hi, In the 24.11.1 build, I have specific questions 1) I need the DPDK output in static lib format. How can I switch off the shared lib build? 2) I need to build librte_kni. a - Is this module deprecated in DPDK 24.11.1 3) How can I enable librte_pmd_* modules? In the driver/net folder, many pm

[DPDK/vhost/virtio Bug 1685] [dpdk-22.11.8RC1] virtio_ipsec_cryptodev_func/test_aesni_mb_aes_cbc_sha1_hmac: dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu

https://bugs.dpdk.org/show_bug.cgi?id=1685 Bug ID: 1685 Summary: [dpdk-22.11.8RC1] virtio_ipsec_cryptodev_func/test_aesni_mb_aes_cbc_sha1 _hmac: dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu

Re: [PATCH 04/10] net/intel: use common base code build handling

On Wed, Apr 02, 2025 at 03:05:07PM +0200, David Marchand wrote: > On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson > wrote: > > diff --git a/drivers/net/intel/ice/base/meson.build > > b/drivers/net/intel/ice/base/meson.build > > index e7ba9c34bc..f453005a1d 100644 > > --- a/drivers/net/intel/ice/

[PATCH 10/10] raw/ifpga: use common base code build handling

Use the base code build handling logic in the drivers/meson.build file, rather than re-implementing it in the driver itself. While making changes similar to that in other drivers, also move content around dependencies from the base/meson.build file to the main driver meson.build file, so that the

[PATCH v4 4/4] net/macb: add necessary docs and update related files

Added missing documentation in doc/guides/nics, mailmap entry, and updated MAINTAINERS file. Signed-off-by: liwencheng --- .mailmap | 1 + MAINTAINERS| 6 ++ doc/guides/nics/features/macb.ini | 27 +++ d

[PATCH v6 6/8] build: use dynamically generated version maps

Switch to dynamically generated version maps. As the map files get generated, tooling around checking, converting, updating etc.. static version maps can be removed. Signed-off-by: David Marchand --- .github/workflows/build.yml | 1 - MAINTAINERS

[PATCH 0/2] dts: smoke test bugfixes

There are two smoke test bugfixes which have come in from our 25.03 DTS development and which should be resolved with this series. 1. The patchseries which we merged for 25.03 which added the testsuite specific configs inadvertently broke enabling smoke tests, as we build the tests config model us

[RFC PATCH 3/4] common/cnxk: provide port type from fwdata

Port type data is made available by firmware via CGX lmac specific firmware data. Extract the same. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 12 drivers/common/cnxk/roc_mbox.h| 4 ++-- drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk

Re: [PATCH v3 1/2] node: add global node mbuf dynfield

On Fri, 4 Apr 2025 12:42:21 +0530 Nitin Saxena wrote: > diff --git a/lib/node/meson.build b/lib/node/meson.build > index 0bed97a96c..4330d0450b 100644 > --- a/lib/node/meson.build > +++ b/lib/node/meson.build > @@ -8,6 +8,7 @@ if is_windows > endif > > sources = files( > +'node_mbuf_dy

[PATCH v2 1/3] eal: centralize core parameter parsing

Rather than parsing the lcore parameters as they are encountered, just save off the lcore parameters and then parse them at the end. This allows better knowledge of what parameters are available or not when parsing. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 183 ++

[PATCH v2] mem: fix infinite loop

When the process address space is insufficient, mmap will fail, which will cause an infinite loop. This patch stops attempting mmap if it fails and the requested size cannot be reduced. Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") Cc: sta...@dpdk.org Signed-off-by:

[Patch v3 1/6] net/netvsc: introduce private data for storing vmbus device for secondary process

From: Long Li To prepare for supporting to set hyperv event from secondary process when the channel has monitoring disable, introduce a private data region for storing the vmbus device. The secondary process will get access to its vmbus device in case it needs to signal the host. Signed-off-by:

[Patch v3 4/6] bus/vmbus: support channels without monitoring enabled

From: Long Li Hyperv host may offer channels without monitor enabled. The max monitor ID it supports is 128. Over those channels without monitor enabled, Hyperv does not send or receive large amount of data traffic and almost all the data traffic is going over the VF. Change the code to not fail

[Patch v3 0/6] Support VMBUS channels without monitoring enabled

From: root Hyperv may expose VMBUS channels without monitoring enabled. In this case, it programs almost all the data traffic to VF. This patchset enabled vmbus/netvsc to use channels without monitoring enabled. This needs to change the APIs exposed by drivers/bus/vmbus. Becuase those APIs are

[Patch v3 6/6] bus/vmbus: set event for channel without monitoring support

From: Long Li For vmbus channels without monitoring support, use kernel UIO interface to indicate packet through interrupt page and UIO file handle. Signed-off-by: Long Li --- Change log: v2: fixed compilation warnings drivers/bus/vmbus/vmbus_channel.c | 21 ++--- 1 file chang

[Patch v3 3/6] bus/vmbus: store UIO fd for secondary process

From: Long Li Secondary process will get access to vmbus device and this UIO fd for signaling hyperv host on channels without monitoring support. Signed-off-by: Long Li --- drivers/bus/vmbus/vmbus_common_uio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers

[Patch v3 5/6] bus/vmbus: add rte_vmbus_device to all functions accessing vmbus

From: Long Li The secondary process can access its vmbus device through device private region. Add and pass it on all call chains leading to vmbus code. Signed-off-by: Long Li --- drivers/bus/vmbus/linux/vmbus_uio.c | 2 +- drivers/bus/vmbus/private.h | 2 +- drivers/bus/vmbus/rte_bu

[Patch v3 2/6] net/netvsc: introduce get_vmbus_device to get the vmbus device

From: Long Li Introduce a function get the vmbus device from hn_data. For secondary process, the vmbus device is in eth_dev's private region. Signed-off-by: Long Li --- drivers/net/netvsc/hn_nvs.c | 15 +++ drivers/net/netvsc/hn_nvs.h | 2 ++ 2 files changed, 17 insertions(+) dif

Re: [PATCH] acl: fix build with GCC 15 on aarch64

Hi guys, On Wed, Mar 26, 2025 at 11:40 AM David Marchand wrote: > > Caught in OBS for Fedora Rawhide on aarch64: > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > [ 198s] from ../lib/acl/acl_run_neon.c:5: > [ 198s] In function ‘alloc_completion’, > [ 198s]