RE: [v2] app/crypto-perf: add RSA support

2025-03-11 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, February 27, 2025 11:51 PM > To: dev@dpdk.org; Brian Dooley > Cc: Anoob Joseph ; Akhil Goyal > Subject: [v2] app/crypto-perf: add RSA support > > From: Akhil Goyal > > Add RSA support in crypto-perf applicati

Re: [PATCH] net/mlx5: fix assert failure on hairpin queue release

2025-03-11 Thread Raslan Darawsheh
Hi, >From: Maayan Kashani >Sent: Thursday, February 27, 2025 12:14 PM >To: dev@dpdk.org >Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; >Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; >Xueming Li >Subject: [PATCH] net/mlx5: fix assert failure on hairpi

Re: [PATCH] net/mlx5: fix crash when using represented port w/o port ID

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Thursday, February 27, 2025 12:33 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Alex Vesker; Mark Bloch Subject: [PATCH] net/mlx5: fix crash when using

Re: [PATCH] net/mlx5: fix LACP packets handling in isolated mode

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Thursday, February 27, 2025 12:20 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH] net/mlx5: fix LACP packets handling in isolated mode In

Re: [PATCH 1/2] net/mlx5: fix non template set VLAN VID

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Thursday, February 27, 2025 12:45 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Gregory Etelson Subject: [PATCH 1/2] net/mlx5: fix non template set VLAN

Re: [PATCH] net/mlx5: fix using wrong group ID for action translation

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Monday, March 3, 2025 3:49 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; Bing Zhao; sta...@dpdk.org; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH] net/mlx5: fix using wrong group ID for action translation From:

RE: [PATCH] common/cnxk: fix aura offset

2025-03-11 Thread Jerin Jacob
> -Original Message- > From: Nawal Kishor > Sent: Tuesday, March 4, 2025 10:52 AM > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Harman Kalra ; Ashwin > Sekhar T K > Cc: Jerin Jacob ; Nawal Kishor > Subje

Re: [PATCH 1/3] maintainers: update for Intel ipn3ke drivers

2025-03-11 Thread David Marchand
Hello, On Fri, Feb 21, 2025 at 2:11 AM Rosen Xu wrote: > > Change of maintainers' email for Intel ipn3ke drivers. > > Signed-off-by: Rosen Xu Series applied, thanks Rosen. -- David Marchand

[PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer

2025-03-11 Thread Stephen Hemminger
The expression *dev->intf->setup_bars and dev->intf->setup_bars are equivalent. Signed-off-by: Stephen Hemminger --- drivers/crypto/ionic/ionic_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ionic/ionic_crypto.h b/drivers/crypto/ionic/ionic_crypto.h

Re: [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers

2025-03-11 Thread Bruce Richardson
On Tue, Mar 11, 2025 at 08:51:29AM -0700, Stephen Hemminger wrote: > The expression *dev->ops->start and dev->ops->start are equivalent. > > Signed-off-by: Stephen Hemminger > --- > drivers/raw/ifpga/afu_pmd_core.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > Acked-

[PATCH 4/4] vhost: remove unnecessary deref of function pointers

2025-03-11 Thread Stephen Hemminger
Since it is a function pointer, the expression *dev->extern_ops.pre_msg_handle and dev->extern_ops.pre_msg_handle are the same. Signed-off-by: Stephen Hemminger --- lib/vhost/vhost_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/v

Re: [PATCH v2 1/3] eal: add function rte_size_to_str

2025-03-11 Thread Bruce Richardson
On Tue, Mar 11, 2025 at 08:49:05AM -0700, Stephen Hemminger wrote: > On Tue, 11 Mar 2025 08:33:13 -0700 > Andre Muezerie wrote: > > > It's common to use %' in the printf format specifier to make large numbers > > more easily readable by having the thousands grouped. However, this > > grouping doe

Re: [PATCH] doc: fix year of final LTS release

2025-03-11 Thread Thomas Monjalon
10/03/2025 11:28, fengchengwen: > Acked-by: Chengwen Feng > > On 2025/3/10 18:08, Kevin Traynor wrote: > > LTS length was updated to 3 years, but a sentence saying > > when the final release would be was not updated. > > > > Fixes: 3c60ea7b289a ("doc: update LTS maintenance to 3 years") > > Cc:

Re: [PATCH 0/4] more unnecessary function pointer

2025-03-11 Thread Bruce Richardson
On Tue, Mar 11, 2025 at 08:51:28AM -0700, Stephen Hemminger wrote: > A few more cases where there is unnecessary deref (*) on > function pointers. > > Stephen Hemminger (4): > raw/ifpga: remove unnecessary deref of function pointers > crypto/ionic: remove unnecessary deref of function pointer

Re: [PATCH v2] devtools: fix regex of skip files

2025-03-11 Thread Thomas Monjalon
06/03/2025 18:12, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > SKIP_FILES should include the path of the file along with the name. > Update the regex to match the entire path. > > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver") > Fixes: 2b843cac232e ("drivers: use

[PATCH 0/4] more unnecessary function pointer

2025-03-11 Thread Stephen Hemminger
A few more cases where there is unnecessary deref (*) on function pointers. Stephen Hemminger (4): raw/ifpga: remove unnecessary deref of function pointers crypto/ionic: remove unnecessary deref of function pointer regexdev: another unnecessary deref of function pointers vhost: remove unne

[PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers

2025-03-11 Thread Stephen Hemminger
The expression *dev->ops->start and dev->ops->start are equivalent. Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/afu_pmd_core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/raw/ifpga/afu_pmd_core.c b/drivers/raw/ifpga/afu_pmd_core.c index

[PATCH 3/4] regexdev: another unnecessary deref of function pointers

2025-03-11 Thread Stephen Hemminger
The expression *dev->enqueue and dev->enqueue are equivalent. Signed-off-by: Stephen Hemminger --- lib/regexdev/rte_regexdev.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h index b18a1d4251..1534e9f84a 100644

Re: [RFC v3 0/8] Symbol versioning and export rework

2025-03-11 Thread David Marchand
On Tue, Mar 11, 2025 at 11:18 AM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Tuesday, 11 March 2025 10.56 > > > > So far, each DPDK library (or driver) exposing symbols in an ABI had to > > maintain a version.map and use some macros for symbol vers

Re: [PATCH] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-11 Thread Raslan Darawsheh
Hi, From: Dariusz Sosnowski Sent: Wednesday, March 5, 2025 3:23 PM To: Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Erez Shitrit; Alex Vesker Cc: dev@dpdk.org; sta...@dpdk.org Subject: [PATCH] net/mlx5/hws: fix incorrect DV FT type convert From: Alex Vesker When creating a

Re: [PATCH] net/mlx5: fix flow create failure with GENEVE options match

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Monday, March 3, 2025 3:29 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Bing Zhao; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH] net/mlx5: fix flow create failure with GENEVE options match For

[PATCH] app/crypto-perf: fix aad offset alignment

2025-03-11 Thread Shani Peretz
AAD offset in AES-GCM crypto test was calculated by adding 16-byte alignment after the IV, which is only needed in AES-CCM. The patch correct the AAD offset calculation in AES-GCM algorithm tests. Fixes: 0b242422d385 ("app/crypto-perf: set AAD after the crypto operation") Cc: sta...@dpdk.org Sig

[PATCH v1] net/mlx5: support multi-host lag probe

2025-03-11 Thread Rongwei Liu
Under multi-host environments, the NIC exports total 4 ports, and each host get 2 ports. The 2 ports' identifier is uncontinous now. It causes the lag port array access violation. Increase the lag port array and allow the hole in middle. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --

RE: [EXTERNAL] [PATCH v10 3/3] eventdev: add atomic atq to test-eventdev app

2025-03-11 Thread Jerin Jacob
> -Original Message- > From: Luka Jankovic > Sent: Thursday, March 6, 2025 2:20 PM > To: luka.janko...@ericsson.com > Cc: dev@dpdk.org; Jerin Jacob ; > mattias.ronnb...@ericsson.com; Pavan Nikhilesh Bhagavatula > > Subject: [EXTERNAL] [PATCH v10 3/3] eventdev: add atomic atq to test- >

RE: [RFC v3 0/8] Symbol versioning and export rework

2025-03-11 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 11 March 2025 10.56 > > So far, each DPDK library (or driver) exposing symbols in an ABI had to > maintain a version.map and use some macros for symbol versioning, > specially crafted with the GNU linker in mind. > > This

Re: [PATCH] net/mlx5: fix GTP flags matching

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Thursday, February 27, 2025 12:49 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Alex Vesker; Mark Bloch Subject: [PATCH] net/mlx5: fix GTP flags matchin

[PATCH v2] common/qat: fix incorrect size in the parser

2025-03-11 Thread Arkadiusz Kusztal
The function `strlen` returns the size of the string without a terminating null-character, therefore a request to allocate memory space for a parsed argument is too small by 1. Fixes: 99ab2806687b ("common/qat: isolate parser arguments configuration") Cc: sta...@dpdk.org Signed-off-by: Arkadiusz

Re: [PATCH 1/2] net/mlx5: fix non template flow validation on validate

2025-03-11 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Monday, March 3, 2025 3:34 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; sta...@dpdk.org; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH 1/2] net/mlx5: fix non template flow validation on validate For

Re: [PATCH v4 7/7] dts: improve configuration errors

2025-03-11 Thread Luca Vizzarro
On 04/03/2025 22:39, Dean Marx wrote: Looks great, thanks Luca! Reviewed-by: Dean Marx Thank you for your review Dean!

[PATCH] net/mlx5: fix mark flow action validation in FDB mode

2025-03-11 Thread Gregory Etelson
The MARK flow action is supported in FDB SWS mode, but it was not supported in the early FDB HWS implementations. The current MARK flow action validation reflects the original HWS functionality. Recent MLX5 FW supports the MARK flow action in FDB mode. The patch clears the MARK action for both S

[RFC v3 1/8] lib: remove incorrect exported symbols

2025-03-11 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. eal_log_journal has no implementation and can be removed. Signed-off-by: David Marchand --- lib/eventdev/version.map | 12 lib/graph/ver

[RFC v3 2/8] drivers: remove incorrect exported symbols

2025-03-11 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. rte_dpaa2_dev_type is an enum token. roc_se_ctx_swap has no implementation (leftover from a previous rework) and can be removed. Signed-off-by: David M

[RFC v3 0/8] Symbol versioning and export rework

2025-03-11 Thread David Marchand
So far, each DPDK library (or driver) exposing symbols in an ABI had to maintain a version.map and use some macros for symbol versioning, specially crafted with the GNU linker in mind. This series proposes to rework the whole principle, and instead rely on marking the symbol exports in the source

[RFC v3 4/8] buildtools: display version when listing symbols

2025-03-11 Thread David Marchand
Display the version when a symbol was introduced. This is needed for scripting the conversion from static to dynamically generated version maps. It is also useful when listing experimental symbols. Signed-off-by: David Marchand --- buildtools/map-list-symbol.sh | 2 +- 1 file changed, 1 insertio

[RFC v3 7/8] build: use dynamically generated version maps

2025-03-11 Thread David Marchand
Switch to always dynamically generate version maps. As the map files get generated, tooling around checking, converting, updating etc.. static version maps can be removed. Signed-off-by: David Marchand --- .github/workflows/build.yml | 1 - MAINTAINERS

[RFC v3 5/8] build: generate symbol maps

2025-03-11 Thread David Marchand
Rather than maintain a file in parallel of the code, symbols to be exported can be marked with a token RTE_EXPORT_*SYMBOL. >From those marks, the build framework generates map files only for symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack becomes unnecessary). The build fra

[RFC v3 3/8] eal: rework function versioning macros

2025-03-11 Thread David Marchand
For versioning symbols: - MSVC uses pragmas on the symbol, - GNU linker uses special asm directives, To accommodate both GNU linker and MSVC linker, introduce new macros for exporting and versioning symbols that will surround the whole function. This has the advantage of hiding all the ugly detai

Re: [PATCH v2] net/ice: fix flow engines order

2025-03-11 Thread Bruce Richardson
On Mon, Mar 10, 2025 at 05:40:28PM +, Vladimir Medvedkin wrote: > Reorder flow engine evaluation for RTE flow rule installation. > Currently, the driver evaluates rules with engines in the order they are > executed in the hardware. However, in this situation, some wildcarded flows > that are al

Re: [PATCH 2/6] dts: use topology in smoke tests

2025-03-11 Thread Luca Vizzarro
On 05/03/2025 23:26, Dean Marx wrote: On Mon, Feb 24, 2025 at 8:30 AM Luca Vizzarro wrote: The smoke tests where wrongly using all the node's ports for the smoke tests. Ensure only the ports specified in the current topology are used. Should be were, not where argh, good catch! thank you!

Re: [PATCH 3/6] dts: add tmp directory facility

2025-03-11 Thread Luca Vizzarro
On 05/03/2025 23:29, Dean Marx wrote: This makes sense, I noticed though that nothing is actually stored in these placeholder directories yet, and dpdk is built in a separate folder. Is the plan in the future to move this to the placeholder directory? Or is there a different use case? Reviewed-b

[PATCH] test/crypto: skip test when virtio PMD not loaded

2025-03-11 Thread Gowrishankar Muthukrishnan
Skip asymmetric test when virtio PMD is not loaded. Fixes: 7e2e9d5f3227 ("test/crypto: add asymmetric cases for virtio") Fixes: a8f3d4f5b547 ("test/crypto: add cases for virtio-user") Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 4 ++-- 1 file changed, 2 insert

[patch v2 4/6] bus/vmbus: support channels without monitoring enabled

2025-03-11 Thread longli
From: Long Li Hyperv host may offer channels without monitor enabled. The max monitor ID it supports is 128. Over those channels without monitor enabled, Hyperv does not send or receive large amount of data traffic and almost all the data traffic is going over the VF. Change the code to not fail

[patch v2 0/6] Support VMBUS channels without monitoring enabled

2025-03-11 Thread longli
From: Long Li Hyperv may expose VMBUS channels without monitoring enabled. In this case, it programs almost all the data traffic to VF. This patchset enabled vmbus/netvsc to use channels without monitoring enabled. Long Li (6): net/netvsc: introduce private data for storing vmbus device for

Re: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-11 Thread Stephen Hemminger
On Mon, 10 Mar 2025 10:51:51 + Bruce Richardson wrote: > On Fri, Mar 07, 2025 at 02:34:01PM -0800, Andre Muezerie wrote: > > On Fri, Mar 07, 2025 at 09:01:28AM +, Bruce Richardson wrote: > > > On Thu, Mar 06, 2025 at 12:03:28PM -0800, Andre Muezerie wrote: > > > > Compiling with MSVC

Re: [PATCH] net/iavf: fix mbuf release bug for ARM Architecture

2025-03-11 Thread Bruce Richardson
On Fri, Mar 07, 2025 at 01:40:22PM +0800, Yang Ming wrote: > This patch addresses a bug related to mbuf release in the ARM > architecture. The previous patch resolved the mbuf release issue > in a multi-process environment but was only applicable to the > x86 architecture, leaving ARM unaddressed.

RE: [PATCH] net/intel: allow fast-free to empty cache

2025-03-11 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 10 March 2025 14.26 > > When freeing transmitted mbufs, there is no reason to send the freed > mbufs directly to the ring if the cache is empty - only if it is zero > size (in which case the cache pointer is NULL). Theref

Re: [PATCH] net/intel: allow fast-free to empty cache

2025-03-11 Thread Bruce Richardson
On Mon, Mar 10, 2025 at 04:34:23PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 10 March 2025 16.27 > > > > On Mon, Mar 10, 2025 at 04:18:35PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.c

[patch v2 6/6] bus/vmbus: set event for channel without monitoring support

2025-03-11 Thread longli
From: Long Li For vmbus channels without monitoring support, use kernel UIO interface to indicate packet through interrupt page and UIO file handle. Signed-off-by: Long Li --- Change log: v2: fixed compilation warnings drivers/bus/vmbus/vmbus_channel.c | 21 ++--- 1 file chang

RE: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-11 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Tuesday, 11 March 2025 15.40 > > On Mon, Mar 10, 2025 at 08:36:40AM -0700, Stephen Hemminger wrote: > > On Mon, 10 Mar 2025 10:51:51 + > > Bruce Richardson wrote: > > > > > On Fri, Mar 07, 2025 at 02:34:01PM -0800, Andre Mue

RE: [PATCH v2 1/3] eal: add function rte_size_to_str

2025-03-11 Thread Morten Brørup
> + return snprintf(buf, buf_size, "%.*f%c%s", precision, > + (double)count / powi, *prefix, use_iec ? "i" : ""); I prefer a space between the number and the postfix (if a postfix is present), e.g. "1.23 M", so when followed by the unit, it becomes "1.23 Mbit/s" rather th

Re: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-11 Thread Andre Muezerie
On Mon, Mar 10, 2025 at 08:36:40AM -0700, Stephen Hemminger wrote: > On Mon, 10 Mar 2025 10:51:51 + > Bruce Richardson wrote: > > > On Fri, Mar 07, 2025 at 02:34:01PM -0800, Andre Muezerie wrote: > > > On Fri, Mar 07, 2025 at 09:01:28AM +, Bruce Richardson wrote: > > > > On Thu, Mar 06,

[PATCH v2 2/3] hash_multiwriter_autotest: fix printf parameters

2025-03-11 Thread Andre Muezerie
Compiling with MSVC logs the warnings below, which result in build error: ../app/test/test_hash_multiwriter.c(71): warning C4476: 'printf' : unknown type field character ''' in format specifier ../app/test/test_hash_multiwriter.c(73): warning C4474: 'printf' : too many arguments passed for

[PATCH v2 1/3] eal: add function rte_size_to_str

2025-03-11 Thread Andre Muezerie
It's common to use %' in the printf format specifier to make large numbers more easily readable by having the thousands grouped. However, this grouping does not work on Windows. Therefore, a function is needed to make uint64_t numbers more easily readable. There are at least two tests that can bene

[PATCH v2 3/3] hash_readwrite_autotest: fix printf parameters

2025-03-11 Thread Andre Muezerie
Compiling with MSVC logs the warnings below, which result in build error: ../app/test/test_hash_readwrite.c(73): warning C4476: 'printf' : unknown type field character ''' in format specifier ../app/test/test_hash_readwrite.c(75): warning C4474: 'printf' : too many arguments passed for for

Re: [PATCH v3 4/5] net/intel: use portable version of __builtin_add_overflow

2025-03-11 Thread Andre Muezerie
On Wed, Mar 05, 2025 at 04:52:09PM +, Bruce Richardson wrote: > On Wed, Mar 05, 2025 at 08:38:09AM -0800, Andre Muezerie wrote: > > __builtin_add_overflow is gcc specific. It should be replaced with > > a portable version that can also be used with other compilers. > > > > Signed-off-by: Andre

Re: [PATCH 0/2] bxnt fixes

2025-03-11 Thread Ajit Khaparde
On Mon, Mar 10, 2025 at 2:01 PM Ajit Khaparde wrote: > > These patches address a couple of issues in the BNXT PMD. > Please apply. Merged in dpdk-next-net-brcm. Thanks > > Ajit Khaparde (2): > net/bnxt: configure burst threshold based on speed > net/bnxt: fix epoch bit calculation > > driver

[PATCH v10 2/3] eventdev: add atomic queue test to test-evnetdev app

2025-03-11 Thread Luka Jankovic
Add an atomic queue test to the test-eventdev app, which is based on the order queue test that exclusively uses atomic queues. Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/meson.build |1 + app/test-eventdev/test_atomic_queue.c | 234

[PATCH] bbdev: enable to be compiled with MSVC

2025-03-11 Thread Andre Muezerie
The errors below popped up when compiling with MSVC: ../lib/bbdev/rte_bbdev.c(79): error C2061: syntax error: identifier 'TAILQ_ENTRY' ../lib/bbdev/rte_bbdev.c(85): error C2059: syntax error: '}' This was caused by a missing include. Signed-off-by: Andre Muezerie --- lib/bbdev/meson.bu

Re: [PATCH] rust: support DPDK API

2025-03-11 Thread Bruce Richardson
On Mon, Mar 10, 2025 at 09:18:44AM -0700, Stephen Hemminger wrote: > On Thu, 6 Mar 2025 15:37:13 +0200 > Gregory Etelson wrote: > > > The patch converts include files with DPDK API to RUST and binds new > > RUST API files info dpdklib package. > > > > The RUST dpdklib files and DPDK libraries bu

[PATCH v10 1/3] eventdev: atomic common for test-eventdev app

2025-03-11 Thread Luka Jankovic
Introduce changes required for atomic tests to run atomic tests. - Producer port maintenance - Common spinlock implementation Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 9 ++ app/test-eventdev/meson.build | 1 + app/test-ev

Re: [PATCH] ethdev: fix get_reg_info

2025-03-11 Thread Stephen Hemminger
On Fri, 7 Mar 2025 17:40:17 +0800 fengchengwen wrote: > I think there are ambiguities in the original API definition: > 1) the width was used as an output parameter in current all PMD impl. > 2) the offset was unused in current all PMD impl. > > But maybe other non-opensource PMD will use these

[PATCH] net/iavf: fix mbuf release bug for ARM Architecture

2025-03-11 Thread Yang Ming
This patch addresses a bug related to mbuf release in the ARM architecture. The previous patch resolved the mbuf release issue in a multi-process environment but was only applicable to the x86 architecture, leaving ARM unaddressed. This patch extends the fix to include the ARM architecture, ensurin

[PATCH v3 9/9] net/ioring: support multi-segment Rx and Tx

2025-03-11 Thread Stephen Hemminger
Use readv/writev to handle multi-segment transmit and receive. Account for virtio header that will be used for offload (later). Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 140 1 file changed, 102 insertions(+), 38 deletions(-) diff --

[PATCH v3 7/9] net/ioring: add VLAN support

2025-03-11 Thread Stephen Hemminger
Add support for VLAN insert and stripping. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 47 +++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c index

[PATCH v3 6/9] net/ioring: implement receive and transmit

2025-03-11 Thread Stephen Hemminger
Use io_uring to read and write from TAP device. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 362 +++- 1 file changed, 361 insertions(+), 1 deletion(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c i

[PATCH v3 1/9] net/ioring: introduce new driver

2025-03-11 Thread Stephen Hemminger
Add basic driver initialization, documentation, and device creation and basic documentation. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 9 + doc/guides/nics/index.rst | 1 + doc/guides/nics/ioring.rst | 66 +++ drivers/net/ioring/meson.

[PATCH v3 2/9] net/ioring: implement link state

2025-03-11 Thread Stephen Hemminger
Add hooks to set kernel link up/down and report state. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 84 + 2 files changed, 85 insertions(+) diff --git a/doc/guides/nics/features/ioring.ini b/d

[PATCH v3 0/9] ioring PMD device

2025-03-11 Thread Stephen Hemminger
This is a new simplified TAP device that uses the Linux kernel ioring API to provide a read/write ring with kernel. This is split from tap device because there are so many unnecessary things in existing tap, and supporting ioring is better without ifdefs etc. The default name of the tap device is

[PATCH v3 3/9] net/ioring: implement control functions

2025-03-11 Thread Stephen Hemminger
These internal ops, just force changes to kernel visible net device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 3 ++ drivers/net/ioring/rte_eth_ioring.c | 69 + 2 files changed, 72 insertions(+) diff --git a/doc/guides/nics/features/

[PATCH v3 5/9] net/ioring: implement secondary process support

2025-03-11 Thread Stephen Hemminger
Add support for communicating fd's from primary to secondary. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 136 +++- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics

[PATCH v3 4/9] net/ioring: implement management functions

2025-03-11 Thread Stephen Hemminger
Add start, stop, configure and info functions. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 72 ++--- 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c in

[PATCH v3 8/9] net/ioring: implement statistics

2025-03-11 Thread Stephen Hemminger
Add support for basic statistics Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 2 + drivers/net/ioring/rte_eth_ioring.c | 57 + 2 files changed, 59 insertions(+) diff --git a/doc/guides/nics/features/ioring.ini b/doc/guides/nics/feature

RE: [PATCH] net/intel: allow fast-free to empty cache

2025-03-11 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 10 March 2025 16.27 > > On Mon, Mar 10, 2025 at 04:18:35PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Monday, 10 March 2025 14.26 > > > > > > When freeing tran

Re: [PATCH] net/intel: allow fast-free to empty cache

2025-03-11 Thread Bruce Richardson
On Mon, Mar 10, 2025 at 04:18:35PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 10 March 2025 14.26 > > > > When freeing transmitted mbufs, there is no reason to send the freed > > mbufs directly to the ring if the cache is empty - on

Re: [PATCH] doc: update ionic driver guides

2025-03-11 Thread Thomas Monjalon
27/02/2025 21:14, Andrew Boyer: > Update broken links and add a link for the DSC3-400 product brief. > > Cc: sta...@dpdk.org > Signed-off-by: Andrew Boyer Applied, thanks.

RE: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without monitoring enabled

2025-03-11 Thread Long Li
> Subject: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without > monitoring enabled > > On Mon, 10 Mar 2025 14:42:51 -0700 > lon...@linuxonhyperv.com wrote: > > > From: Long Li > > > > Hyperv may expose VMBUS channels without monitoring enabled. In this > > case, it programs almost all

[PATCH 2/2] net/iavf: fix crash on app exit on FreeBSD

2025-03-11 Thread Bruce Richardson
With the fallback interrupt path now enabled on FreeBSD there are segmentation faults on app exit, due to the alarm interrupt trying to access invalid pointers. Add checks for null to fix these crashes. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Cc: sta...@dpdk.org Signed-off-by:

[PATCH] buildtools: remove invalid option for Microsoft linker

2025-03-11 Thread Andre Muezerie
When compiling "drivers" directory with MSVC the errors below popped up: drivers/rte_mempool_stack.pmd.c(1): error C2143: syntax error: missing ')' before '(' drivers/rte_mempool_stack.pmd.c(1): error C2059: syntax error: ')' drivers/rte_mempool_stack.pmd.c(1): error C2059: syntax error: ')' d

[PATCH] drivers: remove invalid options for MSVC

2025-03-11 Thread Andre Muezerie
When compiling "drivers" directory with MSVC the errors below popped up: 1) LINK : warning LNK4044: unrecognized option '/Wl,/def:V:\github\dpdk\build\drivers\rte_bus_vdev_exports.def'; ignored 2) cl : Command line warning D9002 : ignoring unknown option '-fno-asynchronous-unwind-tables' The

Re: [External] Re: [PATCH 2/2] net/mlx5: improve log file path

2025-03-11 Thread Yang Ming
On 2025/3/10 22:59, Stephen Hemminger wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Tue, 4 Mar 2025 06:23:06 + Bing Zhao wrote: Hi Ming, -Original Message- Fro

Re: [PATCH 1/2] net/mlx5: improve socket file path

2025-03-11 Thread Yang Ming
On 2025/1/3 10:51, Ming 1. Yang (NSB) wrote: On 2024/12/14 01:16, Bruce Richardson wrote: On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote: On Fri, 13 Dec 2024 17:24:42 +0800 Yang Ming wrote: 1. /var/tmp is hard code which is not a good style 2. /var/tmp may be not allowe

Re: [PATCH] rust: support DPDK API

2025-03-11 Thread Etelson, Gregory
There is no DPDK API for RUST yet. My patch allows RUST application to use native DPDK API. I'll adopt you coding style suggestions in the next patch release. I have same concerns about rust in DPDK as the Linux kernel. What API's are we going to be covered? The plan is to convert API in dem

Re: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-11 Thread Bruce Richardson
On Fri, Mar 07, 2025 at 02:34:01PM -0800, Andre Muezerie wrote: > On Fri, Mar 07, 2025 at 09:01:28AM +, Bruce Richardson wrote: > > On Thu, Mar 06, 2025 at 12:03:28PM -0800, Andre Muezerie wrote: > > > Compiling with MSVC logs the warnings below, which result in > > > build error: > > > > > >

RE: [PATCH] config/arm: fix march features not being set

2025-03-11 Thread Wathsala Wathawana Vithanage
Hi Jerin, We are looking into this internally. Thanks. > -Original Message- > From: Jerin Jacob > Sent: Monday, March 10, 2025 9:23 AM > To: Pavan Nikhilesh Bhagavatula ; Wathsala > Wathawana Vithanage ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula ; > tho...@mon

[PATCH] net/ice: set flags while adding vsi

2025-03-11 Thread Matthew Smith
While adding a vsi for an ice PF, set the ICE_AQ_VSI_SW_FLAG_LOCAL_LB flag. This will prevent packets from being dropped when using a virtual MAC address with VRRP. Also set the ICE_AQ_VSI_SW_FLAG_SRC_PRUNE flag to prevent transmitted packets from being looped back in some circumstances. Fixes: f

Re: [PATCH] eal/linux: enhance ASLR verification

2025-03-11 Thread Yang Ming
On 2025/3/11 05:43, Stephen Hemminger wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Fri, 28 Feb 2025 17:44:04 +0800 Yang Ming wrote: This change ensures that the current pro

Re: [PATCH v2] rust: support raw DPDK API

2025-03-11 Thread Van Haaren, Harry
> From: Gregory Etelson > Sent: Saturday, March 8, 2025 6:50 PM > To: Van Haaren, Harry ; Richardson, Bruce > ; dev@dpdk.org > Cc: getel...@nvidia.com ; mkash...@nvidia.com > ; tho...@monjalon.net > Subject: [PATCH v2] rust: support raw DPDK API > > The patch converts include files with DPDK

[PATCH] doc: fix year of final LTS release

2025-03-11 Thread Kevin Traynor
LTS length was updated to 3 years, but a sentence saying when the final release would be was not updated. Fixes: 3c60ea7b289a ("doc: update LTS maintenance to 3 years") Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- doc/guides/contributing/stable.rst | 2 +- 1 file changed, 1 insertion(+)

RE: [EXTERNAL] Re: [PATCH 6/6] bus/vmbus: set event for channel without monitoring support

2025-03-11 Thread Long Li
> Subject: [EXTERNAL] Re: [PATCH 6/6] bus/vmbus: set event for channel > without monitoring support > > On Thu, 27 Feb 2025 17:09:01 -0800 > lon...@linuxonhyperv.com wrote: > > > From: Long Li > > > > For vmbus channels without monitoring support, use kernel UIO > > interface to indicate packet

RE: [PATCH] config/arm: fix march features not being set

2025-03-11 Thread Jerin Jacob
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Saturday, March 8, 2025 2:29 PM > To: Jerin Jacob ; Wathsala Vithanage > ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > Subject: [PATCH] config/arm: fix march features not being set > > From: Pavan Nik