[PATCH v2 00/34] net/ntnic: bugfixes and refactoring

This patch set addresses fixing issues in the ntnic PMD driver. Changes in this patch: The issues detected by the Coverity Scan tool. The problems that were detected by the internal tests. Fix for Bug 1622: ntnic: using signals and threads: https://bugs.dpdk.org/show_bug.cgi?id=1622. The handli

[PATCH v2 03/34] net/ntnic: add return code handling

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448984, 448982, 448975, 448969, 448968, 448967 API usage errors (BAD_COMPARE). Add memcmp return value checking. Coverity issue: 448984 Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA m

[PATCH v2 01/34] net/ntnic: fix index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448974, 448977, 448978 (OVERRUN). These issues were fixed with updating index verification statement. Coverity issue: 448974 Fixes: effa04693274 ("net/ntnic: add statistics") Signed-off-by: Danylo

[PATCH v2 04/34] net/ntnic: add array index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448983, 448980 Memory - corruptions (OVERRUN) Add check both indices within bounds before calling the macro Coverity issue: 448983 Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA module

[PATCH v2 07/34] net/ntnic: add var definition transparently

From: Danylo Vodopianov set eth_base to NULL after freeing to prevent use-after-free CID: 446746 Use after free (USE_AFTER_FREE) Coverity issue: 446746 Fixes: 1d3f62a0c4f1 ("net/ntnic: add base init and deinit of flow API") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api

[PATCH v2 09/34] net/ntnic: remove unused code

From: Danylo Vodopianov Unused code was removed. CID: 448981 Logically dead code (DEADCODE) Coverity issue: 448981 Fixes: e02fdb65c2a8 ("net/ntnic: add flow create/destroy") Signed-off-by: Danylo Vodopianov --- .../flow_api/profile_inline/flow_api_profile_inline.c| 9 ++--- 1 file ch

[PATCH v2 05/34] net/ntnic: fix realloc memory leak

From: Danylo Vodopianov Issue was fixed with verification in case of the successful memory re-allocation. Coverity issue: 448959 Fixes: 4033e0539435 ("net/ntnic: add flow meter") Signed-off-by: Danylo Vodopianov --- .../profile_inline/flow_api_profile_inline.c | 15 ++- 1 fil

[PATCH v2 13/34] net/ntnic: fix untrusted loop bound

From: Danylo Vodopianov Replace while with if statement to avoid infinite loop in case ther_type will be modified with extenral source. Coverity issue: 448917 Fixes: c6821abf58e8 ("net/ntnic: add flow items GTP and actions raw encap/decap") Signed-off-by: Danylo Vodopianov --- drivers/net/nt

[PATCH v2 19/34] net/ntnic: remove convert error func

From: Danylo Vodopianov convert_error func was removed as far as this approach was deprecated. Coverity issue: 448973 Fixes: e526adf1fdef ("net/ntnic: add minimal create/destroy flow operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/create_elements.h | 1 - drive

[PATCH v2 18/34] net/ntnic: remove unused code

From: Danylo Vodopianov Unused code path in the condition irq_vector >= 0 because the condition irq_vector < 0 is already established Coverity issue: 446745 Fixes: 01e34ed9c756 ("net/ntnic: add availability monitor management") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/

[PATCH v2 11/34] net/ntnic: add null checking

From: Danylo Vodopianov Fix issue with potential rereferencing a pointer that might be NULL p->m_rpp_lr when calling nthw_module_query_register CID 448923: Dereference null return value (NULL_RETURNS) Coverity issue: 448923 Fixes: f543ca6b9ab2 ("net/ntnic: add RPP local retransmit (RPP LR) flo

[PATCH v2 15/34] net/ntnic: move null checking

From: Danylo Vodopianov Move null checking before using Coverity issue: 446759 Fixes: f0fe222ea9cf ("net/ntnic: add releasing virtqueues") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 08/34] net/ntnic: add proper var freed

From: Danylo Vodopianov p_fpga_mgr is properly freed when it's no longer needed CID 440546: Resource leak (RESOURCE_LEAK) Fixes: ddf184d0b6c2 ("net/ntnic: add FPGA initialization") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/core/nthw_fpga.c | 2 ++ 1 file changed, 2 insertion

[PATCH v2 22/34] net/ntnic: remove extra address-of operator

From: Oleksandr Kolomeiets Macro DO_COMPARE_INDEXS expects pointer to array. If condition is true, one of array's elements get overwritten. Misinterpreting pointer to pointer as pointer to array may result in out-of-bounds access. Coverity issue: 448966, 448970, 448971, 448972 Fixes: 6e8b7f11205

[PATCH v2 23/34] net/ntnic: remove extra check for null

From: Oleksandr Kolomeiets pld_ptr points to mp_port_load's element, which is initialized during driver's probe, otherwise probe fails and xstats_get_by_id is not called. Coverity issue: 448945 Fixes: cf6007eac498 ("net/ntnic: add xstats") Signed-off-by: Oleksandr Kolomeiets --- drivers/net/n

[PATCH v2 14/34] net/ntnic: add null checking

From: Danylo Vodopianov Add null checking for fpga var. Coverity issue: 448916 Fixes: 30b2f87ac650 ("net/ntnic: add GMF module") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v2 16/34] net/ntnic: fix var size

From: Danylo Vodopianov Function operate with uint16_r value, meanwhile return value with uint32_t size. This conversion was aligned to the uint8_t as far as max value of the return value could be equal 16. Coverity issue: 446747 Fixes: 67aee0a69665 ("net/ntnic: add used writer data handling")

[PATCH v2 20/34] net/ntnic: fix array verification

From: Danylo Vodopianov if statement was modify to ensure that word_off doesn't exceed the size of the array Coverity issue: 448958 Fixes: 7fa0bf29e667 ("net/ntnic: add hash module") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c | 2 +- 1 file change

[PATCH v2 21/34] net/ntnic: fix memory leak

From: Danylo Vodopianov free for kvlist was added before return to avoid memory leak. Coveriry issue: 446751 Fixes: fe91ade9f5db ("net/ntnic: add basic queue operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/ntnic_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 34/34] net/ntnic: remove tag EXPERIMENTAL

Since nitnic PMD driver for is fully added and verified, the tag EXPERIMENTAL may be removed Signed-off-by: Serhii Iliushyk --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b86cdd266b..b04951de85 100644 --- a/MAINTAINERS +++ b/MA

[PATCH v2 25/34] net/ntnic: refactor RSS implementation

From: Danylo Vodopianov Virtualization backward compatible RSS implementation is no longer needed, thus RSS was refactored as follows: * conversion of RTE_ETH_RSS fields into HSH registers was moved to separate files * profile wrapper for RSS configuration was removed * flow_nic_set_hasher(), t

[PATCH v2 32/34] net/ntnic: add checks for action modify

Following checks were added for `action modify`: * range check to trigger an error in case that value is too large * check for unsupported types of action modify for group 0 Signed-off-by: Serhii Iliushyk --- .../profile_inline/flow_api_profile_inline.c | 89 --- 1 file changed,

[PATCH v2 33/34] net/ntnic: add IFR DROP counter

Support for IP Fragmenter DROP counter to display number of packets dropped due to size larger than MTU. NOTE: Frames are dropped only in case that both IPV4_EN and IPV4_DF_DROP are set to one (resp. their IPV6 counterparts). Signed-off-by: Serhii Iliushyk --- .../net/ntnic/adapter/nt4ga_stat/nt

[PATCH v2 30/34] net/ntnic: refactoring of the FPGA initialization

Remove unnecessary checks and logs. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/core/nthw_fpga.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/ntnic/nthw/core/nthw_fpga.c b/drivers/net/ntnic/nthw/core/nthw_fpga.c index 88641145ec..5ca

[PATCH v2 28/34] net/ntnic: fix group print

From: Danylo Vodopianov Flow dump output was fixed to show original group number for `jumps` stored in action and match sets. Fixes: 6f0fe142caed ("net/ntnic: add flow dump") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api_engine.h | 2 ++ drivers/net/ntnic/nthw/flo

[PATCH v2 24/34] net/ntnic: remove unused code

From: Danylo Vodopianov NTNIC currently cupport only 100G link. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c b/drivers/net/ntnic/adapter/nt4g

[PATCH v2 26/34] net/ntnic: fix age timeout recalculation into fpga unit

From: Danylo Vodopianov The FPGA scrub T parameter shall be encoded timeout using internal unit, which is measured in 2^30 nanoseconds. It is approx 1.074 times longer than age timeout specified in seconds. Internal method hw_mod_flm_inf_sta_data_update_get() was updated to perform conversion bet

[PATCH v2 29/34] net/ntnic: extend module mapping

FPGA module mapping(to string) was extended with new fpga's modules. Signed-off-by: Serhii Iliushyk --- .../nthw/supported/nthw_fpga_mod_str_map.c| 24 +++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_mod_str_map.c b/drivers/net/n

[PATCH v2 10/34] net/ntnic: fix potentially overflow

From: Danylo Vodopianov Issue with potentially overflow was fixed. CID 448944: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Coverity issue: 448944 Fixes: 339ca124e659 ("net/ntnic: add flow action modify field") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/f

[PATCH v2 02/34] net/ntnic: add thread check return code

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448965 Error handling issues (CHECKED_RETURN). Thread return code check was added. Coverity issue: 448965 Fixes: a1ba8c473f5c ("net/ntnic: add statistics poll") Signed-off-by: Danylo Vodopianov --

Re: [PATCH v2 03/54] net/igc: remove the driver

On Tue, Feb 04, 2025 at 03:10:09PM +, Anatoly Burakov wrote: > Now that e1000 and igc drivers have been merged, remove the igc driver > directory. This removes: > > - igc base driver directory together with all files in it > - igc logs header file > - igc and igc base meson build files > - igc

[PATCH v2 17/34] net/ntnic: fix var overflow

From: Danylo Vodopianov Casting either buf_size and num_descr to uint64_t before performing the multiplication was done. Coverity issue: 446740 Fixes: 6b0047fadf41 ("net/ntnic: add queue setup operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/ntnic_ethdev.c | 2 +- 1 file ch

[PATCH v2 12/34] net/ntnic: fix overflow issue

From: Danylo Vodopianov Fix overflow issue with checking max bit shifting value. Coverity issue: 448921 Fixes: 833962ebb893 ("net/ntnic: add CAT module") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v2 27/34] net/ntnic: rework age event generation

From: Danylo Vodopianov Add age event generating only for physical ports. Fixes: 4033e0539435 ("net/ntnic: add flow meter") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v2 06/34] net/ntnic: fix array index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448983 Out-of-bounds write (OVERRUN). These issues were fixed with updating index verification statement. Coverity issue: 448983 Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling") Signed-

Re: [PATCH v3 0/4] remove common iavf and idpf drivers

On Thu, Jan 30, 2025 at 4:12 PM Bruce Richardson wrote: > > The iavf and idpf common directories were used only to share code > between multiple net drivers and did not need to be drivers in their own > right, since it is just as easy to have a dependency from one net driver > on another as a net

[PATCH v2 31/34] net/ntnic: remove shutdown thread

Remove the shutdown thread and SIGINT handling on the level of PMD Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntnic_ethdev.c | 63 1 file changed, 7 insertions(+), 56 deletions(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_

Re: [PATCH v2 02/54] net/e1000: merge igc with e1000

On Tue, Feb 04, 2025 at 03:10:08PM +, Anatoly Burakov wrote: > IGC and E1000 drivers are derived from the same base code. Now that e1000 > code has enabled support for i225 devices, move IGC ethdev code to e1000 > directory (renaming references to base code from igc_* to e1000_*). > > Signed-o

[PATCH v4 3/4] drivers: move iavf common folder to iavf net

The common/iavf driver folder contains the base code for the iavf driver, which is also linked against by the ice driver and others. However, there is no need for this to be in common, and we can move it to the net/intel/iavf as a base code driver. This involves updating dependencies that were on c

[PATCH v4 1/4] drivers: merge common and net idpf drivers

Rather than having some of the idpf code split out into the "common" directory, used by both a net/idpf and a net/cpfl driver, we can merge all idpf code together under net/idpf and have the cpfl driver depend on "net/idpf" rather than "common/idpf". Signed-off-by: Bruce Richardson Acked-by: Prav

[PATCH v4 0/4] remove common iavf and idpf drivers

The iavf and idpf common directories were used only to share code between multiple net drivers and did not need to be drivers in their own right, since it is just as easy to have a dependency from one net driver on another as a net driver on a common one. This patchset therefore aims to eliminate

[PATCH v4 2/4] net/idpf: re-enable unused variable warnings

The idpf driver was being built with warnings disabled for unused variables. However, while the warning was being disabled in the base code directory, all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruce Ri

[PATCH v4 4/4] net/intel: allow building ice driver without iavf

The ice PMD relies on a number of functions from the iavf base code, which can be got by linking against that iavf driver. However, since only three C files are necessary here, we can allow ice to be built independently of iavf by including the base files directly in cases where iavf is not part of

[PATCH v3 06/19] eal: fix out of bounds access in devargs

The code for parsing layers in devargs could reference past the end of layers[] array on stack. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax") Cc: xuemi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hem

[PATCH v3 01/19] common/cnxk: remove duplicate condition

The same condition is checked twice in an if statement. Harmless, but redundant. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Signed-off-by: Stephen Hemminger Acked-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 16 ++-- 1 file changed, 10 insertions(+), 6 delet

[PATCH v3 12/19] crypto/dpaa2_sec: fix bitmask truncation

The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: a77db24643b7 ("crypto/dpaa2_sec: suppor

Re: [PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

Hello André, On Tue, Feb 4, 2025 at 9:57 PM Andre Muezerie wrote: > @@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun > assign_fun, flip_fun flip_fun, size > rand_bitset(bitset, size); > > for (i = 0; i < size; i++) { > - RTE_BITSET_DECLARE(referenc

RE: [PATCH v4] bus: fix inconsistent representation of PCI numbers

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, 29 January 2025 18:25 > To: Shani Peretz > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Tyler Retzlaff ; Parav > Pandit ; Xueming Li ; Nipun Gupta > ; Nikhil Agarwal ; Hemant > Agrawal ; Sachin Saxena > ;

Re: [PATCH] build: remove support for icc compiler

On Wed, Feb 05, 2025 at 06:03:16PM +0100, David Marchand wrote: > On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson > wrote: > > > > The Intel-produced compiler "icc" has been replaced by the newer > > clang-based "icx" compiler. DPDK compilation has also not been tested > > recently with the icc co

RE: [PATCH v4] bus: fix inconsistent representation of PCI numbers

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, 5 February 2025 18:42 > To: Shani Peretz > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Tyler Retzlaff ; Parav > Pandit ; Xueming Li ; Nipun Gupta > ; Nikhil Agarwal ; Hemant > Agrawal ; Sachin Saxena > ;

Re: [PATCH] build: remove support for icc compiler

On Wed, Feb 05, 2025 at 05:32:11PM +, Bruce Richardson wrote: > On Wed, Feb 05, 2025 at 06:03:16PM +0100, David Marchand wrote: > > On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson > > wrote: > > > > > > The Intel-produced compiler "icc" has been replaced by the newer > > > clang-based "icx" co

Re: [PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__

On Wed, Feb 05, 2025 at 03:50:03PM +, Konstantin Ananyev wrote: > > > On Wed, Feb 05, 2025 at 07:37:21AM -0800, Andre Muezerie wrote: > > > On Wed, Feb 05, 2025 at 09:15:43AM +, Bruce Richardson wrote: > > > > On Tue, Feb 04, 2025 at 10:54:24AM -0800, Andre Muezerie wrote: > > > > > Macro

[PATCH v5] eal: define __SIZEOF_LONG__ when using MSVC

Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On Wed, Feb 5, 2025 at 5:44 PM Renyong Wan wrote: > >> That's how we designed it. > >> We designed a low-level device operations framework named xsc_dev_ops to > >> support both VFIO drivers and kernel drivers. Each xsc_dev_ops is > >> registered before the main function runs. During the PCI devic

Re: [PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__

On Wed, Feb 05, 2025 at 09:15:43AM +, Bruce Richardson wrote: > On Tue, Feb 04, 2025 at 10:54:24AM -0800, Andre Muezerie wrote: > > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > > Therefore the errors below are seen with MSVC: > > > > ../lib/mldev/mldev_utils_scalar.

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On 2025/2/5 22:43, Thomas Monjalon wrote: > 05/02/2025 15:37, Renyong Wan: >> On 2025/2/5 19:44, Thomas Monjalon wrote: >>> 28/01/2025 15:46, Renyong Wan: XSC PMD is designed to support both VFIO and private kernel drivers. >>> What's the benefit of private kernel drivers? >>> Why are they pri

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On Wed, Feb 05, 2025 at 04:47:20PM +0100, Thomas Monjalon wrote: > 05/02/2025 15:59, Bruce Richardson: > > On Wed, Feb 05, 2025 at 03:43:30PM +0100, Thomas Monjalon wrote: > > > 05/02/2025 15:37, Renyong Wan: > > > > On 2025/2/5 19:44, Thomas Monjalon wrote: > > > > > 28/01/2025 15:46, Renyong Wan:

Re: [PATCH v4] bus: fix inconsistent representation of PCI numbers

On Wed, 5 Feb 2025 16:36:11 + Shani Peretz wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, 29 January 2025 18:25 > > To: Shani Peretz > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; Tyler Retzlaff ; Parav > > Pandit ; Xueming Li ; Ni

Re: [PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

On Tue, 4 Feb 2025 12:57:09 -0800 Andre Muezerie wrote: > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11) > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Warray-bounds" > +#endif > > + /* gcc is giving false positives here when code is optimized */ >

[PATCH v3 15/19] net/dpaa: fix bitmask truncation

The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 5e7455931442 ("net/dpaa: support Rx que

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On 2025/2/5 23:45, Thomas Monjalon wrote: > 05/02/2025 16:37, Renyong Wan: >> On 2025/2/5 22:43, Thomas Monjalon wrote: >>> 05/02/2025 15:37, Renyong Wan: On 2025/2/5 19:44, Thomas Monjalon wrote: > 28/01/2025 15:46, Renyong Wan: >> XSC PMD is designed to support both VFIO and private

[PATCH v3 13/19] crypto/dpaa_sec: fix bitmask truncation

The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: fe3688ba7950 ("crypto/dpaa_sec: support

Re: [PATCH v1 00/42] Merge Intel IGC and E1000 drivers, and update E1000 base code

On Tue, Feb 4, 2025 at 4:36 PM Burakov, Anatoly wrote: > > On 03/02/2025 9:18, David Marchand wrote: > > Hello Anatoly, > > > > On Fri, Jan 31, 2025 at 1:59 PM Anatoly Burakov > > wrote: > >> > >> Intel IGC and E1000 drivers are distinct, but they are actually generated > >> from the same base co

Re: [PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__

On Tue, Feb 04, 2025 at 10:54:24AM -0800, Andre Muezerie wrote: > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > Therefore the errors below are seen with MSVC: > > ../lib/mldev/mldev_utils_scalar.c(465): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

28/01/2025 15:46, Renyong Wan: > XSC PMD is designed to support both VFIO and private kernel drivers. What's the benefit of private kernel drivers? Why are they private?

RE: [PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__

> On Wed, Feb 05, 2025 at 07:37:21AM -0800, Andre Muezerie wrote: > > On Wed, Feb 05, 2025 at 09:15:43AM +, Bruce Richardson wrote: > > > On Tue, Feb 04, 2025 at 10:54:24AM -0800, Andre Muezerie wrote: > > > > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > > > > Ther

[PATCH 03/11] net/bnxt: fix Rx handler

Fix the code accounting the status of compressed CQE handler. The code was inside the block handling the normal CQE mode. Moved the code out. Without this the Rx datapath was broken for compressed CQEs in scalar mode. Fixes: 5c980062d895 ("net/bnxt: support compressed Rx CQE") Cc: sta...@dpdk.org

[PATCH 00/11] bnxt patch set

Patchset with bug fixes for bnxt PMD. Also addresses various Coverity issues reported in the recent Coverity scan. Please apply. Ajit Khaparde (4): net/bnxt: disable TruFlow if compressed CQE is set net/bnxt: simplify check for CQE mode net/bnxt: fix Rx handler net/bnxt: fix burst handler

[PATCH 01/11] net/bnxt: disable TruFlow if compressed CQE is set

If a user selects compressed CQE mode using the cqe-mode devarg, it is clear that the user does not intend to use TruFlow mode. Since host backed TruFlow setting is enable by default now, disable TruFlow during initialization to prevent unexpected behavior when the two get enabled. Signed-off-by:

[PATCH 05/11] net/bnxt/truFlow: Fix seg fault when rep are re-attached

From: Sangtani Parag Satishbhai When the PCI port is detached using the testpmd command, as part of cleanup testpmd removes resources of parent port and all the children's ports and calls the driver specific pci_remove API with the parent rte ethdev to clean-up ethdevs. For the bnxt driver, a con

[PATCH 04/11] net/bnxt: set burst handler correctly

We are incorrectly setting the Rx and Tx burst handlers to static mode by default. Fix that by using the bnxt_receive_function and bnxt_transmit_function calls to determine if the vector mode is enabled and identify the appropriate burst handler during the initialization. Signed-off-by: Ajit Khapa

[PATCH 02/11] net/bnxt: simplify check for CQE mode

Simplify the check for the CQE mode. We don't have to check the Rx offload mode to determine which CQE mode is supported. CQE mode is configured at load time and once set will decide if TCP LRO or buffer split can be supported or not. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Revie

[PATCH 06/11] net/bnxt: address coverity deadcode issue

From: Peter Spreadborough This change addresses the CID 449075: Control flow issues (DEADCODE) reported by coverity associated with the ASSERT_RETURN macro. The change renames the macro and replaces the log macro to use PMD_DRV_LOG_LINE. Coverity issue: 449075 Signed-off-by: Peter Spreadborough

[PATCH 07/11] net/bnxt: address coverity checked return issues

From: Peter Spreadborough This change addresses the CID 449056: Error handling issues (CHECKED_RETURN) reported by coverity. The changes add return code handling to address the issue. Coverity issue: 449056 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf

[PATCH 09/11] net/bnxt: address coverity integer overflow issues

From: Peter Spreadborough This change addresses the CID 449059: Integer handling issues (INTEGER_OVERFLOW) reported by coverity. Coverity issue: 449059 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c | 6 +- 1 file changed, 5 in

[PATCH 11/11] net/bnxt: address coverity control flow issues

From: Peter Spreadborough This change addresses the CID 449072: Control flow issues (DEADCODE) reported by coverity. Coverity issue: 449072 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 08/11] net/bnxt: address coverity overflow issues

From: Peter Spreadborough This change addresses the CID 449058: Integer handling issues (OVERFLOW_BEFORE_WIDEN) reported by coverity. Coverity issue: 449058 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 2 +- 1 file changed, 1

[PATCH 10/11] net/bnxt: address coverity uninitialized variables issues

From: Peter Spreadborough This change addresses the CID 449065: Uninitialized variables (UNINIT) issues reported by coverity. Coverity issue: 449065 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 + drivers/net/bnxt/tf_ulp/ulp_sc_mg

Re: [PATCH] build: remove support for icc compiler

On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson wrote: > > The Intel-produced compiler "icc" has been replaced by the newer > clang-based "icx" compiler. DPDK compilation has also not been tested > recently with the icc compiler, so let's remove doc and code references > to icc, and any special ma

[PATCH v3 0/2] remove unused variables and add MSVC compiler flag

v3: * rebased. Removed unused variables and added MSVC specific compiler flag to ignore warnings about unused variables, like is being done for other compilers. Andre Muezerie (2): drivers/common: remove unused variables and add MSVC compiler flag drivers/net: add MSVC compiler flag for unus

[PATCH v3 1/2] drivers/common: remove unused variables and add MSVC compiler flag

Removed unused variables and added MSVC specific compiler flag to ignore warnings about unused variables, like is being done for other compilers. Signed-off-by: Andre Muezerie --- drivers/common/idpf/base/meson.build | 13 ++--- drivers/common/idpf/idpf_common_rxtx.c | 2 -- d

[PATCH v3 2/2] drivers/net: add MSVC compiler flag for unused variables

Added MSVC specific compiler flag to ignore warnings about unused variables, like is being done for other compilers. Signed-off-by: Andre Muezerie --- drivers/net/qede/base/meson.build | 57 +-- 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/n

Re: [PATCH v2 2/2] drivers/net: add MSVC compiler flag for unused variables

On Wed, Feb 05, 2025 at 10:33:57AM -0800, Stephen Hemminger wrote: > On Tue, 14 Jan 2025 12:46:51 -0800 > Andre Muezerie wrote: > > > Added MSVC specific compiler flag to ignore warnings about unused > > variables, like is being done for other compilers. > > > > Signed-off-by: Andre Muezerie >

RE: [EXTERNAL] [dpdk-dev] [PATCH v5 1/2] common/cnxk: support NPC flow on cn20k

> -Original Message- > From: psathe...@marvell.com > Sent: Wednesday, February 5, 2025 11:13 AM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Harman Kalra > Cc: dev@dpdk.org; Satheesh Paul Antonysamy > Subject: [EXTER

Re: [PATCH v5 2/4] lib: fix comparison between devices

On 06-02-2025 05:38, Shani Peretz wrote: DPDK supports multiple formats for specifying buses, (such as ":08:00.0" and "08:00.0" for PCI). This flexibility can lead to inconsistencies when using one format while running testpmd, then attempts to use the other format in a later command, resul

Re: [RFC] ci: Add support for Cirrus-CI service to test FreeBSD.

Patrick Robb writes: > On Tue, Feb 4, 2025 at 11:07 AM Aaron Conole wrote: > > This commit adds preliminary support for developer driven FreeBSD testing > via the Cirrus-CI cloud continuous integration system. > > NOTE: Currently, this does not successfully execute. See the following > buil

Re: [PATCH] vhost: fix VDUSE devices registration

Hi Ariel, On 1/31/25 6:34 PM, Ariel Otilibili-Anieli wrote: Hello Maxime, On Friday, January 31, 2025 14:09 CET, Maxime Coquelin wrote: This patch fixes a regression in vhost_driver_register() causing VDUSE devices registration to fail systematically because the return value was initialized

Re: [RFC 0/3] Vhost: fix FD entries cleanup

Hi Chenbo & David, On 2/5/25 8:27 AM, Chenbo Xia wrote: Hi David, On Feb 4, 2025, at 21:18, David Marchand wrote: External email: Use caution opening links or attachments Hello vhost maintainers, On Tue, Dec 24, 2024 at 4:50 PM Maxime Coquelin wrote: The vhost FD manager provides a way

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

05/02/2025 15:59, Bruce Richardson: > On Wed, Feb 05, 2025 at 03:43:30PM +0100, Thomas Monjalon wrote: > > 05/02/2025 15:37, Renyong Wan: > > > On 2025/2/5 19:44, Thomas Monjalon wrote: > > > > 28/01/2025 15:46, Renyong Wan: > > > >> XSC PMD is designed to support both VFIO and private kernel drive

[PATCH v3 09/19] examples/ptpclient: fix self memcmp

Calling memcmp on same structure will always be true. Replace with same conditional used elsewhere. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Cc: danielx.t.mrzyg...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen

[PATCH v3 19/19] common/cnxk: fix null ptr check

The pointer mode is used then checked which is a bug reported by PVS studio. Fixes: bd2fd34ab86f ("common/cnxk: sync eth mode change command with firmware") Cc: tduszyn...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_bphy_cgx.c | 12 ++--

[PATCH v3 14/19] event/dpaa: fix bitmask truncation

More bitmask truncation from mask computation. Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue") Cc: sunil.k...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v3 18/19] examples/l3fwd: fix operator precedence bugs

The expression: if ((socketid = rte_lcore_to_socket_id(lcore) != 0) && gets evaluated as sockeid = (rte_lcore_to_socket_id(lcore) != 0) which is not what was intended. This is goes all the way back to first release. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: af75078fece3 ("fir

[PATCH v3 00/19] minor fixes from PVS studio bug list

More bug fixes from PVS studio bug reports. And one other fix to ptpclient. Stephen Hemminger (19): common/cnxk: remove duplicate condition net/cpfl: avoid calling log (printf) with null raw/cnxk_gpio: fix file descriptor leak net/ntnic: remove dead code net/i40e: remove duplicate code

[PATCH v3 17/19] net/qede: don't use same loop variable twice

Using variable in outer loop, and inner loop is obvious bug. This bug is in base code, so likely on other platforms as well. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 81dba2b2ff61 ("net/qede/base: add LLDP support") Cc: rasesh.m...@cavium.com Cc: sta...@dpdk.org Signed-off-by: S

[PATCH v3 16/19] net/dpaa2: fix bitmask truncation

The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 2d3788631862 ("net/dpaa2: support atomi

Re: [PATCH v4] bus: fix inconsistent representation of PCI numbers

On Wed, 5 Feb 2025 17:37:54 + Shani Peretz wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, 5 February 2025 18:42 > > To: Shani Peretz > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; Tyler Retzlaff ; Parav > > Pandit ; Xueming Li ; Ni

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On Wed, Feb 05, 2025 at 03:43:30PM +0100, Thomas Monjalon wrote: > 05/02/2025 15:37, Renyong Wan: > > On 2025/2/5 19:44, Thomas Monjalon wrote: > > > 28/01/2025 15:46, Renyong Wan: > > >> XSC PMD is designed to support both VFIO and private kernel drivers. > > > What's the benefit of private kernel

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

On 2025/2/5 19:44, Thomas Monjalon wrote: > 28/01/2025 15:46, Renyong Wan: >> XSC PMD is designed to support both VFIO and private kernel drivers. > What's the benefit of private kernel drivers? > Why are they private? > > > Hello Thomas, Thanks for your review. It can support the bifurcation mod

Re: [PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

05/02/2025 15:37, Renyong Wan: > On 2025/2/5 19:44, Thomas Monjalon wrote: > > 28/01/2025 15:46, Renyong Wan: > >> XSC PMD is designed to support both VFIO and private kernel drivers. > > What's the benefit of private kernel drivers? > > Why are they private? > > Hello Thomas, > > Thanks for your

  1   2   >